linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ladislav Michl <ladis@linux-mips.org>
To: "H. Nikolaus Schaller" <hns@goldelico.com>
Cc: MyungJoo Ham <myungjoo.ham@samsung.com>,
	Chanwoo Choi <cw00.choi@samsung.com>,
	linux-kernel@vger.kernel.org, letux-kernel@openphoenux.org,
	kernel@pyra-handheld.com, linux-omap@vger.kernel.org
Subject: Re: [PATCH v3] extcon: palmas: hide error messages if gpio returns -EPROBE_DEFER
Date: Tue, 18 Feb 2020 12:49:02 +0100	[thread overview]
Message-ID: <20200218114902.GA259088@lenoch> (raw)
In-Reply-To: <CEE4951F-085A-4D9C-AD15-F63C80D958EB@goldelico.com>

Hi Nikolaus,

On Mon, Feb 17, 2020 at 09:25:32PM +0100, H. Nikolaus Schaller wrote:
> > The rest of discussion
> > would need disassembly and I'll do it once I'll be waiting for yet another
> > long run recompile.
> 
> :)

Just FYI, original compiled with gcc-8.2.1:
   text    data     bss     dec     hex filename
   4358     104       0    4462    116e drivers/extcon/extcon-palmas.o

Your patch:
   text    data     bss     dec     hex filename
   4382     104       0    4486    1186 drivers/extcon/extcon-palmas.o

My patch with printing error value:
   text	   data	    bss	    dec	    hex	filename
   4406	    104	      0	   4510	   119e	drivers/extcon/extcon-palmas.o

So even without disassembling numbers speak for themselves :)

	l.

  reply	other threads:[~2020-02-18 11:49 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20200217133832epcas1p329af393e88fa76189ca141d2534f9ad2@epcas1p3.samsung.com>
2020-02-17 13:38 ` [PATCH v3] extcon: palmas: hide error messages if gpio returns -EPROBE_DEFER H. Nikolaus Schaller
2020-02-17 13:58   ` H. Nikolaus Schaller
2020-02-17 18:29     ` Ladislav Michl
2020-02-17 18:38       ` H. Nikolaus Schaller
2020-02-17 19:07         ` Ladislav Michl
2020-02-17 19:33           ` H. Nikolaus Schaller
2020-02-17 20:19             ` Ladislav Michl
2020-02-17 20:25               ` H. Nikolaus Schaller
2020-02-18 11:49                 ` Ladislav Michl [this message]
2020-02-18 11:13     ` Chanwoo Choi
2020-02-18  3:28   ` Chanwoo Choi
2020-02-18 10:21     ` Ladislav Michl
2020-02-18 10:35       ` Chanwoo Choi
2020-02-18 10:48         ` Ladislav Michl
2020-02-18 11:09           ` Chanwoo Choi
2020-02-21  7:47             ` Ladislav Michl
2020-02-24  2:12               ` Chanwoo Choi
2020-02-24  7:31                 ` Ladislav Michl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200218114902.GA259088@lenoch \
    --to=ladis@linux-mips.org \
    --cc=cw00.choi@samsung.com \
    --cc=hns@goldelico.com \
    --cc=kernel@pyra-handheld.com \
    --cc=letux-kernel@openphoenux.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=myungjoo.ham@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).