From: "H. Nikolaus Schaller" <hns@goldelico.com>
To: Ladislav Michl <ladis@linux-mips.org>
Cc: MyungJoo Ham <myungjoo.ham@samsung.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
linux-kernel@vger.kernel.org, letux-kernel@openphoenux.org,
kernel@pyra-handheld.com, linux-omap@vger.kernel.org
Subject: Re: [PATCH v3] extcon: palmas: hide error messages if gpio returns -EPROBE_DEFER
Date: Mon, 17 Feb 2020 21:25:32 +0100 [thread overview]
Message-ID: <CEE4951F-085A-4D9C-AD15-F63C80D958EB@goldelico.com> (raw)
In-Reply-To: <20200217201911.GA168683@lenoch>
Hi Ladis,
> Am 17.02.2020 um 21:19 schrieb Ladislav Michl <ladis@linux-mips.org>:
>
> Hi Nikolaus,
>
> On Mon, Feb 17, 2020 at 08:33:52PM +0100, H. Nikolaus Schaller wrote:
>> Hi Ladis,
>>
>>> Am 17.02.2020 um 20:07 schrieb Ladislav Michl <ladis@linux-mips.org>:
>>> Linux kernel prints so many lines on bootup and only few of them are
>>> valuable. Lets improve it by printing error value to give a clue
>>> why it failed.
>>
>> Hm. The upstream code does already print the error. This feature is not removed.
>> But it is also printing an error in the EPROBE_DEFER case as well, where it is
>> not needed or not an error.
>
> It seems you missed I'm printing also error _value_.
Indeed.
Well, usually there is no error so adding the error number is not of much
use (except for debugging)... The most likely one seems to be -EPROBE_DEFER.
On the omap5 boards where I have seen the error message being printed they were
EPROBE_DEFER.
So your proposal changes the subject (which has a very small focus).
> The rest of discussion
> would need disassembly and I'll do it once I'll be waiting for yet another
> long run recompile.
:)
BR and thanks,
Nikolaus
next prev parent reply other threads:[~2020-02-17 20:25 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20200217133832epcas1p329af393e88fa76189ca141d2534f9ad2@epcas1p3.samsung.com>
2020-02-17 13:38 ` [PATCH v3] extcon: palmas: hide error messages if gpio returns -EPROBE_DEFER H. Nikolaus Schaller
2020-02-17 13:58 ` H. Nikolaus Schaller
2020-02-17 18:29 ` Ladislav Michl
2020-02-17 18:38 ` H. Nikolaus Schaller
2020-02-17 19:07 ` Ladislav Michl
2020-02-17 19:33 ` H. Nikolaus Schaller
2020-02-17 20:19 ` Ladislav Michl
2020-02-17 20:25 ` H. Nikolaus Schaller [this message]
2020-02-18 11:49 ` Ladislav Michl
2020-02-18 11:13 ` Chanwoo Choi
2020-02-18 3:28 ` Chanwoo Choi
2020-02-18 10:21 ` Ladislav Michl
2020-02-18 10:35 ` Chanwoo Choi
2020-02-18 10:48 ` Ladislav Michl
2020-02-18 11:09 ` Chanwoo Choi
2020-02-21 7:47 ` Ladislav Michl
2020-02-24 2:12 ` Chanwoo Choi
2020-02-24 7:31 ` Ladislav Michl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CEE4951F-085A-4D9C-AD15-F63C80D958EB@goldelico.com \
--to=hns@goldelico.com \
--cc=cw00.choi@samsung.com \
--cc=kernel@pyra-handheld.com \
--cc=ladis@linux-mips.org \
--cc=letux-kernel@openphoenux.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).