From: Ladislav Michl <ladis@linux-mips.org>
To: Chanwoo Choi <cw00.choi@samsung.com>
Cc: "H. Nikolaus Schaller" <hns@goldelico.com>,
MyungJoo Ham <myungjoo.ham@samsung.com>,
linux-kernel@vger.kernel.org, letux-kernel@openphoenux.org,
kernel@pyra-handheld.com, linux-omap@vger.kernel.org
Subject: Re: [PATCH v3] extcon: palmas: hide error messages if gpio returns -EPROBE_DEFER
Date: Fri, 21 Feb 2020 08:47:40 +0100 [thread overview]
Message-ID: <20200221074740.GA44103@lenoch> (raw)
In-Reply-To: <34f3cd11-321b-9aab-31a7-a3fb03691980@samsung.com>
On Tue, Feb 18, 2020 at 08:09:16PM +0900, Chanwoo Choi wrote:
> On 2/18/20 7:48 PM, Ladislav Michl wrote:
> > On Tue, Feb 18, 2020 at 07:35:47PM +0900, Chanwoo Choi wrote:
> >> On 2/18/20 7:21 PM, Ladislav Michl wrote:
> >>> On Tue, Feb 18, 2020 at 12:28:25PM +0900, Chanwoo Choi wrote:
> >>>> On 2/17/20 10:38 PM, H. Nikolaus Schaller wrote:
> >>>>> If the gpios are probed after this driver (e.g. if they
> >>>>> come from an i2c expander) there is no need to print an
> >>>>> error message.
> >>>>>
> >>>>> Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>
> >>>>> ---
> >>>>> drivers/extcon/extcon-palmas.c | 8 ++++++--
> >>>>> 1 file changed, 6 insertions(+), 2 deletions(-)
> >>>>>
> >>>>> diff --git a/drivers/extcon/extcon-palmas.c b/drivers/extcon/extcon-palmas.c
> >>>>> index edc5016f46f1..cea58d0cb457 100644
> >>>>> --- a/drivers/extcon/extcon-palmas.c
> >>>>> +++ b/drivers/extcon/extcon-palmas.c
> >>>>> @@ -205,14 +205,18 @@ static int palmas_usb_probe(struct platform_device *pdev)
> >>>>>
> >>>>> palmas_usb->id_gpiod = devm_gpiod_get_optional(&pdev->dev, "id",
> >>>>> GPIOD_IN);
> >>>>> - if (IS_ERR(palmas_usb->id_gpiod)) {
> >>>>> + if (PTR_ERR(palmas_usb->id_gpiod) == -EPROBE_DEFER) {
> >>>>> + return -EPROBE_DEFER;
> >
> > Here we returned...
>
> hmm. you better to suggest the result of cocci script
> to understand why it is matter.
You can browse similar fixes online :)
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/log/?qt=grep&q=else+after+return
Best regards,
ladis
next prev parent reply other threads:[~2020-02-21 7:47 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20200217133832epcas1p329af393e88fa76189ca141d2534f9ad2@epcas1p3.samsung.com>
2020-02-17 13:38 ` [PATCH v3] extcon: palmas: hide error messages if gpio returns -EPROBE_DEFER H. Nikolaus Schaller
2020-02-17 13:58 ` H. Nikolaus Schaller
2020-02-17 18:29 ` Ladislav Michl
2020-02-17 18:38 ` H. Nikolaus Schaller
2020-02-17 19:07 ` Ladislav Michl
2020-02-17 19:33 ` H. Nikolaus Schaller
2020-02-17 20:19 ` Ladislav Michl
2020-02-17 20:25 ` H. Nikolaus Schaller
2020-02-18 11:49 ` Ladislav Michl
2020-02-18 11:13 ` Chanwoo Choi
2020-02-18 3:28 ` Chanwoo Choi
2020-02-18 10:21 ` Ladislav Michl
2020-02-18 10:35 ` Chanwoo Choi
2020-02-18 10:48 ` Ladislav Michl
2020-02-18 11:09 ` Chanwoo Choi
2020-02-21 7:47 ` Ladislav Michl [this message]
2020-02-24 2:12 ` Chanwoo Choi
2020-02-24 7:31 ` Ladislav Michl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200221074740.GA44103@lenoch \
--to=ladis@linux-mips.org \
--cc=cw00.choi@samsung.com \
--cc=hns@goldelico.com \
--cc=kernel@pyra-handheld.com \
--cc=letux-kernel@openphoenux.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).