* [PATCH 1/2] tty: serial: samsung_tty: build it for any platform @ 2020-02-20 10:26 Greg Kroah-Hartman 2020-02-20 10:26 ` [PATCH 2/2] tty: serial: samsung_tty: remove SERIAL_SAMSUNG_DEBUG Greg Kroah-Hartman ` (2 more replies) 0 siblings, 3 replies; 10+ messages in thread From: Greg Kroah-Hartman @ 2020-02-20 10:26 UTC (permalink / raw) To: linux-serial Cc: Greg Kroah-Hartman, Kukjin Kim, Donghoon Yu, Hyunki Koo, HYUN-KI KOO, Shinbeom Choi, Krzysztof Kozlowski, Jiri Slaby, linux-arm-kernel, linux-samsung-soc, linux-kernel There is no need to tie this driver to only a specific SoC, or compile test, so remove that dependancy from the Kconfig rules. Cc: Kukjin Kim <kgene@kernel.org> Cc: Donghoon Yu <hoony.yu@samsung.com> Cc: Hyunki Koo <kkoos00@naver.com> Cc: HYUN-KI KOO <hyunki00.koo@samsung.com> Cc: Shinbeom Choi <sbeom.choi@samsung.com> Cc: Krzysztof Kozlowski <krzk@kernel.org> Cc: Jiri Slaby <jslaby@suse.com> Cc: linux-arm-kernel@lists.infradead.org Cc: linux-samsung-soc@vger.kernel.org Cc: linux-serial@vger.kernel.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> --- drivers/tty/serial/Kconfig | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig index 52eaac21ff9f..a310bd22f1e2 100644 --- a/drivers/tty/serial/Kconfig +++ b/drivers/tty/serial/Kconfig @@ -237,7 +237,6 @@ config SERIAL_CLPS711X_CONSOLE config SERIAL_SAMSUNG tristate "Samsung SoC serial support" - depends on PLAT_SAMSUNG || ARCH_EXYNOS || COMPILE_TEST select SERIAL_CORE help Support for the on-chip UARTs on the Samsung S3C24XX series CPUs, base-commit: 11a48a5a18c63fd7621bb050228cebf13566e4d8 -- 2.25.1 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH 2/2] tty: serial: samsung_tty: remove SERIAL_SAMSUNG_DEBUG 2020-02-20 10:26 [PATCH 1/2] tty: serial: samsung_tty: build it for any platform Greg Kroah-Hartman @ 2020-02-20 10:26 ` Greg Kroah-Hartman 2020-02-20 10:55 ` Krzysztof Kozlowski 2020-02-20 10:54 ` [PATCH 1/2] tty: serial: samsung_tty: build it for any platform Krzysztof Kozlowski [not found] ` <CGME20200220121333eucas1p26befa95831b44a793822b4f07b37d2cc@eucas1p2.samsung.com> 2 siblings, 1 reply; 10+ messages in thread From: Greg Kroah-Hartman @ 2020-02-20 10:26 UTC (permalink / raw) To: linux-serial Cc: Greg Kroah-Hartman, Kukjin Kim, Donghoon Yu, Hyunki Koo, HYUN-KI KOO, Shinbeom Choi, Krzysztof Kozlowski, Jiri Slaby, linux-arm-kernel, linux-samsung-soc, linux-kernel Since a05025d0ce72 ("tty: serial: samsung_tty: use standard debugging macros") this configuration option is not used at all, so remove it from the Kconfig file. Cc: Kukjin Kim <kgene@kernel.org> Cc: Donghoon Yu <hoony.yu@samsung.com> Cc: Hyunki Koo <kkoos00@naver.com> Cc: HYUN-KI KOO <hyunki00.koo@samsung.com> Cc: Shinbeom Choi <sbeom.choi@samsung.com> Cc: Krzysztof Kozlowski <krzk@kernel.org> Cc: Jiri Slaby <jslaby@suse.com> Cc: linux-arm-kernel@lists.infradead.org Cc: linux-samsung-soc@vger.kernel.org Cc: linux-serial@vger.kernel.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> --- drivers/tty/serial/Kconfig | 9 --------- 1 file changed, 9 deletions(-) diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig index a310bd22f1e2..fa4380b0b869 100644 --- a/drivers/tty/serial/Kconfig +++ b/drivers/tty/serial/Kconfig @@ -259,15 +259,6 @@ config SERIAL_SAMSUNG_UARTS help Select the number of available UART ports for the Samsung S3C serial driver - -config SERIAL_SAMSUNG_DEBUG - bool "Samsung SoC serial debug" - depends on SERIAL_SAMSUNG && DEBUG_LL - help - Add support for debugging the serial driver. Since this is - generally being used as a console, we use our own output - routines that go via the low-level debug printascii() - function. config SERIAL_SAMSUNG_CONSOLE bool "Support for console on Samsung SoC serial port" -- 2.25.1 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH 2/2] tty: serial: samsung_tty: remove SERIAL_SAMSUNG_DEBUG 2020-02-20 10:26 ` [PATCH 2/2] tty: serial: samsung_tty: remove SERIAL_SAMSUNG_DEBUG Greg Kroah-Hartman @ 2020-02-20 10:55 ` Krzysztof Kozlowski 2020-02-20 11:09 ` Greg Kroah-Hartman 0 siblings, 1 reply; 10+ messages in thread From: Krzysztof Kozlowski @ 2020-02-20 10:55 UTC (permalink / raw) To: Greg Kroah-Hartman Cc: linux-serial, Kukjin Kim, Donghoon Yu, Hyunki Koo, HYUN-KI KOO, Shinbeom Choi, Jiri Slaby, linux-arm-kernel, linux-samsung-soc, linux-kernel On Thu, Feb 20, 2020 at 11:26:28AM +0100, Greg Kroah-Hartman wrote: > Since a05025d0ce72 ("tty: serial: samsung_tty: use standard debugging > macros") this configuration option is not used at all, so remove it from > the Kconfig file. > > Cc: Kukjin Kim <kgene@kernel.org> > Cc: Donghoon Yu <hoony.yu@samsung.com> > Cc: Hyunki Koo <kkoos00@naver.com> > Cc: HYUN-KI KOO <hyunki00.koo@samsung.com> > Cc: Shinbeom Choi <sbeom.choi@samsung.com> > Cc: Krzysztof Kozlowski <krzk@kernel.org> > Cc: Jiri Slaby <jslaby@suse.com> > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-samsung-soc@vger.kernel.org > Cc: linux-serial@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > --- > drivers/tty/serial/Kconfig | 9 --------- > 1 file changed, 9 deletions(-) Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org> Best regards, Krzysztof ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 2/2] tty: serial: samsung_tty: remove SERIAL_SAMSUNG_DEBUG 2020-02-20 10:55 ` Krzysztof Kozlowski @ 2020-02-20 11:09 ` Greg Kroah-Hartman 0 siblings, 0 replies; 10+ messages in thread From: Greg Kroah-Hartman @ 2020-02-20 11:09 UTC (permalink / raw) To: Krzysztof Kozlowski Cc: linux-serial, Kukjin Kim, Donghoon Yu, Hyunki Koo, HYUN-KI KOO, Shinbeom Choi, Jiri Slaby, linux-arm-kernel, linux-samsung-soc, linux-kernel On Thu, Feb 20, 2020 at 11:55:41AM +0100, Krzysztof Kozlowski wrote: > On Thu, Feb 20, 2020 at 11:26:28AM +0100, Greg Kroah-Hartman wrote: > > Since a05025d0ce72 ("tty: serial: samsung_tty: use standard debugging > > macros") this configuration option is not used at all, so remove it from > > the Kconfig file. > > > > Cc: Kukjin Kim <kgene@kernel.org> > > Cc: Donghoon Yu <hoony.yu@samsung.com> > > Cc: Hyunki Koo <kkoos00@naver.com> > > Cc: HYUN-KI KOO <hyunki00.koo@samsung.com> > > Cc: Shinbeom Choi <sbeom.choi@samsung.com> > > Cc: Krzysztof Kozlowski <krzk@kernel.org> > > Cc: Jiri Slaby <jslaby@suse.com> > > Cc: linux-arm-kernel@lists.infradead.org > > Cc: linux-samsung-soc@vger.kernel.org > > Cc: linux-serial@vger.kernel.org > > Cc: linux-kernel@vger.kernel.org > > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > > --- > > drivers/tty/serial/Kconfig | 9 --------- > > 1 file changed, 9 deletions(-) > > Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org> Thanks for the quick review of both of these! greg k-h ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 1/2] tty: serial: samsung_tty: build it for any platform 2020-02-20 10:26 [PATCH 1/2] tty: serial: samsung_tty: build it for any platform Greg Kroah-Hartman 2020-02-20 10:26 ` [PATCH 2/2] tty: serial: samsung_tty: remove SERIAL_SAMSUNG_DEBUG Greg Kroah-Hartman @ 2020-02-20 10:54 ` Krzysztof Kozlowski [not found] ` <CGME20200220121333eucas1p26befa95831b44a793822b4f07b37d2cc@eucas1p2.samsung.com> 2 siblings, 0 replies; 10+ messages in thread From: Krzysztof Kozlowski @ 2020-02-20 10:54 UTC (permalink / raw) To: Greg Kroah-Hartman Cc: linux-serial, Kukjin Kim, Donghoon Yu, Hyunki Koo, HYUN-KI KOO, Shinbeom Choi, Jiri Slaby, linux-arm-kernel, linux-samsung-soc, linux-kernel On Thu, Feb 20, 2020 at 11:26:27AM +0100, Greg Kroah-Hartman wrote: > There is no need to tie this driver to only a specific SoC, or compile > test, so remove that dependancy from the Kconfig rules. > > Cc: Kukjin Kim <kgene@kernel.org> > Cc: Donghoon Yu <hoony.yu@samsung.com> > Cc: Hyunki Koo <kkoos00@naver.com> > Cc: HYUN-KI KOO <hyunki00.koo@samsung.com> > Cc: Shinbeom Choi <sbeom.choi@samsung.com> > Cc: Krzysztof Kozlowski <krzk@kernel.org> > Cc: Jiri Slaby <jslaby@suse.com> > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-samsung-soc@vger.kernel.org > Cc: linux-serial@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > --- > drivers/tty/serial/Kconfig | 1 - > 1 file changed, 1 deletion(-) Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org> Best regards, Krzysztof ^ permalink raw reply [flat|nested] 10+ messages in thread
[parent not found: <CGME20200220121333eucas1p26befa95831b44a793822b4f07b37d2cc@eucas1p2.samsung.com>]
* Re: [PATCH 1/2] tty: serial: samsung_tty: build it for any platform [not found] ` <CGME20200220121333eucas1p26befa95831b44a793822b4f07b37d2cc@eucas1p2.samsung.com> @ 2020-02-20 12:13 ` Bartlomiej Zolnierkiewicz 2020-02-25 8:52 ` Geert Uytterhoeven 0 siblings, 1 reply; 10+ messages in thread From: Bartlomiej Zolnierkiewicz @ 2020-02-20 12:13 UTC (permalink / raw) To: Greg Kroah-Hartman Cc: linux-serial, Kukjin Kim, Donghoon Yu, Hyunki Koo, HYUN-KI KOO, Shinbeom Choi, Krzysztof Kozlowski, Jiri Slaby, linux-arm-kernel, linux-samsung-soc, linux-kernel Hi Greg, On 2/20/20 11:26 AM, Greg Kroah-Hartman wrote: > There is no need to tie this driver to only a specific SoC, or compile > test, so remove that dependancy from the Kconfig rules. samsung_tty driver is hardware specific driver so why should we build it for any platform? This change seems to defeat the whole purpose behind COMPILE_TEST config option (which allows us to build hardware-specific drivers without needlessly presenting the user with tons of non-relevant config options). Please explain this change some more, are you planing to remove COMPILE_TEST config option? Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics > Cc: Kukjin Kim <kgene@kernel.org> > Cc: Donghoon Yu <hoony.yu@samsung.com> > Cc: Hyunki Koo <kkoos00@naver.com> > Cc: HYUN-KI KOO <hyunki00.koo@samsung.com> > Cc: Shinbeom Choi <sbeom.choi@samsung.com> > Cc: Krzysztof Kozlowski <krzk@kernel.org> > Cc: Jiri Slaby <jslaby@suse.com> > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-samsung-soc@vger.kernel.org > Cc: linux-serial@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > --- > drivers/tty/serial/Kconfig | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig > index 52eaac21ff9f..a310bd22f1e2 100644 > --- a/drivers/tty/serial/Kconfig > +++ b/drivers/tty/serial/Kconfig > @@ -237,7 +237,6 @@ config SERIAL_CLPS711X_CONSOLE > > config SERIAL_SAMSUNG > tristate "Samsung SoC serial support" > - depends on PLAT_SAMSUNG || ARCH_EXYNOS || COMPILE_TEST > select SERIAL_CORE > help > Support for the on-chip UARTs on the Samsung S3C24XX series CPUs, > > base-commit: 11a48a5a18c63fd7621bb050228cebf13566e4d8 ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 1/2] tty: serial: samsung_tty: build it for any platform 2020-02-20 12:13 ` Bartlomiej Zolnierkiewicz @ 2020-02-25 8:52 ` Geert Uytterhoeven 2020-02-25 20:41 ` Greg Kroah-Hartman 0 siblings, 1 reply; 10+ messages in thread From: Geert Uytterhoeven @ 2020-02-25 8:52 UTC (permalink / raw) To: Bartlomiej Zolnierkiewicz Cc: Greg Kroah-Hartman, Donghoon Yu, linux-samsung-soc, Linux Kernel Mailing List, Krzysztof Kozlowski, Shinbeom Choi, Hyunki Koo, Kukjin Kim, Linux ARM, open list:SERIAL DRIVERS, Jiri Slaby, HYUN-KI KOO On Thu, Feb 20, 2020 at 1:13 PM Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> wrote: > On 2/20/20 11:26 AM, Greg Kroah-Hartman wrote: > > There is no need to tie this driver to only a specific SoC, or compile > > test, so remove that dependancy from the Kconfig rules. > > samsung_tty driver is hardware specific driver so why should we > build it for any platform? > > This change seems to defeat the whole purpose behind COMPILE_TEST > config option (which allows us to build hardware-specific drivers > without needlessly presenting the user with tons of non-relevant > config options). > > Please explain this change some more, are you planing to remove > COMPILE_TEST config option? +1 I was just going to send a revert... > > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > > --- a/drivers/tty/serial/Kconfig > > +++ b/drivers/tty/serial/Kconfig > > @@ -237,7 +237,6 @@ config SERIAL_CLPS711X_CONSOLE > > > > config SERIAL_SAMSUNG > > tristate "Samsung SoC serial support" > > - depends on PLAT_SAMSUNG || ARCH_EXYNOS || COMPILE_TEST > > select SERIAL_CORE > > help > > Support for the on-chip UARTs on the Samsung S3C24XX series CPUs, > > > > base-commit: 11a48a5a18c63fd7621bb050228cebf13566e4d8 Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 1/2] tty: serial: samsung_tty: build it for any platform 2020-02-25 8:52 ` Geert Uytterhoeven @ 2020-02-25 20:41 ` Greg Kroah-Hartman 2020-02-25 21:22 ` Geert Uytterhoeven 0 siblings, 1 reply; 10+ messages in thread From: Greg Kroah-Hartman @ 2020-02-25 20:41 UTC (permalink / raw) To: Geert Uytterhoeven Cc: Bartlomiej Zolnierkiewicz, Donghoon Yu, linux-samsung-soc, Linux Kernel Mailing List, Krzysztof Kozlowski, Shinbeom Choi, Hyunki Koo, Kukjin Kim, Linux ARM, open list:SERIAL DRIVERS, Jiri Slaby, HYUN-KI KOO On Tue, Feb 25, 2020 at 09:52:38AM +0100, Geert Uytterhoeven wrote: > On Thu, Feb 20, 2020 at 1:13 PM Bartlomiej Zolnierkiewicz > <b.zolnierkie@samsung.com> wrote: > > On 2/20/20 11:26 AM, Greg Kroah-Hartman wrote: > > > There is no need to tie this driver to only a specific SoC, or compile > > > test, so remove that dependancy from the Kconfig rules. > > > > samsung_tty driver is hardware specific driver so why should we > > build it for any platform? Why not? Seriously, this "only this one specific SoC is allowed to build this driver" is crazy. It prevents anyone from building a generic kernel with drivers as a module which are loaded as needed. That needs to be fixed, and removing this unneeded dependancy on this driver allows it to be build for any system and then only loaded when needed. > > This change seems to defeat the whole purpose behind COMPILE_TEST > > config option (which allows us to build hardware-specific drivers > > without needlessly presenting the user with tons of non-relevant > > config options). > > > > Please explain this change some more, are you planing to remove > > COMPILE_TEST config option? I want to get rid of this: > > > - depends on PLAT_SAMSUNG || ARCH_EXYNOS || COMPILE_TEST We should not need PLAT_SAMSUNG or ARCH_EXYNOS at all, we should be able to build an arm64 kernel for all platforms. thanks, greg k-h ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 1/2] tty: serial: samsung_tty: build it for any platform 2020-02-25 20:41 ` Greg Kroah-Hartman @ 2020-02-25 21:22 ` Geert Uytterhoeven 2020-02-26 10:11 ` Bartlomiej Zolnierkiewicz 0 siblings, 1 reply; 10+ messages in thread From: Geert Uytterhoeven @ 2020-02-25 21:22 UTC (permalink / raw) To: Greg Kroah-Hartman Cc: Bartlomiej Zolnierkiewicz, Donghoon Yu, linux-samsung-soc, Linux Kernel Mailing List, Krzysztof Kozlowski, Shinbeom Choi, Hyunki Koo, Kukjin Kim, Linux ARM, open list:SERIAL DRIVERS, Jiri Slaby, HYUN-KI KOO Hi Greg, On Tue, Feb 25, 2020 at 9:41 PM Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote: > On Tue, Feb 25, 2020 at 09:52:38AM +0100, Geert Uytterhoeven wrote: > > On Thu, Feb 20, 2020 at 1:13 PM Bartlomiej Zolnierkiewicz > > <b.zolnierkie@samsung.com> wrote: > > > On 2/20/20 11:26 AM, Greg Kroah-Hartman wrote: > > > > There is no need to tie this driver to only a specific SoC, or compile > > > > test, so remove that dependancy from the Kconfig rules. > > > > > > samsung_tty driver is hardware specific driver so why should we > > > build it for any platform? > > Why not? Because this driver won't bind to a device anyway, when the kernel is configured without Samsung SoC support. It will just bloat the kernel, and asking this question is a silly waste of time for anyone building a (non-generic) kernel for a non-Samsung SoC. > Seriously, this "only this one specific SoC is allowed to build this > driver" is crazy. It prevents anyone from building a generic kernel > with drivers as a module which are loaded as needed. A generic kernel will include Samsung SoC support, hence PLAT_SAMSUNG or ARCH_EXYNOS will be enabled. > That needs to be fixed, and removing this unneeded dependancy on this > driver allows it to be build for any system and then only loaded when > needed. It can only be loaded on a Samsung system, which requires PLAT_SAMSUNG or ARCH_EXYNOS anyway. It's not like a Samsung serial device can be plugged into your PC's PCI bus or so, it only exists on Samsung SoCs. > > > This change seems to defeat the whole purpose behind COMPILE_TEST > > > config option (which allows us to build hardware-specific drivers > > > without needlessly presenting the user with tons of non-relevant > > > config options). > > > > > > Please explain this change some more, are you planing to remove > > > COMPILE_TEST config option? > > I want to get rid of this: IMHO we need _more_ of these dependencies, to avoid all these silly questions when they don't make sense. > > > > - depends on PLAT_SAMSUNG || ARCH_EXYNOS || COMPILE_TEST > > We should not need PLAT_SAMSUNG or ARCH_EXYNOS at all, we should be able > to build an arm64 kernel for all platforms. An arm64 kernel for all platforms will have ARCH_EXYNOS enabled. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 1/2] tty: serial: samsung_tty: build it for any platform 2020-02-25 21:22 ` Geert Uytterhoeven @ 2020-02-26 10:11 ` Bartlomiej Zolnierkiewicz 0 siblings, 0 replies; 10+ messages in thread From: Bartlomiej Zolnierkiewicz @ 2020-02-26 10:11 UTC (permalink / raw) To: Geert Uytterhoeven, Greg Kroah-Hartman Cc: Donghoon Yu, linux-samsung-soc, Linux Kernel Mailing List, Krzysztof Kozlowski, Shinbeom Choi, Hyunki Koo, Kukjin Kim, Linux ARM, open list:SERIAL DRIVERS, Jiri Slaby, HYUN-KI KOO On 2/25/20 10:22 PM, Geert Uytterhoeven wrote: > Hi Greg, > > On Tue, Feb 25, 2020 at 9:41 PM Greg Kroah-Hartman > <gregkh@linuxfoundation.org> wrote: >> On Tue, Feb 25, 2020 at 09:52:38AM +0100, Geert Uytterhoeven wrote: >>> On Thu, Feb 20, 2020 at 1:13 PM Bartlomiej Zolnierkiewicz >>> <b.zolnierkie@samsung.com> wrote: >>>> On 2/20/20 11:26 AM, Greg Kroah-Hartman wrote: >>>>> There is no need to tie this driver to only a specific SoC, or compile >>>>> test, so remove that dependancy from the Kconfig rules. >>>> >>>> samsung_tty driver is hardware specific driver so why should we >>>> build it for any platform? >> >> Why not? > > Because this driver won't bind to a device anyway, when the kernel is > configured without Samsung SoC support. It will just bloat the kernel, > and asking this question is a silly waste of time for anyone building a > (non-generic) kernel for a non-Samsung SoC. > >> Seriously, this "only this one specific SoC is allowed to build this >> driver" is crazy. It prevents anyone from building a generic kernel >> with drivers as a module which are loaded as needed. > > A generic kernel will include Samsung SoC support, hence PLAT_SAMSUNG > or ARCH_EXYNOS will be enabled. > >> That needs to be fixed, and removing this unneeded dependancy on this >> driver allows it to be build for any system and then only loaded when >> needed. > > It can only be loaded on a Samsung system, which requires PLAT_SAMSUNG > or ARCH_EXYNOS anyway. > It's not like a Samsung serial device can be plugged into your PC's PCI > bus or so, it only exists on Samsung SoCs. > >>>> This change seems to defeat the whole purpose behind COMPILE_TEST >>>> config option (which allows us to build hardware-specific drivers >>>> without needlessly presenting the user with tons of non-relevant >>>> config options). >>>> >>>> Please explain this change some more, are you planing to remove >>>> COMPILE_TEST config option? >> >> I want to get rid of this: > > IMHO we need _more_ of these dependencies, to avoid all these silly questions > when they don't make sense. > >>>>> - depends on PLAT_SAMSUNG || ARCH_EXYNOS || COMPILE_TEST >> >> We should not need PLAT_SAMSUNG or ARCH_EXYNOS at all, we should be able >> to build an arm64 kernel for all platforms. > > An arm64 kernel for all platforms will have ARCH_EXYNOS enabled. +1 on all comments from Geert IMHO this change should be reverted (it doesn't fix anything and only makes kernel configuration harder). Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics ^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2020-02-26 10:11 UTC | newest] Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2020-02-20 10:26 [PATCH 1/2] tty: serial: samsung_tty: build it for any platform Greg Kroah-Hartman 2020-02-20 10:26 ` [PATCH 2/2] tty: serial: samsung_tty: remove SERIAL_SAMSUNG_DEBUG Greg Kroah-Hartman 2020-02-20 10:55 ` Krzysztof Kozlowski 2020-02-20 11:09 ` Greg Kroah-Hartman 2020-02-20 10:54 ` [PATCH 1/2] tty: serial: samsung_tty: build it for any platform Krzysztof Kozlowski [not found] ` <CGME20200220121333eucas1p26befa95831b44a793822b4f07b37d2cc@eucas1p2.samsung.com> 2020-02-20 12:13 ` Bartlomiej Zolnierkiewicz 2020-02-25 8:52 ` Geert Uytterhoeven 2020-02-25 20:41 ` Greg Kroah-Hartman 2020-02-25 21:22 ` Geert Uytterhoeven 2020-02-26 10:11 ` Bartlomiej Zolnierkiewicz
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).