* [PATCH] staging: greybus: match parenthesis alignment
@ 2020-02-19 19:56 Kaaira Gupta
2020-02-19 20:19 ` Greg Kroah-Hartman
2020-02-24 11:49 ` [greybus-dev] " Laurent Pinchart
0 siblings, 2 replies; 4+ messages in thread
From: Kaaira Gupta @ 2020-02-19 19:56 UTC (permalink / raw)
To: Vaibhav Agarwal, Mark Greer, Johan Hovold, Alex Elder,
Greg Kroah-Hartman, greybus-dev, devel, linux-kernel
Fix checkpatch.pl warning of alignment should match open parenthesis in
audio_codec.c
Signed-off-by: Kaaira Gupta <kgupta@es.iitr.ac.in>
---
drivers/staging/greybus/audio_codec.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/greybus/audio_codec.c b/drivers/staging/greybus/audio_codec.c
index 08746c85dea6..d62f91f4e9a2 100644
--- a/drivers/staging/greybus/audio_codec.c
+++ b/drivers/staging/greybus/audio_codec.c
@@ -70,7 +70,7 @@ static int gbaudio_module_enable_tx(struct gbaudio_codec_info *codec,
i2s_port = 0; /* fixed for now */
cportid = data->connection->hd_cport_id;
ret = gb_audio_apbridgea_register_cport(data->connection,
- i2s_port, cportid,
+ i2s_port, cportid,
AUDIO_APBRIDGEA_DIRECTION_TX);
if (ret) {
dev_err_ratelimited(module->dev,
@@ -160,7 +160,7 @@ static int gbaudio_module_disable_tx(struct gbaudio_module_info *module, int id)
i2s_port = 0; /* fixed for now */
cportid = data->connection->hd_cport_id;
ret = gb_audio_apbridgea_unregister_cport(data->connection,
- i2s_port, cportid,
+ i2s_port, cportid,
AUDIO_APBRIDGEA_DIRECTION_TX);
if (ret) {
dev_err_ratelimited(module->dev,
@@ -205,7 +205,7 @@ static int gbaudio_module_enable_rx(struct gbaudio_codec_info *codec,
i2s_port = 0; /* fixed for now */
cportid = data->connection->hd_cport_id;
ret = gb_audio_apbridgea_register_cport(data->connection,
- i2s_port, cportid,
+ i2s_port, cportid,
AUDIO_APBRIDGEA_DIRECTION_RX);
if (ret) {
dev_err_ratelimited(module->dev,
@@ -295,7 +295,7 @@ static int gbaudio_module_disable_rx(struct gbaudio_module_info *module, int id)
i2s_port = 0; /* fixed for now */
cportid = data->connection->hd_cport_id;
ret = gb_audio_apbridgea_unregister_cport(data->connection,
- i2s_port, cportid,
+ i2s_port, cportid,
AUDIO_APBRIDGEA_DIRECTION_RX);
if (ret) {
dev_err_ratelimited(module->dev,
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] staging: greybus: match parenthesis alignment
2020-02-19 19:56 [PATCH] staging: greybus: match parenthesis alignment Kaaira Gupta
@ 2020-02-19 20:19 ` Greg Kroah-Hartman
2020-02-24 11:49 ` [greybus-dev] " Laurent Pinchart
1 sibling, 0 replies; 4+ messages in thread
From: Greg Kroah-Hartman @ 2020-02-19 20:19 UTC (permalink / raw)
To: Kaaira Gupta
Cc: Vaibhav Agarwal, Mark Greer, Johan Hovold, Alex Elder,
greybus-dev, devel, linux-kernel
On Thu, Feb 20, 2020 at 01:26:51AM +0530, Kaaira Gupta wrote:
> Fix checkpatch.pl warning of alignment should match open parenthesis in
> audio_codec.c
>
> Signed-off-by: Kaaira Gupta <kgupta@es.iitr.ac.in>
> ---
> drivers/staging/greybus/audio_codec.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/greybus/audio_codec.c b/drivers/staging/greybus/audio_codec.c
> index 08746c85dea6..d62f91f4e9a2 100644
> --- a/drivers/staging/greybus/audio_codec.c
> +++ b/drivers/staging/greybus/audio_codec.c
> @@ -70,7 +70,7 @@ static int gbaudio_module_enable_tx(struct gbaudio_codec_info *codec,
> i2s_port = 0; /* fixed for now */
> cportid = data->connection->hd_cport_id;
> ret = gb_audio_apbridgea_register_cport(data->connection,
> - i2s_port, cportid,
> + i2s_port, cportid,
> AUDIO_APBRIDGEA_DIRECTION_TX);
You can't do it for one line, and not all of the lines.
And if you do it for all lines, then you push past the line-length.
So you are back to what we currently have, which is the best we can do,
sorry.
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [greybus-dev] [PATCH] staging: greybus: match parenthesis alignment
2020-02-19 19:56 [PATCH] staging: greybus: match parenthesis alignment Kaaira Gupta
2020-02-19 20:19 ` Greg Kroah-Hartman
@ 2020-02-24 11:49 ` Laurent Pinchart
2020-02-24 16:53 ` Kaaira Gupta
1 sibling, 1 reply; 4+ messages in thread
From: Laurent Pinchart @ 2020-02-24 11:49 UTC (permalink / raw)
To: Kaaira Gupta
Cc: Vaibhav Agarwal, Mark Greer, Johan Hovold, Alex Elder,
Greg Kroah-Hartman, greybus-dev, devel, linux-kernel
Hi Kaaira,
Thank you for the patch.
On Thu, Feb 20, 2020 at 01:26:51AM +0530, Kaaira Gupta wrote:
> Fix checkpatch.pl warning of alignment should match open parenthesis in
> audio_codec.c
>
> Signed-off-by: Kaaira Gupta <kgupta@es.iitr.ac.in>
> ---
> drivers/staging/greybus/audio_codec.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/greybus/audio_codec.c b/drivers/staging/greybus/audio_codec.c
> index 08746c85dea6..d62f91f4e9a2 100644
> --- a/drivers/staging/greybus/audio_codec.c
> +++ b/drivers/staging/greybus/audio_codec.c
> @@ -70,7 +70,7 @@ static int gbaudio_module_enable_tx(struct gbaudio_codec_info *codec,
> i2s_port = 0; /* fixed for now */
> cportid = data->connection->hd_cport_id;
> ret = gb_audio_apbridgea_register_cport(data->connection,
> - i2s_port, cportid,
> + i2s_port, cportid,
> AUDIO_APBRIDGEA_DIRECTION_TX);
I'm curious to know why you think the line you changed deserves a
modification, while the next one doesn't :-)
> if (ret) {
> dev_err_ratelimited(module->dev,
> @@ -160,7 +160,7 @@ static int gbaudio_module_disable_tx(struct gbaudio_module_info *module, int id)
> i2s_port = 0; /* fixed for now */
> cportid = data->connection->hd_cport_id;
> ret = gb_audio_apbridgea_unregister_cport(data->connection,
> - i2s_port, cportid,
> + i2s_port, cportid,
> AUDIO_APBRIDGEA_DIRECTION_TX);
> if (ret) {
> dev_err_ratelimited(module->dev,
> @@ -205,7 +205,7 @@ static int gbaudio_module_enable_rx(struct gbaudio_codec_info *codec,
> i2s_port = 0; /* fixed for now */
> cportid = data->connection->hd_cport_id;
> ret = gb_audio_apbridgea_register_cport(data->connection,
> - i2s_port, cportid,
> + i2s_port, cportid,
> AUDIO_APBRIDGEA_DIRECTION_RX);
> if (ret) {
> dev_err_ratelimited(module->dev,
> @@ -295,7 +295,7 @@ static int gbaudio_module_disable_rx(struct gbaudio_module_info *module, int id)
> i2s_port = 0; /* fixed for now */
> cportid = data->connection->hd_cport_id;
> ret = gb_audio_apbridgea_unregister_cport(data->connection,
> - i2s_port, cportid,
> + i2s_port, cportid,
> AUDIO_APBRIDGEA_DIRECTION_RX);
> if (ret) {
> dev_err_ratelimited(module->dev,
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [greybus-dev] [PATCH] staging: greybus: match parenthesis alignment
2020-02-24 11:49 ` [greybus-dev] " Laurent Pinchart
@ 2020-02-24 16:53 ` Kaaira Gupta
0 siblings, 0 replies; 4+ messages in thread
From: Kaaira Gupta @ 2020-02-24 16:53 UTC (permalink / raw)
To: Laurent Pinchart, Vaibhav Agarwal, Mark Greer, Johan Hovold,
Alex Elder, Greg Kroah-Hartman, greybus-dev, devel, linux-kernel
On Mon, Feb 24, 2020 at 01:49:29PM +0200, Laurent Pinchart wrote:
> Hi Kaaira,
>
> Thank you for the patch.
>
> On Thu, Feb 20, 2020 at 01:26:51AM +0530, Kaaira Gupta wrote:
> > Fix checkpatch.pl warning of alignment should match open parenthesis in
> > audio_codec.c
> >
> > Signed-off-by: Kaaira Gupta <kgupta@es.iitr.ac.in>
> > ---
> > drivers/staging/greybus/audio_codec.c | 8 ++++----
> > 1 file changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/staging/greybus/audio_codec.c b/drivers/staging/greybus/audio_codec.c
> > index 08746c85dea6..d62f91f4e9a2 100644
> > --- a/drivers/staging/greybus/audio_codec.c
> > +++ b/drivers/staging/greybus/audio_codec.c
> > @@ -70,7 +70,7 @@ static int gbaudio_module_enable_tx(struct gbaudio_codec_info *codec,
> > i2s_port = 0; /* fixed for now */
> > cportid = data->connection->hd_cport_id;
> > ret = gb_audio_apbridgea_register_cport(data->connection,
> > - i2s_port, cportid,
> > + i2s_port, cportid,
> > AUDIO_APBRIDGEA_DIRECTION_TX);
>
> I'm curious to know why you think the line you changed deserves a
> modification, while the next one doesn't :-)
According to me, both the lines deserve a modification. But I did not do
that as changing the other line was throwing 'greater than 80
characters' warning and I wasn't sure if I should go ahead with the
changes anyhow.
>
> > if (ret) {
> > dev_err_ratelimited(module->dev,
> > @@ -160,7 +160,7 @@ static int gbaudio_module_disable_tx(struct gbaudio_module_info *module, int id)
> > i2s_port = 0; /* fixed for now */
> > cportid = data->connection->hd_cport_id;
> > ret = gb_audio_apbridgea_unregister_cport(data->connection,
> > - i2s_port, cportid,
> > + i2s_port, cportid,
> > AUDIO_APBRIDGEA_DIRECTION_TX);
> > if (ret) {
> > dev_err_ratelimited(module->dev,
> > @@ -205,7 +205,7 @@ static int gbaudio_module_enable_rx(struct gbaudio_codec_info *codec,
> > i2s_port = 0; /* fixed for now */
> > cportid = data->connection->hd_cport_id;
> > ret = gb_audio_apbridgea_register_cport(data->connection,
> > - i2s_port, cportid,
> > + i2s_port, cportid,
> > AUDIO_APBRIDGEA_DIRECTION_RX);
> > if (ret) {
> > dev_err_ratelimited(module->dev,
> > @@ -295,7 +295,7 @@ static int gbaudio_module_disable_rx(struct gbaudio_module_info *module, int id)
> > i2s_port = 0; /* fixed for now */
> > cportid = data->connection->hd_cport_id;
> > ret = gb_audio_apbridgea_unregister_cport(data->connection,
> > - i2s_port, cportid,
> > + i2s_port, cportid,
> > AUDIO_APBRIDGEA_DIRECTION_RX);
> > if (ret) {
> > dev_err_ratelimited(module->dev,
>
> --
> Regards,
>
> Laurent Pinchart
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-02-24 16:53 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-19 19:56 [PATCH] staging: greybus: match parenthesis alignment Kaaira Gupta
2020-02-19 20:19 ` Greg Kroah-Hartman
2020-02-24 11:49 ` [greybus-dev] " Laurent Pinchart
2020-02-24 16:53 ` Kaaira Gupta
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).