* [PATCH] can: tcan4x5x: Replace depends on REGMAP_SPI with depends on SPI
@ 2020-04-13 14:10 Enric Balletbo i Serra
2020-04-17 12:00 ` Dan Murphy
0 siblings, 1 reply; 2+ messages in thread
From: Enric Balletbo i Serra @ 2020-04-13 14:10 UTC (permalink / raw)
To: linux-kernel
Cc: Collabora Kernel ML, Dan Murphy, David S. Miller,
Greg Kroah-Hartman, Marc Kleine-Budde, Thomas Gleixner,
Wolfgang Grandegger, linux-can, netdev
regmap is a library function that gets selected by drivers that need
it. No driver modules should depend on it. Instead depends on SPI and
select REGMAP_SPI. Depending on REGMAP_SPI makes this driver only build
if another driver already selected REGMAP_SPI, as the symbol can't be
selected through the menu kernel configuration.
Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
---
drivers/net/can/m_can/Kconfig | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/can/m_can/Kconfig b/drivers/net/can/m_can/Kconfig
index 1ff0b7fe81d6..c10932a7f1fe 100644
--- a/drivers/net/can/m_can/Kconfig
+++ b/drivers/net/can/m_can/Kconfig
@@ -16,7 +16,8 @@ config CAN_M_CAN_PLATFORM
config CAN_M_CAN_TCAN4X5X
depends on CAN_M_CAN
- depends on REGMAP_SPI
+ depends on SPI
+ select REGMAP_SPI
tristate "TCAN4X5X M_CAN device"
---help---
Say Y here if you want support for Texas Instruments TCAN4x5x
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] can: tcan4x5x: Replace depends on REGMAP_SPI with depends on SPI
2020-04-13 14:10 [PATCH] can: tcan4x5x: Replace depends on REGMAP_SPI with depends on SPI Enric Balletbo i Serra
@ 2020-04-17 12:00 ` Dan Murphy
0 siblings, 0 replies; 2+ messages in thread
From: Dan Murphy @ 2020-04-17 12:00 UTC (permalink / raw)
To: Enric Balletbo i Serra, linux-kernel
Cc: Collabora Kernel ML, David S. Miller, Greg Kroah-Hartman,
Marc Kleine-Budde, Thomas Gleixner, Wolfgang Grandegger,
linux-can, netdev
Enric
On 4/13/20 9:10 AM, Enric Balletbo i Serra wrote:
> regmap is a library function that gets selected by drivers that need
> it. No driver modules should depend on it. Instead depends on SPI and
> select REGMAP_SPI. Depending on REGMAP_SPI makes this driver only build
> if another driver already selected REGMAP_SPI, as the symbol can't be
> selected through the menu kernel configuration.
>
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
> ---
>
> drivers/net/can/m_can/Kconfig | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/can/m_can/Kconfig b/drivers/net/can/m_can/Kconfig
> index 1ff0b7fe81d6..c10932a7f1fe 100644
> --- a/drivers/net/can/m_can/Kconfig
> +++ b/drivers/net/can/m_can/Kconfig
> @@ -16,7 +16,8 @@ config CAN_M_CAN_PLATFORM
>
> config CAN_M_CAN_TCAN4X5X
> depends on CAN_M_CAN
> - depends on REGMAP_SPI
> + depends on SPI
> + select REGMAP_SPI
> tristate "TCAN4X5X M_CAN device"
> ---help---
> Say Y here if you want support for Texas Instruments TCAN4x5x
Reviewed-by: Dan Murphy <dmurphy@ti.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-04-17 12:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-13 14:10 [PATCH] can: tcan4x5x: Replace depends on REGMAP_SPI with depends on SPI Enric Balletbo i Serra
2020-04-17 12:00 ` Dan Murphy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).