* [PATCH] media: i2c: imx219: remove redundant writes
@ 2020-04-13 15:51 Sameer Puri
2020-04-28 12:49 ` Dave Stevenson
0 siblings, 1 reply; 2+ messages in thread
From: Sameer Puri @ 2020-04-13 15:51 UTC (permalink / raw)
To: dave.stevenson; +Cc: mchehab, linux-media, linux-kernel
These writes to 0x162, 0x163 already appear earlier in the struct for
the 1920x1080 mode and do not need to be repeated.
Signed-off-by: Sameer Puri <purisame@spuri.io>
---
drivers/media/i2c/imx219.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/media/i2c/imx219.c b/drivers/media/i2c/imx219.c
index cb03bdec1f9c..53dafb7f5f2c 100644
--- a/drivers/media/i2c/imx219.c
+++ b/drivers/media/i2c/imx219.c
@@ -253,8 +253,6 @@ static const struct imx219_reg mode_1920_1080_regs[] = {
{0x4793, 0x10},
{0x4797, 0x0e},
{0x479b, 0x0e},
- {0x0162, 0x0d},
- {0x0163, 0x78},
};
static const struct imx219_reg mode_1640_1232_regs[] = {
base-commit: 8f3d9f354286745c751374f5f1fcafee6b3f3136
--
2.26.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] media: i2c: imx219: remove redundant writes
2020-04-13 15:51 [PATCH] media: i2c: imx219: remove redundant writes Sameer Puri
@ 2020-04-28 12:49 ` Dave Stevenson
0 siblings, 0 replies; 2+ messages in thread
From: Dave Stevenson @ 2020-04-28 12:49 UTC (permalink / raw)
To: Sameer Puri; +Cc: Mauro Carvalho Chehab, Linux Media Mailing List, LKML
Hi Sameer
Thanks for the patch.
On Mon, 13 Apr 2020 at 16:51, Sameer Puri <purisame@spuri.io> wrote:
>
> These writes to 0x162, 0x163 already appear earlier in the struct for
> the 1920x1080 mode and do not need to be repeated.
>
> Signed-off-by: Sameer Puri <purisame@spuri.io>
Reviewed-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
If I was going to be fussy, it would be nice to have the writes to
0x162/0x163 in a consistent place in the table, which is generally the
end (I'm aware that the 640x480 mode has it in the middle). Personally
I'm not overly worried, but others may prefer it.
> ---
> drivers/media/i2c/imx219.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/media/i2c/imx219.c b/drivers/media/i2c/imx219.c
> index cb03bdec1f9c..53dafb7f5f2c 100644
> --- a/drivers/media/i2c/imx219.c
> +++ b/drivers/media/i2c/imx219.c
> @@ -253,8 +253,6 @@ static const struct imx219_reg mode_1920_1080_regs[] = {
> {0x4793, 0x10},
> {0x4797, 0x0e},
> {0x479b, 0x0e},
> - {0x0162, 0x0d},
> - {0x0163, 0x78},
> };
>
> static const struct imx219_reg mode_1640_1232_regs[] = {
>
> base-commit: 8f3d9f354286745c751374f5f1fcafee6b3f3136
> --
> 2.26.0
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-04-28 12:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-13 15:51 [PATCH] media: i2c: imx219: remove redundant writes Sameer Puri
2020-04-28 12:49 ` Dave Stevenson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).