* [PATCH] KVM: arm64: Drop PTE_S2_MEMATTR_MASK
@ 2020-04-15 10:57 Zenghui Yu
2020-04-16 15:36 ` Marc Zyngier
2020-04-28 14:49 ` Will Deacon
0 siblings, 2 replies; 5+ messages in thread
From: Zenghui Yu @ 2020-04-15 10:57 UTC (permalink / raw)
To: kvmarm, linux-arm-kernel, linux-kernel
Cc: maz, catalin.marinas, will, wanghaibin.wang, Zenghui Yu
The only user of PTE_S2_MEMATTR_MASK macro had been removed since
commit a501e32430d4 ("arm64: Clean up the default pgprot setting").
It has been about six years and no one has used it again.
Let's drop it.
Signed-off-by: Zenghui Yu <yuzenghui@huawei.com>
---
arch/arm64/include/asm/pgtable-hwdef.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm64/include/asm/pgtable-hwdef.h b/arch/arm64/include/asm/pgtable-hwdef.h
index 6bf5e650da78..99315bdca0e6 100644
--- a/arch/arm64/include/asm/pgtable-hwdef.h
+++ b/arch/arm64/include/asm/pgtable-hwdef.h
@@ -190,7 +190,6 @@
* Memory Attribute override for Stage-2 (MemAttr[3:0])
*/
#define PTE_S2_MEMATTR(t) (_AT(pteval_t, (t)) << 2)
-#define PTE_S2_MEMATTR_MASK (_AT(pteval_t, 0xf) << 2)
/*
* EL2/HYP PTE/PMD definitions
--
2.19.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] KVM: arm64: Drop PTE_S2_MEMATTR_MASK
2020-04-15 10:57 [PATCH] KVM: arm64: Drop PTE_S2_MEMATTR_MASK Zenghui Yu
@ 2020-04-16 15:36 ` Marc Zyngier
2020-04-16 17:05 ` Will Deacon
2020-04-28 14:49 ` Will Deacon
1 sibling, 1 reply; 5+ messages in thread
From: Marc Zyngier @ 2020-04-16 15:36 UTC (permalink / raw)
To: Zenghui Yu
Cc: kvmarm, linux-arm-kernel, linux-kernel, catalin.marinas, will,
wanghaibin.wang
On Wed, 15 Apr 2020 18:57:46 +0800
Zenghui Yu <yuzenghui@huawei.com> wrote:
> The only user of PTE_S2_MEMATTR_MASK macro had been removed since
> commit a501e32430d4 ("arm64: Clean up the default pgprot setting").
> It has been about six years and no one has used it again.
>
> Let's drop it.
>
> Signed-off-by: Zenghui Yu <yuzenghui@huawei.com>
> ---
> arch/arm64/include/asm/pgtable-hwdef.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm64/include/asm/pgtable-hwdef.h b/arch/arm64/include/asm/pgtable-hwdef.h
> index 6bf5e650da78..99315bdca0e6 100644
> --- a/arch/arm64/include/asm/pgtable-hwdef.h
> +++ b/arch/arm64/include/asm/pgtable-hwdef.h
> @@ -190,7 +190,6 @@
> * Memory Attribute override for Stage-2 (MemAttr[3:0])
> */
> #define PTE_S2_MEMATTR(t) (_AT(pteval_t, (t)) << 2)
> -#define PTE_S2_MEMATTR_MASK (_AT(pteval_t, 0xf) << 2)
>
> /*
> * EL2/HYP PTE/PMD definitions
Looks good to me. Catalin, Will: do you want to take this directly? If
so please add my:
Acked-by: Marc Zyngier <maz@kernel.org>
Otherwise, I'll route it via the KVM tree.
Thanks,
M.
--
Jazz is not dead. It just smells funny...
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] KVM: arm64: Drop PTE_S2_MEMATTR_MASK
2020-04-16 15:36 ` Marc Zyngier
@ 2020-04-16 17:05 ` Will Deacon
2020-04-16 17:24 ` Marc Zyngier
0 siblings, 1 reply; 5+ messages in thread
From: Will Deacon @ 2020-04-16 17:05 UTC (permalink / raw)
To: Marc Zyngier
Cc: Zenghui Yu, kvmarm, linux-arm-kernel, linux-kernel,
catalin.marinas, wanghaibin.wang
On Thu, Apr 16, 2020 at 04:36:05PM +0100, Marc Zyngier wrote:
> On Wed, 15 Apr 2020 18:57:46 +0800
> Zenghui Yu <yuzenghui@huawei.com> wrote:
>
> > The only user of PTE_S2_MEMATTR_MASK macro had been removed since
> > commit a501e32430d4 ("arm64: Clean up the default pgprot setting").
> > It has been about six years and no one has used it again.
> >
> > Let's drop it.
> >
> > Signed-off-by: Zenghui Yu <yuzenghui@huawei.com>
> > ---
> > arch/arm64/include/asm/pgtable-hwdef.h | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/arch/arm64/include/asm/pgtable-hwdef.h b/arch/arm64/include/asm/pgtable-hwdef.h
> > index 6bf5e650da78..99315bdca0e6 100644
> > --- a/arch/arm64/include/asm/pgtable-hwdef.h
> > +++ b/arch/arm64/include/asm/pgtable-hwdef.h
> > @@ -190,7 +190,6 @@
> > * Memory Attribute override for Stage-2 (MemAttr[3:0])
> > */
> > #define PTE_S2_MEMATTR(t) (_AT(pteval_t, (t)) << 2)
> > -#define PTE_S2_MEMATTR_MASK (_AT(pteval_t, 0xf) << 2)
> >
> > /*
> > * EL2/HYP PTE/PMD definitions
>
> Looks good to me. Catalin, Will: do you want to take this directly? If
> so please add my:
>
> Acked-by: Marc Zyngier <maz@kernel.org>
>
> Otherwise, I'll route it via the KVM tree.
I can take it for 5.8 if it's not urgent.
Will
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] KVM: arm64: Drop PTE_S2_MEMATTR_MASK
2020-04-16 17:05 ` Will Deacon
@ 2020-04-16 17:24 ` Marc Zyngier
0 siblings, 0 replies; 5+ messages in thread
From: Marc Zyngier @ 2020-04-16 17:24 UTC (permalink / raw)
To: Will Deacon
Cc: Zenghui Yu, kvmarm, linux-arm-kernel, linux-kernel,
catalin.marinas, wanghaibin.wang
On 2020-04-16 18:05, Will Deacon wrote:
> On Thu, Apr 16, 2020 at 04:36:05PM +0100, Marc Zyngier wrote:
>> On Wed, 15 Apr 2020 18:57:46 +0800
>> Zenghui Yu <yuzenghui@huawei.com> wrote:
>>
>> > The only user of PTE_S2_MEMATTR_MASK macro had been removed since
>> > commit a501e32430d4 ("arm64: Clean up the default pgprot setting").
>> > It has been about six years and no one has used it again.
>> >
>> > Let's drop it.
>> >
>> > Signed-off-by: Zenghui Yu <yuzenghui@huawei.com>
>> > ---
>> > arch/arm64/include/asm/pgtable-hwdef.h | 1 -
>> > 1 file changed, 1 deletion(-)
>> >
>> > diff --git a/arch/arm64/include/asm/pgtable-hwdef.h b/arch/arm64/include/asm/pgtable-hwdef.h
>> > index 6bf5e650da78..99315bdca0e6 100644
>> > --- a/arch/arm64/include/asm/pgtable-hwdef.h
>> > +++ b/arch/arm64/include/asm/pgtable-hwdef.h
>> > @@ -190,7 +190,6 @@
>> > * Memory Attribute override for Stage-2 (MemAttr[3:0])
>> > */
>> > #define PTE_S2_MEMATTR(t) (_AT(pteval_t, (t)) << 2)
>> > -#define PTE_S2_MEMATTR_MASK (_AT(pteval_t, 0xf) << 2)
>> >
>> > /*
>> > * EL2/HYP PTE/PMD definitions
>>
>> Looks good to me. Catalin, Will: do you want to take this directly? If
>> so please add my:
>>
>> Acked-by: Marc Zyngier <maz@kernel.org>
>>
>> Otherwise, I'll route it via the KVM tree.
>
> I can take it for 5.8 if it's not urgent.
It has been there 6 years, I think we can cope with another few
months... ;-)
Thanks,
M.
--
Jazz is not dead. It just smells funny...
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] KVM: arm64: Drop PTE_S2_MEMATTR_MASK
2020-04-15 10:57 [PATCH] KVM: arm64: Drop PTE_S2_MEMATTR_MASK Zenghui Yu
2020-04-16 15:36 ` Marc Zyngier
@ 2020-04-28 14:49 ` Will Deacon
1 sibling, 0 replies; 5+ messages in thread
From: Will Deacon @ 2020-04-28 14:49 UTC (permalink / raw)
To: kvmarm, linux-arm-kernel, Zenghui Yu, linux-kernel
Cc: catalin.marinas, Will Deacon, maz
On Wed, 15 Apr 2020 18:57:46 +0800, Zenghui Yu wrote:
> The only user of PTE_S2_MEMATTR_MASK macro had been removed since
> commit a501e32430d4 ("arm64: Clean up the default pgprot setting").
> It has been about six years and no one has used it again.
>
> Let's drop it.
Applied to arm64 (for-next/misc), thanks!
[1/1] KVM: arm64: Drop PTE_S2_MEMATTR_MASK
https://git.kernel.org/arm64/c/f4be140fa33f
Cheers,
--
Will
https://fixes.arm64.dev
https://next.arm64.dev
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-04-28 14:50 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-15 10:57 [PATCH] KVM: arm64: Drop PTE_S2_MEMATTR_MASK Zenghui Yu
2020-04-16 15:36 ` Marc Zyngier
2020-04-16 17:05 ` Will Deacon
2020-04-16 17:24 ` Marc Zyngier
2020-04-28 14:49 ` Will Deacon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).