* [PATCH -next] drm/panel: remove set but not used variable 'config'
@ 2020-04-17 10:14 YueHaibing
2020-04-25 14:57 ` Sam Ravnborg
0 siblings, 1 reply; 3+ messages in thread
From: YueHaibing @ 2020-04-17 10:14 UTC (permalink / raw)
To: thierry.reding, sam, airlied, daniel; +Cc: dri-devel, linux-kernel, YueHaibing
drivers/gpu/drm/panel/panel-truly-nt35597.c:493:31: warning: variable ‘config’ set but not used [-Wunused-but-set-variable]
const struct nt35597_config *config;
^~~~~~
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/gpu/drm/panel/panel-truly-nt35597.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/panel/panel-truly-nt35597.c b/drivers/gpu/drm/panel/panel-truly-nt35597.c
index 012ca62bf30e..f0ad6081570f 100644
--- a/drivers/gpu/drm/panel/panel-truly-nt35597.c
+++ b/drivers/gpu/drm/panel/panel-truly-nt35597.c
@@ -490,9 +490,7 @@ static int truly_nt35597_panel_add(struct truly_nt35597 *ctx)
{
struct device *dev = ctx->dev;
int ret, i;
- const struct nt35597_config *config;
- config = ctx->config;
for (i = 0; i < ARRAY_SIZE(ctx->supplies); i++)
ctx->supplies[i].supply = regulator_names[i];
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH -next] drm/panel: remove set but not used variable 'config'
2020-04-17 10:14 [PATCH -next] drm/panel: remove set but not used variable 'config' YueHaibing
@ 2020-04-25 14:57 ` Sam Ravnborg
0 siblings, 0 replies; 3+ messages in thread
From: Sam Ravnborg @ 2020-04-25 14:57 UTC (permalink / raw)
To: YueHaibing; +Cc: thierry.reding, airlied, daniel, linux-kernel, dri-devel
Hi YueHaibing
On Fri, Apr 17, 2020 at 06:14:01PM +0800, YueHaibing wrote:
> drivers/gpu/drm/panel/panel-truly-nt35597.c:493:31: warning: variable ‘config’ set but not used [-Wunused-but-set-variable]
> const struct nt35597_config *config;
> ^~~~~~
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Thanks. Applied to drm-misc-next, so it will appear in mainline kernel
in the next merge window.
Sam
> ---
> drivers/gpu/drm/panel/panel-truly-nt35597.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/panel/panel-truly-nt35597.c b/drivers/gpu/drm/panel/panel-truly-nt35597.c
> index 012ca62bf30e..f0ad6081570f 100644
> --- a/drivers/gpu/drm/panel/panel-truly-nt35597.c
> +++ b/drivers/gpu/drm/panel/panel-truly-nt35597.c
> @@ -490,9 +490,7 @@ static int truly_nt35597_panel_add(struct truly_nt35597 *ctx)
> {
> struct device *dev = ctx->dev;
> int ret, i;
> - const struct nt35597_config *config;
>
> - config = ctx->config;
> for (i = 0; i < ARRAY_SIZE(ctx->supplies); i++)
> ctx->supplies[i].supply = regulator_names[i];
>
> --
> 2.17.1
>
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH -next] drm/panel: Remove set but not used variable 'config'
@ 2018-11-10 2:45 YueHaibing
0 siblings, 0 replies; 3+ messages in thread
From: YueHaibing @ 2018-11-10 2:45 UTC (permalink / raw)
To: Thierry Reding, David Airlie
Cc: YueHaibing, dri-devel, linux-kernel, kernel-janitors
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/gpu/drm/panel/panel-truly-nt35597.c: In function 'truly_nt35597_panel_add':
drivers/gpu/drm/panel/panel-truly-nt35597.c:488:31: warning:
variable 'config' set but not used [-Wunused-but-set-variable]
It never used since introdution in
1dd0b147c1ff ("drm/panel: Add support for Truly NT35597 panel driver")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/gpu/drm/panel/panel-truly-nt35597.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/panel/panel-truly-nt35597.c b/drivers/gpu/drm/panel/panel-truly-nt35597.c
index fc2a66c..2d5a540 100644
--- a/drivers/gpu/drm/panel/panel-truly-nt35597.c
+++ b/drivers/gpu/drm/panel/panel-truly-nt35597.c
@@ -485,9 +485,7 @@ static int truly_nt35597_panel_add(struct truly_nt35597 *ctx)
{
struct device *dev = ctx->dev;
int ret, i;
- const struct nt35597_config *config;
- config = ctx->config;
for (i = 0; i < ARRAY_SIZE(ctx->supplies); i++)
ctx->supplies[i].supply = regulator_names[i];
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-04-25 14:58 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-17 10:14 [PATCH -next] drm/panel: remove set but not used variable 'config' YueHaibing
2020-04-25 14:57 ` Sam Ravnborg
-- strict thread matches above, loose matches on Subject: below --
2018-11-10 2:45 [PATCH -next] drm/panel: Remove " YueHaibing
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).