From: Horatiu Vultur <horatiu.vultur@microchip.com>
To: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
Cc: <davem@davemloft.net>, <jiri@resnulli.us>, <ivecera@redhat.com>,
<kuba@kernel.org>, <roopa@cumulusnetworks.com>,
<olteanv@gmail.com>, <andrew@lunn.ch>,
<UNGLinuxDriver@microchip.com>, <linux-kernel@vger.kernel.org>,
<netdev@vger.kernel.org>, <bridge@lists.linux-foundation.org>
Subject: Re: [PATCH net-next 10/13] bridge: mrp: Implement netlink interface to configure MRP
Date: Tue, 21 Apr 2020 11:17:45 +0200 [thread overview]
Message-ID: <20200421091745.qei76hnb7gipfkb4@soft-dev3.microsemi.net> (raw)
In-Reply-To: <4d989958-0c2b-69de-2015-1808e2ce94db@cumulusnetworks.com>
The 04/21/2020 11:47, Nikolay Aleksandrov wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> On 20/04/2020 18:09, Horatiu Vultur wrote:
> > Implement netlink interface to configure MRP. The implementation
> > will do sanity checks over the attributes and then eventually call the MRP
> > interface.
> >
> > Signed-off-by: Horatiu Vultur <horatiu.vultur@microchip.com>
> > ---
> > net/bridge/br_mrp_netlink.c | 117 ++++++++++++++++++++++++++++++++++++
> > 1 file changed, 117 insertions(+)
> > create mode 100644 net/bridge/br_mrp_netlink.c
> >
> > diff --git a/net/bridge/br_mrp_netlink.c b/net/bridge/br_mrp_netlink.c
> > new file mode 100644
> > index 000000000000..0ff42e7c7f57
> > --- /dev/null
> > +++ b/net/bridge/br_mrp_netlink.c
> > @@ -0,0 +1,117 @@
> > +// SPDX-License-Identifier: GPL-2.0-or-later
> > +
> > +#include <net/genetlink.h>
> > +
> > +#include <uapi/linux/mrp_bridge.h>
> > +#include "br_private.h"
> > +#include "br_private_mrp.h"
> > +
> > +static const struct nla_policy br_mrp_policy[IFLA_BRIDGE_MRP_MAX + 1] = {
> > + [IFLA_BRIDGE_MRP_UNSPEC] = { .type = NLA_REJECT },
> > + [IFLA_BRIDGE_MRP_INSTANCE] = { .type = NLA_EXACT_LEN,
> > + .len = sizeof(struct br_mrp_instance)},
> > + [IFLA_BRIDGE_MRP_PORT_STATE] = { .type = NLA_U32 },
> > + [IFLA_BRIDGE_MRP_PORT_ROLE] = { .type = NLA_EXACT_LEN,
> > + .len = sizeof(struct br_mrp_port_role)},
> > + [IFLA_BRIDGE_MRP_RING_STATE] = { .type = NLA_EXACT_LEN,
> > + .len = sizeof(struct br_mrp_ring_state)},
> > + [IFLA_BRIDGE_MRP_RING_ROLE] = { .type = NLA_EXACT_LEN,
> > + .len = sizeof(struct br_mrp_ring_role)},
> > + [IFLA_BRIDGE_MRP_START_TEST] = { .type = NLA_EXACT_LEN,
> > + .len = sizeof(struct br_mrp_start_test)},
> > +};
> > +
> > +int br_mrp_parse(struct net_bridge *br, struct net_bridge_port *p,
> > + struct nlattr *attr, int cmd, struct netlink_ext_ack *extack)
> > +{
>
> Note that "p" can be NULL here if br_afspec() was called for the bridge device.
> Some of the functions below dereference it without any checks and will deref a
> null ptr.
Good check, I will update the functions br_mrp_set_port_role and
br_mrp_set_port_state to check for the null ptr.
>
> > + struct nlattr *tb[IFLA_BRIDGE_MRP_MAX + 1];
> > + int err;
> > +
> > + if (br->stp_enabled != BR_NO_STP) {
> > + NL_SET_ERR_MSG_MOD(extack, "MRP can't be enabled if STP is already enabled\n");
> > + return -EINVAL;
> > + }
> > +
> > + err = nla_parse_nested(tb, IFLA_BRIDGE_MRP_MAX, attr,
> > + NULL, extack);
> > + if (err)
> > + return err;
> > +
> > + if (tb[IFLA_BRIDGE_MRP_INSTANCE]) {
> > + struct br_mrp_instance *instance =
> > + nla_data(tb[IFLA_BRIDGE_MRP_INSTANCE]);
> > +
> > + if (cmd == RTM_SETLINK)
> > + err = br_mrp_add(br, instance);
> > + else
> > + err = br_mrp_del(br, instance);
> > + if (err)
> > + return err;
> > + }
> > +
> > + if (tb[IFLA_BRIDGE_MRP_PORT_STATE]) {
> > + enum br_mrp_port_state_type state =
> > + nla_get_u32(tb[IFLA_BRIDGE_MRP_PORT_STATE]);
> > +
> > + err = br_mrp_set_port_state(p, state);
> > + if (err)
> > + return err;
> > + }
> > +
> > + if (tb[IFLA_BRIDGE_MRP_PORT_ROLE]) {
> > + struct br_mrp_port_role *role =
> > + nla_data(tb[IFLA_BRIDGE_MRP_PORT_ROLE]);
> > +
> > + err = br_mrp_set_port_role(p, role);
> > + if (err)
> > + return err;
> > + }
> > +
> > + if (tb[IFLA_BRIDGE_MRP_RING_STATE]) {
> > + struct br_mrp_ring_state *state =
> > + nla_data(tb[IFLA_BRIDGE_MRP_RING_STATE]);
> > +
> > + err = br_mrp_set_ring_state(br, state);
> > + if (err)
> > + return err;
> > + }
> > +
> > + if (tb[IFLA_BRIDGE_MRP_RING_ROLE]) {
> > + struct br_mrp_ring_role *role =
> > + nla_data(tb[IFLA_BRIDGE_MRP_RING_ROLE]);
> > +
> > + err = br_mrp_set_ring_role(br, role);
> > + if (err)
> > + return err;
> > + }
> > +
> > + if (tb[IFLA_BRIDGE_MRP_START_TEST]) {
> > + struct br_mrp_start_test *test =
> > + nla_data(tb[IFLA_BRIDGE_MRP_START_TEST]);
> > +
> > + err = br_mrp_start_test(br, test);
> > + if (err)
> > + return err;
> > + }
> > +
> > + return 0;
> > +}
> > +
> > +int br_mrp_port_open(struct net_device *dev, u8 loc)
> > +{
> > + struct net_bridge_port *p;
> > + int err = 0;
> > +
> > + p = br_port_get_rcu(dev);
> > + if (!p) {
> > + err = -EINVAL;
> > + goto out;
> > + }
> > +
> > + p->loc = loc;
> > + br_ifinfo_notify(RTM_NEWLINK, NULL, p);
> > +
> > +out:
> > + return err;
> > +}
> > +EXPORT_SYMBOL(br_mrp_port_open);
> >
>
--
/Horatiu
next prev parent reply other threads:[~2020-04-21 9:17 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-20 15:09 [PATCH net-next 00/13] net: bridge: mrp: Add support for Media Redundancy Protocol(MRP) Horatiu Vultur
2020-04-20 15:09 ` [PATCH net-next 01/13] bridge: uapi: mrp: Add mrp attributes Horatiu Vultur
2020-04-20 15:09 ` [PATCH net-next 02/13] net: bridge: Add port attribute IFLA_BRPORT_MRP_RING_OPEN Horatiu Vultur
2020-04-20 15:09 ` [PATCH net-next 03/13] bridge: mrp: Update Kconfig Horatiu Vultur
2020-04-20 15:09 ` [PATCH net-next 04/13] bridge: mrp: Expose function br_mrp_port_open Horatiu Vultur
2020-04-20 17:30 ` Nikolay Aleksandrov
2020-04-20 19:26 ` Horatiu Vultur
2020-04-20 15:09 ` [PATCH net-next 05/13] bridge: mrp: Add MRP interface Horatiu Vultur
2020-04-20 15:09 ` [PATCH net-next 06/13] bridge: mrp: Extend bridge interface Horatiu Vultur
2020-04-20 15:09 ` [PATCH net-next 07/13] switchdev: mrp: Extend switchdev API to offload MRP Horatiu Vultur
2020-04-20 15:09 ` [PATCH net-next 08/13] bridge: switchdev: mrp: Implement MRP API for switchdev Horatiu Vultur
2020-04-20 15:09 ` [PATCH net-next 09/13] bridge: mrp: Connect MRP API with the switchev API Horatiu Vultur
2020-04-20 17:17 ` Nikolay Aleksandrov
2020-04-20 19:13 ` Horatiu Vultur
2020-04-21 8:44 ` Nikolay Aleksandrov
2020-04-21 9:31 ` Horatiu Vultur
2020-04-20 15:09 ` [PATCH net-next 10/13] bridge: mrp: Implement netlink interface to configure MRP Horatiu Vultur
2020-04-20 17:18 ` Nikolay Aleksandrov
2020-04-20 19:16 ` Horatiu Vultur
2020-04-21 8:47 ` Nikolay Aleksandrov
2020-04-21 9:17 ` Horatiu Vultur [this message]
2020-04-20 15:09 ` [PATCH net-next 11/13] bridge: mrp: Update Makefile Horatiu Vultur
2020-04-20 15:09 ` [PATCH net-next 12/13] bridge: mrp: Integrate MRP into the bridge Horatiu Vultur
2020-04-20 15:09 ` [PATCH net-next 13/13] net: bridge: Add checks for enabling the STP Horatiu Vultur
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200421091745.qei76hnb7gipfkb4@soft-dev3.microsemi.net \
--to=horatiu.vultur@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew@lunn.ch \
--cc=bridge@lists.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=ivecera@redhat.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nikolay@cumulusnetworks.com \
--cc=olteanv@gmail.com \
--cc=roopa@cumulusnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).