From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: Roman Kovalivskyi <roman.kovalivskyi@globallogic.com>
Cc: linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
linux-renesas-soc@vger.kernel.org,
"Luis Oliveira" <lolivei@synopsys.com>,
"Niklas Söderlund" <niklas.soderlund@ragnatech.se>,
"Jacopo Mondi" <jacopo@jmondi.org>,
"Michael Rodin" <mrodin@de.adit-jv.com>,
"Mauro Carvalho Chehab" <mchehab@kernel.org>,
"Hugues Fruchet" <hugues.fruchet@st.com>,
"Maxime Ripard" <mripard@kernel.org>,
"Adam Ford" <aford173@gmail.com>,
"Todor Tomov" <todor.tomov@linaro.org>,
"Suresh Udipi" <sudipi@jp.adit-jv.com>,
"Andrew Gabbasov" <andrew_gabbasov@mentor.com>,
"Eugeniu Rosca" <erosca@de.adit-jv.com>,
"Dave Stevenson" <dave.stevenson@raspberrypi.org>
Subject: Re: [PATCH 4/4] media: ov5647: Use gpiod_set_value_cansleep
Date: Thu, 23 Apr 2020 10:55:57 +0300 [thread overview]
Message-ID: <20200423075557.GL5381@paasikivi.fi.intel.com> (raw)
In-Reply-To: <f496fe5d364748e9d625a634581a404f30a13efa.1586759968.git.roman.kovalivskyi@globallogic.com>
Hi Roman,
On Mon, Apr 13, 2020 at 12:17:47PM +0300, Roman Kovalivskyi wrote:
> From: Dave Stevenson <dave.stevenson@raspberrypi.org>
>
> All calls to the gpio library are in contexts that can sleep,
> therefore there is no issue with having those GPIOs controlled
> by controllers which require sleeping (eg I2C GPIO expanders).
>
> Switch to using gpiod_set_value_cansleep instead of gpiod_set_value
> to avoid triggering the warning in gpiolib should the GPIO
> controller need to sleep.
>
> Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.org>
> Signed-off-by: Roman Kovalivskyi <roman.kovalivskyi@globallogic.com>
This should be merged with the second patch.
> ---
> drivers/media/i2c/ov5647.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/media/i2c/ov5647.c b/drivers/media/i2c/ov5647.c
> index 8a1a515388e0..07550377be2e 100644
> --- a/drivers/media/i2c/ov5647.c
> +++ b/drivers/media/i2c/ov5647.c
> @@ -373,7 +373,7 @@ static int ov5647_sensor_power(struct v4l2_subdev *sd, int on)
> dev_dbg(&client->dev, "OV5647 power on\n");
>
> if (ov5647->pwdn) {
> - gpiod_set_value(ov5647->pwdn, 0);
> + gpiod_set_value_cansleep(ov5647->pwdn, 0);
> msleep(PWDN_ACTIVE_DELAY_MS);
> }
>
> @@ -415,7 +415,7 @@ static int ov5647_sensor_power(struct v4l2_subdev *sd, int on)
>
> clk_disable_unprepare(ov5647->xclk);
>
> - gpiod_set_value(ov5647->pwdn, 1);
> + gpiod_set_value_cansleep(ov5647->pwdn, 1);
> }
>
> /* Update the power count. */
> @@ -648,13 +648,13 @@ static int ov5647_probe(struct i2c_client *client)
> goto mutex_remove;
>
> if (sensor->pwdn) {
> - gpiod_set_value(sensor->pwdn, 0);
> + gpiod_set_value_cansleep(sensor->pwdn, 0);
> msleep(PWDN_ACTIVE_DELAY_MS);
> }
>
> ret = ov5647_detect(sd);
>
> - gpiod_set_value(sensor->pwdn, 1);
> + gpiod_set_value_cansleep(sensor->pwdn, 1);
>
> if (ret < 0)
> goto error;
> --
> 2.17.1
>
--
Sakari Ailus
prev parent reply other threads:[~2020-04-23 7:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-13 9:17 [PATCH 0/4] ov5647 driver improvement Roman Kovalivskyi
[not found] ` <cover.1586759968.git.roman.kovalivskyi@globallogic.com>
2020-04-13 9:17 ` [PATCH 1/4] media: ov5647: Add set_fmt and get_fmt calls Roman Kovalivskyi
2020-04-15 12:11 ` Jacopo Mondi
2020-04-13 9:17 ` [PATCH 2/4] media: ov5647: Add support for PWDN GPIO Roman Kovalivskyi
2020-04-15 12:38 ` Jacopo Mondi
2020-04-13 9:17 ` [PATCH 3/4] media: ov5647: Add support for non-continuous clock mode Roman Kovalivskyi
2020-04-15 13:17 ` Jacopo Mondi
2020-04-23 7:47 ` Sakari Ailus
2020-04-13 9:17 ` [PATCH 4/4] media: ov5647: Use gpiod_set_value_cansleep Roman Kovalivskyi
2020-04-23 7:55 ` Sakari Ailus [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200423075557.GL5381@paasikivi.fi.intel.com \
--to=sakari.ailus@linux.intel.com \
--cc=aford173@gmail.com \
--cc=andrew_gabbasov@mentor.com \
--cc=dave.stevenson@raspberrypi.org \
--cc=erosca@de.adit-jv.com \
--cc=hugues.fruchet@st.com \
--cc=jacopo@jmondi.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=lolivei@synopsys.com \
--cc=mchehab@kernel.org \
--cc=mripard@kernel.org \
--cc=mrodin@de.adit-jv.com \
--cc=niklas.soderlund@ragnatech.se \
--cc=roman.kovalivskyi@globallogic.com \
--cc=sudipi@jp.adit-jv.com \
--cc=todor.tomov@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).