From: Roman Kovalivskyi <roman.kovalivskyi@globallogic.com>
To: linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
linux-renesas-soc@vger.kernel.org
Cc: "Luis Oliveira" <lolivei@synopsys.com>,
"Niklas Söderlund" <niklas.soderlund@ragnatech.se>,
"Jacopo Mondi" <jacopo@jmondi.org>,
"Michael Rodin" <mrodin@de.adit-jv.com>,
"Mauro Carvalho Chehab" <mchehab@kernel.org>,
"Sakari Ailus" <sakari.ailus@linux.intel.com>,
"Hugues Fruchet" <hugues.fruchet@st.com>,
"Maxime Ripard" <mripard@kernel.org>,
"Adam Ford" <aford173@gmail.com>,
"Todor Tomov" <todor.tomov@linaro.org>,
"Suresh Udipi" <sudipi@jp.adit-jv.com>,
"Andrew Gabbasov" <andrew_gabbasov@mentor.com>,
"Eugeniu Rosca" <erosca@de.adit-jv.com>,
"Dave Stevenson" <dave.stevenson@raspberrypi.org>,
"Roman Kovalivskyi" <roman.kovalivskyi@globallogic.com>
Subject: [PATCH 3/4] media: ov5647: Add support for non-continuous clock mode
Date: Mon, 13 Apr 2020 12:17:46 +0300 [thread overview]
Message-ID: <c3189c80ac27d67e814509d44a864f8164971efb.1586759968.git.roman.kovalivskyi@globallogic.com> (raw)
In-Reply-To: <cover.1586758372.git.roman.kovalivskyi@globallogic.com>
In-Reply-To: <cover.1586759968.git.roman.kovalivskyi@globallogic.com>
From: Dave Stevenson <dave.stevenson@raspberrypi.org>
The driver was only supporting continuous clock mode
although this was not stated anywhere.
Non-continuous clock saves a small amount of power and
on some SoCs is easier to interface with.
Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.org>
Signed-off-by: Roman Kovalivskyi <roman.kovalivskyi@globallogic.com>
---
drivers/media/i2c/ov5647.c | 17 ++++++++++++++---
1 file changed, 14 insertions(+), 3 deletions(-)
diff --git a/drivers/media/i2c/ov5647.c b/drivers/media/i2c/ov5647.c
index c39e3d20e3ef..8a1a515388e0 100644
--- a/drivers/media/i2c/ov5647.c
+++ b/drivers/media/i2c/ov5647.c
@@ -44,6 +44,7 @@
#define PWDN_ACTIVE_DELAY_MS 20
#define MIPI_CTRL00_CLOCK_LANE_GATE BIT(5)
+#define MIPI_CTRL00_LINE_SYNC_ENABLE BIT(4)
#define MIPI_CTRL00_BUS_IDLE BIT(2)
#define MIPI_CTRL00_CLOCK_LANE_DISABLE BIT(0)
@@ -95,6 +96,7 @@ struct ov5647 {
int power_count;
struct clk *xclk;
struct gpio_desc *pwdn;
+ unsigned int flags;
};
static inline struct ov5647 *to_state(struct v4l2_subdev *sd)
@@ -269,9 +271,15 @@ static int ov5647_set_virtual_channel(struct v4l2_subdev *sd, int channel)
static int ov5647_stream_on(struct v4l2_subdev *sd)
{
+ struct ov5647 *ov5647 = to_state(sd);
+ u8 val = MIPI_CTRL00_BUS_IDLE;
int ret;
- ret = ov5647_write(sd, OV5647_REG_MIPI_CTRL00, MIPI_CTRL00_BUS_IDLE);
+ if (ov5647->flags & V4L2_MBUS_CSI2_NONCONTINUOUS_CLOCK)
+ val |= MIPI_CTRL00_CLOCK_LANE_GATE |
+ MIPI_CTRL00_LINE_SYNC_ENABLE;
+
+ ret = ov5647_write(sd, OV5647_REG_MIPI_CTRL00, val);
if (ret < 0)
return ret;
@@ -568,7 +576,7 @@ static const struct v4l2_subdev_internal_ops ov5647_subdev_internal_ops = {
.open = ov5647_open,
};
-static int ov5647_parse_dt(struct device_node *np)
+static int ov5647_parse_dt(struct device_node *np, struct ov5647 *sensor)
{
struct v4l2_fwnode_endpoint bus_cfg = { .bus_type = 0 };
struct device_node *ep;
@@ -581,6 +589,9 @@ static int ov5647_parse_dt(struct device_node *np)
ret = v4l2_fwnode_endpoint_parse(of_fwnode_handle(ep), &bus_cfg);
+ if (!ret)
+ sensor->flags = bus_cfg.bus.mipi_csi2.flags;
+
of_node_put(ep);
return ret;
}
@@ -599,7 +610,7 @@ static int ov5647_probe(struct i2c_client *client)
return -ENOMEM;
if (IS_ENABLED(CONFIG_OF) && np) {
- ret = ov5647_parse_dt(np);
+ ret = ov5647_parse_dt(np, sensor);
if (ret) {
dev_err(dev, "DT parsing error: %d\n", ret);
return ret;
--
2.17.1
next prev parent reply other threads:[~2020-04-13 10:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-13 9:17 [PATCH 0/4] ov5647 driver improvement Roman Kovalivskyi
[not found] ` <cover.1586759968.git.roman.kovalivskyi@globallogic.com>
2020-04-13 9:17 ` [PATCH 1/4] media: ov5647: Add set_fmt and get_fmt calls Roman Kovalivskyi
2020-04-15 12:11 ` Jacopo Mondi
2020-04-13 9:17 ` [PATCH 2/4] media: ov5647: Add support for PWDN GPIO Roman Kovalivskyi
2020-04-15 12:38 ` Jacopo Mondi
2020-04-13 9:17 ` Roman Kovalivskyi [this message]
2020-04-15 13:17 ` [PATCH 3/4] media: ov5647: Add support for non-continuous clock mode Jacopo Mondi
2020-04-23 7:47 ` Sakari Ailus
2020-04-13 9:17 ` [PATCH 4/4] media: ov5647: Use gpiod_set_value_cansleep Roman Kovalivskyi
2020-04-23 7:55 ` Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c3189c80ac27d67e814509d44a864f8164971efb.1586759968.git.roman.kovalivskyi@globallogic.com \
--to=roman.kovalivskyi@globallogic.com \
--cc=aford173@gmail.com \
--cc=andrew_gabbasov@mentor.com \
--cc=dave.stevenson@raspberrypi.org \
--cc=erosca@de.adit-jv.com \
--cc=hugues.fruchet@st.com \
--cc=jacopo@jmondi.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=lolivei@synopsys.com \
--cc=mchehab@kernel.org \
--cc=mripard@kernel.org \
--cc=mrodin@de.adit-jv.com \
--cc=niklas.soderlund@ragnatech.se \
--cc=sakari.ailus@linux.intel.com \
--cc=sudipi@jp.adit-jv.com \
--cc=todor.tomov@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).