* [PATCH] arm64: dts: allwinner: h6: fix cooling-cell property
@ 2020-04-20 14:30 Clément Péron
2020-04-23 7:48 ` Clément Péron
2020-04-23 9:44 ` Maxime Ripard
0 siblings, 2 replies; 3+ messages in thread
From: Clément Péron @ 2020-04-20 14:30 UTC (permalink / raw)
To: Maxime Ripard, Chen-Yu Tsai, Rob Herring
Cc: linux-arm-kernel, devicetree, linux-kernel, linux-sunxi,
Clément Péron
We define cooling-cells property for CPUs only for board including
the sun50i-h6-cpu-opp.dtsi. As not all boards have the CPU OPP
dtsi file included this create a warning because the cooling-maps
is defined but not the cooling-cells property in CPU nodes.
Move the cooling-cells to the sun50i-h6.dtsi instead of the
sun50i-h6-cpu-opp.dtsi
Signed-off-by: Clément Péron <peron.clem@gmail.com>
---
arch/arm64/boot/dts/allwinner/sun50i-h6-cpu-opp.dtsi | 4 ----
arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi | 4 ++++
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6-cpu-opp.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-h6-cpu-opp.dtsi
index 9ebd97b04b1a..dcb789519797 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-h6-cpu-opp.dtsi
+++ b/arch/arm64/boot/dts/allwinner/sun50i-h6-cpu-opp.dtsi
@@ -102,20 +102,16 @@
&cpu0 {
operating-points-v2 = <&cpu_opp_table>;
- #cooling-cells = <2>;
};
&cpu1 {
operating-points-v2 = <&cpu_opp_table>;
- #cooling-cells = <2>;
};
&cpu2 {
operating-points-v2 = <&cpu_opp_table>;
- #cooling-cells = <2>;
};
&cpu3 {
operating-points-v2 = <&cpu_opp_table>;
- #cooling-cells = <2>;
};
diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi
index 83e32f9c4977..2e31632c6ca8 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi
+++ b/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi
@@ -27,6 +27,7 @@
enable-method = "psci";
clocks = <&ccu CLK_CPUX>;
clock-latency-ns = <244144>; /* 8 32k periods */
+ #cooling-cells = <2>;
};
cpu1: cpu@1 {
@@ -36,6 +37,7 @@
enable-method = "psci";
clocks = <&ccu CLK_CPUX>;
clock-latency-ns = <244144>; /* 8 32k periods */
+ #cooling-cells = <2>;
};
cpu2: cpu@2 {
@@ -45,6 +47,7 @@
enable-method = "psci";
clocks = <&ccu CLK_CPUX>;
clock-latency-ns = <244144>; /* 8 32k periods */
+ #cooling-cells = <2>;
};
cpu3: cpu@3 {
@@ -54,6 +57,7 @@
enable-method = "psci";
clocks = <&ccu CLK_CPUX>;
clock-latency-ns = <244144>; /* 8 32k periods */
+ #cooling-cells = <2>;
};
};
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: dts: allwinner: h6: fix cooling-cell property
2020-04-20 14:30 [PATCH] arm64: dts: allwinner: h6: fix cooling-cell property Clément Péron
@ 2020-04-23 7:48 ` Clément Péron
2020-04-23 9:44 ` Maxime Ripard
1 sibling, 0 replies; 3+ messages in thread
From: Clément Péron @ 2020-04-23 7:48 UTC (permalink / raw)
To: Maxime Ripard, Chen-Yu Tsai, Rob Herring
Cc: linux-arm-kernel, devicetree, linux-kernel, linux-sunxi
Hi Maxime,
On Mon, 20 Apr 2020 at 16:30, Clément Péron <peron.clem@gmail.com> wrote:
>
> We define cooling-cells property for CPUs only for board including
> the sun50i-h6-cpu-opp.dtsi. As not all boards have the CPU OPP
> dtsi file included this create a warning because the cooling-maps
> is defined but not the cooling-cells property in CPU nodes.
This fix some warnings introduced by the H6 DVFS serie that I sent last week...
The cooling-cells has been introduced in
7e4bbf3fe67c ("arm64: dts: allwinner: h6: Add CPU Operating
Performance Points table")
instead of
5fc0928782e9 ("arm64: dts: allwinner: h6: Add thermal trip points/cooling map")
Do you plan to squash it? If yes do you want me to sent two patches
separately (it will be a bit easier to squash them)?
Regards,
Clement
>
> Move the cooling-cells to the sun50i-h6.dtsi instead of the
> sun50i-h6-cpu-opp.dtsi
>
> Signed-off-by: Clément Péron <peron.clem@gmail.com>
> ---
> arch/arm64/boot/dts/allwinner/sun50i-h6-cpu-opp.dtsi | 4 ----
> arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi | 4 ++++
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6-cpu-opp.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-h6-cpu-opp.dtsi
> index 9ebd97b04b1a..dcb789519797 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-h6-cpu-opp.dtsi
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6-cpu-opp.dtsi
> @@ -102,20 +102,16 @@
>
> &cpu0 {
> operating-points-v2 = <&cpu_opp_table>;
> - #cooling-cells = <2>;
> };
>
> &cpu1 {
> operating-points-v2 = <&cpu_opp_table>;
> - #cooling-cells = <2>;
> };
>
> &cpu2 {
> operating-points-v2 = <&cpu_opp_table>;
> - #cooling-cells = <2>;
> };
>
> &cpu3 {
> operating-points-v2 = <&cpu_opp_table>;
> - #cooling-cells = <2>;
> };
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi
> index 83e32f9c4977..2e31632c6ca8 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi
> @@ -27,6 +27,7 @@
> enable-method = "psci";
> clocks = <&ccu CLK_CPUX>;
> clock-latency-ns = <244144>; /* 8 32k periods */
> + #cooling-cells = <2>;
> };
>
> cpu1: cpu@1 {
> @@ -36,6 +37,7 @@
> enable-method = "psci";
> clocks = <&ccu CLK_CPUX>;
> clock-latency-ns = <244144>; /* 8 32k periods */
> + #cooling-cells = <2>;
> };
>
> cpu2: cpu@2 {
> @@ -45,6 +47,7 @@
> enable-method = "psci";
> clocks = <&ccu CLK_CPUX>;
> clock-latency-ns = <244144>; /* 8 32k periods */
> + #cooling-cells = <2>;
> };
>
> cpu3: cpu@3 {
> @@ -54,6 +57,7 @@
> enable-method = "psci";
> clocks = <&ccu CLK_CPUX>;
> clock-latency-ns = <244144>; /* 8 32k periods */
> + #cooling-cells = <2>;
> };
> };
>
> --
> 2.20.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: dts: allwinner: h6: fix cooling-cell property
2020-04-20 14:30 [PATCH] arm64: dts: allwinner: h6: fix cooling-cell property Clément Péron
2020-04-23 7:48 ` Clément Péron
@ 2020-04-23 9:44 ` Maxime Ripard
1 sibling, 0 replies; 3+ messages in thread
From: Maxime Ripard @ 2020-04-23 9:44 UTC (permalink / raw)
To: Clément Péron
Cc: Chen-Yu Tsai, Rob Herring, linux-arm-kernel, devicetree,
linux-kernel, linux-sunxi
[-- Attachment #1: Type: text/plain, Size: 557 bytes --]
On Mon, Apr 20, 2020 at 04:30:16PM +0200, Clément Péron wrote:
> We define cooling-cells property for CPUs only for board including
> the sun50i-h6-cpu-opp.dtsi. As not all boards have the CPU OPP
> dtsi file included this create a warning because the cooling-maps
> is defined but not the cooling-cells property in CPU nodes.
>
> Move the cooling-cells to the sun50i-h6.dtsi instead of the
> sun50i-h6-cpu-opp.dtsi
>
> Signed-off-by: Clément Péron <peron.clem@gmail.com>
Squashed it into the patches 2 and 3 of your series,
Thanks!
Maxime
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-04-23 9:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-20 14:30 [PATCH] arm64: dts: allwinner: h6: fix cooling-cell property Clément Péron
2020-04-23 7:48 ` Clément Péron
2020-04-23 9:44 ` Maxime Ripard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).