LKML Archive on lore.kernel.org
 help / color / Atom feed
From: Jiri Olsa <jolsa@redhat.com>
To: Ian Rogers <irogers@google.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	Arnaldo Carvalho de Melo <acme@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Namhyung Kim <namhyung@kernel.org>,
	Kan Liang <kan.liang@linux.intel.com>,
	Andi Kleen <ak@linux.intel.com>,
	Haiyan Song <haiyanx.song@intel.com>,
	Jin Yao <yao.jin@linux.intel.com>,
	Song Liu <songliubraving@fb.com>,
	Ravi Bangoria <ravi.bangoria@linux.ibm.com>,
	John Garry <john.garry@huawei.com>, Leo Yan <leo.yan@linaro.org>,
	Adrian Hunter <adrian.hunter@intel.com>,
	Paul Clarke <pc@us.ibm.com>,
	linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
	Stephane Eranian <eranian@google.com>
Subject: Re: [PATCH v2 05/11] perf expr: increase max other
Date: Thu, 23 Apr 2020 13:29:15 +0200
Message-ID: <20200423112915.GH1136647@krava> (raw)
In-Reply-To: <20200422220430.254014-6-irogers@google.com>

On Wed, Apr 22, 2020 at 03:04:24PM -0700, Ian Rogers wrote:
> Large metrics such as Branch_Misprediction_Cost_SMT on x86 broadwell
> need more space.
> 
> Signed-off-by: Ian Rogers <irogers@google.com>
> ---
>  tools/perf/util/expr.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/perf/util/expr.h b/tools/perf/util/expr.h
> index 0938ad166ece..4938bfc608b7 100644
> --- a/tools/perf/util/expr.h
> +++ b/tools/perf/util/expr.h
> @@ -2,7 +2,7 @@
>  #ifndef PARSE_CTX_H
>  #define PARSE_CTX_H 1
>  
> -#define EXPR_MAX_OTHER 20
> +#define EXPR_MAX_OTHER 64
>  #define MAX_PARSE_ID EXPR_MAX_OTHER
>  
>  struct expr_parse_id {
> -- 
> 2.26.2.303.gf8c07b1a785-goog
> 

ok, and we should probably start to think about what Andi suggested
in here: https://lore.kernel.org/lkml/20200224210308.GQ160988@tassilo.jf.intel.com/

jirka


  reply index

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-22 22:04 [PATCH v2 00/11] perf metric fixes and test Ian Rogers
2020-04-22 22:04 ` [PATCH v2 01/11] perf expr: unlimited escaped characters in a symbol Ian Rogers
2020-04-23 11:29   ` Jiri Olsa
2020-04-27  9:31     ` kajoljain
2020-04-22 22:04 ` [PATCH v2 02/11] perf metrics: fix parse errors in cascade lake metrics Ian Rogers
2020-04-22 22:04 ` [PATCH v2 03/11] perf metrics: fix parse errors in skylake metrics Ian Rogers
2020-04-22 22:04 ` [PATCH v2 04/11] perf expr: allow ',' to be an other token Ian Rogers
2020-04-23 11:29   ` Jiri Olsa
2020-04-22 22:04 ` [PATCH v2 05/11] perf expr: increase max other Ian Rogers
2020-04-23 11:29   ` Jiri Olsa [this message]
2020-04-23 14:23     ` Ian Rogers
2020-05-06 22:52       ` Ian Rogers
2020-04-22 22:04 ` [PATCH v2 06/11] perf expr: parse numbers as doubles Ian Rogers
2020-04-23 11:29   ` Jiri Olsa
2020-04-27 11:11   ` kajoljain
2020-04-27 18:03     ` Ian Rogers
2020-04-28  6:35   ` kajoljain
2020-04-22 22:04 ` [PATCH v2 07/11] perf expr: debug lex if debugging yacc Ian Rogers
2020-04-22 22:04 ` [PATCH v2 08/11] perf metrics: fix parse errors in power8 metrics Ian Rogers
2020-04-22 22:31   ` Paul Clarke
2020-04-22 22:46     ` Ian Rogers
2020-04-22 22:04 ` [PATCH v2 09/11] perf metrics: fix parse errors in power9 metrics Ian Rogers
2020-04-22 22:31   ` Paul Clarke
2020-04-22 22:04 ` [PATCH v2 10/11] perf expr: print a debug message for division by zero Ian Rogers
2020-04-23 11:28   ` Jiri Olsa
2020-04-23 14:16     ` Ian Rogers
2020-04-22 22:04 ` [PATCH v2 11/11] perf test: add expr test for pmu metrics Ian Rogers
2020-04-23 11:28   ` Jiri Olsa
2020-04-23 14:22     ` Ian Rogers
2020-04-23 15:11       ` John Garry
2020-04-23 16:21         ` Ian Rogers
2020-04-23 11:28 ` [PATCH v2 00/11] perf metric fixes and test Jiri Olsa
2020-04-23 13:44   ` Jin, Yao
2020-04-23 14:02     ` Jiri Olsa
2020-04-23 14:31       ` Ian Rogers
2020-04-24  2:46         ` Jin, Yao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200423112915.GH1136647@krava \
    --to=jolsa@redhat.com \
    --cc=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=ak@linux.intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=eranian@google.com \
    --cc=haiyanx.song@intel.com \
    --cc=irogers@google.com \
    --cc=john.garry@huawei.com \
    --cc=kan.liang@linux.intel.com \
    --cc=leo.yan@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=pc@us.ibm.com \
    --cc=peterz@infradead.org \
    --cc=ravi.bangoria@linux.ibm.com \
    --cc=songliubraving@fb.com \
    --cc=yao.jin@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

LKML Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/lkml/0 lkml/git/0.git
	git clone --mirror https://lore.kernel.org/lkml/1 lkml/git/1.git
	git clone --mirror https://lore.kernel.org/lkml/2 lkml/git/2.git
	git clone --mirror https://lore.kernel.org/lkml/3 lkml/git/3.git
	git clone --mirror https://lore.kernel.org/lkml/4 lkml/git/4.git
	git clone --mirror https://lore.kernel.org/lkml/5 lkml/git/5.git
	git clone --mirror https://lore.kernel.org/lkml/6 lkml/git/6.git
	git clone --mirror https://lore.kernel.org/lkml/7 lkml/git/7.git
	git clone --mirror https://lore.kernel.org/lkml/8 lkml/git/8.git
	git clone --mirror https://lore.kernel.org/lkml/9 lkml/git/9.git
	git clone --mirror https://lore.kernel.org/lkml/10 lkml/git/10.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 lkml lkml/ https://lore.kernel.org/lkml \
		linux-kernel@vger.kernel.org
	public-inbox-index lkml

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-kernel


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git