From: Ian Rogers <irogers@google.com>
To: John Garry <john.garry@huawei.com>
Cc: Jiri Olsa <jolsa@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Namhyung Kim <namhyung@kernel.org>,
Kan Liang <kan.liang@linux.intel.com>,
Andi Kleen <ak@linux.intel.com>,
Haiyan Song <haiyanx.song@intel.com>,
Jin Yao <yao.jin@linux.intel.com>,
Song Liu <songliubraving@fb.com>,
Ravi Bangoria <ravi.bangoria@linux.ibm.com>,
Leo Yan <leo.yan@linaro.org>,
Adrian Hunter <adrian.hunter@intel.com>,
Paul Clarke <pc@us.ibm.com>, LKML <linux-kernel@vger.kernel.org>,
linux-perf-users <linux-perf-users@vger.kernel.org>,
Stephane Eranian <eranian@google.com>
Subject: Re: [PATCH v2 11/11] perf test: add expr test for pmu metrics
Date: Thu, 23 Apr 2020 09:21:23 -0700 [thread overview]
Message-ID: <CAP-5=fWTgdQ-RC-CtyEPKFvOPfbANajgT61+4k6-7S9poaNEog@mail.gmail.com> (raw)
In-Reply-To: <0edf66da-bedf-c5e9-aa2b-e9073a2d0203@huawei.com>
On Thu, Apr 23, 2020 at 8:11 AM John Garry <john.garry@huawei.com> wrote:
>
> On 23/04/2020 15:22, Ian Rogers wrote:
> > On Thu, Apr 23, 2020 at 4:29 AM Jiri Olsa <jolsa@redhat.com> wrote:
> >>
> >> On Wed, Apr 22, 2020 at 03:04:30PM -0700, Ian Rogers wrote:
> >>
> >> SNIP
> >>
> >>> +
> >>> +static int pmu_tests(void)
> >>> +{
> >>> + struct pmu_events_map *map;
> >>> + struct pmu_event *pe;
> >>> + int i, j, k;
> >>> + const char **ids;
> >>> + int idnum;
> >>> + int ret = 0;
> >>> + struct expr_parse_ctx ctx;
> >>> + double result;
> >>> +
> >>> + i = 0;
> >>> + for (;;) {
> >>> + map = &pmu_events_map[i++];
> >>> + if (!map->table) {
> >>> + map = NULL;
> >>> + break;
> >>> + }
> >>> + j = 0;
> >>> + for (;;) {
> >>> + pe = &map->table[j++];
> >>> + if (!pe->name && !pe->metric_group && !pe->metric_name)
> >>> + break;
> >>> + if (!pe->metric_expr)
> >>> + continue;
> >>
> >> so we go throught all the metrics for the current cpu
> >> and test the parsing on them.. great!
> >
> > It's not just the current CPU (such as skylake) it is every map
> > (skylake, cascade lake, etc), but this only works for the architecture
> > that jevents built.
> > If jevents built all architectures then this could check them as well.
> > Perhaps there should be a jevents test suite, but I think even then
> > this test has value.
>
> note: there is test__pmu_events(), which verifies that some test events
> generated in pmu-events.c are as expected, and also verifies that we
> create PMU events aliases as expected (for those test events). Nothing
> is done for metrics, ATM.
Thanks John, that sounds like the right place to start.
Ian
> Thanks,
> John
next prev parent reply other threads:[~2020-04-23 16:21 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-22 22:04 [PATCH v2 00/11] perf metric fixes and test Ian Rogers
2020-04-22 22:04 ` [PATCH v2 01/11] perf expr: unlimited escaped characters in a symbol Ian Rogers
2020-04-23 11:29 ` Jiri Olsa
2020-04-27 9:31 ` kajoljain
2020-04-22 22:04 ` [PATCH v2 02/11] perf metrics: fix parse errors in cascade lake metrics Ian Rogers
2020-04-22 22:04 ` [PATCH v2 03/11] perf metrics: fix parse errors in skylake metrics Ian Rogers
2020-04-22 22:04 ` [PATCH v2 04/11] perf expr: allow ',' to be an other token Ian Rogers
2020-04-23 11:29 ` Jiri Olsa
2020-04-22 22:04 ` [PATCH v2 05/11] perf expr: increase max other Ian Rogers
2020-04-23 11:29 ` Jiri Olsa
2020-04-23 14:23 ` Ian Rogers
2020-05-06 22:52 ` Ian Rogers
2020-04-22 22:04 ` [PATCH v2 06/11] perf expr: parse numbers as doubles Ian Rogers
2020-04-23 11:29 ` Jiri Olsa
2020-04-27 11:11 ` kajoljain
2020-04-27 18:03 ` Ian Rogers
2020-04-28 6:35 ` kajoljain
2020-04-22 22:04 ` [PATCH v2 07/11] perf expr: debug lex if debugging yacc Ian Rogers
2020-04-22 22:04 ` [PATCH v2 08/11] perf metrics: fix parse errors in power8 metrics Ian Rogers
2020-04-22 22:31 ` Paul Clarke
2020-04-22 22:46 ` Ian Rogers
2020-04-22 22:04 ` [PATCH v2 09/11] perf metrics: fix parse errors in power9 metrics Ian Rogers
2020-04-22 22:31 ` Paul Clarke
2020-04-22 22:04 ` [PATCH v2 10/11] perf expr: print a debug message for division by zero Ian Rogers
2020-04-23 11:28 ` Jiri Olsa
2020-04-23 14:16 ` Ian Rogers
2020-04-22 22:04 ` [PATCH v2 11/11] perf test: add expr test for pmu metrics Ian Rogers
2020-04-23 11:28 ` Jiri Olsa
2020-04-23 14:22 ` Ian Rogers
2020-04-23 15:11 ` John Garry
2020-04-23 16:21 ` Ian Rogers [this message]
2020-04-23 11:28 ` [PATCH v2 00/11] perf metric fixes and test Jiri Olsa
2020-04-23 13:44 ` Jin, Yao
2020-04-23 14:02 ` Jiri Olsa
2020-04-23 14:31 ` Ian Rogers
2020-04-24 2:46 ` Jin, Yao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAP-5=fWTgdQ-RC-CtyEPKFvOPfbANajgT61+4k6-7S9poaNEog@mail.gmail.com' \
--to=irogers@google.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=eranian@google.com \
--cc=haiyanx.song@intel.com \
--cc=john.garry@huawei.com \
--cc=jolsa@redhat.com \
--cc=kan.liang@linux.intel.com \
--cc=leo.yan@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=pc@us.ibm.com \
--cc=peterz@infradead.org \
--cc=ravi.bangoria@linux.ibm.com \
--cc=songliubraving@fb.com \
--cc=yao.jin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).