* [PATCH net v1] net: rtw88: fix an issue about leak system resources
@ 2020-05-04 8:34 Dejin Zheng
2020-05-04 8:37 ` Tony Chuang
2020-05-06 8:38 ` [PATCH net v1] " Kalle Valo
0 siblings, 2 replies; 3+ messages in thread
From: Dejin Zheng @ 2020-05-04 8:34 UTC (permalink / raw)
To: yhchuang, kvalo, davem, sgruszka, briannorris, linux-wireless, netdev
Cc: linux-kernel, Dejin Zheng, Andy Shevchenko
the related system resources were not released when pci_iomap() return
error in the rtw_pci_io_mapping() function. add pci_release_regions() to
fix it.
Fixes: e3037485c68ec1a ("rtw88: new Realtek 802.11ac driver")
Cc: Andy Shevchenko <andy.shevchenko@gmail.com>
Signed-off-by: Dejin Zheng <zhengdejin5@gmail.com>
---
drivers/net/wireless/realtek/rtw88/pci.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/wireless/realtek/rtw88/pci.c b/drivers/net/wireless/realtek/rtw88/pci.c
index 695c2c0d64b0..a9752c34c9d8 100644
--- a/drivers/net/wireless/realtek/rtw88/pci.c
+++ b/drivers/net/wireless/realtek/rtw88/pci.c
@@ -1102,6 +1102,7 @@ static int rtw_pci_io_mapping(struct rtw_dev *rtwdev,
len = pci_resource_len(pdev, bar_id);
rtwpci->mmap = pci_iomap(pdev, bar_id, len);
if (!rtwpci->mmap) {
+ pci_release_regions(pdev);
rtw_err(rtwdev, "failed to map pci memory\n");
return -ENOMEM;
}
--
2.25.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [PATCH net v1] net: rtw88: fix an issue about leak system resources
2020-05-04 8:34 [PATCH net v1] net: rtw88: fix an issue about leak system resources Dejin Zheng
@ 2020-05-04 8:37 ` Tony Chuang
2020-05-06 8:38 ` [PATCH net v1] " Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Tony Chuang @ 2020-05-04 8:37 UTC (permalink / raw)
To: Dejin Zheng, kvalo, davem, sgruszka, briannorris, linux-wireless, netdev
Cc: linux-kernel, Andy Shevchenko
> Subject: [PATCH net v1] net: rtw88: fix an issue about leak system resources
>
> the related system resources were not released when pci_iomap() return
> error in the rtw_pci_io_mapping() function. add pci_release_regions() to
> fix it.
>
> Fixes: e3037485c68ec1a ("rtw88: new Realtek 802.11ac driver")
> Cc: Andy Shevchenko <andy.shevchenko@gmail.com>
> Signed-off-by: Dejin Zheng <zhengdejin5@gmail.com>
Acked-by: Yan-Hsuan Chuang <yhchuang@realtek.com>
> ---
> drivers/net/wireless/realtek/rtw88/pci.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/wireless/realtek/rtw88/pci.c
> b/drivers/net/wireless/realtek/rtw88/pci.c
> index 695c2c0d64b0..a9752c34c9d8 100644
> --- a/drivers/net/wireless/realtek/rtw88/pci.c
> +++ b/drivers/net/wireless/realtek/rtw88/pci.c
> @@ -1102,6 +1102,7 @@ static int rtw_pci_io_mapping(struct rtw_dev
> *rtwdev,
> len = pci_resource_len(pdev, bar_id);
> rtwpci->mmap = pci_iomap(pdev, bar_id, len);
> if (!rtwpci->mmap) {
> + pci_release_regions(pdev);
> rtw_err(rtwdev, "failed to map pci memory\n");
> return -ENOMEM;
> }
> --
> 2.25.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net v1] rtw88: fix an issue about leak system resources
2020-05-04 8:34 [PATCH net v1] net: rtw88: fix an issue about leak system resources Dejin Zheng
2020-05-04 8:37 ` Tony Chuang
@ 2020-05-06 8:38 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Kalle Valo @ 2020-05-06 8:38 UTC (permalink / raw)
To: Dejin Zheng
Cc: yhchuang, davem, sgruszka, briannorris, linux-wireless, netdev,
linux-kernel, Dejin Zheng, Andy Shevchenko
Dejin Zheng <zhengdejin5@gmail.com> wrote:
> the related system resources were not released when pci_iomap() return
> error in the rtw_pci_io_mapping() function. add pci_release_regions() to
> fix it.
>
> Fixes: e3037485c68ec1a ("rtw88: new Realtek 802.11ac driver")
> Cc: Andy Shevchenko <andy.shevchenko@gmail.com>
> Signed-off-by: Dejin Zheng <zhengdejin5@gmail.com>
> Acked-by: Yan-Hsuan Chuang <yhchuang@realtek.com>
Patch applied to wireless-drivers-next.git, thanks.
191f6b08bfef rtw88: fix an issue about leak system resources
--
https://patchwork.kernel.org/patch/11525207/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-05-06 8:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-04 8:34 [PATCH net v1] net: rtw88: fix an issue about leak system resources Dejin Zheng
2020-05-04 8:37 ` Tony Chuang
2020-05-06 8:38 ` [PATCH net v1] " Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).