archive mirror
 help / color / mirror / Atom feed
* [PATCH] lib: linear_ranges: Add missing MODULE_LICENSE()
@ 2020-05-09 15:15 Matti Vaittinen
  2020-05-10 19:50 ` Sebastian Reichel
  2020-05-11 11:25 ` Mark Brown
  0 siblings, 2 replies; 4+ messages in thread
From: Matti Vaittinen @ 2020-05-09 15:15 UTC (permalink / raw)
  To: matti.vaittinen, mazziesaccount
  Cc: Mark Brown, sre, linux-pm, brendanhiggins, linux-kernel, lgirdwood

When linear_ranges is compiled as module we get warning
about missing MODULE_LICENSE(). Fix it by adding
MODULE_LICENSE("GPL") as is suggested by SPDX and EXPORTs.

Signed-off-by: Matti Vaittinen <>

I saw Mark applied the linear-ranges patch. So I sent this fix as
incremental patch - but I still use the same Linus tree as a base of
this fix - the linear-ranges file should be unchanged in regulator tree.
If this does not apply I can clone regulator tree and create this fix on

I don't know if this is the correct way to fix this as the linear-ranges
should be merged to power-supply tree.

I guess we can either:
- Use this patch to fix regulator tree and create fixed tag for
- Add this fix in the original series and resend whole series(?)
- re-create the series and drop the already applied patches. Add this
  fix as a fixup patch in new series and apply it to power-supply tree
  after the linear-ranges from regulator is merged to power-supply.

 Please adviece me if this patch is not the way to go.

Oh, and I am really sorry for the trouble. I saw I had regulators=y
in all of my compilations due to some pincontrol dependencies. So
linear-ranges was not built as module in any of my test compilations :(

Thanks for testing Mark!

 lib/linear_ranges.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/lib/linear_ranges.c b/lib/linear_ranges.c
index d1336c75ccd7..9495ef3572b7 100644
--- a/lib/linear_ranges.c
+++ b/lib/linear_ranges.c
@@ -12,6 +12,7 @@
 #include <linux/export.h>
 #include <linux/kernel.h>
 #include <linux/linear_range.h>
+#include <linux/module.h>
  * linear_range_values_in_range - return the amount of values in a range
@@ -239,3 +240,6 @@ int linear_range_get_selector_high(const struct linear_range *r,
 	return 0;
+MODULE_DESCRIPTION("linear-ranges helper");

Matti Vaittinen, Linux device drivers
ROHM Semiconductors, Finland SWDC
Kiviharjunlenkki 1E
90220 OULU

~~~ "I don't think so," said Rene Descartes. Just then he vanished ~~~
Simon says - in Latin please.
~~~ "non cogito me" dixit Rene Descarte, deinde evanescavit ~~~
Thanks to Simon Glass for the translation =] 

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2020-05-11 11:25 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-09 15:15 [PATCH] lib: linear_ranges: Add missing MODULE_LICENSE() Matti Vaittinen
2020-05-10 19:50 ` Sebastian Reichel
2020-05-11  6:55   ` Vaittinen, Matti
2020-05-11 11:25 ` Mark Brown

This is a public inbox, see mirroring instructions
on how to clone and mirror all data and code used for this inbox