linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jisheng Zhang <Jisheng.Zhang@synaptics.com>
To: Heiner Kallweit <hkallweit1@gmail.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
	Florian Fainelli <f.fainelli@gmail.com>,
	Russell King <linux@armlinux.org.uk>,
	"David S. Miller" <davem@davemloft.net>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: phy: realtek: clear interrupt during init for rtl8211f
Date: Wed, 13 May 2020 14:51:51 +0800	[thread overview]
Message-ID: <20200513145151.04a6ee46@xhacker.debian> (raw)
In-Reply-To: <7735a257-21ff-e6c0-acdc-f5ee187b1f57@gmail.com>

Hi,

On Tue, 12 May 2020 20:43:40 +0200 Heiner Kallweit wrote:

> 
> 
> On 12.05.2020 12:46, Jisheng Zhang wrote:
> > The PHY Register Accessible Interrupt is enabled by default, so
> > there's such an interrupt during init. In PHY POLL mode case, the
> > INTB/PMEB pin is alway active, it is not good. Clear the interrupt by
> > calling rtl8211f_ack_interrupt().  
> 
> As you say "it's not good" w/o elaborating a little bit more on it:
> Do you face any actual issue? Or do you just think that it's not nice?


The INTB/PMEB pin can be used in two different modes:
INTB: used for interrupt
PMEB: special mode for Wake-on-LAN

The PHY Register Accessible Interrupt is enabled by
default, there's always such an interrupt during the init. In PHY POLL mode
case, the pin is always active. If platforms plans to use the INTB/PMEB pin
as WOL, then the platform will see WOL active. It's not good.


> I'm asking because you don't provide a Fixes tag and you don't
> annotate your patch as net or net-next.

should be Fixes: 3447cf2e9a11 ("net/phy: Add support for Realtek RTL8211F")

> Once you provide more details we would also get an idea whether a
> change would have to be made to phylib, because what you describe
> doesn't seem to be specific to this one PHY model.

Nope, we don't need this change in phylib, this is specific to rtl8211f

Thanks,
Jisheng

  reply	other threads:[~2020-05-13  6:52 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-12 10:46 [PATCH] net: phy: realtek: clear interrupt during init for rtl8211f Jisheng Zhang
2020-05-12 18:43 ` Heiner Kallweit
2020-05-13  6:51   ` Jisheng Zhang [this message]
2020-05-13 18:45     ` Heiner Kallweit
2020-05-14  6:25       ` Jisheng Zhang
2020-05-14 19:50         ` Heiner Kallweit
2020-05-15  7:41           ` Jisheng Zhang
2020-05-15 16:18             ` Florian Fainelli
2020-05-15 17:30               ` Heiner Kallweit
2020-06-17  9:09                 ` Jisheng Zhang
2020-06-21 20:16                   ` Heiner Kallweit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200513145151.04a6ee46@xhacker.debian \
    --to=jisheng.zhang@synaptics.com \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=f.fainelli@gmail.com \
    --cc=hkallweit1@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).