From: Heiner Kallweit <hkallweit1@gmail.com>
To: Jisheng Zhang <Jisheng.Zhang@synaptics.com>,
Andrew Lunn <andrew@lunn.ch>,
Florian Fainelli <f.fainelli@gmail.com>,
Russell King <linux@armlinux.org.uk>,
"David S. Miller" <davem@davemloft.net>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: phy: realtek: clear interrupt during init for rtl8211f
Date: Tue, 12 May 2020 20:43:40 +0200 [thread overview]
Message-ID: <7735a257-21ff-e6c0-acdc-f5ee187b1f57@gmail.com> (raw)
In-Reply-To: <20200512184601.40b1758a@xhacker.debian>
On 12.05.2020 12:46, Jisheng Zhang wrote:
> The PHY Register Accessible Interrupt is enabled by default, so
> there's such an interrupt during init. In PHY POLL mode case, the
> INTB/PMEB pin is alway active, it is not good. Clear the interrupt by
> calling rtl8211f_ack_interrupt().
As you say "it's not good" w/o elaborating a little bit more on it:
Do you face any actual issue? Or do you just think that it's not nice?
I'm asking because you don't provide a Fixes tag and you don't
annotate your patch as net or net-next.
Once you provide more details we would also get an idea whether a
change would have to be made to phylib, because what you describe
doesn't seem to be specific to this one PHY model.
>
> Signed-off-by: Jisheng Zhang <Jisheng.Zhang@synaptics.com>
> ---
> drivers/net/phy/realtek.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/net/phy/realtek.c b/drivers/net/phy/realtek.c
> index 2d99e9de6ee1..398607268a3c 100644
> --- a/drivers/net/phy/realtek.c
> +++ b/drivers/net/phy/realtek.c
> @@ -179,6 +179,10 @@ static int rtl8211f_config_init(struct phy_device *phydev)
> u16 val_txdly, val_rxdly;
> int ret;
>
> + ret = rtl8211f_ack_interrupt(phydev);
> + if (ret < 0)
> + return ret;
> +
> switch (phydev->interface) {
> case PHY_INTERFACE_MODE_RGMII:
> val_txdly = 0;
>
next prev parent reply other threads:[~2020-05-12 18:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-12 10:46 [PATCH] net: phy: realtek: clear interrupt during init for rtl8211f Jisheng Zhang
2020-05-12 18:43 ` Heiner Kallweit [this message]
2020-05-13 6:51 ` Jisheng Zhang
2020-05-13 18:45 ` Heiner Kallweit
2020-05-14 6:25 ` Jisheng Zhang
2020-05-14 19:50 ` Heiner Kallweit
2020-05-15 7:41 ` Jisheng Zhang
2020-05-15 16:18 ` Florian Fainelli
2020-05-15 17:30 ` Heiner Kallweit
2020-06-17 9:09 ` Jisheng Zhang
2020-06-21 20:16 ` Heiner Kallweit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7735a257-21ff-e6c0-acdc-f5ee187b1f57@gmail.com \
--to=hkallweit1@gmail.com \
--cc=Jisheng.Zhang@synaptics.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).