* [PATCH] MIPS: Fix IRQ tracing when call handle_fpe() and handle_msa_fpe()
@ 2020-05-27 6:11 YuanJunQing
2020-05-27 11:35 ` Thomas Bogendoerfer
0 siblings, 1 reply; 4+ messages in thread
From: YuanJunQing @ 2020-05-27 6:11 UTC (permalink / raw)
To: tsbogend
Cc: paulburton, chenhc, linux-mips, linux-kernel, liulichao, YuanJunQing
Register "a1" is unsaved in this function,
when CONFIG_TRACE_IRQFLAGS is enabled,
the TRACE_IRQS_OFF macro will call trace_hardirqs_off(),
and this may change register "a1".
The changed register "a1" as argument will be send
to do_fpe() and do_msa_fpe().
Signed-off-by: YuanJunQing <yuanjunqing66@163.com>
---
arch/mips/kernel/genex.S | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/mips/kernel/genex.S b/arch/mips/kernel/genex.S
index 8236fb291e3f..a1b966f3578e 100644
--- a/arch/mips/kernel/genex.S
+++ b/arch/mips/kernel/genex.S
@@ -476,20 +476,20 @@ NESTED(nmi_handler, PT_SIZE, sp)
.endm
.macro __build_clear_fpe
+ CLI
+ TRACE_IRQS_OFF
.set push
/* gas fails to assemble cfc1 for some archs (octeon).*/ \
.set mips1
SET_HARDFLOAT
cfc1 a1, fcr31
.set pop
- CLI
- TRACE_IRQS_OFF
.endm
.macro __build_clear_msa_fpe
- _cfcmsa a1, MSA_CSR
CLI
TRACE_IRQS_OFF
+ _cfcmsa a1, MSA_CSR
.endm
.macro __build_clear_ade
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] MIPS: Fix IRQ tracing when call handle_fpe() and handle_msa_fpe()
2020-05-27 6:11 [PATCH] MIPS: Fix IRQ tracing when call handle_fpe() and handle_msa_fpe() YuanJunQing
@ 2020-05-27 11:35 ` Thomas Bogendoerfer
0 siblings, 0 replies; 4+ messages in thread
From: Thomas Bogendoerfer @ 2020-05-27 11:35 UTC (permalink / raw)
To: YuanJunQing; +Cc: paulburton, chenhc, linux-mips, linux-kernel, liulichao
On Wed, May 27, 2020 at 02:11:30PM +0800, YuanJunQing wrote:
> Register "a1" is unsaved in this function,
> when CONFIG_TRACE_IRQFLAGS is enabled,
> the TRACE_IRQS_OFF macro will call trace_hardirqs_off(),
> and this may change register "a1".
> The changed register "a1" as argument will be send
> to do_fpe() and do_msa_fpe().
>
> Signed-off-by: YuanJunQing <yuanjunqing66@163.com>
> ---
> arch/mips/kernel/genex.S | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
applied to mips-next.
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] MIPS: Fix IRQ tracing when call handle_fpe() and handle_msa_fpe()
@ 2020-05-28 12:35 YuanJunQing
2020-05-28 12:37 ` yuanjunqing
0 siblings, 1 reply; 4+ messages in thread
From: YuanJunQing @ 2020-05-28 12:35 UTC (permalink / raw)
To: tsbogend
Cc: paulburton, chenhc, linux-mips, linux-kernel, liulichao, YuanJunQing
Register "a1" is unsaved in this function,
when CONFIG_TRACE_IRQFLAGS is enabled,
the TRACE_IRQS_OFF macro will call trace_hardirqs_off(),
and this may change register "a1".
The changed register "a1" as argument will be send
to do_fpe() and do_msa_fpe().
Signed-off-by: YuanJunQing <yuanjunqing66@163.com>
---
arch/mips/kernel/genex.S | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/mips/kernel/genex.S b/arch/mips/kernel/genex.S
index 8236fb291e3f..a1b966f3578e 100644
--- a/arch/mips/kernel/genex.S
+++ b/arch/mips/kernel/genex.S
@@ -476,20 +476,20 @@ NESTED(nmi_handler, PT_SIZE, sp)
.endm
.macro __build_clear_fpe
+ CLI
+ TRACE_IRQS_OFF
.set push
/* gas fails to assemble cfc1 for some archs (octeon).*/ \
.set mips1
SET_HARDFLOAT
cfc1 a1, fcr31
.set pop
- CLI
- TRACE_IRQS_OFF
.endm
.macro __build_clear_msa_fpe
- _cfcmsa a1, MSA_CSR
CLI
TRACE_IRQS_OFF
+ _cfcmsa a1, MSA_CSR
.endm
.macro __build_clear_ade
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] MIPS: Fix IRQ tracing when call handle_fpe() and handle_msa_fpe()
2020-05-28 12:35 YuanJunQing
@ 2020-05-28 12:37 ` yuanjunqing
0 siblings, 0 replies; 4+ messages in thread
From: yuanjunqing @ 2020-05-28 12:37 UTC (permalink / raw)
To: tsbogend; +Cc: paulburton, chenhc, linux-mips, linux-kernel, liulichao
sorry!
在 2020/5/28 下午8:35, YuanJunQing 写道:
> Register "a1" is unsaved in this function,
> when CONFIG_TRACE_IRQFLAGS is enabled,
> the TRACE_IRQS_OFF macro will call trace_hardirqs_off(),
> and this may change register "a1".
> The changed register "a1" as argument will be send
> to do_fpe() and do_msa_fpe().
>
> Signed-off-by: YuanJunQing <yuanjunqing66@163.com>
> ---
> arch/mips/kernel/genex.S | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/mips/kernel/genex.S b/arch/mips/kernel/genex.S
> index 8236fb291e3f..a1b966f3578e 100644
> --- a/arch/mips/kernel/genex.S
> +++ b/arch/mips/kernel/genex.S
> @@ -476,20 +476,20 @@ NESTED(nmi_handler, PT_SIZE, sp)
> .endm
>
> .macro __build_clear_fpe
> + CLI
> + TRACE_IRQS_OFF
> .set push
> /* gas fails to assemble cfc1 for some archs (octeon).*/ \
> .set mips1
> SET_HARDFLOAT
> cfc1 a1, fcr31
> .set pop
> - CLI
> - TRACE_IRQS_OFF
> .endm
>
> .macro __build_clear_msa_fpe
> - _cfcmsa a1, MSA_CSR
> CLI
> TRACE_IRQS_OFF
> + _cfcmsa a1, MSA_CSR
> .endm
>
> .macro __build_clear_ade
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-05-28 12:52 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-27 6:11 [PATCH] MIPS: Fix IRQ tracing when call handle_fpe() and handle_msa_fpe() YuanJunQing
2020-05-27 11:35 ` Thomas Bogendoerfer
2020-05-28 12:35 YuanJunQing
2020-05-28 12:37 ` yuanjunqing
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).