* [PATCH] tee: fix crypto select
@ 2020-05-27 13:39 Arnd Bergmann
2020-05-27 15:07 ` Jens Wiklander
0 siblings, 1 reply; 3+ messages in thread
From: Arnd Bergmann @ 2020-05-27 13:39 UTC (permalink / raw)
To: soc, Jens Wiklander, Vesa Jääskeläinen
Cc: Arnd Bergmann, Devaraj Rangasamy, Rijo Thomas, Gary R Hook,
Herbert Xu, tee-dev, linux-kernel
When selecting a crypto cipher, we also need to select the
subsystem itself:
WARNING: unmet direct dependencies detected for CRYPTO_SHA1
Depends on [m]: CRYPTO [=m]
Selected by [y]:
- TEE [=y] && (HAVE_ARM_SMCCC [=n] || COMPILE_TEST [=y] || CPU_SUP_AMD [=y])
Selected by [m]:
- CRYPTO_DEV_QAT [=m] && CRYPTO [=m] && CRYPTO_HW [=y]
- CRYPTO_DEV_MEDIATEK [=m] && CRYPTO [=m] && CRYPTO_HW [=y] && (ARM && ARCH_MEDIATEK || COMPILE_TEST [=y])
- CRYPTO_DEV_SAFEXCEL [=m] && CRYPTO [=m] && CRYPTO_HW [=y] && (OF [=y] || PCI [=y] || COMPILE_TEST [=y]) && HAS_IOMEM [=y]
- CRYPTO_DEV_CCREE [=m] && CRYPTO [=m] && CRYPTO_HW [=y] && OF [=y] && HAS_DMA [=y]
- CRYPTO_DEV_SP_CCP [=y] && CRYPTO [=m] && CRYPTO_HW [=y] && CRYPTO_DEV_CCP [=y] && CRYPTO_DEV_CCP_DD [=m] && DMADEVICES [=y]
Fixes: e33bcbab16d1 ("tee: add support for session's client UUID generation")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
The regression was introduced in the soc tree, I'd pick this patch
up directly into that unless someone sees a problem
---
drivers/tee/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/tee/Kconfig b/drivers/tee/Kconfig
index 806eb87d4da0..e99d840c2511 100644
--- a/drivers/tee/Kconfig
+++ b/drivers/tee/Kconfig
@@ -3,6 +3,7 @@
config TEE
tristate "Trusted Execution Environment support"
depends on HAVE_ARM_SMCCC || COMPILE_TEST || CPU_SUP_AMD
+ select CRYPTO
select CRYPTO_SHA1
select DMA_SHARED_BUFFER
select GENERIC_ALLOCATOR
--
2.26.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] tee: fix crypto select
2020-05-27 13:39 [PATCH] tee: fix crypto select Arnd Bergmann
@ 2020-05-27 15:07 ` Jens Wiklander
2020-05-28 6:08 ` Vesa Jääskeläinen
0 siblings, 1 reply; 3+ messages in thread
From: Jens Wiklander @ 2020-05-27 15:07 UTC (permalink / raw)
To: Arnd Bergmann
Cc: soc, Vesa Jääskeläinen, Devaraj Rangasamy,
Rijo Thomas, Gary R Hook, Herbert Xu,
tee-dev @ lists . linaro . org, Linux Kernel Mailing List
Hi Arnd,
On Wed, May 27, 2020 at 3:39 PM Arnd Bergmann <arnd@arndb.de> wrote:
>
> When selecting a crypto cipher, we also need to select the
> subsystem itself:
>
> WARNING: unmet direct dependencies detected for CRYPTO_SHA1
> Depends on [m]: CRYPTO [=m]
> Selected by [y]:
> - TEE [=y] && (HAVE_ARM_SMCCC [=n] || COMPILE_TEST [=y] || CPU_SUP_AMD [=y])
> Selected by [m]:
> - CRYPTO_DEV_QAT [=m] && CRYPTO [=m] && CRYPTO_HW [=y]
> - CRYPTO_DEV_MEDIATEK [=m] && CRYPTO [=m] && CRYPTO_HW [=y] && (ARM && ARCH_MEDIATEK || COMPILE_TEST [=y])
> - CRYPTO_DEV_SAFEXCEL [=m] && CRYPTO [=m] && CRYPTO_HW [=y] && (OF [=y] || PCI [=y] || COMPILE_TEST [=y]) && HAS_IOMEM [=y]
> - CRYPTO_DEV_CCREE [=m] && CRYPTO [=m] && CRYPTO_HW [=y] && OF [=y] && HAS_DMA [=y]
> - CRYPTO_DEV_SP_CCP [=y] && CRYPTO [=m] && CRYPTO_HW [=y] && CRYPTO_DEV_CCP [=y] && CRYPTO_DEV_CCP_DD [=m] && DMADEVICES [=y]
>
> Fixes: e33bcbab16d1 ("tee: add support for session's client UUID generation")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> The regression was introduced in the soc tree, I'd pick this patch
> up directly into that unless someone sees a problem
Thanks for taking care of this, please go ahead.
Cheers,
Jens
> ---
> drivers/tee/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/tee/Kconfig b/drivers/tee/Kconfig
> index 806eb87d4da0..e99d840c2511 100644
> --- a/drivers/tee/Kconfig
> +++ b/drivers/tee/Kconfig
> @@ -3,6 +3,7 @@
> config TEE
> tristate "Trusted Execution Environment support"
> depends on HAVE_ARM_SMCCC || COMPILE_TEST || CPU_SUP_AMD
> + select CRYPTO
> select CRYPTO_SHA1
> select DMA_SHARED_BUFFER
> select GENERIC_ALLOCATOR
> --
> 2.26.2
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] tee: fix crypto select
2020-05-27 15:07 ` Jens Wiklander
@ 2020-05-28 6:08 ` Vesa Jääskeläinen
0 siblings, 0 replies; 3+ messages in thread
From: Vesa Jääskeläinen @ 2020-05-28 6:08 UTC (permalink / raw)
To: Jens Wiklander, Arnd Bergmann
Cc: soc, Devaraj Rangasamy, Rijo Thomas, Gary R Hook, Herbert Xu,
tee-dev @ lists . linaro . org, Linux Kernel Mailing List
Hi Arnd & Jens,
On 2020-05-27 18:07, Jens Wiklander wrote:
> Hi Arnd,
>
> On Wed, May 27, 2020 at 3:39 PM Arnd Bergmann <arnd@arndb.de> wrote:
>>
>> When selecting a crypto cipher, we also need to select the
>> subsystem itself:
>>
>> WARNING: unmet direct dependencies detected for CRYPTO_SHA1
>> Depends on [m]: CRYPTO [=m]
>> Selected by [y]:
>> - TEE [=y] && (HAVE_ARM_SMCCC [=n] || COMPILE_TEST [=y] || CPU_SUP_AMD [=y])
>> Selected by [m]:
>> - CRYPTO_DEV_QAT [=m] && CRYPTO [=m] && CRYPTO_HW [=y]
>> - CRYPTO_DEV_MEDIATEK [=m] && CRYPTO [=m] && CRYPTO_HW [=y] && (ARM && ARCH_MEDIATEK || COMPILE_TEST [=y])
>> - CRYPTO_DEV_SAFEXCEL [=m] && CRYPTO [=m] && CRYPTO_HW [=y] && (OF [=y] || PCI [=y] || COMPILE_TEST [=y]) && HAS_IOMEM [=y]
>> - CRYPTO_DEV_CCREE [=m] && CRYPTO [=m] && CRYPTO_HW [=y] && OF [=y] && HAS_DMA [=y]
>> - CRYPTO_DEV_SP_CCP [=y] && CRYPTO [=m] && CRYPTO_HW [=y] && CRYPTO_DEV_CCP [=y] && CRYPTO_DEV_CCP_DD [=m] && DMADEVICES [=y]
>>
>> Fixes: e33bcbab16d1 ("tee: add support for session's client UUID generation")
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>> ---
>> The regression was introduced in the soc tree, I'd pick this patch
>> up directly into that unless someone sees a problem
>
> Thanks for taking care of this, please go ahead.
>
> Cheers,
> Jens
I am also OK for the change. Sorry that we did not notice this during
the review.
Feel free to merge it to the original commit or leave as separate commit.
Reviewed-by: Vesa Jääskeläinen <vesa.jaaskelainen@vaisala.com>
>
>> ---
>> drivers/tee/Kconfig | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/tee/Kconfig b/drivers/tee/Kconfig
>> index 806eb87d4da0..e99d840c2511 100644
>> --- a/drivers/tee/Kconfig
>> +++ b/drivers/tee/Kconfig
>> @@ -3,6 +3,7 @@
>> config TEE
>> tristate "Trusted Execution Environment support"
>> depends on HAVE_ARM_SMCCC || COMPILE_TEST || CPU_SUP_AMD
>> + select CRYPTO
>> select CRYPTO_SHA1
>> select DMA_SHARED_BUFFER
>> select GENERIC_ALLOCATOR
>> --
>> 2.26.2
>>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-05-28 6:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-27 13:39 [PATCH] tee: fix crypto select Arnd Bergmann
2020-05-27 15:07 ` Jens Wiklander
2020-05-28 6:08 ` Vesa Jääskeläinen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).