* [PATCH] lan743x: Use correct MAC_CR configuration for 1 GBit speed
@ 2020-06-03 21:54 Roelof Berg
2020-06-04 1:01 ` Andrew Lunn
2020-06-04 22:57 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Roelof Berg @ 2020-06-03 21:54 UTC (permalink / raw)
Cc: andrew, rberg, Bryan Whitehead, Microchip Linux Driver Support,
David S. Miller, Jakub Kicinski, netdev, linux-kernel
Corrected the MAC_CR configuration bits for 1 GBit operation. The data
sheet allows MAC_CR(2:1) to be 10 and also 11 for 1 GBit/s speed, but
only 10 works correctly.
Devices tested:
Microchip Lan7431, fixed-phy mode
Microchip Lan7430, normal phy mode
Signed-off-by: Roelof Berg <rberg@berg-solutions.de>
---
drivers/net/ethernet/microchip/lan743x_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/microchip/lan743x_main.c b/drivers/net/ethernet/microchip/lan743x_main.c
index 36624e3c633b..c5c5c688b7e2 100644
--- a/drivers/net/ethernet/microchip/lan743x_main.c
+++ b/drivers/net/ethernet/microchip/lan743x_main.c
@@ -985,7 +985,7 @@ static void lan743x_phy_link_status_change(struct net_device *netdev)
break;
case SPEED_1000:
data |= MAC_CR_CFG_H_;
- data |= MAC_CR_CFG_L_;
+ data &= ~MAC_CR_CFG_L_;
break;
}
lan743x_csr_write(adapter, MAC_CR, data);
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] lan743x: Use correct MAC_CR configuration for 1 GBit speed
2020-06-03 21:54 [PATCH] lan743x: Use correct MAC_CR configuration for 1 GBit speed Roelof Berg
@ 2020-06-04 1:01 ` Andrew Lunn
2020-06-04 22:57 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Andrew Lunn @ 2020-06-04 1:01 UTC (permalink / raw)
To: Roelof Berg
Cc: Bryan Whitehead, Microchip Linux Driver Support, David S. Miller,
Jakub Kicinski, netdev, linux-kernel
On Wed, Jun 03, 2020 at 11:54:14PM +0200, Roelof Berg wrote:
> Corrected the MAC_CR configuration bits for 1 GBit operation. The data
> sheet allows MAC_CR(2:1) to be 10 and also 11 for 1 GBit/s speed, but
> only 10 works correctly.
>
> Devices tested:
> Microchip Lan7431, fixed-phy mode
> Microchip Lan7430, normal phy mode
>
> Signed-off-by: Roelof Berg <rberg@berg-solutions.de>
Fixes: 6f197fb63850 ("lan743x: Added fixed link and RGMII support")
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
This was probably in the pull request for the merge window.
Andrew
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] lan743x: Use correct MAC_CR configuration for 1 GBit speed
2020-06-03 21:54 [PATCH] lan743x: Use correct MAC_CR configuration for 1 GBit speed Roelof Berg
2020-06-04 1:01 ` Andrew Lunn
@ 2020-06-04 22:57 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2020-06-04 22:57 UTC (permalink / raw)
To: rberg; +Cc: andrew, bryan.whitehead, UNGLinuxDriver, kuba, netdev, linux-kernel
From: Roelof Berg <rberg@berg-solutions.de>
Date: Wed, 3 Jun 2020 23:54:14 +0200
> Corrected the MAC_CR configuration bits for 1 GBit operation. The data
> sheet allows MAC_CR(2:1) to be 10 and also 11 for 1 GBit/s speed, but
> only 10 works correctly.
>
> Devices tested:
> Microchip Lan7431, fixed-phy mode
> Microchip Lan7430, normal phy mode
>
> Signed-off-by: Roelof Berg <rberg@berg-solutions.de>
Applied, thank you.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-06-04 22:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-03 21:54 [PATCH] lan743x: Use correct MAC_CR configuration for 1 GBit speed Roelof Berg
2020-06-04 1:01 ` Andrew Lunn
2020-06-04 22:57 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).