* [PATCH 0/4] panel-simple: CDTech S070PWS19HP-FC21 and S070SWV29HG-DC44, Tianma TM070JVHG33
@ 2020-06-10 12:01 Matthias Schiffer
2020-06-10 12:01 ` [PATCH 1/4] dt-bindings: display: simple: add CDTech S070PWS19HP-FC21 and S070SWV29HG-DC44 Matthias Schiffer
` (7 more replies)
0 siblings, 8 replies; 16+ messages in thread
From: Matthias Schiffer @ 2020-06-10 12:01 UTC (permalink / raw)
To: Thierry Reding, Sam Ravnborg, David Airlie, Daniel Vetter, Rob Herring
Cc: dri-devel, devicetree, linux-kernel, Matthias Schiffer
From: Matthias Schiffer <matthias.schiffer@tq-group.com>
This adds a few panels TQ-Systems uses with various starterkit
mainboards. Device trees actually using these panels will be added with
a later submission.
Matthias Schiffer (2):
dt-bindings: display: simple: add CDTech S070PWS19HP-FC21 and
S070SWV29HG-DC44
dt-bindings: display: simple: add Tianma TM070JVHG33
Max Merchel (1):
drm/panel: simple: add Tianma TM070JVHG33
Michael Krummsdorf (1):
drm/panel: simple: add CDTech S070PWS19HP-FC21 and S070SWV29HG-DC44
.../bindings/display/panel/panel-simple.yaml | 6 ++
drivers/gpu/drm/panel/panel-simple.c | 74 +++++++++++++++++++
2 files changed, 80 insertions(+)
--
2.17.1
^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH 1/4] dt-bindings: display: simple: add CDTech S070PWS19HP-FC21 and S070SWV29HG-DC44
2020-06-10 12:01 [PATCH 0/4] panel-simple: CDTech S070PWS19HP-FC21 and S070SWV29HG-DC44, Tianma TM070JVHG33 Matthias Schiffer
@ 2020-06-10 12:01 ` Matthias Schiffer
2020-06-10 12:01 ` [PATCH 2/4] dt-bindings: display: simple: add Tianma TM070JVHG33 Matthias Schiffer
` (6 subsequent siblings)
7 siblings, 0 replies; 16+ messages in thread
From: Matthias Schiffer @ 2020-06-10 12:01 UTC (permalink / raw)
To: Thierry Reding, Sam Ravnborg, David Airlie, Daniel Vetter, Rob Herring
Cc: dri-devel, devicetree, linux-kernel, Matthias Schiffer
Add the CDTech Electronics displays S070PWS19HP-FC21 (7.0" WSVGA) and
S070SWV29HG-DC44 (7.0" WVGA) to the panel-simple compatible list.
Signed-off-by: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
---
.../devicetree/bindings/display/panel/panel-simple.yaml | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
index d6cca1479633..7749fbd14c6f 100644
--- a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
+++ b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
@@ -81,6 +81,10 @@ properties:
- boe,nv140fhmn49
# CDTech(H.K.) Electronics Limited 4.3" 480x272 color TFT-LCD panel
- cdtech,s043wq26h-ct7
+ # CDTech(H.K.) Electronics Limited 7" WSVGA (1024x600) TFT LCD Panel
+ - cdtech,s070pws19hp-fc21
+ # CDTech(H.K.) Electronics Limited 7" WVGA (800x480) TFT LCD Panel
+ - cdtech,s070swv29hg-dc44
# CDTech(H.K.) Electronics Limited 7" 800x480 color TFT-LCD panel
- cdtech,s070wv95-ct16
# Chunghwa Picture Tubes Ltd. 7" WXGA TFT LCD panel
--
2.17.1
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [PATCH 2/4] dt-bindings: display: simple: add Tianma TM070JVHG33
2020-06-10 12:01 [PATCH 0/4] panel-simple: CDTech S070PWS19HP-FC21 and S070SWV29HG-DC44, Tianma TM070JVHG33 Matthias Schiffer
2020-06-10 12:01 ` [PATCH 1/4] dt-bindings: display: simple: add CDTech S070PWS19HP-FC21 and S070SWV29HG-DC44 Matthias Schiffer
@ 2020-06-10 12:01 ` Matthias Schiffer
2020-06-10 12:01 ` [PATCH 3/4] drm/panel: simple: add CDTech S070PWS19HP-FC21 and S070SWV29HG-DC44 Matthias Schiffer
` (5 subsequent siblings)
7 siblings, 0 replies; 16+ messages in thread
From: Matthias Schiffer @ 2020-06-10 12:01 UTC (permalink / raw)
To: Thierry Reding, Sam Ravnborg, David Airlie, Daniel Vetter, Rob Herring
Cc: dri-devel, devicetree, linux-kernel, Matthias Schiffer
Add the Tianma Micro-electronics TM070JVHG33 7.0" WXGA display to the
panel-simple compatible list.
Signed-off-by: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
---
.../devicetree/bindings/display/panel/panel-simple.yaml | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
index 7749fbd14c6f..3d5edef2ebad 100644
--- a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
+++ b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
@@ -249,6 +249,8 @@ properties:
- starry,kr122ea0sra
# Tianma Micro-electronics TM070JDHG30 7.0" WXGA TFT LCD panel
- tianma,tm070jdhg30
+ # Tianma Micro-electronics TM070JVHG33 7.0" WXGA TFT LCD panel
+ - tianma,tm070jvhg33
# Tianma Micro-electronics TM070RVHG71 7.0" WXGA TFT LCD panel
- tianma,tm070rvhg71
# Toshiba 8.9" WXGA (1280x768) TFT LCD panel
--
2.17.1
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [PATCH 3/4] drm/panel: simple: add CDTech S070PWS19HP-FC21 and S070SWV29HG-DC44
2020-06-10 12:01 [PATCH 0/4] panel-simple: CDTech S070PWS19HP-FC21 and S070SWV29HG-DC44, Tianma TM070JVHG33 Matthias Schiffer
2020-06-10 12:01 ` [PATCH 1/4] dt-bindings: display: simple: add CDTech S070PWS19HP-FC21 and S070SWV29HG-DC44 Matthias Schiffer
2020-06-10 12:01 ` [PATCH 2/4] dt-bindings: display: simple: add Tianma TM070JVHG33 Matthias Schiffer
@ 2020-06-10 12:01 ` Matthias Schiffer
2020-06-10 14:59 ` Sam Ravnborg
2020-06-10 12:01 ` [PATCH 4/4] drm/panel: simple: add Tianma TM070JVHG33 Matthias Schiffer
` (4 subsequent siblings)
7 siblings, 1 reply; 16+ messages in thread
From: Matthias Schiffer @ 2020-06-10 12:01 UTC (permalink / raw)
To: Thierry Reding, Sam Ravnborg, David Airlie, Daniel Vetter, Rob Herring
Cc: dri-devel, devicetree, linux-kernel, Matthias Schiffer
From: Michael Krummsdorf <michael.krummsdorf@tq-group.com>
Add support for the CDTech Electronics displays S070PWS19HP-FC21
(7.0" WSVGA) and S070SWV29HG-DC44 (7.0" WVGA) to panel-simple.
Signed-off-by: Michael Krummsdorf <michael.krummsdorf@tq-group.com>
Signed-off-by: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
---
drivers/gpu/drm/panel/panel-simple.c | 60 ++++++++++++++++++++++++++++
1 file changed, 60 insertions(+)
diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
index b6ecd1552132..1673113e5a5a 100644
--- a/drivers/gpu/drm/panel/panel-simple.c
+++ b/drivers/gpu/drm/panel/panel-simple.c
@@ -1315,6 +1315,60 @@ static const struct panel_desc cdtech_s043wq26h_ct7 = {
.bus_flags = DRM_BUS_FLAG_PIXDATA_DRIVE_POSEDGE,
};
+/* S070PWS19HP-FC21 2017/04/22 */
+static const struct drm_display_mode cdtech_s070pws19hp_fc21_mode = {
+ .clock = 51200,
+ .hdisplay = 1024,
+ .hsync_start = 1024 + 160,
+ .hsync_end = 1024 + 160 + 20,
+ .htotal = 1024 + 160 + 20 + 140,
+ .vdisplay = 600,
+ .vsync_start = 600 + 12,
+ .vsync_end = 600 + 12 + 3,
+ .vtotal = 600 + 12 + 3 + 20,
+ .vrefresh = 60,
+ .flags = DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_NVSYNC,
+};
+
+static const struct panel_desc cdtech_s070pws19hp_fc21 = {
+ .modes = &cdtech_s070pws19hp_fc21_mode,
+ .num_modes = 1,
+ .bpc = 6,
+ .size = {
+ .width = 154,
+ .height = 86,
+ },
+ .bus_format = MEDIA_BUS_FMT_RGB666_1X18,
+ .bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_POSEDGE,
+};
+
+/* S070SWV29HG-DC44 2017/09/21 */
+static const struct drm_display_mode cdtech_s070swv29hg_dc44_mode = {
+ .clock = 33300,
+ .hdisplay = 800,
+ .hsync_start = 800 + 210,
+ .hsync_end = 800 + 210 + 2,
+ .htotal = 800 + 210 + 2 + 44,
+ .vdisplay = 480,
+ .vsync_start = 480 + 22,
+ .vsync_end = 480 + 22 + 2,
+ .vtotal = 480 + 22 + 2 + 21,
+ .vrefresh = 60,
+ .flags = DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_NVSYNC,
+};
+
+static const struct panel_desc cdtech_s070swv29hg_dc44 = {
+ .modes = &cdtech_s070swv29hg_dc44_mode,
+ .num_modes = 1,
+ .bpc = 6,
+ .size = {
+ .width = 154,
+ .height = 86,
+ },
+ .bus_format = MEDIA_BUS_FMT_RGB666_1X18,
+ .bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_POSEDGE,
+};
+
static const struct drm_display_mode cdtech_s070wv95_ct16_mode = {
.clock = 35000,
.hdisplay = 800,
@@ -3723,6 +3777,12 @@ static const struct of_device_id platform_of_match[] = {
}, {
.compatible = "cdtech,s043wq26h-ct7",
.data = &cdtech_s043wq26h_ct7,
+ }, {
+ .compatible = "cdtech,s070pws19hp-fc21",
+ .data = &cdtech_s070pws19hp_fc21,
+ }, {
+ .compatible = "cdtech,s070swv29hg-dc44",
+ .data = &cdtech_s070swv29hg_dc44,
}, {
.compatible = "cdtech,s070wv95-ct16",
.data = &cdtech_s070wv95_ct16,
--
2.17.1
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [PATCH 4/4] drm/panel: simple: add Tianma TM070JVHG33
2020-06-10 12:01 [PATCH 0/4] panel-simple: CDTech S070PWS19HP-FC21 and S070SWV29HG-DC44, Tianma TM070JVHG33 Matthias Schiffer
` (2 preceding siblings ...)
2020-06-10 12:01 ` [PATCH 3/4] drm/panel: simple: add CDTech S070PWS19HP-FC21 and S070SWV29HG-DC44 Matthias Schiffer
@ 2020-06-10 12:01 ` Matthias Schiffer
2020-06-10 15:00 ` Sam Ravnborg
2020-06-11 12:42 ` [PATCH v2 1/4] dt-bindings: display: simple: add CDTech S070PWS19HP-FC21 and S070SWV29HG-DC44 Matthias Schiffer
` (3 subsequent siblings)
7 siblings, 1 reply; 16+ messages in thread
From: Matthias Schiffer @ 2020-06-10 12:01 UTC (permalink / raw)
To: Thierry Reding, Sam Ravnborg, David Airlie, Daniel Vetter, Rob Herring
Cc: dri-devel, devicetree, linux-kernel, Matthias Schiffer
From: Max Merchel <Max.Merchel@tq-group.com>
Add support for the Tianma Micro-electronics TM070JVHG33 7.0" WXGA display
to panel-simple.
Signed-off-by: Max Merchel <Max.Merchel@tq-group.com>
Signed-off-by: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
---
drivers/gpu/drm/panel/panel-simple.c | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
index 1673113e5a5a..68fcf68da1f3 100644
--- a/drivers/gpu/drm/panel/panel-simple.c
+++ b/drivers/gpu/drm/panel/panel-simple.c
@@ -3421,6 +3421,17 @@ static const struct panel_desc tianma_tm070jdhg30 = {
.connector_type = DRM_MODE_CONNECTOR_LVDS,
};
+static const struct panel_desc tianma_tm070jvhg33 = {
+ .timings = &tianma_tm070jdhg30_timing,
+ .num_timings = 1,
+ .bpc = 8,
+ .size = {
+ .width = 150,
+ .height = 94,
+ },
+ .bus_format = MEDIA_BUS_FMT_RGB888_1X24,
+};
+
static const struct display_timing tianma_tm070rvhg71_timing = {
.pixelclock = { 27700000, 29200000, 39600000 },
.hactive = { 800, 800, 800 },
@@ -4029,6 +4040,9 @@ static const struct of_device_id platform_of_match[] = {
}, {
.compatible = "tianma,tm070jdhg30",
.data = &tianma_tm070jdhg30,
+ }, {
+ .compatible = "tianma,tm070jvhg33",
+ .data = &tianma_tm070jvhg33,
}, {
.compatible = "tianma,tm070rvhg71",
.data = &tianma_tm070rvhg71,
--
2.17.1
^ permalink raw reply related [flat|nested] 16+ messages in thread
* Re: [PATCH 3/4] drm/panel: simple: add CDTech S070PWS19HP-FC21 and S070SWV29HG-DC44
2020-06-10 12:01 ` [PATCH 3/4] drm/panel: simple: add CDTech S070PWS19HP-FC21 and S070SWV29HG-DC44 Matthias Schiffer
@ 2020-06-10 14:59 ` Sam Ravnborg
2020-06-10 15:26 ` (EXT) " Matthias Schiffer
0 siblings, 1 reply; 16+ messages in thread
From: Sam Ravnborg @ 2020-06-10 14:59 UTC (permalink / raw)
To: Matthias Schiffer
Cc: Thierry Reding, David Airlie, Daniel Vetter, Rob Herring,
dri-devel, devicetree, linux-kernel
Hi Matthias.
Thanks, a few details you need to fix. See below.
Sam
On Wed, Jun 10, 2020 at 02:01:30PM +0200, Matthias Schiffer wrote:
> From: Michael Krummsdorf <michael.krummsdorf@tq-group.com>
>
> Add support for the CDTech Electronics displays S070PWS19HP-FC21
> (7.0" WSVGA) and S070SWV29HG-DC44 (7.0" WVGA) to panel-simple.
>
> Signed-off-by: Michael Krummsdorf <michael.krummsdorf@tq-group.com>
> Signed-off-by: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
> ---
> drivers/gpu/drm/panel/panel-simple.c | 60 ++++++++++++++++++++++++++++
> 1 file changed, 60 insertions(+)
>
> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
> index b6ecd1552132..1673113e5a5a 100644
> --- a/drivers/gpu/drm/panel/panel-simple.c
> +++ b/drivers/gpu/drm/panel/panel-simple.c
> @@ -1315,6 +1315,60 @@ static const struct panel_desc cdtech_s043wq26h_ct7 = {
> .bus_flags = DRM_BUS_FLAG_PIXDATA_DRIVE_POSEDGE,
> };
>
> +/* S070PWS19HP-FC21 2017/04/22 */
> +static const struct drm_display_mode cdtech_s070pws19hp_fc21_mode = {
> + .clock = 51200,
> + .hdisplay = 1024,
> + .hsync_start = 1024 + 160,
> + .hsync_end = 1024 + 160 + 20,
> + .htotal = 1024 + 160 + 20 + 140,
> + .vdisplay = 600,
> + .vsync_start = 600 + 12,
> + .vsync_end = 600 + 12 + 3,
> + .vtotal = 600 + 12 + 3 + 20,
> + .vrefresh = 60,
.vrefresh is no longer present, please drop.
> + .flags = DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_NVSYNC,
> +};
> +
> +static const struct panel_desc cdtech_s070pws19hp_fc21 = {
> + .modes = &cdtech_s070pws19hp_fc21_mode,
> + .num_modes = 1,
> + .bpc = 6,
> + .size = {
> + .width = 154,
> + .height = 86,
> + },
> + .bus_format = MEDIA_BUS_FMT_RGB666_1X18,
> + .bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_POSEDGE,
> +};
Please add .connector_type - it is mandatory.
> +
> +/* S070SWV29HG-DC44 2017/09/21 */
> +static const struct drm_display_mode cdtech_s070swv29hg_dc44_mode = {
> + .clock = 33300,
> + .hdisplay = 800,
> + .hsync_start = 800 + 210,
> + .hsync_end = 800 + 210 + 2,
> + .htotal = 800 + 210 + 2 + 44,
> + .vdisplay = 480,
> + .vsync_start = 480 + 22,
> + .vsync_end = 480 + 22 + 2,
> + .vtotal = 480 + 22 + 2 + 21,
> + .vrefresh = 60,
.vrefresh is no longer present, please drop.
> + .flags = DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_NVSYNC,
> +};
> +
> +static const struct panel_desc cdtech_s070swv29hg_dc44 = {
> + .modes = &cdtech_s070swv29hg_dc44_mode,
> + .num_modes = 1,
> + .bpc = 6,
> + .size = {
> + .width = 154,
> + .height = 86,
> + },
> + .bus_format = MEDIA_BUS_FMT_RGB666_1X18,
> + .bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_POSEDGE,
Please add .connector_type - it is mandatory.
> +};
> +
> static const struct drm_display_mode cdtech_s070wv95_ct16_mode = {
> .clock = 35000,
> .hdisplay = 800,
> @@ -3723,6 +3777,12 @@ static const struct of_device_id platform_of_match[] = {
> }, {
> .compatible = "cdtech,s043wq26h-ct7",
> .data = &cdtech_s043wq26h_ct7,
> + }, {
> + .compatible = "cdtech,s070pws19hp-fc21",
> + .data = &cdtech_s070pws19hp_fc21,
> + }, {
> + .compatible = "cdtech,s070swv29hg-dc44",
> + .data = &cdtech_s070swv29hg_dc44,
> }, {
> .compatible = "cdtech,s070wv95-ct16",
> .data = &cdtech_s070wv95_ct16,
> --
> 2.17.1
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 4/4] drm/panel: simple: add Tianma TM070JVHG33
2020-06-10 12:01 ` [PATCH 4/4] drm/panel: simple: add Tianma TM070JVHG33 Matthias Schiffer
@ 2020-06-10 15:00 ` Sam Ravnborg
0 siblings, 0 replies; 16+ messages in thread
From: Sam Ravnborg @ 2020-06-10 15:00 UTC (permalink / raw)
To: Matthias Schiffer
Cc: Thierry Reding, David Airlie, Daniel Vetter, Rob Herring,
dri-devel, devicetree, linux-kernel
Hi Matthias.
Thanks,
also a few details here to fix.
Sam
On Wed, Jun 10, 2020 at 02:01:31PM +0200, Matthias Schiffer wrote:
> From: Max Merchel <Max.Merchel@tq-group.com>
>
> Add support for the Tianma Micro-electronics TM070JVHG33 7.0" WXGA display
> to panel-simple.
>
> Signed-off-by: Max Merchel <Max.Merchel@tq-group.com>
> Signed-off-by: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
> ---
> drivers/gpu/drm/panel/panel-simple.c | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
> index 1673113e5a5a..68fcf68da1f3 100644
> --- a/drivers/gpu/drm/panel/panel-simple.c
> +++ b/drivers/gpu/drm/panel/panel-simple.c
> @@ -3421,6 +3421,17 @@ static const struct panel_desc tianma_tm070jdhg30 = {
> .connector_type = DRM_MODE_CONNECTOR_LVDS,
> };
>
> +static const struct panel_desc tianma_tm070jvhg33 = {
> + .timings = &tianma_tm070jdhg30_timing,
> + .num_timings = 1,
> + .bpc = 8,
> + .size = {
> + .width = 150,
> + .height = 94,
> + },
> + .bus_format = MEDIA_BUS_FMT_RGB888_1X24,
.bus_flags??
And again .connector_type.
Sam
> +};
> +
> static const struct display_timing tianma_tm070rvhg71_timing = {
> .pixelclock = { 27700000, 29200000, 39600000 },
> .hactive = { 800, 800, 800 },
> @@ -4029,6 +4040,9 @@ static const struct of_device_id platform_of_match[] = {
> }, {
> .compatible = "tianma,tm070jdhg30",
> .data = &tianma_tm070jdhg30,
> + }, {
> + .compatible = "tianma,tm070jvhg33",
> + .data = &tianma_tm070jvhg33,
> }, {
> .compatible = "tianma,tm070rvhg71",
> .data = &tianma_tm070rvhg71,
> --
> 2.17.1
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: (EXT) Re: [PATCH 3/4] drm/panel: simple: add CDTech S070PWS19HP-FC21 and S070SWV29HG-DC44
2020-06-10 14:59 ` Sam Ravnborg
@ 2020-06-10 15:26 ` Matthias Schiffer
2020-06-10 16:02 ` Sam Ravnborg
2020-06-15 21:20 ` Emil Velikov
0 siblings, 2 replies; 16+ messages in thread
From: Matthias Schiffer @ 2020-06-10 15:26 UTC (permalink / raw)
To: Sam Ravnborg
Cc: Thierry Reding, David Airlie, Daniel Vetter, Rob Herring,
dri-devel, devicetree, linux-kernel
On Wed, 2020-06-10 at 16:59 +0200, Sam Ravnborg wrote:
> Hi Matthias.
>
> Thanks, a few details you need to fix. See below.
>
> Sam
>
> On Wed, Jun 10, 2020 at 02:01:30PM +0200, Matthias Schiffer wrote:
> > From: Michael Krummsdorf <michael.krummsdorf@tq-group.com>
> >
> > Add support for the CDTech Electronics displays S070PWS19HP-FC21
> > (7.0" WSVGA) and S070SWV29HG-DC44 (7.0" WVGA) to panel-simple.
> >
> > Signed-off-by: Michael Krummsdorf <michael.krummsdorf@tq-group.com>
> > Signed-off-by: Matthias Schiffer <matthias.schiffer@ew.tq-group.com
> > >
> > ---
> > drivers/gpu/drm/panel/panel-simple.c | 60
> > ++++++++++++++++++++++++++++
> > 1 file changed, 60 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/panel/panel-simple.c
> > b/drivers/gpu/drm/panel/panel-simple.c
> > index b6ecd1552132..1673113e5a5a 100644
> > --- a/drivers/gpu/drm/panel/panel-simple.c
> > +++ b/drivers/gpu/drm/panel/panel-simple.c
> > @@ -1315,6 +1315,60 @@ static const struct panel_desc
> > cdtech_s043wq26h_ct7 = {
> > .bus_flags = DRM_BUS_FLAG_PIXDATA_DRIVE_POSEDGE,
> > };
> >
> > +/* S070PWS19HP-FC21 2017/04/22 */
> > +static const struct drm_display_mode cdtech_s070pws19hp_fc21_mode
> > = {
> > + .clock = 51200,
> > + .hdisplay = 1024,
> > + .hsync_start = 1024 + 160,
> > + .hsync_end = 1024 + 160 + 20,
> > + .htotal = 1024 + 160 + 20 + 140,
> > + .vdisplay = 600,
> > + .vsync_start = 600 + 12,
> > + .vsync_end = 600 + 12 + 3,
> > + .vtotal = 600 + 12 + 3 + 20,
> > + .vrefresh = 60,
>
> .vrefresh is no longer present, please drop.
I based my patches on the branch drm-next of
https://cgit.freedesktop.org/drm/drm, should I have used a different
branch?
> > + .flags = DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_NVSYNC,
> > +};
> > +
> > +static const struct panel_desc cdtech_s070pws19hp_fc21 = {
> > + .modes = &cdtech_s070pws19hp_fc21_mode,
> > + .num_modes = 1,
> > + .bpc = 6,
> > + .size = {
> > + .width = 154,
> > + .height = 86,
> > + },
> > + .bus_format = MEDIA_BUS_FMT_RGB666_1X18,
> > + .bus_flags = DRM_BUS_FLAG_DE_HIGH |
> > DRM_BUS_FLAG_PIXDATA_POSEDGE,
> > +};
>
> Please add .connector_type - it is mandatory.
> > +
> > +/* S070SWV29HG-DC44 2017/09/21 */
> > +static const struct drm_display_mode cdtech_s070swv29hg_dc44_mode
> > = {
> > + .clock = 33300,
> > + .hdisplay = 800,
> > + .hsync_start = 800 + 210,
> > + .hsync_end = 800 + 210 + 2,
> > + .htotal = 800 + 210 + 2 + 44,
> > + .vdisplay = 480,
> > + .vsync_start = 480 + 22,
> > + .vsync_end = 480 + 22 + 2,
> > + .vtotal = 480 + 22 + 2 + 21,
> > + .vrefresh = 60,
>
> .vrefresh is no longer present, please drop.
> > + .flags = DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_NVSYNC,
> > +};
> > +
> > +static const struct panel_desc cdtech_s070swv29hg_dc44 = {
> > + .modes = &cdtech_s070swv29hg_dc44_mode,
> > + .num_modes = 1,
> > + .bpc = 6,
> > + .size = {
> > + .width = 154,
> > + .height = 86,
> > + },
> > + .bus_format = MEDIA_BUS_FMT_RGB666_1X18,
> > + .bus_flags = DRM_BUS_FLAG_DE_HIGH |
> > DRM_BUS_FLAG_PIXDATA_POSEDGE,
>
> Please add .connector_type - it is mandatory.
> > +};
> > +
> > static const struct drm_display_mode cdtech_s070wv95_ct16_mode = {
> > .clock = 35000,
> > .hdisplay = 800,
> > @@ -3723,6 +3777,12 @@ static const struct of_device_id
> > platform_of_match[] = {
> > }, {
> > .compatible = "cdtech,s043wq26h-ct7",
> > .data = &cdtech_s043wq26h_ct7,
> > + }, {
> > + .compatible = "cdtech,s070pws19hp-fc21",
> > + .data = &cdtech_s070pws19hp_fc21,
> > + }, {
> > + .compatible = "cdtech,s070swv29hg-dc44",
> > + .data = &cdtech_s070swv29hg_dc44,
> > }, {
> > .compatible = "cdtech,s070wv95-ct16",
> > .data = &cdtech_s070wv95_ct16,
> > --
> > 2.17.1
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: (EXT) Re: [PATCH 3/4] drm/panel: simple: add CDTech S070PWS19HP-FC21 and S070SWV29HG-DC44
2020-06-10 15:26 ` (EXT) " Matthias Schiffer
@ 2020-06-10 16:02 ` Sam Ravnborg
2020-06-15 21:20 ` Emil Velikov
1 sibling, 0 replies; 16+ messages in thread
From: Sam Ravnborg @ 2020-06-10 16:02 UTC (permalink / raw)
To: Matthias Schiffer
Cc: Thierry Reding, David Airlie, Daniel Vetter, Rob Herring,
dri-devel, devicetree, linux-kernel
On Wed, Jun 10, 2020 at 05:26:23PM +0200, Matthias Schiffer wrote:
> On Wed, 2020-06-10 at 16:59 +0200, Sam Ravnborg wrote:
> > Hi Matthias.
> >
> > Thanks, a few details you need to fix. See below.
> >
> > Sam
> >
> > On Wed, Jun 10, 2020 at 02:01:30PM +0200, Matthias Schiffer wrote:
> > > From: Michael Krummsdorf <michael.krummsdorf@tq-group.com>
> > >
> > > Add support for the CDTech Electronics displays S070PWS19HP-FC21
> > > (7.0" WSVGA) and S070SWV29HG-DC44 (7.0" WVGA) to panel-simple.
> > >
> > > Signed-off-by: Michael Krummsdorf <michael.krummsdorf@tq-group.com>
> > > Signed-off-by: Matthias Schiffer <matthias.schiffer@ew.tq-group.com
> > > >
> > > ---
> > > drivers/gpu/drm/panel/panel-simple.c | 60
> > > ++++++++++++++++++++++++++++
> > > 1 file changed, 60 insertions(+)
> > >
> > > diff --git a/drivers/gpu/drm/panel/panel-simple.c
> > > b/drivers/gpu/drm/panel/panel-simple.c
> > > index b6ecd1552132..1673113e5a5a 100644
> > > --- a/drivers/gpu/drm/panel/panel-simple.c
> > > +++ b/drivers/gpu/drm/panel/panel-simple.c
> > > @@ -1315,6 +1315,60 @@ static const struct panel_desc
> > > cdtech_s043wq26h_ct7 = {
> > > .bus_flags = DRM_BUS_FLAG_PIXDATA_DRIVE_POSEDGE,
> > > };
> > >
> > > +/* S070PWS19HP-FC21 2017/04/22 */
> > > +static const struct drm_display_mode cdtech_s070pws19hp_fc21_mode
> > > = {
> > > + .clock = 51200,
> > > + .hdisplay = 1024,
> > > + .hsync_start = 1024 + 160,
> > > + .hsync_end = 1024 + 160 + 20,
> > > + .htotal = 1024 + 160 + 20 + 140,
> > > + .vdisplay = 600,
> > > + .vsync_start = 600 + 12,
> > > + .vsync_end = 600 + 12 + 3,
> > > + .vtotal = 600 + 12 + 3 + 20,
> > > + .vrefresh = 60,
> >
> > .vrefresh is no longer present, please drop.
>
> I based my patches on the branch drm-next of
> https://cgit.freedesktop.org/drm/drm, should I have used a different
> branch?
drm-misc-next would in this case be a better choice.
In most cases both would have worked equally well, but we have nuked
.refresh recently.
Sam
>
>
> > > + .flags = DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_NVSYNC,
> > > +};
> > > +
> > > +static const struct panel_desc cdtech_s070pws19hp_fc21 = {
> > > + .modes = &cdtech_s070pws19hp_fc21_mode,
> > > + .num_modes = 1,
> > > + .bpc = 6,
> > > + .size = {
> > > + .width = 154,
> > > + .height = 86,
> > > + },
> > > + .bus_format = MEDIA_BUS_FMT_RGB666_1X18,
> > > + .bus_flags = DRM_BUS_FLAG_DE_HIGH |
> > > DRM_BUS_FLAG_PIXDATA_POSEDGE,
> > > +};
> >
> > Please add .connector_type - it is mandatory.
> > > +
> > > +/* S070SWV29HG-DC44 2017/09/21 */
> > > +static const struct drm_display_mode cdtech_s070swv29hg_dc44_mode
> > > = {
> > > + .clock = 33300,
> > > + .hdisplay = 800,
> > > + .hsync_start = 800 + 210,
> > > + .hsync_end = 800 + 210 + 2,
> > > + .htotal = 800 + 210 + 2 + 44,
> > > + .vdisplay = 480,
> > > + .vsync_start = 480 + 22,
> > > + .vsync_end = 480 + 22 + 2,
> > > + .vtotal = 480 + 22 + 2 + 21,
> > > + .vrefresh = 60,
> >
> > .vrefresh is no longer present, please drop.
> > > + .flags = DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_NVSYNC,
> > > +};
> > > +
> > > +static const struct panel_desc cdtech_s070swv29hg_dc44 = {
> > > + .modes = &cdtech_s070swv29hg_dc44_mode,
> > > + .num_modes = 1,
> > > + .bpc = 6,
> > > + .size = {
> > > + .width = 154,
> > > + .height = 86,
> > > + },
> > > + .bus_format = MEDIA_BUS_FMT_RGB666_1X18,
> > > + .bus_flags = DRM_BUS_FLAG_DE_HIGH |
> > > DRM_BUS_FLAG_PIXDATA_POSEDGE,
> >
> > Please add .connector_type - it is mandatory.
> > > +};
> > > +
> > > static const struct drm_display_mode cdtech_s070wv95_ct16_mode = {
> > > .clock = 35000,
> > > .hdisplay = 800,
> > > @@ -3723,6 +3777,12 @@ static const struct of_device_id
> > > platform_of_match[] = {
> > > }, {
> > > .compatible = "cdtech,s043wq26h-ct7",
> > > .data = &cdtech_s043wq26h_ct7,
> > > + }, {
> > > + .compatible = "cdtech,s070pws19hp-fc21",
> > > + .data = &cdtech_s070pws19hp_fc21,
> > > + }, {
> > > + .compatible = "cdtech,s070swv29hg-dc44",
> > > + .data = &cdtech_s070swv29hg_dc44,
> > > }, {
> > > .compatible = "cdtech,s070wv95-ct16",
> > > .data = &cdtech_s070wv95_ct16,
> > > --
> > > 2.17.1
^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH v2 1/4] dt-bindings: display: simple: add CDTech S070PWS19HP-FC21 and S070SWV29HG-DC44
2020-06-10 12:01 [PATCH 0/4] panel-simple: CDTech S070PWS19HP-FC21 and S070SWV29HG-DC44, Tianma TM070JVHG33 Matthias Schiffer
` (3 preceding siblings ...)
2020-06-10 12:01 ` [PATCH 4/4] drm/panel: simple: add Tianma TM070JVHG33 Matthias Schiffer
@ 2020-06-11 12:42 ` Matthias Schiffer
2020-06-11 12:46 ` Matthias Schiffer
2020-06-11 12:42 ` [PATCH v2 2/4] dt-bindings: display: simple: add Tianma TM070JVHG33 Matthias Schiffer
` (2 subsequent siblings)
7 siblings, 1 reply; 16+ messages in thread
From: Matthias Schiffer @ 2020-06-11 12:42 UTC (permalink / raw)
To: Thierry Reding, Sam Ravnborg, David Airlie, Daniel Vetter, Rob Herring
Cc: dri-devel, devicetree, linux-kernel, Matthias Schiffer
Add the CDTech Electronics displays S070PWS19HP-FC21 (7.0" WSVGA) and
S070SWV29HG-DC44 (7.0" WVGA) to the panel-simple compatible list.
Signed-off-by: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
---
v2: no changes
.../devicetree/bindings/display/panel/panel-simple.yaml | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
index 31e3efc73e00..2ddb520edc6d 100644
--- a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
+++ b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
@@ -81,6 +81,10 @@ properties:
- boe,nv140fhmn49
# CDTech(H.K.) Electronics Limited 4.3" 480x272 color TFT-LCD panel
- cdtech,s043wq26h-ct7
+ # CDTech(H.K.) Electronics Limited 7" WSVGA (1024x600) TFT LCD Panel
+ - cdtech,s070pws19hp-fc21
+ # CDTech(H.K.) Electronics Limited 7" WVGA (800x480) TFT LCD Panel
+ - cdtech,s070swv29hg-dc44
# CDTech(H.K.) Electronics Limited 7" 800x480 color TFT-LCD panel
- cdtech,s070wv95-ct16
# Chunghwa Picture Tubes Ltd. 7" WXGA TFT LCD panel
--
2.17.1
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [PATCH v2 2/4] dt-bindings: display: simple: add Tianma TM070JVHG33
2020-06-10 12:01 [PATCH 0/4] panel-simple: CDTech S070PWS19HP-FC21 and S070SWV29HG-DC44, Tianma TM070JVHG33 Matthias Schiffer
` (4 preceding siblings ...)
2020-06-11 12:42 ` [PATCH v2 1/4] dt-bindings: display: simple: add CDTech S070PWS19HP-FC21 and S070SWV29HG-DC44 Matthias Schiffer
@ 2020-06-11 12:42 ` Matthias Schiffer
2020-06-11 12:42 ` [PATCH v2 3/4] drm/panel: simple: add CDTech S070PWS19HP-FC21 and S070SWV29HG-DC44 Matthias Schiffer
2020-06-11 12:42 ` [PATCH v2 4/4] drm/panel: simple: add Tianma TM070JVHG33 Matthias Schiffer
7 siblings, 0 replies; 16+ messages in thread
From: Matthias Schiffer @ 2020-06-11 12:42 UTC (permalink / raw)
To: Thierry Reding, Sam Ravnborg, David Airlie, Daniel Vetter, Rob Herring
Cc: dri-devel, devicetree, linux-kernel, Matthias Schiffer
Add the Tianma Micro-electronics TM070JVHG33 7.0" WXGA display to the
panel-simple compatible list.
Signed-off-by: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
---
v2: no changes
.../devicetree/bindings/display/panel/panel-simple.yaml | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
index 2ddb520edc6d..6deeeed59e59 100644
--- a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
+++ b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
@@ -251,6 +251,8 @@ properties:
- starry,kr122ea0sra
# Tianma Micro-electronics TM070JDHG30 7.0" WXGA TFT LCD panel
- tianma,tm070jdhg30
+ # Tianma Micro-electronics TM070JVHG33 7.0" WXGA TFT LCD panel
+ - tianma,tm070jvhg33
# Tianma Micro-electronics TM070RVHG71 7.0" WXGA TFT LCD panel
- tianma,tm070rvhg71
# Toshiba 8.9" WXGA (1280x768) TFT LCD panel
--
2.17.1
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [PATCH v2 3/4] drm/panel: simple: add CDTech S070PWS19HP-FC21 and S070SWV29HG-DC44
2020-06-10 12:01 [PATCH 0/4] panel-simple: CDTech S070PWS19HP-FC21 and S070SWV29HG-DC44, Tianma TM070JVHG33 Matthias Schiffer
` (5 preceding siblings ...)
2020-06-11 12:42 ` [PATCH v2 2/4] dt-bindings: display: simple: add Tianma TM070JVHG33 Matthias Schiffer
@ 2020-06-11 12:42 ` Matthias Schiffer
2020-06-11 12:42 ` [PATCH v2 4/4] drm/panel: simple: add Tianma TM070JVHG33 Matthias Schiffer
7 siblings, 0 replies; 16+ messages in thread
From: Matthias Schiffer @ 2020-06-11 12:42 UTC (permalink / raw)
To: Thierry Reding, Sam Ravnborg, David Airlie, Daniel Vetter, Rob Herring
Cc: dri-devel, devicetree, linux-kernel, Matthias Schiffer
From: Michael Krummsdorf <michael.krummsdorf@tq-group.com>
Add support for the CDTech Electronics displays S070PWS19HP-FC21
(7.0" WSVGA) and S070SWV29HG-DC44 (7.0" WVGA) to panel-simple.
Signed-off-by: Michael Krummsdorf <michael.krummsdorf@tq-group.com>
Signed-off-by: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
---
v2:
- removed vrefresh
- added connector_type
drivers/gpu/drm/panel/panel-simple.c | 60 ++++++++++++++++++++++++++++
1 file changed, 60 insertions(+)
diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
index 6764ac630e22..ee9815e5eee8 100644
--- a/drivers/gpu/drm/panel/panel-simple.c
+++ b/drivers/gpu/drm/panel/panel-simple.c
@@ -1296,6 +1296,60 @@ static const struct panel_desc cdtech_s043wq26h_ct7 = {
.bus_flags = DRM_BUS_FLAG_PIXDATA_DRIVE_POSEDGE,
};
+/* S070PWS19HP-FC21 2017/04/22 */
+static const struct drm_display_mode cdtech_s070pws19hp_fc21_mode = {
+ .clock = 51200,
+ .hdisplay = 1024,
+ .hsync_start = 1024 + 160,
+ .hsync_end = 1024 + 160 + 20,
+ .htotal = 1024 + 160 + 20 + 140,
+ .vdisplay = 600,
+ .vsync_start = 600 + 12,
+ .vsync_end = 600 + 12 + 3,
+ .vtotal = 600 + 12 + 3 + 20,
+ .flags = DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_NVSYNC,
+};
+
+static const struct panel_desc cdtech_s070pws19hp_fc21 = {
+ .modes = &cdtech_s070pws19hp_fc21_mode,
+ .num_modes = 1,
+ .bpc = 6,
+ .size = {
+ .width = 154,
+ .height = 86,
+ },
+ .bus_format = MEDIA_BUS_FMT_RGB666_1X18,
+ .bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_POSEDGE,
+ .connector_type = DRM_MODE_CONNECTOR_DPI,
+};
+
+/* S070SWV29HG-DC44 2017/09/21 */
+static const struct drm_display_mode cdtech_s070swv29hg_dc44_mode = {
+ .clock = 33300,
+ .hdisplay = 800,
+ .hsync_start = 800 + 210,
+ .hsync_end = 800 + 210 + 2,
+ .htotal = 800 + 210 + 2 + 44,
+ .vdisplay = 480,
+ .vsync_start = 480 + 22,
+ .vsync_end = 480 + 22 + 2,
+ .vtotal = 480 + 22 + 2 + 21,
+ .flags = DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_NVSYNC,
+};
+
+static const struct panel_desc cdtech_s070swv29hg_dc44 = {
+ .modes = &cdtech_s070swv29hg_dc44_mode,
+ .num_modes = 1,
+ .bpc = 6,
+ .size = {
+ .width = 154,
+ .height = 86,
+ },
+ .bus_format = MEDIA_BUS_FMT_RGB666_1X18,
+ .bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_POSEDGE,
+ .connector_type = DRM_MODE_CONNECTOR_DPI,
+};
+
static const struct drm_display_mode cdtech_s070wv95_ct16_mode = {
.clock = 35000,
.hdisplay = 800,
@@ -3674,6 +3728,12 @@ static const struct of_device_id platform_of_match[] = {
}, {
.compatible = "cdtech,s043wq26h-ct7",
.data = &cdtech_s043wq26h_ct7,
+ }, {
+ .compatible = "cdtech,s070pws19hp-fc21",
+ .data = &cdtech_s070pws19hp_fc21,
+ }, {
+ .compatible = "cdtech,s070swv29hg-dc44",
+ .data = &cdtech_s070swv29hg_dc44,
}, {
.compatible = "cdtech,s070wv95-ct16",
.data = &cdtech_s070wv95_ct16,
--
2.17.1
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [PATCH v2 4/4] drm/panel: simple: add Tianma TM070JVHG33
2020-06-10 12:01 [PATCH 0/4] panel-simple: CDTech S070PWS19HP-FC21 and S070SWV29HG-DC44, Tianma TM070JVHG33 Matthias Schiffer
` (6 preceding siblings ...)
2020-06-11 12:42 ` [PATCH v2 3/4] drm/panel: simple: add CDTech S070PWS19HP-FC21 and S070SWV29HG-DC44 Matthias Schiffer
@ 2020-06-11 12:42 ` Matthias Schiffer
7 siblings, 0 replies; 16+ messages in thread
From: Matthias Schiffer @ 2020-06-11 12:42 UTC (permalink / raw)
To: Thierry Reding, Sam Ravnborg, David Airlie, Daniel Vetter, Rob Herring
Cc: dri-devel, devicetree, linux-kernel, Matthias Schiffer
From: Max Merchel <Max.Merchel@tq-group.com>
Add support for the Tianma Micro-electronics TM070JVHG33 7.0" WXGA display
to panel-simple.
Signed-off-by: Max Merchel <Max.Merchel@tq-group.com>
Signed-off-by: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
---
v2:
- added connector_type
- fixed bus_format
drivers/gpu/drm/panel/panel-simple.c | 15 +++++++++++++++
1 file changed, 15 insertions(+)
diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
index ee9815e5eee8..54f121256832 100644
--- a/drivers/gpu/drm/panel/panel-simple.c
+++ b/drivers/gpu/drm/panel/panel-simple.c
@@ -3380,6 +3380,18 @@ static const struct panel_desc tianma_tm070jdhg30 = {
.connector_type = DRM_MODE_CONNECTOR_LVDS,
};
+static const struct panel_desc tianma_tm070jvhg33 = {
+ .timings = &tianma_tm070jdhg30_timing,
+ .num_timings = 1,
+ .bpc = 8,
+ .size = {
+ .width = 150,
+ .height = 94,
+ },
+ .bus_format = MEDIA_BUS_FMT_RGB888_1X7X4_SPWG,
+ .connector_type = DRM_MODE_CONNECTOR_LVDS,
+};
+
static const struct display_timing tianma_tm070rvhg71_timing = {
.pixelclock = { 27700000, 29200000, 39600000 },
.hactive = { 800, 800, 800 },
@@ -3983,6 +3995,9 @@ static const struct of_device_id platform_of_match[] = {
}, {
.compatible = "tianma,tm070jdhg30",
.data = &tianma_tm070jdhg30,
+ }, {
+ .compatible = "tianma,tm070jvhg33",
+ .data = &tianma_tm070jvhg33,
}, {
.compatible = "tianma,tm070rvhg71",
.data = &tianma_tm070rvhg71,
--
2.17.1
^ permalink raw reply related [flat|nested] 16+ messages in thread
* Re: [PATCH v2 1/4] dt-bindings: display: simple: add CDTech S070PWS19HP-FC21 and S070SWV29HG-DC44
2020-06-11 12:42 ` [PATCH v2 1/4] dt-bindings: display: simple: add CDTech S070PWS19HP-FC21 and S070SWV29HG-DC44 Matthias Schiffer
@ 2020-06-11 12:46 ` Matthias Schiffer
2020-06-11 19:48 ` Sam Ravnborg
0 siblings, 1 reply; 16+ messages in thread
From: Matthias Schiffer @ 2020-06-11 12:46 UTC (permalink / raw)
To: Thierry Reding, Sam Ravnborg, David Airlie, Daniel Vetter, Rob Herring
Cc: dri-devel, devicetree, linux-kernel
On Thu, 2020-06-11 at 14:42 +0200, Matthias Schiffer wrote:
> Add the CDTech Electronics displays S070PWS19HP-FC21 (7.0" WSVGA) and
> S070SWV29HG-DC44 (7.0" WVGA) to the panel-simple compatible list.
>
> Signed-off-by: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
> ---
>
> v2: no changes
Oops, it seems I held my git send-email wrong, which caused patches v2
2-4 to bounce from some servers, should I resend?
>
> .../devicetree/bindings/display/panel/panel-simple.yaml | 4
> ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/display/panel/panel-
> simple.yaml b/Documentation/devicetree/bindings/display/panel/panel-
> simple.yaml
> index 31e3efc73e00..2ddb520edc6d 100644
> --- a/Documentation/devicetree/bindings/display/panel/panel-
> simple.yaml
> +++ b/Documentation/devicetree/bindings/display/panel/panel-
> simple.yaml
> @@ -81,6 +81,10 @@ properties:
> - boe,nv140fhmn49
> # CDTech(H.K.) Electronics Limited 4.3" 480x272 color TFT-
> LCD panel
> - cdtech,s043wq26h-ct7
> + # CDTech(H.K.) Electronics Limited 7" WSVGA (1024x600) TFT
> LCD Panel
> + - cdtech,s070pws19hp-fc21
> + # CDTech(H.K.) Electronics Limited 7" WVGA (800x480) TFT LCD
> Panel
> + - cdtech,s070swv29hg-dc44
> # CDTech(H.K.) Electronics Limited 7" 800x480 color TFT-LCD
> panel
> - cdtech,s070wv95-ct16
> # Chunghwa Picture Tubes Ltd. 7" WXGA TFT LCD panel
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH v2 1/4] dt-bindings: display: simple: add CDTech S070PWS19HP-FC21 and S070SWV29HG-DC44
2020-06-11 12:46 ` Matthias Schiffer
@ 2020-06-11 19:48 ` Sam Ravnborg
0 siblings, 0 replies; 16+ messages in thread
From: Sam Ravnborg @ 2020-06-11 19:48 UTC (permalink / raw)
To: Matthias Schiffer
Cc: Thierry Reding, David Airlie, Daniel Vetter, Rob Herring,
dri-devel, devicetree, linux-kernel
Hi Matthias.
On Thu, Jun 11, 2020 at 02:46:22PM +0200, Matthias Schiffer wrote:
> On Thu, 2020-06-11 at 14:42 +0200, Matthias Schiffer wrote:
> > Add the CDTech Electronics displays S070PWS19HP-FC21 (7.0" WSVGA) and
> > S070SWV29HG-DC44 (7.0" WVGA) to the panel-simple compatible list.
> >
> > Signed-off-by: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
> > ---
> >
> > v2: no changes
>
> Oops, it seems I held my git send-email wrong, which caused patches v2
> 2-4 to bounce from some servers, should I resend?
Please do, I do not see them here.
Sam
>
>
> >
> > .../devicetree/bindings/display/panel/panel-simple.yaml | 4
> > ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/display/panel/panel-
> > simple.yaml b/Documentation/devicetree/bindings/display/panel/panel-
> > simple.yaml
> > index 31e3efc73e00..2ddb520edc6d 100644
> > --- a/Documentation/devicetree/bindings/display/panel/panel-
> > simple.yaml
> > +++ b/Documentation/devicetree/bindings/display/panel/panel-
> > simple.yaml
> > @@ -81,6 +81,10 @@ properties:
> > - boe,nv140fhmn49
> > # CDTech(H.K.) Electronics Limited 4.3" 480x272 color TFT-
> > LCD panel
> > - cdtech,s043wq26h-ct7
> > + # CDTech(H.K.) Electronics Limited 7" WSVGA (1024x600) TFT
> > LCD Panel
> > + - cdtech,s070pws19hp-fc21
> > + # CDTech(H.K.) Electronics Limited 7" WVGA (800x480) TFT LCD
> > Panel
> > + - cdtech,s070swv29hg-dc44
> > # CDTech(H.K.) Electronics Limited 7" 800x480 color TFT-LCD
> > panel
> > - cdtech,s070wv95-ct16
> > # Chunghwa Picture Tubes Ltd. 7" WXGA TFT LCD panel
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: (EXT) Re: [PATCH 3/4] drm/panel: simple: add CDTech S070PWS19HP-FC21 and S070SWV29HG-DC44
2020-06-10 15:26 ` (EXT) " Matthias Schiffer
2020-06-10 16:02 ` Sam Ravnborg
@ 2020-06-15 21:20 ` Emil Velikov
1 sibling, 0 replies; 16+ messages in thread
From: Emil Velikov @ 2020-06-15 21:20 UTC (permalink / raw)
To: Matthias Schiffer
Cc: Sam Ravnborg, devicetree, David Airlie,
Linux-Kernel@Vger. Kernel. Org, ML dri-devel, Rob Herring,
Thierry Reding
Hi Matthias,
On Thu, 11 Jun 2020 at 08:54, Matthias Schiffer
<matthias.schiffer@ew.tq-group.com> wrote:
> On Wed, 2020-06-10 at 16:59 +0200, Sam Ravnborg wrote:
> > On Wed, Jun 10, 2020 at 02:01:30PM +0200, Matthias Schiffer wrote:
> > > + .vrefresh = 60,
> >
> > .vrefresh is no longer present, please drop.
>
> I based my patches on the branch drm-next of
> https://cgit.freedesktop.org/drm/drm, should I have used a different
> branch?
>
Small tip for the future:
The best way to find the correct tree is to check with the MAINTAINERS
file or via ./scripts/get_maintainer --scm ...
-Emil
^ permalink raw reply [flat|nested] 16+ messages in thread
end of thread, other threads:[~2020-06-15 21:24 UTC | newest]
Thread overview: 16+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-10 12:01 [PATCH 0/4] panel-simple: CDTech S070PWS19HP-FC21 and S070SWV29HG-DC44, Tianma TM070JVHG33 Matthias Schiffer
2020-06-10 12:01 ` [PATCH 1/4] dt-bindings: display: simple: add CDTech S070PWS19HP-FC21 and S070SWV29HG-DC44 Matthias Schiffer
2020-06-10 12:01 ` [PATCH 2/4] dt-bindings: display: simple: add Tianma TM070JVHG33 Matthias Schiffer
2020-06-10 12:01 ` [PATCH 3/4] drm/panel: simple: add CDTech S070PWS19HP-FC21 and S070SWV29HG-DC44 Matthias Schiffer
2020-06-10 14:59 ` Sam Ravnborg
2020-06-10 15:26 ` (EXT) " Matthias Schiffer
2020-06-10 16:02 ` Sam Ravnborg
2020-06-15 21:20 ` Emil Velikov
2020-06-10 12:01 ` [PATCH 4/4] drm/panel: simple: add Tianma TM070JVHG33 Matthias Schiffer
2020-06-10 15:00 ` Sam Ravnborg
2020-06-11 12:42 ` [PATCH v2 1/4] dt-bindings: display: simple: add CDTech S070PWS19HP-FC21 and S070SWV29HG-DC44 Matthias Schiffer
2020-06-11 12:46 ` Matthias Schiffer
2020-06-11 19:48 ` Sam Ravnborg
2020-06-11 12:42 ` [PATCH v2 2/4] dt-bindings: display: simple: add Tianma TM070JVHG33 Matthias Schiffer
2020-06-11 12:42 ` [PATCH v2 3/4] drm/panel: simple: add CDTech S070PWS19HP-FC21 and S070SWV29HG-DC44 Matthias Schiffer
2020-06-11 12:42 ` [PATCH v2 4/4] drm/panel: simple: add Tianma TM070JVHG33 Matthias Schiffer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).