From: Vinod Koul <vkoul@kernel.org>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Cc: Takashi Iwai <tiwai@suse.com>, Jaroslav Kysela <perex@perex.cz>,
Charles Keepax <ckeepax@opensource.cirrus.com>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] ALSA: compress: document the compress audio state machine
Date: Mon, 22 Jun 2020 11:03:04 +0530 [thread overview]
Message-ID: <20200622053304.GD2324254@vkoul-mobl> (raw)
In-Reply-To: <8e322574-14bc-aaaa-5fdb-751cb8b97fff@linux.intel.com>
HI Pierre,
On 19-06-20, 09:22, Pierre-Louis Bossart wrote:
>
> > +
> > + +----------+
> > + | |
> > + | OPEN |
> > + | |
> > + +----------+
> > + |
> > + |
> > + | compr_set_params()
> > + |
> > + V
> > + +----------+
> > + compr_drain_notify() | |
> > + +------------------------>| SETUP |
> > + | | |
> > + | +----------+
> > + | |
> > + | |
> > + | | compr_write()
> > + | |
> > + | V
> > + | +----------+
> > + | | |
> > + | | PREPARE |
> > + | | |
> > + | +----------+
> > + | |
> > + | |
> > + | | compr_start()
> > + | |
> > + | V
> > + +----------+ +----------+ compr_pause() +----------+
> > + | | | |----------------------->| |
> > + | DRAIN |<-------------------| RUNNING | | PAUSE |
> > + | | | |<-----------------------| |
> > + +----------+ +----------+ compr_resume() +----------+
> > + | |
> > + | |
> > + | | compr_free()
> > + | |
> > + | V
> > + | +----------+
> > + | compr_free() | |
> > + +------------------------>| |
> > + | STOP |
> > + | |
> > + +----------+
>
>
> The STOP state doesn't seem quite right to me, sorry.
We should call it free, Will update
> the direction of the DRAIN-STOP comp_free() arrow seems wrong? Of if it is
> correct, then something's missing to exit the STOP state so that the stream
> can be opened again.
Once stream is freed, it can't be opened again.
But we have trigger stop which is not comprehended here, I will add
compr_stop() above which would transition to SETUP state. And a stopped
stream can be freed up as well, so one more transition from SETUP to
FREE.
Thanks for reviewing
--
~Vinod
next prev parent reply other threads:[~2020-06-22 5:33 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-19 4:54 [PATCH 0/3] ALSA: compress: Document stream states and fix gaplless SM Vinod Koul
2020-06-19 4:54 ` [PATCH 1/3] ALSA: compress: document the compress audio state machine Vinod Koul
2020-06-19 9:29 ` Srinivas Kandagatla
2020-06-19 14:22 ` Pierre-Louis Bossart
2020-06-22 5:33 ` Vinod Koul [this message]
2020-06-19 4:54 ` [PATCH 2/3] ALSA: compress: document the compress gapless " Vinod Koul
2020-06-19 14:27 ` Pierre-Louis Bossart
2020-06-22 5:34 ` Vinod Koul
2020-06-22 13:22 ` Pierre-Louis Bossart
2020-06-19 4:54 ` [PATCH 3/3] ALSA: compress: fix partial_drain completion state Vinod Koul
2020-06-19 9:13 ` Srinivas Kandagatla
2020-06-22 5:35 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200622053304.GD2324254@vkoul-mobl \
--to=vkoul@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=ckeepax@opensource.cirrus.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).