From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Vinod Koul <vkoul@kernel.org>, Takashi Iwai <tiwai@suse.com>,
Jaroslav Kysela <perex@perex.cz>
Cc: Charles Keepax <ckeepax@opensource.cirrus.com>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] ALSA: compress: document the compress audio state machine
Date: Fri, 19 Jun 2020 09:22:09 -0500 [thread overview]
Message-ID: <8e322574-14bc-aaaa-5fdb-751cb8b97fff@linux.intel.com> (raw)
In-Reply-To: <20200619045449.3966868-2-vkoul@kernel.org>
> +
> + +----------+
> + | |
> + | OPEN |
> + | |
> + +----------+
> + |
> + |
> + | compr_set_params()
> + |
> + V
> + +----------+
> + compr_drain_notify() | |
> + +------------------------>| SETUP |
> + | | |
> + | +----------+
> + | |
> + | |
> + | | compr_write()
> + | |
> + | V
> + | +----------+
> + | | |
> + | | PREPARE |
> + | | |
> + | +----------+
> + | |
> + | |
> + | | compr_start()
> + | |
> + | V
> + +----------+ +----------+ compr_pause() +----------+
> + | | | |----------------------->| |
> + | DRAIN |<-------------------| RUNNING | | PAUSE |
> + | | | |<-----------------------| |
> + +----------+ +----------+ compr_resume() +----------+
> + | |
> + | |
> + | | compr_free()
> + | |
> + | V
> + | +----------+
> + | compr_free() | |
> + +------------------------>| |
> + | STOP |
> + | |
> + +----------+
The STOP state doesn't seem quite right to me, sorry.
the direction of the DRAIN-STOP comp_free() arrow seems wrong? Of if it
is correct, then something's missing to exit the STOP state so that the
stream can be opened again.
next prev parent reply other threads:[~2020-06-19 16:19 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-19 4:54 [PATCH 0/3] ALSA: compress: Document stream states and fix gaplless SM Vinod Koul
2020-06-19 4:54 ` [PATCH 1/3] ALSA: compress: document the compress audio state machine Vinod Koul
2020-06-19 9:29 ` Srinivas Kandagatla
2020-06-19 14:22 ` Pierre-Louis Bossart [this message]
2020-06-22 5:33 ` Vinod Koul
2020-06-19 4:54 ` [PATCH 2/3] ALSA: compress: document the compress gapless " Vinod Koul
2020-06-19 14:27 ` Pierre-Louis Bossart
2020-06-22 5:34 ` Vinod Koul
2020-06-22 13:22 ` Pierre-Louis Bossart
2020-06-19 4:54 ` [PATCH 3/3] ALSA: compress: fix partial_drain completion state Vinod Koul
2020-06-19 9:13 ` Srinivas Kandagatla
2020-06-22 5:35 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8e322574-14bc-aaaa-5fdb-751cb8b97fff@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=ckeepax@opensource.cirrus.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).