From: Vinod Koul <vkoul@kernel.org>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc: Takashi Iwai <tiwai@suse.com>, Jaroslav Kysela <perex@perex.cz>,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
Charles Keepax <ckeepax@opensource.cirrus.com>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] ALSA: compress: fix partial_drain completion state
Date: Mon, 22 Jun 2020 11:05:02 +0530 [thread overview]
Message-ID: <20200622053502.GF2324254@vkoul-mobl> (raw)
In-Reply-To: <0a0fcd4c-40dd-621e-b0ad-51296178aa9e@linaro.org>
On 19-06-20, 10:13, Srinivas Kandagatla wrote:
>
>
> On 19/06/2020 05:54, Vinod Koul wrote:
> > On partial_drain completion we should be in SNDRV_PCM_STATE_RUNNING
> > state, so set that for partially draining streams in
> > snd_compr_drain_notify() and use a flag for partially draining streams
> >
> > While at it, add locks for stream state change in
> > snd_compr_drain_notify() as well.
> >
> > Fixes: f44f2a5417b2 ("ALSA: compress: fix drain calls blocking other compress functions (v6)")
> > Reported-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> > Signed-off-by: Vinod Koul <vkoul@kernel.org>
> > ---
>
> Reviewed-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> Tested-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Thanks for testing Srini
--
~Vinod
prev parent reply other threads:[~2020-06-22 5:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-19 4:54 [PATCH 0/3] ALSA: compress: Document stream states and fix gaplless SM Vinod Koul
2020-06-19 4:54 ` [PATCH 1/3] ALSA: compress: document the compress audio state machine Vinod Koul
2020-06-19 9:29 ` Srinivas Kandagatla
2020-06-19 14:22 ` Pierre-Louis Bossart
2020-06-22 5:33 ` Vinod Koul
2020-06-19 4:54 ` [PATCH 2/3] ALSA: compress: document the compress gapless " Vinod Koul
2020-06-19 14:27 ` Pierre-Louis Bossart
2020-06-22 5:34 ` Vinod Koul
2020-06-22 13:22 ` Pierre-Louis Bossart
2020-06-19 4:54 ` [PATCH 3/3] ALSA: compress: fix partial_drain completion state Vinod Koul
2020-06-19 9:13 ` Srinivas Kandagatla
2020-06-22 5:35 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200622053502.GF2324254@vkoul-mobl \
--to=vkoul@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=ckeepax@opensource.cirrus.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=srinivas.kandagatla@linaro.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).