From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Konrad Dybcio <konradybcio@gmail.com>
Cc: skrzynka@konradybcio.pl, Andy Gross <agross@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Kees Cook <keescook@chromium.org>,
Anton Vorontsov <anton@enomsg.org>,
Colin Cross <ccross@android.com>, Tony Luck <tony.luck@intel.com>,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-gpio@vger.kernel.org
Subject: Re: [PATCH v2 5/8] arm64: dts: qcom: pm660(l): Add base dts files
Date: Mon, 22 Jun 2020 01:09:43 -0700 [thread overview]
Message-ID: <20200622080943.GE2421@builder.lan> (raw)
In-Reply-To: <20200622075749.21925-6-konradybcio@gmail.com>
On Mon 22 Jun 00:57 PDT 2020, Konrad Dybcio wrote:
> Add base DTS files for pm660(l) along with GPIOs, power-on and
> rtc nodes.
>
> Signed-off-by: Konrad Dybcio <konradybcio@gmail.com>
> ---
> arch/arm64/boot/dts/qcom/pm660.dtsi | 60 ++++++++++++++++++++++++++++
> arch/arm64/boot/dts/qcom/pm660l.dtsi | 46 +++++++++++++++++++++
> 2 files changed, 106 insertions(+)
> create mode 100644 arch/arm64/boot/dts/qcom/pm660.dtsi
> create mode 100644 arch/arm64/boot/dts/qcom/pm660l.dtsi
>
> diff --git a/arch/arm64/boot/dts/qcom/pm660.dtsi b/arch/arm64/boot/dts/qcom/pm660.dtsi
> new file mode 100644
> index 000000000000..041f45264255
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/pm660.dtsi
> @@ -0,0 +1,60 @@
> +// SPDX-License-Identifier: BSD-3-Clause
> +/*
> + * Copyright (c) 2020, Konrad Dybcio
> + */
> +
> +#include <dt-bindings/interrupt-controller/irq.h>
> +#include <dt-bindings/spmi/spmi.h>
> +#include <dt-bindings/input/linux-event-codes.h>
Please keep things alphabetically sorted.
> +
> +&spmi_bus {
> +
> + pmic@0 {
> + compatible = "qcom,pm660", "qcom,spmi-pmic";
> + reg = <0x0 SPMI_USID>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + rtc@6000 {
> + compatible = "qcom,pm8941-rtc";
> + reg = <0x6000>, <0x6100>;
> + reg-names = "rtc", "alarm";
> + interrupts = <0x0 0x61 0x1 IRQ_TYPE_EDGE_RISING>;
> + };
> +
> + pon: pon@800 {
> + compatible = "qcom,pm8916-pon";
> +
> + reg = <0x800>;
> +
> + pwrkey {
> + compatible = "qcom,pm8941-pwrkey";
> + interrupts = <0x0 0x8 0 IRQ_TYPE_EDGE_BOTH>;
> + debounce = <15625>;
> + bias-pull-up;
> + linux,code = <KEY_POWER>;
> + };
> +
> + };
> +
> + pm660_gpios: gpios@c000 {
> + compatible = "qcom,pm660-gpio";
> + reg = <0xc000>;
> + gpio-controller;
> + #gpio-cells = <2>;
> + interrupts = <0 0xc0 0 IRQ_TYPE_NONE>,
The spmi gpio driver now relies on hierarchical irq chips to map its
pins to the interrupt controller's. So you shouldn't list the interrupts
anymore.
But it should be an "interrupt-controller" and you need "gpio-ranges".
> + <0 0xc1 0 IRQ_TYPE_NONE>,
> + <0 0xc2 0 IRQ_TYPE_NONE>,
> + <0 0xc3 0 IRQ_TYPE_NONE>,
> + <0 0xc4 0 IRQ_TYPE_NONE>,
> + <0 0xc5 0 IRQ_TYPE_NONE>,
> + <0 0xc6 0 IRQ_TYPE_NONE>,
> + <0 0xc7 0 IRQ_TYPE_NONE>,
> + <0 0xc8 0 IRQ_TYPE_NONE>,
> + <0 0xc9 0 IRQ_TYPE_NONE>,
> + <0 0xca 0 IRQ_TYPE_NONE>,
> + <0 0xcb 0 IRQ_TYPE_NONE>,
> + <0 0xcc 0 IRQ_TYPE_NONE>;
> + };
> + };
> +};
> diff --git a/arch/arm64/boot/dts/qcom/pm660l.dtsi b/arch/arm64/boot/dts/qcom/pm660l.dtsi
> new file mode 100644
> index 000000000000..5e0f1a6e3966
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/pm660l.dtsi
> @@ -0,0 +1,46 @@
> +// SPDX-License-Identifier: BSD-3-Clause
> +/*
> + * Copyright (c) 2020, Konrad Dybcio
> + */
> +
> +#include <dt-bindings/interrupt-controller/irq.h>
> +#include <dt-bindings/spmi/spmi.h>
> +#include <dt-bindings/input/linux-event-codes.h>
> +
> +&spmi_bus {
> +
> + pmic@2 {
> + compatible = "qcom,pm660l", "qcom,spmi-pmic";
> + reg = <0x2 SPMI_USID>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + pm660l_gpios: gpios@c000 {
> + compatible = "qcom,pm660l-gpio", "qcom,spmi-gpio";
> + reg = <0xc000>;
> + gpio-controller;
> + #gpio-cells = <2>;
> + #interrupt-cells = <2>;
> + interrupts = <0x2 0xc0 0x0 IRQ_TYPE_NONE>,
As above.
Regards,
Bjorn
> + <0x2 0xc1 0x0 IRQ_TYPE_NONE>,
> + <0x2 0xc2 0x0 IRQ_TYPE_NONE>,
> + <0x2 0xc3 0x0 IRQ_TYPE_NONE>,
> + <0x2 0xc4 0x0 IRQ_TYPE_NONE>,
> + <0x2 0xc5 0x0 IRQ_TYPE_NONE>,
> + <0x2 0xc6 0x0 IRQ_TYPE_NONE>,
> + <0x2 0xc7 0x0 IRQ_TYPE_NONE>,
> + <0x2 0xc8 0x0 IRQ_TYPE_NONE>,
> + <0x2 0xc9 0x0 IRQ_TYPE_NONE>,
> + <0x2 0xca 0x0 IRQ_TYPE_NONE>,
> + <0x2 0xcb 0x0 IRQ_TYPE_NONE>;
> + };
> + };
> +
> + pmic@3 {
> + compatible = "qcom,pm660l", "qcom,spmi-pmic";
> + reg = <0x3 SPMI_USID>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> + };
> +};
> +
> --
> 2.27.0
>
next prev parent reply other threads:[~2020-06-22 8:12 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-22 7:57 [PATCH v2 0/8] Add support for Sony SDM630-based boards Konrad Dybcio
2020-06-22 7:57 ` [PATCH v2 1/8] pinctrl: qcom: spmi-gpio: Add pm660(l) compatibility Konrad Dybcio
2020-06-22 8:02 ` Bjorn Andersson
2020-06-22 7:57 ` [PATCH v2 2/8] Documentation: Document pm660(l) SPMI GPIOs compatible Konrad Dybcio
2020-06-22 8:03 ` Bjorn Andersson
2020-06-22 7:57 ` [PATCH v2 3/8] soc: qcom: socinfo: Add socinfo entry for SDM630 Konrad Dybcio
2020-06-22 8:05 ` Bjorn Andersson
2020-06-22 8:37 ` Konrad Dybcio
2020-06-22 17:43 ` Bjorn Andersson
2020-06-22 7:57 ` [PATCH v2 4/8] clk: qcom: smd: Add support for SDM660 rpm clocks Konrad Dybcio
2020-06-22 8:48 ` Stephen Boyd
2020-06-22 7:57 ` [PATCH v2 5/8] arm64: dts: qcom: pm660(l): Add base dts files Konrad Dybcio
2020-06-22 8:09 ` Bjorn Andersson [this message]
2020-06-22 7:57 ` [PATCH v2 6/8] arm64: dts: qcom: sdm630: Add sdm630 dts file Konrad Dybcio
2020-06-22 17:49 ` Bjorn Andersson
2020-06-22 18:01 ` Konrad Dybcio
2020-06-22 7:57 ` [PATCH v2 7/8] arm64: dts: qcom: Add support for Sony Xperia XA2/Plus/Ultra (Nile platform) Konrad Dybcio
2020-06-22 17:52 ` Bjorn Andersson
2020-06-22 7:57 ` [PATCH v2 8/8] arm64: dts: qcom: Add support for Sony Xperia 10/10 Plus (Ganges platform) Konrad Dybcio
2020-06-22 17:54 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200622080943.GE2421@builder.lan \
--to=bjorn.andersson@linaro.org \
--cc=agross@kernel.org \
--cc=anton@enomsg.org \
--cc=ccross@android.com \
--cc=devicetree@vger.kernel.org \
--cc=keescook@chromium.org \
--cc=konradybcio@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=skrzynka@konradybcio.pl \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).