From: Lee Jones <lee.jones@linaro.org>
To: jejb@linux.ibm.com, martin.petersen@oracle.com
Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
Lee Jones <lee.jones@linaro.org>,
Kashyap Desai <kashyap.desai@broadcom.com>,
Sumit Saxena <sumit.saxena@broadcom.com>,
Shivasharan S <shivasharan.srikanteshwara@broadcom.com>,
megaraidlinux.pdl@broadcom.com
Subject: [PATCH 05/10] scsi: megaraid: megaraid_sas_base: Provide prototypes for non-static functions
Date: Tue, 7 Jul 2020 15:00:50 +0100 [thread overview]
Message-ID: <20200707140055.2956235-6-lee.jones@linaro.org> (raw)
In-Reply-To: <20200707140055.2956235-1-lee.jones@linaro.org>
For Megaraid DebugFS functions called from 'megaraid_sas_base.c'.
Fixes the following W=1 kernel build warning(s):
drivers/scsi/megaraid/megaraid_sas_debugfs.c:102:6: warning: no previous prototype for ‘megasas_init_debugfs’ [-Wmissing-prototypes]
102 | void megasas_init_debugfs(void)
| ^~~~~~~~~~~~~~~~~~~~
drivers/scsi/megaraid/megaraid_sas_debugfs.c:112:6: warning: no previous prototype for ‘megasas_exit_debugfs’ [-Wmissing-prototypes]
112 | void megasas_exit_debugfs(void)
| ^~~~~~~~~~~~~~~~~~~~
drivers/scsi/megaraid/megaraid_sas_debugfs.c:122:1: warning: no previous prototype for ‘megasas_setup_debugfs’ [-Wmissing-prototypes]
122 | megasas_setup_debugfs(struct megasas_instance *instance)
| ^~~~~~~~~~~~~~~~~~~~~
drivers/scsi/megaraid/megaraid_sas_debugfs.c:161:6: warning: no previous prototype for ‘megasas_destroy_debugfs’ [-Wmissing-prototypes]
161 | void megasas_destroy_debugfs(struct megasas_instance *instance)
| ^~~~~~~~~~~~~~~~~~~~~~~
Cc: Kashyap Desai <kashyap.desai@broadcom.com>
Cc: Sumit Saxena <sumit.saxena@broadcom.com>
Cc: Shivasharan S <shivasharan.srikanteshwara@broadcom.com>
Cc: megaraidlinux.pdl@broadcom.com
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/scsi/megaraid/megaraid_sas_base.c | 4 ----
drivers/scsi/megaraid/megaraid_sas_fusion.h | 6 ++++++
2 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c b/drivers/scsi/megaraid/megaraid_sas_base.c
index 00668335c2afc..1ccd72b1cbe7f 100644
--- a/drivers/scsi/megaraid/megaraid_sas_base.c
+++ b/drivers/scsi/megaraid/megaraid_sas_base.c
@@ -202,10 +202,6 @@ static bool support_pci_lane_margining;
static spinlock_t poll_aen_lock;
extern struct dentry *megasas_debugfs_root;
-extern void megasas_init_debugfs(void);
-extern void megasas_exit_debugfs(void);
-extern void megasas_setup_debugfs(struct megasas_instance *instance);
-extern void megasas_destroy_debugfs(struct megasas_instance *instance);
void
megasas_complete_cmd(struct megasas_instance *instance, struct megasas_cmd *cmd,
diff --git a/drivers/scsi/megaraid/megaraid_sas_fusion.h b/drivers/scsi/megaraid/megaraid_sas_fusion.h
index 30de4b01f7035..5f657d2ba733a 100644
--- a/drivers/scsi/megaraid/megaraid_sas_fusion.h
+++ b/drivers/scsi/megaraid/megaraid_sas_fusion.h
@@ -1388,4 +1388,10 @@ int megasas_check_mpio_paths(struct megasas_instance *instance,
struct scsi_cmnd *scmd);
void megasas_fusion_ocr_wq(struct work_struct *work);
+/* DebugFS Prototypes */
+void megasas_init_debugfs(void);
+void megasas_exit_debugfs(void);
+void megasas_setup_debugfs(struct megasas_instance *instance);
+void megasas_destroy_debugfs(struct megasas_instance *instance);
+
#endif /* _MEGARAID_SAS_FUSION_H_ */
--
2.25.1
next prev parent reply other threads:[~2020-07-07 14:01 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-07 14:00 [PATCH 00/10] Fix a bunch SCSI related W=1 warnings Lee Jones
2020-07-07 14:00 ` [PATCH 01/10] scsi: megaraid: megaraid_mm: Strip excess function param description Lee Jones
2020-07-07 14:00 ` [PATCH 02/10] scsi: megaraid: megaraid_mbox: Fix some kerneldoc bitrot Lee Jones
2020-07-07 14:00 ` [PATCH 03/10] scsi: fdomain: Mark 'fdomain_pm_ops' as __maybe_unused Lee Jones
2020-07-07 14:00 ` [PATCH 04/10] scsi: megaraid: megaraid_sas_fusion: Fix-up a whole myriad of kerneldoc misdemeanours Lee Jones
2020-07-07 14:00 ` Lee Jones [this message]
2020-07-07 14:00 ` [PATCH 06/10] scsi: aha152x: Remove unused variable 'ret' Lee Jones
2020-07-07 14:00 ` [PATCH 07/10] scsi: pcmcia: nsp_cs: Use new __printf() format notation Lee Jones
2020-07-07 14:00 ` [PATCH 08/10] scsi: pcmcia: nsp_cs: Remove unused variable 'dummy' Lee Jones
2020-07-07 14:00 ` [PATCH 09/10] scsi: libfc: fc_disc: Fix-up some incorrectly referenced function parameters Lee Jones
2020-07-08 6:30 ` Hannes Reinecke
2020-07-08 7:34 ` Johannes Thumshirn
2020-07-08 7:46 ` Lee Jones
2020-07-07 14:00 ` [PATCH 10/10] scsi: megaraid: megaraid_sas: Convert forward-declarations to prototypes Lee Jones
2020-07-08 0:53 ` [PATCH 00/10] Fix a bunch SCSI related W=1 warnings Damien Le Moal
2020-07-08 6:51 ` Lee Jones
2020-07-08 7:35 ` Damien Le Moal
2020-07-08 7:42 ` Lee Jones
2020-07-08 6:06 ` Martin K. Petersen
2020-07-08 6:51 ` Lee Jones
2020-07-08 7:17 ` Martin K. Petersen
2020-07-08 7:28 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200707140055.2956235-6-lee.jones@linaro.org \
--to=lee.jones@linaro.org \
--cc=jejb@linux.ibm.com \
--cc=kashyap.desai@broadcom.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=megaraidlinux.pdl@broadcom.com \
--cc=shivasharan.srikanteshwara@broadcom.com \
--cc=sumit.saxena@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).