linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Lee Jones <lee.jones@linaro.org>
To: jejb@linux.ibm.com, martin.petersen@oracle.com
Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
	Lee Jones <lee.jones@linaro.org>,
	YOKOTA Hiroshi <yokota@netlab.is.tsukuba.ac.jp>
Subject: [PATCH 07/10] scsi: pcmcia: nsp_cs: Use new __printf() format notation
Date: Tue,  7 Jul 2020 15:00:52 +0100	[thread overview]
Message-ID: <20200707140055.2956235-8-lee.jones@linaro.org> (raw)
In-Reply-To: <20200707140055.2956235-1-lee.jones@linaro.org>

Fixes the following W=1 kernel build warning(s):

 drivers/scsi/pcmcia/nsp_cs.c: In function ‘nsp_cs_message’:
 drivers/scsi/pcmcia/nsp_cs.c:143:2: warning: function ‘nsp_cs_message’ might be a candidate for ‘gnu_printf’ format attribute [-Wsuggest-attribute=format]
 drivers/scsi/pcmcia/nsp_cs.c: In function ‘nsp_fifo_count’:
 drivers/scsi/pcmcia/nsp_cs.c:692:24: warning: variable ‘dummy’ set but not used [-Wunused-but-set-variable]

Cc: YOKOTA Hiroshi <yokota@netlab.is.tsukuba.ac.jp>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 drivers/scsi/pcmcia/nsp_cs.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/scsi/pcmcia/nsp_cs.c b/drivers/scsi/pcmcia/nsp_cs.c
index d79ce97a04bd7..57a78f84f97ab 100644
--- a/drivers/scsi/pcmcia/nsp_cs.c
+++ b/drivers/scsi/pcmcia/nsp_cs.c
@@ -134,6 +134,7 @@ static inline void nsp_inc_resid(struct scsi_cmnd *SCpnt, int residInc)
 	scsi_set_resid(SCpnt, scsi_get_resid(SCpnt) + residInc);
 }
 
+__printf(4, 5)
 static void nsp_cs_message(const char *func, int line, char *type, char *fmt, ...)
 {
 	va_list args;
-- 
2.25.1


  parent reply	other threads:[~2020-07-07 14:01 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-07 14:00 [PATCH 00/10] Fix a bunch SCSI related W=1 warnings Lee Jones
2020-07-07 14:00 ` [PATCH 01/10] scsi: megaraid: megaraid_mm: Strip excess function param description Lee Jones
2020-07-07 14:00 ` [PATCH 02/10] scsi: megaraid: megaraid_mbox: Fix some kerneldoc bitrot Lee Jones
2020-07-07 14:00 ` [PATCH 03/10] scsi: fdomain: Mark 'fdomain_pm_ops' as __maybe_unused Lee Jones
2020-07-07 14:00 ` [PATCH 04/10] scsi: megaraid: megaraid_sas_fusion: Fix-up a whole myriad of kerneldoc misdemeanours Lee Jones
2020-07-07 14:00 ` [PATCH 05/10] scsi: megaraid: megaraid_sas_base: Provide prototypes for non-static functions Lee Jones
2020-07-07 14:00 ` [PATCH 06/10] scsi: aha152x: Remove unused variable 'ret' Lee Jones
2020-07-07 14:00 ` Lee Jones [this message]
2020-07-07 14:00 ` [PATCH 08/10] scsi: pcmcia: nsp_cs: Remove unused variable 'dummy' Lee Jones
2020-07-07 14:00 ` [PATCH 09/10] scsi: libfc: fc_disc: Fix-up some incorrectly referenced function parameters Lee Jones
2020-07-08  6:30   ` Hannes Reinecke
2020-07-08  7:34   ` Johannes Thumshirn
2020-07-08  7:46     ` Lee Jones
2020-07-07 14:00 ` [PATCH 10/10] scsi: megaraid: megaraid_sas: Convert forward-declarations to prototypes Lee Jones
2020-07-08  0:53 ` [PATCH 00/10] Fix a bunch SCSI related W=1 warnings Damien Le Moal
2020-07-08  6:51   ` Lee Jones
2020-07-08  7:35     ` Damien Le Moal
2020-07-08  7:42       ` Lee Jones
2020-07-08  6:06 ` Martin K. Petersen
2020-07-08  6:51   ` Lee Jones
2020-07-08  7:17     ` Martin K. Petersen
2020-07-08  7:28       ` Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200707140055.2956235-8-lee.jones@linaro.org \
    --to=lee.jones@linaro.org \
    --cc=jejb@linux.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=yokota@netlab.is.tsukuba.ac.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).