From: Hannes Reinecke <hare@suse.de>
To: Lee Jones <lee.jones@linaro.org>,
jejb@linux.ibm.com, martin.petersen@oracle.com
Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org
Subject: Re: [PATCH 09/10] scsi: libfc: fc_disc: Fix-up some incorrectly referenced function parameters
Date: Wed, 8 Jul 2020 08:30:50 +0200 [thread overview]
Message-ID: <cd81c7d2-0a65-fb8e-d16f-350e93ed66ea@suse.de> (raw)
In-Reply-To: <20200707140055.2956235-10-lee.jones@linaro.org>
On 7/7/20 4:00 PM, Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):
>
> drivers/scsi/libfc/fc_disc.c:343: warning: Function parameter or member 'disc' not described in 'fc_disc_gpn_ft_req'
> drivers/scsi/libfc/fc_disc.c:343: warning: Excess function parameter 'lport' description in 'fc_disc_gpn_ft_req'
> drivers/scsi/libfc/fc_disc.c:380: warning: Function parameter or member 'disc' not described in 'fc_disc_gpn_ft_parse'
> drivers/scsi/libfc/fc_disc.c:380: warning: Excess function parameter 'lport' description in 'fc_disc_gpn_ft_parse'
> drivers/scsi/libfc/fc_disc.c:498: warning: Function parameter or member 'disc_arg' not described in 'fc_disc_gpn_ft_resp'
> drivers/scsi/libfc/fc_disc.c:498: warning: Excess function parameter 'lp_arg' description in 'fc_disc_gpn_ft_resp'
>
> Cc: Hannes Reinecke <hare@suse.de>
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
> ---
> drivers/scsi/libfc/fc_disc.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/scsi/libfc/fc_disc.c b/drivers/scsi/libfc/fc_disc.c
> index 2b865c6423e29..428f40cfd1c36 100644
> --- a/drivers/scsi/libfc/fc_disc.c
> +++ b/drivers/scsi/libfc/fc_disc.c
> @@ -337,7 +337,7 @@ static void fc_disc_error(struct fc_disc *disc, struct fc_frame *fp)
>
> /**
> * fc_disc_gpn_ft_req() - Send Get Port Names by FC-4 type (GPN_FT) request
> - * @lport: The discovery context
> + * @disc: The discovery context
> */
> static void fc_disc_gpn_ft_req(struct fc_disc *disc)
> {
> @@ -370,7 +370,7 @@ static void fc_disc_gpn_ft_req(struct fc_disc *disc)
>
> /**
> * fc_disc_gpn_ft_parse() - Parse the body of the dNS GPN_FT response.
> - * @lport: The local port the GPN_FT was received on
> + * @disc: The descovery context
> * @buf: The GPN_FT response buffer
> * @len: The size of response buffer
> *
> @@ -488,7 +488,7 @@ static void fc_disc_timeout(struct work_struct *work)
> * fc_disc_gpn_ft_resp() - Handle a response frame from Get Port Names (GPN_FT)
> * @sp: The sequence that the GPN_FT response was received on
> * @fp: The GPN_FT response frame
> - * @lp_arg: The discovery context
> + * @disc_arg: The discovery context
> *
> * Locking Note: This function is called without disc mutex held, and
> * should do all its processing with the mutex held
>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Cheers,
Hannes
--
Dr. Hannes Reinecke Teamlead Storage & Networking
hare@suse.de +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer
next prev parent reply other threads:[~2020-07-08 6:30 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-07 14:00 [PATCH 00/10] Fix a bunch SCSI related W=1 warnings Lee Jones
2020-07-07 14:00 ` [PATCH 01/10] scsi: megaraid: megaraid_mm: Strip excess function param description Lee Jones
2020-07-07 14:00 ` [PATCH 02/10] scsi: megaraid: megaraid_mbox: Fix some kerneldoc bitrot Lee Jones
2020-07-07 14:00 ` [PATCH 03/10] scsi: fdomain: Mark 'fdomain_pm_ops' as __maybe_unused Lee Jones
2020-07-07 14:00 ` [PATCH 04/10] scsi: megaraid: megaraid_sas_fusion: Fix-up a whole myriad of kerneldoc misdemeanours Lee Jones
2020-07-07 14:00 ` [PATCH 05/10] scsi: megaraid: megaraid_sas_base: Provide prototypes for non-static functions Lee Jones
2020-07-07 14:00 ` [PATCH 06/10] scsi: aha152x: Remove unused variable 'ret' Lee Jones
2020-07-07 14:00 ` [PATCH 07/10] scsi: pcmcia: nsp_cs: Use new __printf() format notation Lee Jones
2020-07-07 14:00 ` [PATCH 08/10] scsi: pcmcia: nsp_cs: Remove unused variable 'dummy' Lee Jones
2020-07-07 14:00 ` [PATCH 09/10] scsi: libfc: fc_disc: Fix-up some incorrectly referenced function parameters Lee Jones
2020-07-08 6:30 ` Hannes Reinecke [this message]
2020-07-08 7:34 ` Johannes Thumshirn
2020-07-08 7:46 ` Lee Jones
2020-07-07 14:00 ` [PATCH 10/10] scsi: megaraid: megaraid_sas: Convert forward-declarations to prototypes Lee Jones
2020-07-08 0:53 ` [PATCH 00/10] Fix a bunch SCSI related W=1 warnings Damien Le Moal
2020-07-08 6:51 ` Lee Jones
2020-07-08 7:35 ` Damien Le Moal
2020-07-08 7:42 ` Lee Jones
2020-07-08 6:06 ` Martin K. Petersen
2020-07-08 6:51 ` Lee Jones
2020-07-08 7:17 ` Martin K. Petersen
2020-07-08 7:28 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cd81c7d2-0a65-fb8e-d16f-350e93ed66ea@suse.de \
--to=hare@suse.de \
--cc=jejb@linux.ibm.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).