* [PATCH v2 1/5] power: supply: core: add quick charge type property
[not found] <cover.1594612572.git.huangqiwu@xiaomi.com>
@ 2020-07-13 4:03 ` Qiwu Huang
2020-07-13 8:41 ` Greg KH
2020-07-13 4:03 ` [PATCH v2 2/5] power: supply: core: add wireless charger adapter " Qiwu Huang
` (3 subsequent siblings)
4 siblings, 1 reply; 10+ messages in thread
From: Qiwu Huang @ 2020-07-13 4:03 UTC (permalink / raw)
To: sre; +Cc: linux-pm, linux-kernel, gregkh, jiangfei1, Qiwu Huang
From: Qiwu Huang <huangqiwu@xiaomi.com>
Reports the kind of quick charge type based on
different adapter power. UI will show different
animation effect for different quick charge type.
Signed-off-by: Qiwu Huang <huangqiwu@xiaomi.com>
---
Documentation/ABI/testing/sysfs-class-power | 10 ++++++++++
drivers/power/supply/power_supply_sysfs.c | 1 +
include/linux/power_supply.h | 1 +
3 files changed, 12 insertions(+)
diff --git a/Documentation/ABI/testing/sysfs-class-power b/Documentation/ABI/testing/sysfs-class-power
index 216d61a22f1e..d3169d47e359 100644
--- a/Documentation/ABI/testing/sysfs-class-power
+++ b/Documentation/ABI/testing/sysfs-class-power
@@ -708,3 +708,13 @@ Description:
Access: Read
Valid values: 1-31
+
+What: /sys/class/power_supply/<supply_name>/quick_charge_type
+Date: Jul 2020
+Contact: Fei Jiang <jiangfei1@xiaomi.com>
+ Description:
+ Reports the kind of quick charge type based on different adapter power.
+
+ Access: Read-Only
+ Valid values: Reported as integer
+
diff --git a/drivers/power/supply/power_supply_sysfs.c b/drivers/power/supply/power_supply_sysfs.c
index bc79560229b5..9554d7907373 100644
--- a/drivers/power/supply/power_supply_sysfs.c
+++ b/drivers/power/supply/power_supply_sysfs.c
@@ -206,6 +206,7 @@ static struct power_supply_attr power_supply_attrs[] = {
POWER_SUPPLY_ATTR(MODEL_NAME),
POWER_SUPPLY_ATTR(MANUFACTURER),
POWER_SUPPLY_ATTR(SERIAL_NUMBER),
+ POWER_SUPPLY_ATTR(QUICK_CHARGE_TYPE),
};
static struct attribute *
diff --git a/include/linux/power_supply.h b/include/linux/power_supply.h
index ac1345a48ad0..3fe7e9ef2f0f 100644
--- a/include/linux/power_supply.h
+++ b/include/linux/power_supply.h
@@ -167,6 +167,7 @@ enum power_supply_property {
POWER_SUPPLY_PROP_MODEL_NAME,
POWER_SUPPLY_PROP_MANUFACTURER,
POWER_SUPPLY_PROP_SERIAL_NUMBER,
+ POWER_SUPPLY_PROP_QUICK_CHARGE_TYPE,
};
enum power_supply_type {
--
2.27.0
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH v2 2/5] power: supply: core: add wireless charger adapter type property
[not found] <cover.1594612572.git.huangqiwu@xiaomi.com>
2020-07-13 4:03 ` [PATCH v2 1/5] power: supply: core: add quick charge type property Qiwu Huang
@ 2020-07-13 4:03 ` Qiwu Huang
2020-07-13 8:42 ` Greg KH
2020-07-13 4:03 ` [PATCH v2 3/5] power: supply: core: add wireless signal strength property Qiwu Huang
` (2 subsequent siblings)
4 siblings, 1 reply; 10+ messages in thread
From: Qiwu Huang @ 2020-07-13 4:03 UTC (permalink / raw)
To: sre; +Cc: linux-pm, linux-kernel, gregkh, jiangfei1, Qiwu Huang
From: Qiwu Huang <huangqiwu@xiaomi.com>
Reports what type of wireless adapter connection is
currently active forthe supply.
for example it can show if ADAPTER_PD capable source is attached.
Signed-off-by: Qiwu Huang <huangqiwu@xiaomi.com>
---
Documentation/ABI/testing/sysfs-class-power | 11 +++++++++++
drivers/power/supply/power_supply_sysfs.c | 1 +
include/linux/power_supply.h | 1 +
3 files changed, 13 insertions(+)
diff --git a/Documentation/ABI/testing/sysfs-class-power b/Documentation/ABI/testing/sysfs-class-power
index d3169d47e359..cd07d3f4e8b1 100644
--- a/Documentation/ABI/testing/sysfs-class-power
+++ b/Documentation/ABI/testing/sysfs-class-power
@@ -718,3 +718,14 @@ Contact: Fei Jiang <jiangfei1@xiaomi.com>
Access: Read-Only
Valid values: Reported as integer
+===== Wireless Charger Properties =====
+What: /sys/class/power_supply/<supply_name>/tx_adapter
+Date: Jul 2020
+Contact: Fei Jiang <jiangfei1@xiaomi.com>
+Description:
+ Reports what type of wireless adapter connection is currently active for
+ the supply, for example it can show if ADAPTER_PD capable source
+ is attached.
+
+ Access: Read-Only
+ Valid values: Reported as integer
diff --git a/drivers/power/supply/power_supply_sysfs.c b/drivers/power/supply/power_supply_sysfs.c
index 9554d7907373..f2458e21d02b 100644
--- a/drivers/power/supply/power_supply_sysfs.c
+++ b/drivers/power/supply/power_supply_sysfs.c
@@ -207,6 +207,7 @@ static struct power_supply_attr power_supply_attrs[] = {
POWER_SUPPLY_ATTR(MANUFACTURER),
POWER_SUPPLY_ATTR(SERIAL_NUMBER),
POWER_SUPPLY_ATTR(QUICK_CHARGE_TYPE),
+ POWER_SUPPLY_ATTR(TX_ADAPTER),
};
static struct attribute *
diff --git a/include/linux/power_supply.h b/include/linux/power_supply.h
index 3fe7e9ef2f0f..2de9a4c93723 100644
--- a/include/linux/power_supply.h
+++ b/include/linux/power_supply.h
@@ -168,6 +168,7 @@ enum power_supply_property {
POWER_SUPPLY_PROP_MANUFACTURER,
POWER_SUPPLY_PROP_SERIAL_NUMBER,
POWER_SUPPLY_PROP_QUICK_CHARGE_TYPE,
+ POWER_SUPPLY_PROP_TX_ADAPTER,
};
enum power_supply_type {
--
2.27.0
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH v2 3/5] power: supply: core: add wireless signal strength property
[not found] <cover.1594612572.git.huangqiwu@xiaomi.com>
2020-07-13 4:03 ` [PATCH v2 1/5] power: supply: core: add quick charge type property Qiwu Huang
2020-07-13 4:03 ` [PATCH v2 2/5] power: supply: core: add wireless charger adapter " Qiwu Huang
@ 2020-07-13 4:03 ` Qiwu Huang
2020-07-13 4:03 ` [PATCH v2 4/5] power: supply: core: property to control reverse charge Qiwu Huang
2020-07-13 4:03 ` [PATCH v2 5/5] power: supply: core: supply battery soc with decimal form Qiwu Huang
4 siblings, 0 replies; 10+ messages in thread
From: Qiwu Huang @ 2020-07-13 4:03 UTC (permalink / raw)
To: sre; +Cc: linux-pm, linux-kernel, gregkh, jiangfei1, Qiwu Huang
From: Qiwu Huang <huangqiwu@xiaomi.com>
reports wireless signal strength.
The value show degree of coupling between tx and rx.
Signed-off-by: Qiwu Huang <huangqiwu@xiaomi.com>
---
Documentation/ABI/testing/sysfs-class-power | 11 +++++++++++
drivers/power/supply/power_supply_sysfs.c | 1 +
include/linux/power_supply.h | 1 +
3 files changed, 13 insertions(+)
diff --git a/Documentation/ABI/testing/sysfs-class-power b/Documentation/ABI/testing/sysfs-class-power
index cd07d3f4e8b1..f10780be2732 100644
--- a/Documentation/ABI/testing/sysfs-class-power
+++ b/Documentation/ABI/testing/sysfs-class-power
@@ -729,3 +729,14 @@ Description:
Access: Read-Only
Valid values: Reported as integer
+
+What: /sys/class/power_supply/<supply_name>/signal_strength
+Date: Jul 2020
+Contact: Fei Jiang <jiangfei1@xiaomi.com>
+Description:
+ Reports wireless signal strength.The value show degree of coupling.
+ Unit is KHZ,the "value" means the working frequency of receiver
+ chip of wireless charging.
+
+ Access: Read-Only
+ Valid values: Reported as integer
diff --git a/drivers/power/supply/power_supply_sysfs.c b/drivers/power/supply/power_supply_sysfs.c
index f2458e21d02b..e420a453095e 100644
--- a/drivers/power/supply/power_supply_sysfs.c
+++ b/drivers/power/supply/power_supply_sysfs.c
@@ -208,6 +208,7 @@ static struct power_supply_attr power_supply_attrs[] = {
POWER_SUPPLY_ATTR(SERIAL_NUMBER),
POWER_SUPPLY_ATTR(QUICK_CHARGE_TYPE),
POWER_SUPPLY_ATTR(TX_ADAPTER),
+ POWER_SUPPLY_ATTR(SIGNAL_STRENGTH),
};
static struct attribute *
diff --git a/include/linux/power_supply.h b/include/linux/power_supply.h
index 2de9a4c93723..397fb8e96b03 100644
--- a/include/linux/power_supply.h
+++ b/include/linux/power_supply.h
@@ -169,6 +169,7 @@ enum power_supply_property {
POWER_SUPPLY_PROP_SERIAL_NUMBER,
POWER_SUPPLY_PROP_QUICK_CHARGE_TYPE,
POWER_SUPPLY_PROP_TX_ADAPTER,
+ POWER_SUPPLY_PROP_SIGNAL_STRENGTH,
};
enum power_supply_type {
--
2.27.0
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH v2 4/5] power: supply: core: property to control reverse charge
[not found] <cover.1594612572.git.huangqiwu@xiaomi.com>
` (2 preceding siblings ...)
2020-07-13 4:03 ` [PATCH v2 3/5] power: supply: core: add wireless signal strength property Qiwu Huang
@ 2020-07-13 4:03 ` Qiwu Huang
2020-07-13 4:03 ` [PATCH v2 5/5] power: supply: core: supply battery soc with decimal form Qiwu Huang
4 siblings, 0 replies; 10+ messages in thread
From: Qiwu Huang @ 2020-07-13 4:03 UTC (permalink / raw)
To: sre; +Cc: linux-pm, linux-kernel, gregkh, jiangfei1, Qiwu Huang
From: Qiwu Huang <huangqiwu@xiaomi.com>
Interface to control wireless reverse charge.
Supply reverse charge function when enabled.
Signed-off-by: Qiwu Huang <huangqiwu@xiaomi.com>
---
Documentation/ABI/testing/sysfs-class-power | 12 ++++++++++++
drivers/power/supply/power_supply_sysfs.c | 1 +
include/linux/power_supply.h | 1 +
3 files changed, 14 insertions(+)
diff --git a/Documentation/ABI/testing/sysfs-class-power b/Documentation/ABI/testing/sysfs-class-power
index f10780be2732..f4234ba1684a 100644
--- a/Documentation/ABI/testing/sysfs-class-power
+++ b/Documentation/ABI/testing/sysfs-class-power
@@ -740,3 +740,15 @@ Description:
Access: Read-Only
Valid values: Reported as integer
+
+What: /sys/class/power_supply/<supply_name>/reverse_chg_mode
+Date: Jul 2020
+Contact: Fei Jiang <jiangfei1@xiaomi.com>
+Description:
+ The property supply interface to control wireless
+ reverse charge mode.
+
+ Valid values:
+ - 1: enabled
+ - 0: disabled
+
diff --git a/drivers/power/supply/power_supply_sysfs.c b/drivers/power/supply/power_supply_sysfs.c
index e420a453095e..81916b6b6ccf 100644
--- a/drivers/power/supply/power_supply_sysfs.c
+++ b/drivers/power/supply/power_supply_sysfs.c
@@ -209,6 +209,7 @@ static struct power_supply_attr power_supply_attrs[] = {
POWER_SUPPLY_ATTR(QUICK_CHARGE_TYPE),
POWER_SUPPLY_ATTR(TX_ADAPTER),
POWER_SUPPLY_ATTR(SIGNAL_STRENGTH),
+ POWER_SUPPLY_ATTR(REVERSE_CHG_MODE),
};
static struct attribute *
diff --git a/include/linux/power_supply.h b/include/linux/power_supply.h
index 397fb8e96b03..319bf6456867 100644
--- a/include/linux/power_supply.h
+++ b/include/linux/power_supply.h
@@ -170,6 +170,7 @@ enum power_supply_property {
POWER_SUPPLY_PROP_QUICK_CHARGE_TYPE,
POWER_SUPPLY_PROP_TX_ADAPTER,
POWER_SUPPLY_PROP_SIGNAL_STRENGTH,
+ POWER_SUPPLY_PROP_REVERSE_CHG_MODE,
};
enum power_supply_type {
--
2.27.0
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH v2 5/5] power: supply: core: supply battery soc with decimal form
[not found] <cover.1594612572.git.huangqiwu@xiaomi.com>
` (3 preceding siblings ...)
2020-07-13 4:03 ` [PATCH v2 4/5] power: supply: core: property to control reverse charge Qiwu Huang
@ 2020-07-13 4:03 ` Qiwu Huang
2020-07-13 8:44 ` Greg KH
4 siblings, 1 reply; 10+ messages in thread
From: Qiwu Huang @ 2020-07-13 4:03 UTC (permalink / raw)
To: sre; +Cc: linux-pm, linux-kernel, gregkh, jiangfei1, Qiwu Huang
From: Qiwu Huang <huangqiwu@xiaomi.com>
Broadcast battery soc with decimal form.
soc_decimal is the decimal part of battery soc.
soc_decimal_rate is update frequency of decimal
part of battery soc.
We want to report such as 0.01 to 99.99% to
user space to improve user experience
when do very quick charging.
Signed-off-by: Qiwu Huang <huangqiwu@xiaomi.com>
---
Documentation/ABI/testing/sysfs-class-power | 20 ++++++++++++++++++++
drivers/power/supply/power_supply_sysfs.c | 2 ++
include/linux/power_supply.h | 2 ++
3 files changed, 24 insertions(+)
diff --git a/Documentation/ABI/testing/sysfs-class-power b/Documentation/ABI/testing/sysfs-class-power
index f4234ba1684a..bcc8ccad8163 100644
--- a/Documentation/ABI/testing/sysfs-class-power
+++ b/Documentation/ABI/testing/sysfs-class-power
@@ -349,6 +349,26 @@ Description:
Access: Read
Valid values: Represented in microvolts
+What: /sys/class/power_supply/<supply_name>/soc_decimal,
+Date: Jul 2020
+Contact: jiangfei1@xiaomi.com
+Description:
+ Broadcast battery soc with decimal form.
+ soc_decimal is the start decimal part of battery soc.
+
+ Access: Read
+ Valid values: 0 - 100
+
+What: /sys/class/power_supply/<supply_name>/soc_decimal_rate,
+Date: Jul 2020
+Contact: jiangfei1@xiaomi.com
+Description:
+ Broadcast battery soc with decimal form.
+ soc_decimal_rate is the decimal part of battery soc update freqency.
+
+ Access: Read
+ Valid values: 0 - 100
+
===== USB Properties =====
What: /sys/class/power_supply/<supply_name>/current_avg
diff --git a/drivers/power/supply/power_supply_sysfs.c b/drivers/power/supply/power_supply_sysfs.c
index 81916b6b6ccf..a837addb4f21 100644
--- a/drivers/power/supply/power_supply_sysfs.c
+++ b/drivers/power/supply/power_supply_sysfs.c
@@ -210,6 +210,8 @@ static struct power_supply_attr power_supply_attrs[] = {
POWER_SUPPLY_ATTR(TX_ADAPTER),
POWER_SUPPLY_ATTR(SIGNAL_STRENGTH),
POWER_SUPPLY_ATTR(REVERSE_CHG_MODE),
+ POWER_SUPPLY_ATTR(SOC_DECIMAL),
+ POWER_SUPPLY_ATTR(SOC_DECIMAL_RATE),
};
static struct attribute *
diff --git a/include/linux/power_supply.h b/include/linux/power_supply.h
index 319bf6456867..d1aa5497938e 100644
--- a/include/linux/power_supply.h
+++ b/include/linux/power_supply.h
@@ -171,6 +171,8 @@ enum power_supply_property {
POWER_SUPPLY_PROP_TX_ADAPTER,
POWER_SUPPLY_PROP_SIGNAL_STRENGTH,
POWER_SUPPLY_PROP_REVERSE_CHG_MODE,
+ POWER_SUPPLY_PROP_SOC_DECIMAL,
+ POWER_SUPPLY_PROP_SOC_DECIMAL_RATE,
};
enum power_supply_type {
--
2.27.0
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH v2 1/5] power: supply: core: add quick charge type property
2020-07-13 4:03 ` [PATCH v2 1/5] power: supply: core: add quick charge type property Qiwu Huang
@ 2020-07-13 8:41 ` Greg KH
[not found] ` <CAPtXDt2ALhYRTTn7m6Jb3k+339VC84YUDC7V=Yb7-a+DpvuVtg@mail.gmail.com>
0 siblings, 1 reply; 10+ messages in thread
From: Greg KH @ 2020-07-13 8:41 UTC (permalink / raw)
To: Qiwu Huang; +Cc: sre, linux-pm, linux-kernel, jiangfei1, Qiwu Huang
On Mon, Jul 13, 2020 at 12:03:36PM +0800, Qiwu Huang wrote:
> From: Qiwu Huang <huangqiwu@xiaomi.com>
>
> Reports the kind of quick charge type based on
> different adapter power. UI will show different
> animation effect for different quick charge type.
>
> Signed-off-by: Qiwu Huang <huangqiwu@xiaomi.com>
> ---
> Documentation/ABI/testing/sysfs-class-power | 10 ++++++++++
> drivers/power/supply/power_supply_sysfs.c | 1 +
> include/linux/power_supply.h | 1 +
> 3 files changed, 12 insertions(+)
What changed from v1 of this patch? SHouldn't that always be below the
--- line?
>
> diff --git a/Documentation/ABI/testing/sysfs-class-power b/Documentation/ABI/testing/sysfs-class-power
> index 216d61a22f1e..d3169d47e359 100644
> --- a/Documentation/ABI/testing/sysfs-class-power
> +++ b/Documentation/ABI/testing/sysfs-class-power
> @@ -708,3 +708,13 @@ Description:
>
> Access: Read
> Valid values: 1-31
> +
> +What: /sys/class/power_supply/<supply_name>/quick_charge_type
> +Date: Jul 2020
> +Contact: Fei Jiang <jiangfei1@xiaomi.com>
> + Description:
> + Reports the kind of quick charge type based on different adapter power.
What are the allowed types here? Shouldn't that also be an enumerated
type with a predefined string?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v2 2/5] power: supply: core: add wireless charger adapter type property
2020-07-13 4:03 ` [PATCH v2 2/5] power: supply: core: add wireless charger adapter " Qiwu Huang
@ 2020-07-13 8:42 ` Greg KH
[not found] ` <CAPtXDt3kX0=MNXUjDfKr0EgmTxejctdoSoDWUY561gfT6CAr1Q@mail.gmail.com>
0 siblings, 1 reply; 10+ messages in thread
From: Greg KH @ 2020-07-13 8:42 UTC (permalink / raw)
To: Qiwu Huang; +Cc: sre, linux-pm, linux-kernel, jiangfei1, Qiwu Huang
On Mon, Jul 13, 2020 at 12:03:37PM +0800, Qiwu Huang wrote:
> From: Qiwu Huang <huangqiwu@xiaomi.com>
>
> Reports what type of wireless adapter connection is
> currently active forthe supply.
> for example it can show if ADAPTER_PD capable source is attached.
>
> Signed-off-by: Qiwu Huang <huangqiwu@xiaomi.com>
> ---
> Documentation/ABI/testing/sysfs-class-power | 11 +++++++++++
> drivers/power/supply/power_supply_sysfs.c | 1 +
> include/linux/power_supply.h | 1 +
> 3 files changed, 13 insertions(+)
>
> diff --git a/Documentation/ABI/testing/sysfs-class-power b/Documentation/ABI/testing/sysfs-class-power
> index d3169d47e359..cd07d3f4e8b1 100644
> --- a/Documentation/ABI/testing/sysfs-class-power
> +++ b/Documentation/ABI/testing/sysfs-class-power
> @@ -718,3 +718,14 @@ Contact: Fei Jiang <jiangfei1@xiaomi.com>
> Access: Read-Only
> Valid values: Reported as integer
>
> +===== Wireless Charger Properties =====
> +What: /sys/class/power_supply/<supply_name>/tx_adapter
> +Date: Jul 2020
> +Contact: Fei Jiang <jiangfei1@xiaomi.com>
> +Description:
> + Reports what type of wireless adapter connection is currently active for
> + the supply, for example it can show if ADAPTER_PD capable source
> + is attached.
Same question as before, what are the allowed types here?
> +
> + Access: Read-Only
> + Valid values: Reported as integer
What integer maps to what values?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v2 5/5] power: supply: core: supply battery soc with decimal form
2020-07-13 4:03 ` [PATCH v2 5/5] power: supply: core: supply battery soc with decimal form Qiwu Huang
@ 2020-07-13 8:44 ` Greg KH
0 siblings, 0 replies; 10+ messages in thread
From: Greg KH @ 2020-07-13 8:44 UTC (permalink / raw)
To: Qiwu Huang; +Cc: sre, linux-pm, linux-kernel, jiangfei1, Qiwu Huang
On Mon, Jul 13, 2020 at 12:03:40PM +0800, Qiwu Huang wrote:
> From: Qiwu Huang <huangqiwu@xiaomi.com>
>
> Broadcast battery soc with decimal form.
> soc_decimal is the decimal part of battery soc.
> soc_decimal_rate is update frequency of decimal
> part of battery soc.
> We want to report such as 0.01 to 99.99% to
> user space to improve user experience
> when do very quick charging.
>
> Signed-off-by: Qiwu Huang <huangqiwu@xiaomi.com>
> ---
> Documentation/ABI/testing/sysfs-class-power | 20 ++++++++++++++++++++
> drivers/power/supply/power_supply_sysfs.c | 2 ++
> include/linux/power_supply.h | 2 ++
> 3 files changed, 24 insertions(+)
>
> diff --git a/Documentation/ABI/testing/sysfs-class-power b/Documentation/ABI/testing/sysfs-class-power
> index f4234ba1684a..bcc8ccad8163 100644
> --- a/Documentation/ABI/testing/sysfs-class-power
> +++ b/Documentation/ABI/testing/sysfs-class-power
> @@ -349,6 +349,26 @@ Description:
> Access: Read
> Valid values: Represented in microvolts
>
> +What: /sys/class/power_supply/<supply_name>/soc_decimal,
> +Date: Jul 2020
> +Contact: jiangfei1@xiaomi.com
> +Description:
> + Broadcast battery soc with decimal form.
> + soc_decimal is the start decimal part of battery soc.
> +
> + Access: Read
> + Valid values: 0 - 100
How can "100" be a valid decimal form here if this is a percent?
> +
> +What: /sys/class/power_supply/<supply_name>/soc_decimal_rate,
> +Date: Jul 2020
> +Contact: jiangfei1@xiaomi.com
> +Description:
> + Broadcast battery soc with decimal form.
> + soc_decimal_rate is the decimal part of battery soc update freqency.
> +
> + Access: Read
> + Valid values: 0 - 100
I think you need to document this a lot better as I still don't really
understand what this is for or how to use it or report it.
And what does "soc" mean here?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v2 1/5] power: supply: core: add quick charge type property
[not found] ` <CAPtXDt2ALhYRTTn7m6Jb3k+339VC84YUDC7V=Yb7-a+DpvuVtg@mail.gmail.com>
@ 2020-07-14 7:37 ` Greg KH
0 siblings, 0 replies; 10+ messages in thread
From: Greg KH @ 2020-07-14 7:37 UTC (permalink / raw)
To: ivan; +Cc: sre, linux-pm, linux-kernel, jiangfei1, Qiwu Huang
A: http://en.wikipedia.org/wiki/Top_post
Q: Were do I find info about this thing called top-posting?
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?
A: No.
Q: Should I include quotations after my reply?
http://daringfireball.net/2007/07/on_top
On Tue, Jul 14, 2020 at 03:31:52PM +0800, ivan wrote:
> I think we should add an enumederated for this
What is "this"?
>
> for example
>
> abi document
>
> What: /sys/class/power_supply/<supply_name>/quick_charge_type
> Date: Jul 2020
> Contact: Fei Jiang <jiangfei1@xiaomi.com>
> Description:
> Reports the kind of quick charge type based on different adapter power.
> Different quick charge type represent different charging power.
> QUICK_CHARGE_NORMAL : Charging Power <= 10W
> QUICK_CHARGE_FAST : 10W < Charging Power <= 20W
> QUICK_CHARGE_FLASH : 20W < Charging Power <= 30W
> QUICK_CHARGE_TURBE : 30W < Charging Power <= 50W
> QUICK_CHARGE_SUPER : Charging Power > 50W
>
> Access: Read-Only
> Valid values:
> 0: QUICK_CHARGE_NORMAL,
> 1: QUICK_CHARGE_FAST,
> 2: QUICK_CHARGE_FLASH,
> 3: QUICK_CHARGE_TURBE,
> 4: QUICK_CHARGE_SUPER.
>
>
> power_supply.h
>
> enum power_supply_quick_charge_type {
> QUICK_CHARGE_NORMAL = 0,
> QUICK_CHARGE_FAST,
> QUICK_CHARGE_FLASH,
> QUICK_CHARGE_TURBE,
> QUICK_CHARGE_SUPER,
> QUICK_CHARGE_MAX,
> };
That seems like a good change, why not do this? :)
thanks,
greg k-h
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v2 2/5] power: supply: core: add wireless charger adapter type property
[not found] ` <CAPtXDt3kX0=MNXUjDfKr0EgmTxejctdoSoDWUY561gfT6CAr1Q@mail.gmail.com>
@ 2020-07-14 7:37 ` Greg KH
0 siblings, 0 replies; 10+ messages in thread
From: Greg KH @ 2020-07-14 7:37 UTC (permalink / raw)
To: ivan; +Cc: sre, linux-pm, linux-kernel, jiangfei1, Qiwu Huang
On Tue, Jul 14, 2020 at 03:34:04PM +0800, ivan wrote:
> same as before, we should add it
Please do.
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2020-07-14 7:37 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <cover.1594612572.git.huangqiwu@xiaomi.com>
2020-07-13 4:03 ` [PATCH v2 1/5] power: supply: core: add quick charge type property Qiwu Huang
2020-07-13 8:41 ` Greg KH
[not found] ` <CAPtXDt2ALhYRTTn7m6Jb3k+339VC84YUDC7V=Yb7-a+DpvuVtg@mail.gmail.com>
2020-07-14 7:37 ` Greg KH
2020-07-13 4:03 ` [PATCH v2 2/5] power: supply: core: add wireless charger adapter " Qiwu Huang
2020-07-13 8:42 ` Greg KH
[not found] ` <CAPtXDt3kX0=MNXUjDfKr0EgmTxejctdoSoDWUY561gfT6CAr1Q@mail.gmail.com>
2020-07-14 7:37 ` Greg KH
2020-07-13 4:03 ` [PATCH v2 3/5] power: supply: core: add wireless signal strength property Qiwu Huang
2020-07-13 4:03 ` [PATCH v2 4/5] power: supply: core: property to control reverse charge Qiwu Huang
2020-07-13 4:03 ` [PATCH v2 5/5] power: supply: core: supply battery soc with decimal form Qiwu Huang
2020-07-13 8:44 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).