From: Steven Rostedt <rostedt@goodmis.org>
To: Joe Perches <joe@perches.com>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Petr Mladek <pmladek@suse.com>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
linux-kernel@vger.kernel.org,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Pantelis Antoniou <pantelis.antoniou@konsulko.com>,
Rob Herring <robh@kernel.org>,
Grant Likely <grant.likely@arm.com>
Subject: Re: [PATCH v2 2/3] lib/vsprintf: Replace custom spec to print decimals with generic one
Date: Fri, 31 Jul 2020 16:48:09 -0400 [thread overview]
Message-ID: <20200731164809.352f4b89@oasis.local.home> (raw)
In-Reply-To: <f8f423cd6afeca88cfa635f20a0b2bf85ddda3c5.camel@perches.com>
On Fri, 31 Jul 2020 11:20:21 -0700
Joe Perches <joe@perches.com> wrote:
> On Fri, 2020-07-31 at 21:08 +0300, Andy Shevchenko wrote:
> > When printing phandle via %pOFp the custom spec is used. First of all,
> > it has a SMALL flag which makes no sense for decimal numbers. Second,
> > we have already default spec for decimal numbers. Use the latter in
> > the %pOFp case as well.
> []
> > diff --git a/lib/vsprintf.c b/lib/vsprintf.c
> []
> > @@ -1979,12 +1979,6 @@ char *device_node_string(char *buf, char *end, struct device_node *dn,
> > char *buf_start = buf;
> > struct property *prop;
> > bool has_mult, pass;
> > - static const struct printf_spec num_spec = {
> > - .flags = SMALL,
> > - .field_width = -1,
> > - .precision = -1,
> > - .base = 10,
> > - };
> >
> > struct printf_spec str_spec = spec;
> > str_spec.field_width = -1;
> > @@ -2024,7 +2018,7 @@ char *device_node_string(char *buf, char *end, struct device_node *dn,
> > str_spec.precision = precision;
> > break;
> > case 'p': /* phandle */
> > - buf = number(buf, end, (unsigned int)dn->phandle, num_spec);
> > + buf = number(buf, end, (unsigned int)dn->phandle, default_dec_spec);
>
> Could changing .precision = -1 to 0 change any output?
>
static const struct printf_spec default_dec_spec = {
.base = 10,
.precision = -1,
};
It's the field_width that changes from -1 to 0, which shouldn't cause
any issue.
-- Steve
next prev parent reply other threads:[~2020-07-31 20:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-31 18:08 [PATCH v2 1/3] lib/vsprintf: Replace hidden BUILD_BUG_ON() with static_assert() Andy Shevchenko
2020-07-31 18:08 ` [PATCH v2 2/3] lib/vsprintf: Replace custom spec to print decimals with generic one Andy Shevchenko
2020-07-31 18:18 ` Andy Shevchenko
2020-07-31 18:20 ` Joe Perches
2020-07-31 20:48 ` Steven Rostedt [this message]
2020-08-01 1:42 ` Sergey Senozhatsky
2020-08-01 1:40 ` Sergey Senozhatsky
2020-07-31 18:08 ` [PATCH v2 3/3] lib/vsprintf: Force type of flags value for gfp_t Andy Shevchenko
2020-07-31 20:49 ` Steven Rostedt
2020-08-01 1:36 ` Sergey Senozhatsky
2020-08-01 1:39 ` [PATCH v2 1/3] lib/vsprintf: Replace hidden BUILD_BUG_ON() with static_assert() Sergey Senozhatsky
2020-08-01 4:46 ` Sergey Senozhatsky
2020-08-04 8:34 ` Petr Mladek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200731164809.352f4b89@oasis.local.home \
--to=rostedt@goodmis.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=grant.likely@arm.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=pantelis.antoniou@konsulko.com \
--cc=pmladek@suse.com \
--cc=robh@kernel.org \
--cc=sergey.senozhatsky@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).