From: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Petr Mladek <pmladek@suse.com>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
linux-kernel@vger.kernel.org,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [PATCH v2 1/3] lib/vsprintf: Replace hidden BUILD_BUG_ON() with static_assert()
Date: Sat, 1 Aug 2020 13:46:20 +0900 [thread overview]
Message-ID: <20200801044620.GA683@jagdpanzerIV.localdomain> (raw)
In-Reply-To: <20200731180825.30575-1-andriy.shevchenko@linux.intel.com>
On (20/07/31 21:08), Andy Shevchenko wrote:
> First of all, there is no compile time check for the SMALL
> to be ' ' (0x20, i.e. space). Second, for ZEROPAD the check
> is hidden in the code.
>
> For better maintenance replace BUILD_BUG_ON() with static_assert()
> for ZEROPAD and move it closer to the definition. While at it,
> introduce check for SMALL.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Reviewed-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
The series was applied to for-5.9
I ran more tests (+ cross compile tests: ppc/ppc64/arm/arm64/x86/x86_64).
-ss
next prev parent reply other threads:[~2020-08-01 4:53 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-31 18:08 [PATCH v2 1/3] lib/vsprintf: Replace hidden BUILD_BUG_ON() with static_assert() Andy Shevchenko
2020-07-31 18:08 ` [PATCH v2 2/3] lib/vsprintf: Replace custom spec to print decimals with generic one Andy Shevchenko
2020-07-31 18:18 ` Andy Shevchenko
2020-07-31 18:20 ` Joe Perches
2020-07-31 20:48 ` Steven Rostedt
2020-08-01 1:42 ` Sergey Senozhatsky
2020-08-01 1:40 ` Sergey Senozhatsky
2020-07-31 18:08 ` [PATCH v2 3/3] lib/vsprintf: Force type of flags value for gfp_t Andy Shevchenko
2020-07-31 20:49 ` Steven Rostedt
2020-08-01 1:36 ` Sergey Senozhatsky
2020-08-01 1:39 ` [PATCH v2 1/3] lib/vsprintf: Replace hidden BUILD_BUG_ON() with static_assert() Sergey Senozhatsky
2020-08-01 4:46 ` Sergey Senozhatsky [this message]
2020-08-04 8:34 ` Petr Mladek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200801044620.GA683@jagdpanzerIV.localdomain \
--to=sergey.senozhatsky@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).