From: Steven Rostedt <rostedt@goodmis.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Petr Mladek <pmladek@suse.com>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
linux-kernel@vger.kernel.org,
Rasmus Villemoes <linux@rasmusvillemoes.dk>
Subject: Re: [PATCH v2 3/3] lib/vsprintf: Force type of flags value for gfp_t
Date: Fri, 31 Jul 2020 16:49:00 -0400 [thread overview]
Message-ID: <20200731164900.3ece67fb@oasis.local.home> (raw)
In-Reply-To: <20200731180825.30575-3-andriy.shevchenko@linux.intel.com>
On Fri, 31 Jul 2020 21:08:24 +0300
Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> Sparse is not happy about restricted type being assigned:
> lib/vsprintf.c:1940:23: warning: incorrect type in assignment (different base types)
> lib/vsprintf.c:1940:23: expected unsigned long [assigned] flags
> lib/vsprintf.c:1940:23: got restricted gfp_t [usertype]
>
> Force type of flags value to make sparse happy.
>
> Cc: Steven Rostedt (VMware) <rostedt@goodmis.org>
Reviewed-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
Petr or Sergey,
Want to take these through the printk tree?
-- Steve
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> v2: used explicit type to be forced to (Steven)
> lib/vsprintf.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/vsprintf.c b/lib/vsprintf.c
> index 182a3e2e1629..c155769559ab 100644
> --- a/lib/vsprintf.c
> +++ b/lib/vsprintf.c
> @@ -1937,7 +1937,7 @@ char *flags_string(char *buf, char *end, void *flags_ptr,
> names = vmaflag_names;
> break;
> case 'g':
> - flags = *(gfp_t *)flags_ptr;
> + flags = (__force unsigned long)(*(gfp_t *)flags_ptr);
> names = gfpflag_names;
> break;
> default:
next prev parent reply other threads:[~2020-07-31 20:49 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-31 18:08 [PATCH v2 1/3] lib/vsprintf: Replace hidden BUILD_BUG_ON() with static_assert() Andy Shevchenko
2020-07-31 18:08 ` [PATCH v2 2/3] lib/vsprintf: Replace custom spec to print decimals with generic one Andy Shevchenko
2020-07-31 18:18 ` Andy Shevchenko
2020-07-31 18:20 ` Joe Perches
2020-07-31 20:48 ` Steven Rostedt
2020-08-01 1:42 ` Sergey Senozhatsky
2020-08-01 1:40 ` Sergey Senozhatsky
2020-07-31 18:08 ` [PATCH v2 3/3] lib/vsprintf: Force type of flags value for gfp_t Andy Shevchenko
2020-07-31 20:49 ` Steven Rostedt [this message]
2020-08-01 1:36 ` Sergey Senozhatsky
2020-08-01 1:39 ` [PATCH v2 1/3] lib/vsprintf: Replace hidden BUILD_BUG_ON() with static_assert() Sergey Senozhatsky
2020-08-01 4:46 ` Sergey Senozhatsky
2020-08-04 8:34 ` Petr Mladek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200731164900.3ece67fb@oasis.local.home \
--to=rostedt@goodmis.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=pmladek@suse.com \
--cc=sergey.senozhatsky@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).