* [PATCH] i2c: mediatek: Fix i2c_spec_values description
@ 2020-08-06 9:48 Matthias Brugger
2020-08-06 11:06 ` Qii Wang
2020-08-10 9:40 ` wsa
0 siblings, 2 replies; 5+ messages in thread
From: Matthias Brugger @ 2020-08-06 9:48 UTC (permalink / raw)
To: qii.wang, wsa, yingjoe.chen
Cc: linux-i2c, linux-arm-kernel, linux-mediatek, linux-kernel,
Matthias Brugger
The struct i2c_spec_values have it's members documented but is missing the
starting '@', which leads to warings like:
drivers/i2c/busses/i2c-mt65xx.c:267: warning: Function parameter or member
'min_low_ns' not described in 'i2c_spec_values'
Signed-off-by: Matthias Brugger <matthias.bgg@gmail.com>
---
drivers/i2c/busses/i2c-mt65xx.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/i2c/busses/i2c-mt65xx.c b/drivers/i2c/busses/i2c-mt65xx.c
index e889f74703e4..f51b35fc400f 100644
--- a/drivers/i2c/busses/i2c-mt65xx.c
+++ b/drivers/i2c/busses/i2c-mt65xx.c
@@ -253,10 +253,10 @@ struct mtk_i2c {
/**
* struct i2c_spec_values:
- * min_low_ns: min LOW period of the SCL clock
- * min_su_sta_ns: min set-up time for a repeated START condition
- * max_hd_dat_ns: max data hold time
- * min_su_dat_ns: min data set-up time
+ * @min_low_ns: min LOW period of the SCL clock
+ * @min_su_sta_ns: min set-up time for a repeated START condition
+ * @max_hd_dat_ns: max data hold time
+ * @min_su_dat_ns: min data set-up time
*/
struct i2c_spec_values {
unsigned int min_low_ns;
--
2.27.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] i2c: mediatek: Fix i2c_spec_values description
2020-08-06 9:48 [PATCH] i2c: mediatek: Fix i2c_spec_values description Matthias Brugger
@ 2020-08-06 11:06 ` Qii Wang
2020-08-06 13:35 ` Matthias Brugger
2020-08-10 9:40 ` wsa
1 sibling, 1 reply; 5+ messages in thread
From: Qii Wang @ 2020-08-06 11:06 UTC (permalink / raw)
To: Matthias Brugger
Cc: wsa, yingjoe.chen, linux-i2c, linux-arm-kernel, linux-mediatek,
linux-kernel, Matthias Brugger
On Thu, 2020-08-06 at 11:48 +0200, Matthias Brugger wrote:
> The struct i2c_spec_values have it's members documented but is missing the
> starting '@', which leads to warings like:
>
> drivers/i2c/busses/i2c-mt65xx.c:267: warning: Function parameter or member
> 'min_low_ns' not described in 'i2c_spec_values'
>
> Signed-off-by: Matthias Brugger <matthias.bgg@gmail.com>
> ---
> drivers/i2c/busses/i2c-mt65xx.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-mt65xx.c b/drivers/i2c/busses/i2c-mt65xx.c
> index e889f74703e4..f51b35fc400f 100644
> --- a/drivers/i2c/busses/i2c-mt65xx.c
> +++ b/drivers/i2c/busses/i2c-mt65xx.c
> @@ -253,10 +253,10 @@ struct mtk_i2c {
>
> /**
> * struct i2c_spec_values:
> - * min_low_ns: min LOW period of the SCL clock
Can you help me add a description of min_high_ns. As
@min_high_ns: min HIGH period of the SCL clock
Thanks
> - * min_su_sta_ns: min set-up time for a repeated START condition
> - * max_hd_dat_ns: max data hold time
> - * min_su_dat_ns: min data set-up time
> + * @min_low_ns: min LOW period of the SCL clock
> + * @min_su_sta_ns: min set-up time for a repeated START condition
> + * @max_hd_dat_ns: max data hold time
> + * @min_su_dat_ns: min data set-up time
> */
> struct i2c_spec_values {
> unsigned int min_low_ns;
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] i2c: mediatek: Fix i2c_spec_values description
2020-08-06 11:06 ` Qii Wang
@ 2020-08-06 13:35 ` Matthias Brugger
2020-08-07 1:05 ` Qii Wang
0 siblings, 1 reply; 5+ messages in thread
From: Matthias Brugger @ 2020-08-06 13:35 UTC (permalink / raw)
To: Qii Wang, Matthias Brugger
Cc: wsa, yingjoe.chen, linux-i2c, linux-arm-kernel, linux-mediatek,
linux-kernel
On 06/08/2020 13:06, Qii Wang wrote:
> On Thu, 2020-08-06 at 11:48 +0200, Matthias Brugger wrote:
>> The struct i2c_spec_values have it's members documented but is missing the
>> starting '@', which leads to warings like:
>>
>> drivers/i2c/busses/i2c-mt65xx.c:267: warning: Function parameter or member
>> 'min_low_ns' not described in 'i2c_spec_values'
>>
>> Signed-off-by: Matthias Brugger <matthias.bgg@gmail.com>
>> ---
>> drivers/i2c/busses/i2c-mt65xx.c | 8 ++++----
>> 1 file changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/i2c/busses/i2c-mt65xx.c b/drivers/i2c/busses/i2c-mt65xx.c
>> index e889f74703e4..f51b35fc400f 100644
>> --- a/drivers/i2c/busses/i2c-mt65xx.c
>> +++ b/drivers/i2c/busses/i2c-mt65xx.c
>> @@ -253,10 +253,10 @@ struct mtk_i2c {
>>
>> /**
>> * struct i2c_spec_values:
>> - * min_low_ns: min LOW period of the SCL clock
>
> Can you help me add a description of min_high_ns. As
> @min_high_ns: min HIGH period of the SCL clock
Right, I forgot about this one.
Actually I don't see any code which uses the value, so I think it should be
deleted from the struct.
Do you have any thoughts on this.
Regards,
Matthias
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] i2c: mediatek: Fix i2c_spec_values description
2020-08-06 13:35 ` Matthias Brugger
@ 2020-08-07 1:05 ` Qii Wang
0 siblings, 0 replies; 5+ messages in thread
From: Qii Wang @ 2020-08-07 1:05 UTC (permalink / raw)
To: Matthias Brugger
Cc: Matthias Brugger, wsa, yingjoe.chen, linux-i2c, linux-arm-kernel,
linux-mediatek, linux-kernel
On Thu, 2020-08-06 at 15:35 +0200, Matthias Brugger wrote:
>
> On 06/08/2020 13:06, Qii Wang wrote:
> > On Thu, 2020-08-06 at 11:48 +0200, Matthias Brugger wrote:
> >> The struct i2c_spec_values have it's members documented but is missing the
> >> starting '@', which leads to warings like:
> >>
> >> drivers/i2c/busses/i2c-mt65xx.c:267: warning: Function parameter or member
> >> 'min_low_ns' not described in 'i2c_spec_values'
> >>
> >> Signed-off-by: Matthias Brugger <matthias.bgg@gmail.com>
> >> ---
> >> drivers/i2c/busses/i2c-mt65xx.c | 8 ++++----
> >> 1 file changed, 4 insertions(+), 4 deletions(-)
> >>
> >> diff --git a/drivers/i2c/busses/i2c-mt65xx.c b/drivers/i2c/busses/i2c-mt65xx.c
> >> index e889f74703e4..f51b35fc400f 100644
> >> --- a/drivers/i2c/busses/i2c-mt65xx.c
> >> +++ b/drivers/i2c/busses/i2c-mt65xx.c
> >> @@ -253,10 +253,10 @@ struct mtk_i2c {
> >>
> >> /**
> >> * struct i2c_spec_values:
> >> - * min_low_ns: min LOW period of the SCL clock
> >
> > Can you help me add a description of min_high_ns. As
> > @min_high_ns: min HIGH period of the SCL clock
>
> Right, I forgot about this one.
>
> Actually I don't see any code which uses the value, so I think it should be
> deleted from the struct.
>
> Do you have any thoughts on this.
>
That is right, it is used for internal test before. You can deleted it.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] i2c: mediatek: Fix i2c_spec_values description
2020-08-06 9:48 [PATCH] i2c: mediatek: Fix i2c_spec_values description Matthias Brugger
2020-08-06 11:06 ` Qii Wang
@ 2020-08-10 9:40 ` wsa
1 sibling, 0 replies; 5+ messages in thread
From: wsa @ 2020-08-10 9:40 UTC (permalink / raw)
To: Matthias Brugger
Cc: qii.wang, yingjoe.chen, linux-i2c, linux-arm-kernel,
linux-mediatek, linux-kernel, Matthias Brugger
[-- Attachment #1: Type: text/plain, Size: 422 bytes --]
On Thu, Aug 06, 2020 at 11:48:37AM +0200, Matthias Brugger wrote:
> The struct i2c_spec_values have it's members documented but is missing the
> starting '@', which leads to warings like:
>
> drivers/i2c/busses/i2c-mt65xx.c:267: warning: Function parameter or member
> 'min_low_ns' not described in 'i2c_spec_values'
>
> Signed-off-by: Matthias Brugger <matthias.bgg@gmail.com>
Applied to for-next, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-08-10 9:40 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-06 9:48 [PATCH] i2c: mediatek: Fix i2c_spec_values description Matthias Brugger
2020-08-06 11:06 ` Qii Wang
2020-08-06 13:35 ` Matthias Brugger
2020-08-07 1:05 ` Qii Wang
2020-08-10 9:40 ` wsa
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).