linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 0/2] Modernize rocktech,jh057n00900 bindings a bit
@ 2020-08-16  7:13 Guido Günther
  2020-08-16  7:13 ` [PATCH 1/2] dt-bindings: panel: rocktech,jh057n00900: Modernize Guido Günther
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: Guido Günther @ 2020-08-16  7:13 UTC (permalink / raw)
  To: Thierry Reding, Sam Ravnborg, David Airlie, Daniel Vetter,
	Rob Herring, Ondrej Jirman, dri-devel, devicetree, linux-kernel

This was prompted by Sam's review in
https://lore.kernel.org/dri-devel/20200815210802.GA1242831@ravnborg.org/
and yamllint. I also added myself as maintainer, hope that's o.k.

Guido Günther (2):
  dt-bindings: panel: rocktech,jh057n00900: Modernize
  dt-bindings: panel: rocktech,jh057n00900: Add myself as maintainer

 .../display/panel/rocktech,jh057n00900.yaml   | 40 +++++++++----------
 1 file changed, 19 insertions(+), 21 deletions(-)

-- 
2.26.2


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH 1/2] dt-bindings: panel: rocktech,jh057n00900: Modernize
  2020-08-16  7:13 [PATCH 0/2] Modernize rocktech,jh057n00900 bindings a bit Guido Günther
@ 2020-08-16  7:13 ` Guido Günther
  2020-08-16  7:13 ` [PATCH 2/2] dt-bindings: panel: rocktech,jh057n00900: Add myself as maintainer Guido Günther
  2020-08-16 15:25 ` [PATCH 0/2] Modernize rocktech,jh057n00900 bindings a bit Sam Ravnborg
  2 siblings, 0 replies; 5+ messages in thread
From: Guido Günther @ 2020-08-16  7:13 UTC (permalink / raw)
  To: Thierry Reding, Sam Ravnborg, David Airlie, Daniel Vetter,
	Rob Herring, Ondrej Jirman, dri-devel, devicetree, linux-kernel

- Use common properties from panel-common.yaml
- Indent comment like content
- Don't preserve newlines in description
- Indent example by four spaces

Signed-off-by: Guido Günther <agx@sigxcpu.org>
---
 .../display/panel/rocktech,jh057n00900.yaml   | 39 +++++++++----------
 1 file changed, 18 insertions(+), 21 deletions(-)

diff --git a/Documentation/devicetree/bindings/display/panel/rocktech,jh057n00900.yaml b/Documentation/devicetree/bindings/display/panel/rocktech,jh057n00900.yaml
index d5733ef309549..c97e89707342e 100644
--- a/Documentation/devicetree/bindings/display/panel/rocktech,jh057n00900.yaml
+++ b/Documentation/devicetree/bindings/display/panel/rocktech,jh057n00900.yaml
@@ -9,9 +9,9 @@ title: Rocktech JH057N00900 5.5" 720x1440 TFT LCD panel
 maintainers:
   - Ondrej Jirman <megi@xff.cz>
 
-description: |
-             Rocktech JH057N00900 is a 720x1440 TFT LCD panel
-             connected using a MIPI-DSI video interface.
+description:
+  Rocktech JH057N00900 is a 720x1440 TFT LCD panel
+  connected using a MIPI-DSI video interface.
 
 allOf:
   - $ref: panel-common.yaml#
@@ -19,9 +19,9 @@ allOf:
 properties:
   compatible:
     enum:
-        # Rocktech JH057N00900 5.5" 720x1440 TFT LCD panel
+      # Rocktech JH057N00900 5.5" 720x1440 TFT LCD panel
       - rocktech,jh057n00900
-        # Xingbangda XBD599 5.99" 720x1440 TFT LCD panel
+      # Xingbangda XBD599 5.99" 720x1440 TFT LCD panel
       - xingbangda,xbd599
 
   port: true
@@ -35,13 +35,9 @@ properties:
   iovcc-supply:
     description: I/O voltage supply
 
-  reset-gpios:
-    description: GPIO used for the reset pin
-    maxItems: 1
+  reset-gpios: true
 
-  backlight:
-    description: Backlight used by the panel
-    $ref: "/schemas/types.yaml#/definitions/phandle"
+  backlight: true
 
 required:
   - compatible
@@ -57,15 +53,16 @@ examples:
     #include <dt-bindings/gpio/gpio.h>
 
     dsi {
-      #address-cells = <1>;
-      #size-cells = <0>;
-      panel@0 {
-        compatible = "rocktech,jh057n00900";
-        reg = <0>;
-        vcc-supply = <&reg_2v8_p>;
-        iovcc-supply = <&reg_1v8_p>;
-        reset-gpios = <&gpio3 13 GPIO_ACTIVE_LOW>;
-        backlight = <&backlight>;
-      };
+        #address-cells = <1>;
+        #size-cells = <0>;
+        panel@0 {
+            compatible = "rocktech,jh057n00900";
+            reg = <0>;
+            vcc-supply = <&reg_2v8_p>;
+            iovcc-supply = <&reg_1v8_p>;
+            reset-gpios = <&gpio3 13 GPIO_ACTIVE_LOW>;
+            backlight = <&backlight>;
+        };
     };
+
 ...
-- 
2.26.2


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH 2/2] dt-bindings: panel: rocktech,jh057n00900: Add myself as maintainer
  2020-08-16  7:13 [PATCH 0/2] Modernize rocktech,jh057n00900 bindings a bit Guido Günther
  2020-08-16  7:13 ` [PATCH 1/2] dt-bindings: panel: rocktech,jh057n00900: Modernize Guido Günther
@ 2020-08-16  7:13 ` Guido Günther
  2020-08-16 15:25 ` [PATCH 0/2] Modernize rocktech,jh057n00900 bindings a bit Sam Ravnborg
  2 siblings, 0 replies; 5+ messages in thread
From: Guido Günther @ 2020-08-16  7:13 UTC (permalink / raw)
  To: Thierry Reding, Sam Ravnborg, David Airlie, Daniel Vetter,
	Rob Herring, Ondrej Jirman, dri-devel, devicetree, linux-kernel

I maintained the txt based bindings before yaml conversion and care
about the driver.

Signed-off-by: Guido Günther <agx@sigxcpu.org>
---
 .../devicetree/bindings/display/panel/rocktech,jh057n00900.yaml  | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/display/panel/rocktech,jh057n00900.yaml b/Documentation/devicetree/bindings/display/panel/rocktech,jh057n00900.yaml
index c97e89707342e..09b5eb7542f8a 100644
--- a/Documentation/devicetree/bindings/display/panel/rocktech,jh057n00900.yaml
+++ b/Documentation/devicetree/bindings/display/panel/rocktech,jh057n00900.yaml
@@ -8,6 +8,7 @@ title: Rocktech JH057N00900 5.5" 720x1440 TFT LCD panel
 
 maintainers:
   - Ondrej Jirman <megi@xff.cz>
+  - Guido Gŭnther <agx@sigxcpu.org>
 
 description:
   Rocktech JH057N00900 is a 720x1440 TFT LCD panel
-- 
2.26.2


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH 0/2] Modernize rocktech,jh057n00900 bindings a bit
  2020-08-16  7:13 [PATCH 0/2] Modernize rocktech,jh057n00900 bindings a bit Guido Günther
  2020-08-16  7:13 ` [PATCH 1/2] dt-bindings: panel: rocktech,jh057n00900: Modernize Guido Günther
  2020-08-16  7:13 ` [PATCH 2/2] dt-bindings: panel: rocktech,jh057n00900: Add myself as maintainer Guido Günther
@ 2020-08-16 15:25 ` Sam Ravnborg
  2020-08-17  8:22   ` Guido Günther
  2 siblings, 1 reply; 5+ messages in thread
From: Sam Ravnborg @ 2020-08-16 15:25 UTC (permalink / raw)
  To: Guido Günther
  Cc: Thierry Reding, David Airlie, Daniel Vetter, Rob Herring,
	Ondrej Jirman, dri-devel, devicetree, linux-kernel

Hi Guido.

On Sun, Aug 16, 2020 at 09:13:41AM +0200, Guido Günther wrote:
> This was prompted by Sam's review in
> https://lore.kernel.org/dri-devel/20200815210802.GA1242831@ravnborg.org/
> and yamllint. I also added myself as maintainer, hope that's o.k.
> 
> Guido Günther (2):
>   dt-bindings: panel: rocktech,jh057n00900: Modernize
>   dt-bindings: panel: rocktech,jh057n00900: Add myself as maintainer

Thanks for this nice clean-up, and always good with an extra person
caring for something.
Applied to drm-misc-next

	Sam

> 
>  .../display/panel/rocktech,jh057n00900.yaml   | 40 +++++++++----------
>  1 file changed, 19 insertions(+), 21 deletions(-)
> 
> -- 
> 2.26.2

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 0/2] Modernize rocktech,jh057n00900 bindings a bit
  2020-08-16 15:25 ` [PATCH 0/2] Modernize rocktech,jh057n00900 bindings a bit Sam Ravnborg
@ 2020-08-17  8:22   ` Guido Günther
  0 siblings, 0 replies; 5+ messages in thread
From: Guido Günther @ 2020-08-17  8:22 UTC (permalink / raw)
  To: Sam Ravnborg; +Cc: dri-devel, devicetree, linux-kernel

Hi,
On Sun, Aug 16, 2020 at 05:25:34PM +0200, Sam Ravnborg wrote:
> Hi Guido.
> 
> On Sun, Aug 16, 2020 at 09:13:41AM +0200, Guido Günther wrote:
> > This was prompted by Sam's review in
> > https://lore.kernel.org/dri-devel/20200815210802.GA1242831@ravnborg.org/
> > and yamllint. I also added myself as maintainer, hope that's o.k.
> > 
> > Guido Günther (2):
> >   dt-bindings: panel: rocktech,jh057n00900: Modernize
> >   dt-bindings: panel: rocktech,jh057n00900: Add myself as maintainer
> 
> Thanks for this nice clean-up, and always good with an extra person
> caring for something.
> Applied to drm-misc-next

Thanks!
 -- Guido

> 
> 	Sam
> 
> > 
> >  .../display/panel/rocktech,jh057n00900.yaml   | 40 +++++++++----------
> >  1 file changed, 19 insertions(+), 21 deletions(-)
> > 
> > -- 
> > 2.26.2
> 

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2020-08-17  8:22 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-16  7:13 [PATCH 0/2] Modernize rocktech,jh057n00900 bindings a bit Guido Günther
2020-08-16  7:13 ` [PATCH 1/2] dt-bindings: panel: rocktech,jh057n00900: Modernize Guido Günther
2020-08-16  7:13 ` [PATCH 2/2] dt-bindings: panel: rocktech,jh057n00900: Add myself as maintainer Guido Günther
2020-08-16 15:25 ` [PATCH 0/2] Modernize rocktech,jh057n00900 bindings a bit Sam Ravnborg
2020-08-17  8:22   ` Guido Günther

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).