* [PATCH] selftests: use "$(MAKE)" instead of "make" for headers_install
@ 2020-08-17 15:09 Denys Vlasenko
2020-08-31 20:49 ` Shuah Khan
0 siblings, 1 reply; 2+ messages in thread
From: Denys Vlasenko @ 2020-08-17 15:09 UTC (permalink / raw)
To: linux-kernel; +Cc: Denys Vlasenko, Shuah Khan, Shuah Khan, linux-kselftest
If top make invocation uses -j4 or larger, this patch reduces
"make headers_install" subtask run time from 30 to 7 seconds.
CC: Shuah Khan <shuah@kernel.org>
CC: Shuah Khan <skhan@linuxfoundation.org>
CC: linux-kselftest@vger.kernel.org
CC: linux-kernel@vger.kernel.org
Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
---
tools/testing/selftests/lib.mk | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/testing/selftests/lib.mk b/tools/testing/selftests/lib.mk
index 7a17ea815736..51124b962d56 100644
--- a/tools/testing/selftests/lib.mk
+++ b/tools/testing/selftests/lib.mk
@@ -47,9 +47,9 @@ ARCH ?= $(SUBARCH)
khdr:
ifndef KSFT_KHDR_INSTALL_DONE
ifeq (1,$(DEFAULT_INSTALL_HDR_PATH))
- make --no-builtin-rules ARCH=$(ARCH) -C $(top_srcdir) headers_install
+ $(MAKE) --no-builtin-rules ARCH=$(ARCH) -C $(top_srcdir) headers_install
else
- make --no-builtin-rules INSTALL_HDR_PATH=$$OUTPUT/usr \
+ $(MAKE) --no-builtin-rules INSTALL_HDR_PATH=$$OUTPUT/usr \
ARCH=$(ARCH) -C $(top_srcdir) headers_install
endif
endif
--
2.25.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] selftests: use "$(MAKE)" instead of "make" for headers_install
2020-08-17 15:09 [PATCH] selftests: use "$(MAKE)" instead of "make" for headers_install Denys Vlasenko
@ 2020-08-31 20:49 ` Shuah Khan
0 siblings, 0 replies; 2+ messages in thread
From: Shuah Khan @ 2020-08-31 20:49 UTC (permalink / raw)
To: Denys Vlasenko, linux-kernel; +Cc: Shuah Khan, linux-kselftest, Shuah Khan
On 8/17/20 9:09 AM, Denys Vlasenko wrote:
> If top make invocation uses -j4 or larger, this patch reduces
> "make headers_install" subtask run time from 30 to 7 seconds.
>
> CC: Shuah Khan <shuah@kernel.org>
> CC: Shuah Khan <skhan@linuxfoundation.org>
> CC: linux-kselftest@vger.kernel.org
> CC: linux-kernel@vger.kernel.org
> Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
> ---
> tools/testing/selftests/lib.mk | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/testing/selftests/lib.mk b/tools/testing/selftests/lib.mk
> index 7a17ea815736..51124b962d56 100644
> --- a/tools/testing/selftests/lib.mk
> +++ b/tools/testing/selftests/lib.mk
> @@ -47,9 +47,9 @@ ARCH ?= $(SUBARCH)
> khdr:
> ifndef KSFT_KHDR_INSTALL_DONE
> ifeq (1,$(DEFAULT_INSTALL_HDR_PATH))
> - make --no-builtin-rules ARCH=$(ARCH) -C $(top_srcdir) headers_install
> + $(MAKE) --no-builtin-rules ARCH=$(ARCH) -C $(top_srcdir) headers_install
> else
> - make --no-builtin-rules INSTALL_HDR_PATH=$$OUTPUT/usr \
> + $(MAKE) --no-builtin-rules INSTALL_HDR_PATH=$$OUTPUT/usr \
> ARCH=$(ARCH) -C $(top_srcdir) headers_install
> endif
> endif
>
Thanks for the patch. Applied to linux-kselftest next for 5.10
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-08-31 20:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-17 15:09 [PATCH] selftests: use "$(MAKE)" instead of "make" for headers_install Denys Vlasenko
2020-08-31 20:49 ` Shuah Khan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).