* [PATCH v2] Fixes: tty: serial: earlycon dependency
@ 2020-08-17 18:52 Tong Zhang
0 siblings, 0 replies; 5+ messages in thread
From: Tong Zhang @ 2020-08-17 18:52 UTC (permalink / raw)
To: ztong0001; +Cc: Greg Kroah-Hartman, Jiri Slaby, linux-serial, linux-kernel
parse_options() in drivers/tty/serial/earlycon.c calls uart_parse_earlycon
in drivers/tty/serial/serial_core.c therefore selecting SERIAL_EARLYCON
should automatically select SERIAL_CORE, otherwise will result in symbol
not found error during linking if SERIAL_CORE is not configured as builtin
Signed-off-by: Tong Zhang <ztong0001@gmail.com>
---
drivers/tty/serial/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig
index 8a0352eb337c..42e844314cbb 100644
--- a/drivers/tty/serial/Kconfig
+++ b/drivers/tty/serial/Kconfig
@@ -8,6 +8,7 @@ menu "Serial drivers"
config SERIAL_EARLYCON
bool
+ select SERIAL_CORE
help
Support for early consoles with the earlycon parameter. This enables
the console before standard serial driver is probed. The console is
--
2.25.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v2] Fixes: tty: serial: earlycon dependency
2020-08-18 11:19 ` Greg KH
@ 2020-08-18 16:27 ` Tong Zhang
0 siblings, 0 replies; 5+ messages in thread
From: Tong Zhang @ 2020-08-18 16:27 UTC (permalink / raw)
To: Greg KH; +Cc: Jiri Slaby, linux-serial, linux-kernel
Thanks Greg and Jiri for your suggestion!
I made another attempt to fix those problems. Hope it will work this time.
Thank you!
On Tue, Aug 18, 2020 at 7:19 AM Greg KH <gregkh@linuxfoundation.org> wrote:
>
> On Mon, Aug 17, 2020 at 02:54:19PM -0400, Tong Zhang wrote:
> > parse_options() in drivers/tty/serial/earlycon.c calls uart_parse_earlycon
> > in drivers/tty/serial/serial_core.c therefore selecting SERIAL_EARLYCON
> > should automatically select SERIAL_CORE, otherwise will result in symbol
> > not found error during linking if SERIAL_CORE is not configured as builtin
> >
> > Signed-off-by: Tong Zhang <ztong0001@gmail.com>
>
> As Jiri pointed out, the Fixes: line goes down here, not in your subject
> line :)
>
> Please fix up, thanks.
>
> > ---
> > drivers/tty/serial/Kconfig | 1 +
> > 1 file changed, 1 insertion(+)
>
> What changed from v1? Also always list that below the --- line so we
> know.
>
> thanks,
>
> greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] Fixes: tty: serial: earlycon dependency
2020-08-17 18:54 ` [PATCH v2] Fixes: tty: serial: " Tong Zhang
2020-08-18 5:42 ` Jiri Slaby
@ 2020-08-18 11:19 ` Greg KH
2020-08-18 16:27 ` Tong Zhang
1 sibling, 1 reply; 5+ messages in thread
From: Greg KH @ 2020-08-18 11:19 UTC (permalink / raw)
To: Tong Zhang; +Cc: jirislaby, linux-serial, linux-kernel
On Mon, Aug 17, 2020 at 02:54:19PM -0400, Tong Zhang wrote:
> parse_options() in drivers/tty/serial/earlycon.c calls uart_parse_earlycon
> in drivers/tty/serial/serial_core.c therefore selecting SERIAL_EARLYCON
> should automatically select SERIAL_CORE, otherwise will result in symbol
> not found error during linking if SERIAL_CORE is not configured as builtin
>
> Signed-off-by: Tong Zhang <ztong0001@gmail.com>
As Jiri pointed out, the Fixes: line goes down here, not in your subject
line :)
Please fix up, thanks.
> ---
> drivers/tty/serial/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
What changed from v1? Also always list that below the --- line so we
know.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] Fixes: tty: serial: earlycon dependency
2020-08-17 18:54 ` [PATCH v2] Fixes: tty: serial: " Tong Zhang
@ 2020-08-18 5:42 ` Jiri Slaby
2020-08-18 11:19 ` Greg KH
1 sibling, 0 replies; 5+ messages in thread
From: Jiri Slaby @ 2020-08-18 5:42 UTC (permalink / raw)
To: Tong Zhang, gregkh, linux-serial; +Cc: linux-kernel, Peter Hurley
On 17. 08. 20, 20:54, Tong Zhang wrote:
> parse_options() in drivers/tty/serial/earlycon.c calls uart_parse_earlycon
> in drivers/tty/serial/serial_core.c therefore selecting SERIAL_EARLYCON
> should automatically select SERIAL_CORE, otherwise will result in symbol
> not found error during linking if SERIAL_CORE is not configured as builtin
>
> Signed-off-by: Tong Zhang <ztong0001@gmail.com>
The "Fixes:" keyword should not have been in the Subject but here.
According to your findings something like this:
Fixes: 73abaf87f01b (serial: earlycon: Refactor parse_options into
serial core)
I am not sure:
1) it should be "select" (and not "depends")
2) serial earlycon should depend on serial core. But it's likely OK.
> drivers/tty/serial/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig
> index 8a0352eb337c..42e844314cbb 100644
> --- a/drivers/tty/serial/Kconfig
> +++ b/drivers/tty/serial/Kconfig
> @@ -8,6 +8,7 @@ menu "Serial drivers"
>
> config SERIAL_EARLYCON
> bool
> + select SERIAL_CORE
> help
> Support for early consoles with the earlycon parameter. This enables
> the console before standard serial driver is probed. The console is
>
thanks,
--
js
suse labs
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v2] Fixes: tty: serial: earlycon dependency
2020-08-17 17:00 [PATCH] tty: serial: fix " Greg KH
@ 2020-08-17 18:54 ` Tong Zhang
2020-08-18 5:42 ` Jiri Slaby
2020-08-18 11:19 ` Greg KH
0 siblings, 2 replies; 5+ messages in thread
From: Tong Zhang @ 2020-08-17 18:54 UTC (permalink / raw)
To: gregkh, jirislaby, linux-serial; +Cc: ztong0001, linux-kernel
parse_options() in drivers/tty/serial/earlycon.c calls uart_parse_earlycon
in drivers/tty/serial/serial_core.c therefore selecting SERIAL_EARLYCON
should automatically select SERIAL_CORE, otherwise will result in symbol
not found error during linking if SERIAL_CORE is not configured as builtin
Signed-off-by: Tong Zhang <ztong0001@gmail.com>
---
drivers/tty/serial/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig
index 8a0352eb337c..42e844314cbb 100644
--- a/drivers/tty/serial/Kconfig
+++ b/drivers/tty/serial/Kconfig
@@ -8,6 +8,7 @@ menu "Serial drivers"
config SERIAL_EARLYCON
bool
+ select SERIAL_CORE
help
Support for early consoles with the earlycon parameter. This enables
the console before standard serial driver is probed. The console is
--
2.25.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-08-18 16:28 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-17 18:52 [PATCH v2] Fixes: tty: serial: earlycon dependency Tong Zhang
-- strict thread matches above, loose matches on Subject: below --
2020-08-17 17:00 [PATCH] tty: serial: fix " Greg KH
2020-08-17 18:54 ` [PATCH v2] Fixes: tty: serial: " Tong Zhang
2020-08-18 5:42 ` Jiri Slaby
2020-08-18 11:19 ` Greg KH
2020-08-18 16:27 ` Tong Zhang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).