* [PATCH] mm/memory.c: Correct the function name in comment
@ 2020-08-18 7:29 yanfei.xu
2020-08-18 7:34 ` David Hildenbrand
0 siblings, 1 reply; 3+ messages in thread
From: yanfei.xu @ 2020-08-18 7:29 UTC (permalink / raw)
To: akpm; +Cc: linux-kernel, linux-mm
From: Yanfei Xu <yanfei.xu@windriver.com>
Correct the function name which is "pte_alloc_pne" to "pte_alloc_one"
Signed-off-by: Yanfei Xu <yanfei.xu@windriver.com>
---
mm/memory.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/memory.c b/mm/memory.c
index c3a83f4ca851..9cc3d0dc816c 100644
--- a/mm/memory.c
+++ b/mm/memory.c
@@ -3446,7 +3446,7 @@ static vm_fault_t __do_fault(struct vm_fault *vmf)
* unlock_page(A)
* lock_page(B)
* lock_page(B)
- * pte_alloc_pne
+ * pte_alloc_one
* shrink_page_list
* wait_on_page_writeback(A)
* SetPageWriteback(B)
--
2.18.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] mm/memory.c: Correct the function name in comment
2020-08-18 7:29 [PATCH] mm/memory.c: Correct the function name in comment yanfei.xu
@ 2020-08-18 7:34 ` David Hildenbrand
2020-08-18 10:26 ` Xu, Yanfei
0 siblings, 1 reply; 3+ messages in thread
From: David Hildenbrand @ 2020-08-18 7:34 UTC (permalink / raw)
To: yanfei.xu, akpm; +Cc: linux-kernel, linux-mm
On 18.08.20 09:29, yanfei.xu@windriver.com wrote:
> From: Yanfei Xu <yanfei.xu@windriver.com>
>
> Correct the function name which is "pte_alloc_pne" to "pte_alloc_one"
>
I'd have phrased this like
"mm/memory: Fix typo in __do_fault() comment
It's "pte_alloc_one", not "pte_alloc_pne". Let's fix that.
"
Reviewed-by: David Hildenbrand <david@redhat.com>
> Signed-off-by: Yanfei Xu <yanfei.xu@windriver.com>
> ---
> mm/memory.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/memory.c b/mm/memory.c
> index c3a83f4ca851..9cc3d0dc816c 100644
> --- a/mm/memory.c
> +++ b/mm/memory.c
> @@ -3446,7 +3446,7 @@ static vm_fault_t __do_fault(struct vm_fault *vmf)
> * unlock_page(A)
> * lock_page(B)
> * lock_page(B)
> - * pte_alloc_pne
> + * pte_alloc_one
> * shrink_page_list
> * wait_on_page_writeback(A)
> * SetPageWriteback(B)
>
--
Thanks,
David / dhildenb
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mm/memory.c: Correct the function name in comment
2020-08-18 7:34 ` David Hildenbrand
@ 2020-08-18 10:26 ` Xu, Yanfei
0 siblings, 0 replies; 3+ messages in thread
From: Xu, Yanfei @ 2020-08-18 10:26 UTC (permalink / raw)
To: David Hildenbrand, akpm; +Cc: linux-kernel, linux-mm
On 8/18/20 3:34 PM, David Hildenbrand wrote:
> On 18.08.20 09:29, yanfei.xu@windriver.com wrote:
>> From: Yanfei Xu <yanfei.xu@windriver.com>
>>
>> Correct the function name which is "pte_alloc_pne" to "pte_alloc_one"
>>
>
> I'd have phrased this like
>
> "mm/memory: Fix typo in __do_fault() comment
>
> It's "pte_alloc_one", not "pte_alloc_pne". Let's fix that.
> "
>
Hah, yours is more clear. I'll send a v2
Thanks for your suggestion. :)
//Yanfei
> Reviewed-by: David Hildenbrand <david@redhat.com>
>
>> Signed-off-by: Yanfei Xu <yanfei.xu@windriver.com>
>> ---
>> mm/memory.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/mm/memory.c b/mm/memory.c
>> index c3a83f4ca851..9cc3d0dc816c 100644
>> --- a/mm/memory.c
>> +++ b/mm/memory.c
>> @@ -3446,7 +3446,7 @@ static vm_fault_t __do_fault(struct vm_fault *vmf)
>> * unlock_page(A)
>> * lock_page(B)
>> * lock_page(B)
>> - * pte_alloc_pne
>> + * pte_alloc_one
>> * shrink_page_list
>> * wait_on_page_writeback(A)
>> * SetPageWriteback(B)
>>
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-08-18 10:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-18 7:29 [PATCH] mm/memory.c: Correct the function name in comment yanfei.xu
2020-08-18 7:34 ` David Hildenbrand
2020-08-18 10:26 ` Xu, Yanfei
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).