* [PATCH 1/3] dt-bindings: arm: stm32: Add compatible for syscon tamp node
2020-08-27 7:20 [PATCH 0/3] ARM: stm32: add DT properties for remote proc synchronisation Arnaud Pouliquen
@ 2020-08-27 7:20 ` Arnaud Pouliquen
2020-09-09 20:19 ` Rob Herring
2020-08-27 7:21 ` [PATCH 2/3] dt-bindings: remoteproc: stm32_rproc: update for firmware synchronization Arnaud Pouliquen
2020-08-27 7:21 ` [PATCH 3/3] ARM: dts: stm32: update stm32mp151 for remote proc synchronisation support Arnaud Pouliquen
2 siblings, 1 reply; 10+ messages in thread
From: Arnaud Pouliquen @ 2020-08-27 7:20 UTC (permalink / raw)
To: Rob Herring, Alexandre Torgue
Cc: devicetree, linux-stm32, linux-arm-kernel, linux-remoteproc,
linux-kernel, Fabien Dessenne, Arnaud Pouliquen, Mathieu Poirier,
Ohad Ben-Cohen, Bjorn Andersson
Since commit ad440432d1f9 ("dt-bindings: mfd: Ensure 'syscon' has a
more specific compatible")
It is required to provide at least 2 compatibles string for syscon node.
This patch documents the new compatible for stm32 SoC to support
TAMP registers access.
Signed-off-by: Arnaud Pouliquen <arnaud.pouliquen@st.com>
---
Documentation/devicetree/bindings/arm/stm32/st,stm32-syscon.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/arm/stm32/st,stm32-syscon.yaml b/Documentation/devicetree/bindings/arm/stm32/st,stm32-syscon.yaml
index 6f1cd0103c74..6634b3e0853e 100644
--- a/Documentation/devicetree/bindings/arm/stm32/st,stm32-syscon.yaml
+++ b/Documentation/devicetree/bindings/arm/stm32/st,stm32-syscon.yaml
@@ -19,6 +19,7 @@ properties:
- st,stm32mp151-pwr-mcu
- st,stm32-syscfg
- st,stm32-power-config
+ - st,stm32-tamp
- const: syscon
reg:
--
2.17.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH 1/3] dt-bindings: arm: stm32: Add compatible for syscon tamp node
2020-08-27 7:20 ` [PATCH 1/3] dt-bindings: arm: stm32: Add compatible for syscon tamp node Arnaud Pouliquen
@ 2020-09-09 20:19 ` Rob Herring
0 siblings, 0 replies; 10+ messages in thread
From: Rob Herring @ 2020-09-09 20:19 UTC (permalink / raw)
To: Arnaud Pouliquen
Cc: Fabien Dessenne, linux-remoteproc, devicetree, Ohad Ben-Cohen,
linux-arm-kernel, linux-kernel, linux-stm32, Alexandre Torgue,
Bjorn Andersson, Mathieu Poirier
On Thu, 27 Aug 2020 09:20:59 +0200, Arnaud Pouliquen wrote:
> Since commit ad440432d1f9 ("dt-bindings: mfd: Ensure 'syscon' has a
> more specific compatible")
> It is required to provide at least 2 compatibles string for syscon node.
> This patch documents the new compatible for stm32 SoC to support
> TAMP registers access.
>
> Signed-off-by: Arnaud Pouliquen <arnaud.pouliquen@st.com>
> ---
> Documentation/devicetree/bindings/arm/stm32/st,stm32-syscon.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 2/3] dt-bindings: remoteproc: stm32_rproc: update for firmware synchronization
2020-08-27 7:20 [PATCH 0/3] ARM: stm32: add DT properties for remote proc synchronisation Arnaud Pouliquen
2020-08-27 7:20 ` [PATCH 1/3] dt-bindings: arm: stm32: Add compatible for syscon tamp node Arnaud Pouliquen
@ 2020-08-27 7:21 ` Arnaud Pouliquen
2020-09-09 20:22 ` Rob Herring
2020-08-27 7:21 ` [PATCH 3/3] ARM: dts: stm32: update stm32mp151 for remote proc synchronisation support Arnaud Pouliquen
2 siblings, 1 reply; 10+ messages in thread
From: Arnaud Pouliquen @ 2020-08-27 7:21 UTC (permalink / raw)
To: Rob Herring, Alexandre Torgue
Cc: devicetree, linux-stm32, linux-arm-kernel, linux-remoteproc,
linux-kernel, Fabien Dessenne, Arnaud Pouliquen, Mathieu Poirier,
Ohad Ben-Cohen, Bjorn Andersson
Add new properties description used to attach to a pre-loaded
firmware according to the commit 9276536f455b3
("remoteproc: stm32: Parse syscon that will manage M4 synchronisation")
which updates the driver part.
Signed-off-by: Arnaud Pouliquen <arnaud.pouliquen@st.com>
---
.../bindings/remoteproc/st,stm32-rproc.yaml | 19 +++++++++++++++++++
1 file changed, 19 insertions(+)
diff --git a/Documentation/devicetree/bindings/remoteproc/st,stm32-rproc.yaml b/Documentation/devicetree/bindings/remoteproc/st,stm32-rproc.yaml
index 4ffa25268fcc..e50957d86b1c 100644
--- a/Documentation/devicetree/bindings/remoteproc/st,stm32-rproc.yaml
+++ b/Documentation/devicetree/bindings/remoteproc/st,stm32-rproc.yaml
@@ -96,6 +96,25 @@ properties:
3rd cell: register bitmask for the deep sleep bit
maxItems: 1
+ st,syscfg-m4-state:
+ $ref: "/schemas/types.yaml#/definitions/phandle-array"
+ description: |
+ Reference to the tamp register which exposes the Cortex-M4 state.
+ 1st cell: phandle to syscon block
+ 2nd cell: register offset containing the Cortex-M4 state
+ 3rd cell: register bitmask for the Cortex-M4 state
+ maxItems: 1
+
+ st,syscfg-rsc-tbl:
+ $ref: "/schemas/types.yaml#/definitions/phandle-array"
+ description: |
+ Reference to the tamp register which references the Cortex-M4
+ resource table address.
+ 1st cell: phandle to syscon block
+ 2nd cell: register offset containing the resource table address
+ 3rd cell: register bitmask for the resource table address
+ maxItems: 1
+
st,auto-boot:
$ref: /schemas/types.yaml#/definitions/flag
description:
--
2.17.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH 2/3] dt-bindings: remoteproc: stm32_rproc: update for firmware synchronization
2020-08-27 7:21 ` [PATCH 2/3] dt-bindings: remoteproc: stm32_rproc: update for firmware synchronization Arnaud Pouliquen
@ 2020-09-09 20:22 ` Rob Herring
2020-09-11 13:49 ` Arnaud POULIQUEN
0 siblings, 1 reply; 10+ messages in thread
From: Rob Herring @ 2020-09-09 20:22 UTC (permalink / raw)
To: Arnaud Pouliquen
Cc: Alexandre Torgue, devicetree, linux-stm32, linux-arm-kernel,
linux-remoteproc, linux-kernel, Fabien Dessenne, Mathieu Poirier,
Ohad Ben-Cohen, Bjorn Andersson
On Thu, Aug 27, 2020 at 09:21:00AM +0200, Arnaud Pouliquen wrote:
> Add new properties description used to attach to a pre-loaded
> firmware according to the commit 9276536f455b3
> ("remoteproc: stm32: Parse syscon that will manage M4 synchronisation")
> which updates the driver part.
>
> Signed-off-by: Arnaud Pouliquen <arnaud.pouliquen@st.com>
> ---
> .../bindings/remoteproc/st,stm32-rproc.yaml | 19 +++++++++++++++++++
> 1 file changed, 19 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/remoteproc/st,stm32-rproc.yaml b/Documentation/devicetree/bindings/remoteproc/st,stm32-rproc.yaml
> index 4ffa25268fcc..e50957d86b1c 100644
> --- a/Documentation/devicetree/bindings/remoteproc/st,stm32-rproc.yaml
> +++ b/Documentation/devicetree/bindings/remoteproc/st,stm32-rproc.yaml
> @@ -96,6 +96,25 @@ properties:
> 3rd cell: register bitmask for the deep sleep bit
> maxItems: 1
>
> + st,syscfg-m4-state:
> + $ref: "/schemas/types.yaml#/definitions/phandle-array"
> + description: |
> + Reference to the tamp register which exposes the Cortex-M4 state.
> + 1st cell: phandle to syscon block
> + 2nd cell: register offset containing the Cortex-M4 state
> + 3rd cell: register bitmask for the Cortex-M4 state
> + maxItems: 1
> +
> + st,syscfg-rsc-tbl:
> + $ref: "/schemas/types.yaml#/definitions/phandle-array"
> + description: |
> + Reference to the tamp register which references the Cortex-M4
> + resource table address.
> + 1st cell: phandle to syscon block
> + 2nd cell: register offset containing the resource table address
> + 3rd cell: register bitmask for the resource table address
> + maxItems: 1
Why can't these be implied? You can lookup the tamp syscon by
compatible.
Please add these to the example.
> +
> st,auto-boot:
> $ref: /schemas/types.yaml#/definitions/flag
> description:
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 2/3] dt-bindings: remoteproc: stm32_rproc: update for firmware synchronization
2020-09-09 20:22 ` Rob Herring
@ 2020-09-11 13:49 ` Arnaud POULIQUEN
2020-09-23 14:30 ` Arnaud POULIQUEN
0 siblings, 1 reply; 10+ messages in thread
From: Arnaud POULIQUEN @ 2020-09-11 13:49 UTC (permalink / raw)
To: Rob Herring
Cc: Alexandre TORGUE, devicetree, linux-stm32, linux-arm-kernel,
linux-remoteproc, linux-kernel, Fabien DESSENNE, Mathieu Poirier,
Ohad Ben-Cohen, Bjorn Andersson
Hi Rob,
On 9/9/20 10:22 PM, Rob Herring wrote:
> On Thu, Aug 27, 2020 at 09:21:00AM +0200, Arnaud Pouliquen wrote:
>> Add new properties description used to attach to a pre-loaded
>> firmware according to the commit 9276536f455b3
>> ("remoteproc: stm32: Parse syscon that will manage M4 synchronisation")
>> which updates the driver part.
>>
>> Signed-off-by: Arnaud Pouliquen <arnaud.pouliquen@st.com>
>> ---
>> .../bindings/remoteproc/st,stm32-rproc.yaml | 19 +++++++++++++++++++
>> 1 file changed, 19 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/remoteproc/st,stm32-rproc.yaml b/Documentation/devicetree/bindings/remoteproc/st,stm32-rproc.yaml
>> index 4ffa25268fcc..e50957d86b1c 100644
>> --- a/Documentation/devicetree/bindings/remoteproc/st,stm32-rproc.yaml
>> +++ b/Documentation/devicetree/bindings/remoteproc/st,stm32-rproc.yaml
>> @@ -96,6 +96,25 @@ properties:
>> 3rd cell: register bitmask for the deep sleep bit
>> maxItems: 1
>>
>> + st,syscfg-m4-state:
>> + $ref: "/schemas/types.yaml#/definitions/phandle-array"
>> + description: |
>> + Reference to the tamp register which exposes the Cortex-M4 state.
>> + 1st cell: phandle to syscon block
>> + 2nd cell: register offset containing the Cortex-M4 state
>> + 3rd cell: register bitmask for the Cortex-M4 state
>> + maxItems: 1
>> +
>> + st,syscfg-rsc-tbl:
>> + $ref: "/schemas/types.yaml#/definitions/phandle-array"
>> + description: |
>> + Reference to the tamp register which references the Cortex-M4
>> + resource table address.
>> + 1st cell: phandle to syscon block
>> + 2nd cell: register offset containing the resource table address
>> + 3rd cell: register bitmask for the resource table address
>> + maxItems: 1
>
> Why can't these be implied? You can lookup the tamp syscon by
> compatible.
I just made a copy/past of the "st,syscfg-pdds" syscon description available in the same file [1]
I can provide a shorter descriptions, something like this:
description: |
Reference to the tamp syscon register and bitmask which contains the Cortex-M4
resource table address.
maxItems: 1
Would this meet your expectations? If yes, I will also add in next version an extra patch to fix [1]
[1] https://elixir.bootlin.com/linux/v5.9-rc3/source/Documentation/devicetree/bindings/remoteproc/st,stm32-rproc.yaml#L90
>
> Please add these to the example.
I will extend the example with these properties
Thanks,
Arnaud
>
>> +
>> st,auto-boot:
>> $ref: /schemas/types.yaml#/definitions/flag
>> description:
>> --
>> 2.17.1
>>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 2/3] dt-bindings: remoteproc: stm32_rproc: update for firmware synchronization
2020-09-11 13:49 ` Arnaud POULIQUEN
@ 2020-09-23 14:30 ` Arnaud POULIQUEN
0 siblings, 0 replies; 10+ messages in thread
From: Arnaud POULIQUEN @ 2020-09-23 14:30 UTC (permalink / raw)
To: Rob Herring
Cc: Alexandre TORGUE, devicetree, linux-stm32, linux-arm-kernel,
linux-remoteproc, linux-kernel, Fabien DESSENNE, Mathieu Poirier,
Ohad Ben-Cohen, Bjorn Andersson
Hi Rob,
Gentle reminder.
As I'm not sure to well understand your comment I would appreciate if you could
confirm your expectation before I sent a v2.
Thanks in advance,
Arnaud
On 9/11/20 3:49 PM, Arnaud POULIQUEN wrote:
> Hi Rob,
>
> On 9/9/20 10:22 PM, Rob Herring wrote:
>> On Thu, Aug 27, 2020 at 09:21:00AM +0200, Arnaud Pouliquen wrote:
>>> Add new properties description used to attach to a pre-loaded
>>> firmware according to the commit 9276536f455b3
>>> ("remoteproc: stm32: Parse syscon that will manage M4 synchronisation")
>>> which updates the driver part.
>>>
>>> Signed-off-by: Arnaud Pouliquen <arnaud.pouliquen@st.com>
>>> ---
>>> .../bindings/remoteproc/st,stm32-rproc.yaml | 19 +++++++++++++++++++
>>> 1 file changed, 19 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/remoteproc/st,stm32-rproc.yaml b/Documentation/devicetree/bindings/remoteproc/st,stm32-rproc.yaml
>>> index 4ffa25268fcc..e50957d86b1c 100644
>>> --- a/Documentation/devicetree/bindings/remoteproc/st,stm32-rproc.yaml
>>> +++ b/Documentation/devicetree/bindings/remoteproc/st,stm32-rproc.yaml
>>> @@ -96,6 +96,25 @@ properties:
>>> 3rd cell: register bitmask for the deep sleep bit
>>> maxItems: 1
>>>
>>> + st,syscfg-m4-state:
>>> + $ref: "/schemas/types.yaml#/definitions/phandle-array"
>>> + description: |
>>> + Reference to the tamp register which exposes the Cortex-M4 state.
>>> + 1st cell: phandle to syscon block
>>> + 2nd cell: register offset containing the Cortex-M4 state
>>> + 3rd cell: register bitmask for the Cortex-M4 state
>>> + maxItems: 1
>>> +
>>> + st,syscfg-rsc-tbl:
>>> + $ref: "/schemas/types.yaml#/definitions/phandle-array"
>>> + description: |
>>> + Reference to the tamp register which references the Cortex-M4
>>> + resource table address.
>>> + 1st cell: phandle to syscon block
>>> + 2nd cell: register offset containing the resource table address
>>> + 3rd cell: register bitmask for the resource table address
>>> + maxItems: 1
>>
>> Why can't these be implied? You can lookup the tamp syscon by
>> compatible.
>
> I just made a copy/past of the "st,syscfg-pdds" syscon description available in the same file [1]
>
> I can provide a shorter descriptions, something like this:
>
> description: |
> Reference to the tamp syscon register and bitmask which contains the Cortex-M4
> resource table address.
> maxItems: 1
>
> Would this meet your expectations? If yes, I will also add in next version an extra patch to fix [1]
>
> [1] https://elixir.bootlin.com/linux/v5.9-rc3/source/Documentation/devicetree/bindings/remoteproc/st,stm32-rproc.yaml#L90
>
>>
>> Please add these to the example.
>
> I will extend the example with these properties
>
> Thanks,
> Arnaud
>
>>
>>> +
>>> st,auto-boot:
>>> $ref: /schemas/types.yaml#/definitions/flag
>>> description:
>>> --
>>> 2.17.1
>>>
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 3/3] ARM: dts: stm32: update stm32mp151 for remote proc synchronisation support
2020-08-27 7:20 [PATCH 0/3] ARM: stm32: add DT properties for remote proc synchronisation Arnaud Pouliquen
2020-08-27 7:20 ` [PATCH 1/3] dt-bindings: arm: stm32: Add compatible for syscon tamp node Arnaud Pouliquen
2020-08-27 7:21 ` [PATCH 2/3] dt-bindings: remoteproc: stm32_rproc: update for firmware synchronization Arnaud Pouliquen
@ 2020-08-27 7:21 ` Arnaud Pouliquen
2020-09-24 5:45 ` [Linux-stm32] " Ahmad Fatoum
2 siblings, 1 reply; 10+ messages in thread
From: Arnaud Pouliquen @ 2020-08-27 7:21 UTC (permalink / raw)
To: Rob Herring, Alexandre Torgue
Cc: devicetree, linux-stm32, linux-arm-kernel, linux-remoteproc,
linux-kernel, Fabien Dessenne, Arnaud Pouliquen, Mathieu Poirier,
Ohad Ben-Cohen, Bjorn Andersson
Two backup registers are used to store the Cortex-M4 state and the resource
table address.
Declare the tamp node and add associated properties in m4_rproc node
to allow Linux to attach to a firmware loaded by the first boot stages.
Associated driver implementation is available in commit 9276536f455b3
("remoteproc: stm32: Parse syscon that will manage M4 synchronisation").
Signed-off-by: Arnaud Pouliquen <arnaud.pouliquen@st.com>
---
arch/arm/boot/dts/stm32mp151.dtsi | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/arch/arm/boot/dts/stm32mp151.dtsi b/arch/arm/boot/dts/stm32mp151.dtsi
index bfe29023fbd5..842ecffae73a 100644
--- a/arch/arm/boot/dts/stm32mp151.dtsi
+++ b/arch/arm/boot/dts/stm32mp151.dtsi
@@ -1541,6 +1541,11 @@
status = "disabled";
};
+ tamp: tamp@5c00a000 {
+ compatible = "st,stm32-tamp", "syscon";
+ reg = <0x5c00a000 0x400>;
+ };
+
/*
* Break node order to solve dependency probe issue between
* pinctrl and exti.
@@ -1717,6 +1722,8 @@
st,syscfg-holdboot = <&rcc 0x10C 0x1>;
st,syscfg-tz = <&rcc 0x000 0x1>;
st,syscfg-pdds = <&pwr_mcu 0x0 0x1>;
+ st,syscfg-rsc-tbl = <&tamp 0x144 0xFFFFFFFF>;
+ st,syscfg-m4-state = <&tamp 0x148 0xFFFFFFFF>;
status = "disabled";
};
};
--
2.17.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [Linux-stm32] [PATCH 3/3] ARM: dts: stm32: update stm32mp151 for remote proc synchronisation support
2020-08-27 7:21 ` [PATCH 3/3] ARM: dts: stm32: update stm32mp151 for remote proc synchronisation support Arnaud Pouliquen
@ 2020-09-24 5:45 ` Ahmad Fatoum
2020-09-24 8:02 ` Arnaud POULIQUEN
0 siblings, 1 reply; 10+ messages in thread
From: Ahmad Fatoum @ 2020-09-24 5:45 UTC (permalink / raw)
To: Arnaud Pouliquen, Rob Herring, Alexandre Torgue
Cc: Ohad Ben-Cohen, devicetree, Mathieu Poirier, linux-remoteproc,
linux-kernel, Fabien Dessenne, Bjorn Andersson, linux-stm32,
linux-arm-kernel
Hello Arnaud,
On 8/27/20 9:21 AM, Arnaud Pouliquen wrote:
> Two backup registers are used to store the Cortex-M4 state and the resource
> table address.
> Declare the tamp node and add associated properties in m4_rproc node
> to allow Linux to attach to a firmware loaded by the first boot stages.
>
> Associated driver implementation is available in commit 9276536f455b3
> ("remoteproc: stm32: Parse syscon that will manage M4 synchronisation").
>
> Signed-off-by: Arnaud Pouliquen <arnaud.pouliquen@st.com>
> ---
> arch/arm/boot/dts/stm32mp151.dtsi | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/arch/arm/boot/dts/stm32mp151.dtsi b/arch/arm/boot/dts/stm32mp151.dtsi
> index bfe29023fbd5..842ecffae73a 100644
> --- a/arch/arm/boot/dts/stm32mp151.dtsi
> +++ b/arch/arm/boot/dts/stm32mp151.dtsi
> @@ -1541,6 +1541,11 @@
> status = "disabled";
> };
>
> + tamp: tamp@5c00a000 {
> + compatible = "st,stm32-tamp", "syscon";
> + reg = <0x5c00a000 0x400>;
> + };
> +
Just saw this now. I have a pending patch adding this node as well:
https://lore.kernel.org/patchwork/patch/1306971/
For my use case, I need a "simple-mfd" compatible to allow child
nodes to be probed.
Could you CC me when you send out your v2, so I can rebase?
(Or if you don't mind, just add the "simple-mfd" into the compatible
list yourself :-)
Cheers
Ahmad
> /*
> * Break node order to solve dependency probe issue between
> * pinctrl and exti.
> @@ -1717,6 +1722,8 @@
> st,syscfg-holdboot = <&rcc 0x10C 0x1>;
> st,syscfg-tz = <&rcc 0x000 0x1>;
> st,syscfg-pdds = <&pwr_mcu 0x0 0x1>;
> + st,syscfg-rsc-tbl = <&tamp 0x144 0xFFFFFFFF>;
> + st,syscfg-m4-state = <&tamp 0x148 0xFFFFFFFF>;
> status = "disabled";
> };
> };
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Linux-stm32] [PATCH 3/3] ARM: dts: stm32: update stm32mp151 for remote proc synchronisation support
2020-09-24 5:45 ` [Linux-stm32] " Ahmad Fatoum
@ 2020-09-24 8:02 ` Arnaud POULIQUEN
0 siblings, 0 replies; 10+ messages in thread
From: Arnaud POULIQUEN @ 2020-09-24 8:02 UTC (permalink / raw)
To: Ahmad Fatoum, Rob Herring, Alexandre TORGUE
Cc: Ohad Ben-Cohen, devicetree, Mathieu Poirier, linux-remoteproc,
linux-kernel, Fabien DESSENNE, Bjorn Andersson, linux-stm32,
linux-arm-kernel
Hi Ahmad,
On 9/24/20 7:45 AM, Ahmad Fatoum wrote:
> Hello Arnaud,
>
> On 8/27/20 9:21 AM, Arnaud Pouliquen wrote:
>> Two backup registers are used to store the Cortex-M4 state and the resource
>> table address.
>> Declare the tamp node and add associated properties in m4_rproc node
>> to allow Linux to attach to a firmware loaded by the first boot stages.
>>
>> Associated driver implementation is available in commit 9276536f455b3
>> ("remoteproc: stm32: Parse syscon that will manage M4 synchronisation").
>>
>> Signed-off-by: Arnaud Pouliquen <arnaud.pouliquen@st.com>
>> ---
>> arch/arm/boot/dts/stm32mp151.dtsi | 7 +++++++
>> 1 file changed, 7 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/stm32mp151.dtsi b/arch/arm/boot/dts/stm32mp151.dtsi
>> index bfe29023fbd5..842ecffae73a 100644
>> --- a/arch/arm/boot/dts/stm32mp151.dtsi
>> +++ b/arch/arm/boot/dts/stm32mp151.dtsi
>> @@ -1541,6 +1541,11 @@
>> status = "disabled";
>> };
>>
>> + tamp: tamp@5c00a000 {
>> + compatible = "st,stm32-tamp", "syscon";
>> + reg = <0x5c00a000 0x400>;
>> + };
>> +
>
> Just saw this now. I have a pending patch adding this node as well:
> https://lore.kernel.org/patchwork/patch/1306971/
>
> For my use case, I need a "simple-mfd" compatible to allow child
> nodes to be probed.
>
> Could you CC me when you send out your v2, so I can rebase?
> (Or if you don't mind, just add the "simple-mfd" into the compatible
> list yourself :-)
I prefer that you propose the "simple-mfd" compatibility. I do not master the
consequence of adding it...
I will add you in cc of my v2 , but as your patch could trig some discussions
I would suggest to send in advance a patchset including this patch and your patch
on top of, just add a reference to this series in the cover letter and explain
potential impact (or non impact) on the legacy.
Regards,
Arnaud
>
> Cheers
> Ahmad
>
>> /*
>> * Break node order to solve dependency probe issue between
>> * pinctrl and exti.
>> @@ -1717,6 +1722,8 @@
>> st,syscfg-holdboot = <&rcc 0x10C 0x1>;
>> st,syscfg-tz = <&rcc 0x000 0x1>;
>> st,syscfg-pdds = <&pwr_mcu 0x0 0x1>;
>> + st,syscfg-rsc-tbl = <&tamp 0x144 0xFFFFFFFF>;
>> + st,syscfg-m4-state = <&tamp 0x148 0xFFFFFFFF>;
>> status = "disabled";
>> };
>> };
>>
>
^ permalink raw reply [flat|nested] 10+ messages in thread