* [PATCH 1/6] mtd: onenand: Simplify with dev_err_probe()
@ 2020-09-01 14:25 Krzysztof Kozlowski
2020-09-01 14:25 ` [PATCH 2/6] mtd: rawnand: atmel: " Krzysztof Kozlowski
` (5 more replies)
0 siblings, 6 replies; 13+ messages in thread
From: Krzysztof Kozlowski @ 2020-09-01 14:25 UTC (permalink / raw)
To: Kyungmin Park, Miquel Raynal, Richard Weinberger,
Vignesh Raghavendra, Tudor Ambarus, Nicolas Ferre,
Alexandre Belloni, Ludovic Desroches, Han Xu, linux-mtd,
linux-kernel, linux-arm-kernel
Cc: Krzysztof Kozlowski
Common pattern of handling deferred probe can be simplified with
dev_err_probe(). Less code and the error value gets printed.
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
drivers/mtd/nand/onenand/onenand_omap2.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/mtd/nand/onenand/onenand_omap2.c b/drivers/mtd/nand/onenand/onenand_omap2.c
index aa9368bf7a0c..d8c0bd002c2b 100644
--- a/drivers/mtd/nand/onenand/onenand_omap2.c
+++ b/drivers/mtd/nand/onenand/onenand_omap2.c
@@ -494,11 +494,8 @@ static int omap2_onenand_probe(struct platform_device *pdev)
c->int_gpiod = devm_gpiod_get_optional(dev, "int", GPIOD_IN);
if (IS_ERR(c->int_gpiod)) {
- r = PTR_ERR(c->int_gpiod);
/* Just try again if this happens */
- if (r != -EPROBE_DEFER)
- dev_err(dev, "error getting gpio: %d\n", r);
- return r;
+ return dev_err_probe(dev, PTR_ERR(c->int_gpiod), "error getting gpio\n");
}
if (c->int_gpiod) {
--
2.17.1
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [PATCH 2/6] mtd: rawnand: atmel: Simplify with dev_err_probe()
2020-09-01 14:25 [PATCH 1/6] mtd: onenand: Simplify with dev_err_probe() Krzysztof Kozlowski
@ 2020-09-01 14:25 ` Krzysztof Kozlowski
2020-09-01 19:12 ` Alexandre Belloni
2020-09-11 16:56 ` Miquel Raynal
2020-09-01 14:25 ` [PATCH 3/6] mtd: rawnand: gpmi: " Krzysztof Kozlowski
` (4 subsequent siblings)
5 siblings, 2 replies; 13+ messages in thread
From: Krzysztof Kozlowski @ 2020-09-01 14:25 UTC (permalink / raw)
To: Kyungmin Park, Miquel Raynal, Richard Weinberger,
Vignesh Raghavendra, Tudor Ambarus, Nicolas Ferre,
Alexandre Belloni, Ludovic Desroches, Han Xu, linux-mtd,
linux-kernel, linux-arm-kernel
Cc: Krzysztof Kozlowski
Common pattern of handling deferred probe can be simplified with
dev_err_probe(). Less code and the error value gets printed.
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
drivers/mtd/nand/raw/atmel/nand-controller.c | 10 +++-------
1 file changed, 3 insertions(+), 7 deletions(-)
diff --git a/drivers/mtd/nand/raw/atmel/nand-controller.c b/drivers/mtd/nand/raw/atmel/nand-controller.c
index c9818f548d07..71e2b83485d7 100644
--- a/drivers/mtd/nand/raw/atmel/nand-controller.c
+++ b/drivers/mtd/nand/raw/atmel/nand-controller.c
@@ -1976,13 +1976,9 @@ static int atmel_nand_controller_init(struct atmel_nand_controller *nc,
platform_set_drvdata(pdev, nc);
nc->pmecc = devm_atmel_pmecc_get(dev);
- if (IS_ERR(nc->pmecc)) {
- ret = PTR_ERR(nc->pmecc);
- if (ret != -EPROBE_DEFER)
- dev_err(dev, "Could not get PMECC object (err = %d)\n",
- ret);
- return ret;
- }
+ if (IS_ERR(nc->pmecc))
+ return dev_err_probe(dev, PTR_ERR(nc->pmecc),
+ "Could not get PMECC object\n");
if (nc->caps->has_dma && !atmel_nand_avoid_dma) {
dma_cap_mask_t mask;
--
2.17.1
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [PATCH 3/6] mtd: rawnand: gpmi: Simplify with dev_err_probe()
2020-09-01 14:25 [PATCH 1/6] mtd: onenand: Simplify with dev_err_probe() Krzysztof Kozlowski
2020-09-01 14:25 ` [PATCH 2/6] mtd: rawnand: atmel: " Krzysztof Kozlowski
@ 2020-09-01 14:25 ` Krzysztof Kozlowski
2020-09-11 16:55 ` Miquel Raynal
2020-09-01 14:25 ` [PATCH 4/6] mtd: rawnand: marvell: " Krzysztof Kozlowski
` (3 subsequent siblings)
5 siblings, 1 reply; 13+ messages in thread
From: Krzysztof Kozlowski @ 2020-09-01 14:25 UTC (permalink / raw)
To: Kyungmin Park, Miquel Raynal, Richard Weinberger,
Vignesh Raghavendra, Tudor Ambarus, Nicolas Ferre,
Alexandre Belloni, Ludovic Desroches, Han Xu, linux-mtd,
linux-kernel, linux-arm-kernel
Cc: Krzysztof Kozlowski
Common pattern of handling deferred probe can be simplified with
dev_err_probe(). Less code and the error value gets printed.
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c b/drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c
index 5d4aee46cc55..3d8fe0d0721f 100644
--- a/drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c
+++ b/drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c
@@ -1003,10 +1003,8 @@ static int acquire_dma_channels(struct gpmi_nand_data *this)
/* request dma channel */
dma_chan = dma_request_chan(&pdev->dev, "rx-tx");
if (IS_ERR(dma_chan)) {
- ret = PTR_ERR(dma_chan);
- if (ret != -EPROBE_DEFER)
- dev_err(this->dev, "DMA channel request failed: %d\n",
- ret);
+ ret = dev_err_probe(this->dev, PTR_ERR(dma_chan),
+ "DMA channel request failed\n");
release_dma_channels(this);
} else {
this->dma_chans[0] = dma_chan;
--
2.17.1
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [PATCH 4/6] mtd: rawnand: marvell: Simplify with dev_err_probe()
2020-09-01 14:25 [PATCH 1/6] mtd: onenand: Simplify with dev_err_probe() Krzysztof Kozlowski
2020-09-01 14:25 ` [PATCH 2/6] mtd: rawnand: atmel: " Krzysztof Kozlowski
2020-09-01 14:25 ` [PATCH 3/6] mtd: rawnand: gpmi: " Krzysztof Kozlowski
@ 2020-09-01 14:25 ` Krzysztof Kozlowski
2020-09-11 16:55 ` Miquel Raynal
2020-09-01 14:25 ` [PATCH 5/6] mtd: rawnand: marvell: Fix and update kerneldoc Krzysztof Kozlowski
` (2 subsequent siblings)
5 siblings, 1 reply; 13+ messages in thread
From: Krzysztof Kozlowski @ 2020-09-01 14:25 UTC (permalink / raw)
To: Kyungmin Park, Miquel Raynal, Richard Weinberger,
Vignesh Raghavendra, Tudor Ambarus, Nicolas Ferre,
Alexandre Belloni, Ludovic Desroches, Han Xu, linux-mtd,
linux-kernel, linux-arm-kernel
Cc: Krzysztof Kozlowski
Common pattern of handling deferred probe can be simplified with
dev_err_probe(). Less code and the error value gets printed.
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
drivers/mtd/nand/raw/marvell_nand.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/mtd/nand/raw/marvell_nand.c b/drivers/mtd/nand/raw/marvell_nand.c
index 8482d3bd8b1f..52cb7da2fc02 100644
--- a/drivers/mtd/nand/raw/marvell_nand.c
+++ b/drivers/mtd/nand/raw/marvell_nand.c
@@ -2759,10 +2759,7 @@ static int marvell_nfc_init_dma(struct marvell_nfc *nfc)
if (IS_ERR(nfc->dma_chan)) {
ret = PTR_ERR(nfc->dma_chan);
nfc->dma_chan = NULL;
- if (ret != -EPROBE_DEFER)
- dev_err(nfc->dev, "DMA channel request failed: %d\n",
- ret);
- return ret;
+ return dev_err_probe(nfc->dev, ret, "DMA channel request failed\n");
}
r = platform_get_resource(pdev, IORESOURCE_MEM, 0);
--
2.17.1
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [PATCH 5/6] mtd: rawnand: marvell: Fix and update kerneldoc
2020-09-01 14:25 [PATCH 1/6] mtd: onenand: Simplify with dev_err_probe() Krzysztof Kozlowski
` (2 preceding siblings ...)
2020-09-01 14:25 ` [PATCH 4/6] mtd: rawnand: marvell: " Krzysztof Kozlowski
@ 2020-09-01 14:25 ` Krzysztof Kozlowski
2020-09-11 16:55 ` Miquel Raynal
2020-09-01 14:25 ` [PATCH 6/6] mtd: rawnand: qcom: Simplify with dev_err_probe() Krzysztof Kozlowski
2020-09-11 16:56 ` [PATCH 1/6] mtd: onenand: " Miquel Raynal
5 siblings, 1 reply; 13+ messages in thread
From: Krzysztof Kozlowski @ 2020-09-01 14:25 UTC (permalink / raw)
To: Kyungmin Park, Miquel Raynal, Richard Weinberger,
Vignesh Raghavendra, Tudor Ambarus, Nicolas Ferre,
Alexandre Belloni, Ludovic Desroches, Han Xu, linux-mtd,
linux-kernel, linux-arm-kernel
Cc: Krzysztof Kozlowski
Fix kerneldoc comments and add missing documentation for members to fix
W=1 compile warnings like:
drivers/mtd/nand/raw/marvell_nand.c:251: warning:
cannot understand function prototype: 'struct marvell_hw_ecc_layout '
drivers/mtd/nand/raw/marvell_nand.c:342: warning:
Function parameter or member 'layout' not described in 'marvell_nand_chip'
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
drivers/mtd/nand/raw/marvell_nand.c | 23 ++++++++++++++++-------
1 file changed, 16 insertions(+), 7 deletions(-)
diff --git a/drivers/mtd/nand/raw/marvell_nand.c b/drivers/mtd/nand/raw/marvell_nand.c
index 52cb7da2fc02..fbffbb3fcc1c 100644
--- a/drivers/mtd/nand/raw/marvell_nand.c
+++ b/drivers/mtd/nand/raw/marvell_nand.c
@@ -227,6 +227,8 @@
#define XTYPE_MASK 7
/**
+ * struct marvell_hw_ecc_layout - layout of Marvell ECC
+ *
* Marvell ECC engine works differently than the others, in order to limit the
* size of the IP, hardware engineers chose to set a fixed strength at 16 bits
* per subpage, and depending on a the desired strength needed by the NAND chip,
@@ -292,6 +294,8 @@ static const struct marvell_hw_ecc_layout marvell_nfc_layouts[] = {
};
/**
+ * struct marvell_nand_chip_sel - CS line description
+ *
* The Nand Flash Controller has up to 4 CE and 2 RB pins. The CE selection
* is made by a field in NDCB0 register, and in another field in NDCB2 register.
* The datasheet describes the logic with an error: ADDR5 field is once
@@ -312,14 +316,15 @@ struct marvell_nand_chip_sel {
};
/**
- * NAND chip structure: stores NAND chip device related information
+ * struct marvell_nand_chip - stores NAND chip device related information
*
* @chip: Base NAND chip structure
* @node: Used to store NAND chips into a list
- * @layout NAND layout when using hardware ECC
+ * @layout: NAND layout when using hardware ECC
* @ndcr: Controller register value for this NAND chip
* @ndtr0: Timing registers 0 value for this NAND chip
* @ndtr1: Timing registers 1 value for this NAND chip
+ * @addr_cyc: Amount of cycles needed to pass column address
* @selected_die: Current active CS
* @nsels: Number of CS lines required by the NAND chip
* @sels: Array of CS lines descriptions
@@ -349,7 +354,8 @@ static inline struct marvell_nand_chip_sel *to_nand_sel(struct marvell_nand_chip
}
/**
- * NAND controller capabilities for distinction between compatible strings
+ * struct marvell_nfc_caps - NAND controller capabilities for distinction
+ * between compatible strings
*
* @max_cs_nb: Number of Chip Select lines available
* @max_rb_nb: Number of Ready/Busy lines available
@@ -372,7 +378,7 @@ struct marvell_nfc_caps {
};
/**
- * NAND controller structure: stores Marvell NAND controller information
+ * struct marvell_nfc - stores Marvell NAND controller information
*
* @controller: Base controller structure
* @dev: Parent device (used to print error messages)
@@ -383,7 +389,9 @@ struct marvell_nfc_caps {
* @assigned_cs: Bitmask describing already assigned CS lines
* @chips: List containing all the NAND chips attached to
* this NAND controller
+ * @selected_chip: Currently selected target chip
* @caps: NAND controller capabilities for each compatible string
+ * @use_dma: Whetner DMA is used
* @dma_chan: DMA channel (NFCv1 only)
* @dma_buf: 32-bit aligned buffer for DMA transfers (NFCv1 only)
*/
@@ -411,7 +419,8 @@ static inline struct marvell_nfc *to_marvell_nfc(struct nand_controller *ctrl)
}
/**
- * NAND controller timings expressed in NAND Controller clock cycles
+ * struct marvell_nfc_timings - NAND controller timings expressed in NAND
+ * Controller clock cycles
*
* @tRP: ND_nRE pulse width
* @tRH: ND_nRE high duration
@@ -455,8 +464,8 @@ struct marvell_nfc_timings {
period_ns))
/**
- * NAND driver structure filled during the parsing of the ->exec_op() subop
- * subset of instructions.
+ * struct marvell_nfc_op - filled during the parsing of the ->exec_op()
+ * subop subset of instructions.
*
* @ndcb: Array of values written to NDCBx registers
* @cle_ale_delay_ns: Optional delay after the last CMD or ADDR cycle
--
2.17.1
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [PATCH 6/6] mtd: rawnand: qcom: Simplify with dev_err_probe()
2020-09-01 14:25 [PATCH 1/6] mtd: onenand: Simplify with dev_err_probe() Krzysztof Kozlowski
` (3 preceding siblings ...)
2020-09-01 14:25 ` [PATCH 5/6] mtd: rawnand: marvell: Fix and update kerneldoc Krzysztof Kozlowski
@ 2020-09-01 14:25 ` Krzysztof Kozlowski
2020-09-11 16:55 ` Miquel Raynal
2020-09-11 16:56 ` [PATCH 1/6] mtd: onenand: " Miquel Raynal
5 siblings, 1 reply; 13+ messages in thread
From: Krzysztof Kozlowski @ 2020-09-01 14:25 UTC (permalink / raw)
To: Kyungmin Park, Miquel Raynal, Richard Weinberger,
Vignesh Raghavendra, Tudor Ambarus, Nicolas Ferre,
Alexandre Belloni, Ludovic Desroches, Han Xu, linux-mtd,
linux-kernel, linux-arm-kernel
Cc: Krzysztof Kozlowski
Common pattern of handling deferred probe can be simplified with
dev_err_probe(). Less code and the error value gets printed.
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
drivers/mtd/nand/raw/qcom_nandc.c | 24 ++++++++----------------
1 file changed, 8 insertions(+), 16 deletions(-)
diff --git a/drivers/mtd/nand/raw/qcom_nandc.c b/drivers/mtd/nand/raw/qcom_nandc.c
index bd7a7251429b..31d6b9682e3d 100644
--- a/drivers/mtd/nand/raw/qcom_nandc.c
+++ b/drivers/mtd/nand/raw/qcom_nandc.c
@@ -2702,10 +2702,8 @@ static int qcom_nandc_alloc(struct qcom_nand_controller *nandc)
if (IS_ERR(nandc->tx_chan)) {
ret = PTR_ERR(nandc->tx_chan);
nandc->tx_chan = NULL;
- if (ret != -EPROBE_DEFER)
- dev_err(nandc->dev,
- "tx DMA channel request failed: %d\n",
- ret);
+ dev_err_probe(nandc->dev, ret,
+ "tx DMA channel request failed\n");
goto unalloc;
}
@@ -2713,10 +2711,8 @@ static int qcom_nandc_alloc(struct qcom_nand_controller *nandc)
if (IS_ERR(nandc->rx_chan)) {
ret = PTR_ERR(nandc->rx_chan);
nandc->rx_chan = NULL;
- if (ret != -EPROBE_DEFER)
- dev_err(nandc->dev,
- "rx DMA channel request failed: %d\n",
- ret);
+ dev_err_probe(nandc->dev, ret,
+ "rx DMA channel request failed\n");
goto unalloc;
}
@@ -2724,10 +2720,8 @@ static int qcom_nandc_alloc(struct qcom_nand_controller *nandc)
if (IS_ERR(nandc->cmd_chan)) {
ret = PTR_ERR(nandc->cmd_chan);
nandc->cmd_chan = NULL;
- if (ret != -EPROBE_DEFER)
- dev_err(nandc->dev,
- "cmd DMA channel request failed: %d\n",
- ret);
+ dev_err_probe(nandc->dev, ret,
+ "cmd DMA channel request failed\n");
goto unalloc;
}
@@ -2750,10 +2744,8 @@ static int qcom_nandc_alloc(struct qcom_nand_controller *nandc)
if (IS_ERR(nandc->chan)) {
ret = PTR_ERR(nandc->chan);
nandc->chan = NULL;
- if (ret != -EPROBE_DEFER)
- dev_err(nandc->dev,
- "rxtx DMA channel request failed: %d\n",
- ret);
+ dev_err_probe(nandc->dev, ret,
+ "rxtx DMA channel request failed\n");
return ret;
}
}
--
2.17.1
^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [PATCH 2/6] mtd: rawnand: atmel: Simplify with dev_err_probe()
2020-09-01 14:25 ` [PATCH 2/6] mtd: rawnand: atmel: " Krzysztof Kozlowski
@ 2020-09-01 19:12 ` Alexandre Belloni
2020-09-11 16:56 ` Miquel Raynal
1 sibling, 0 replies; 13+ messages in thread
From: Alexandre Belloni @ 2020-09-01 19:12 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Kyungmin Park, Miquel Raynal, Richard Weinberger,
Vignesh Raghavendra, Tudor Ambarus, Nicolas Ferre,
Ludovic Desroches, Han Xu, linux-mtd, linux-kernel,
linux-arm-kernel
On 01/09/2020 16:25:31+0200, Krzysztof Kozlowski wrote:
> Common pattern of handling deferred probe can be simplified with
> dev_err_probe(). Less code and the error value gets printed.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Reviewed-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
> ---
> drivers/mtd/nand/raw/atmel/nand-controller.c | 10 +++-------
> 1 file changed, 3 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/mtd/nand/raw/atmel/nand-controller.c b/drivers/mtd/nand/raw/atmel/nand-controller.c
> index c9818f548d07..71e2b83485d7 100644
> --- a/drivers/mtd/nand/raw/atmel/nand-controller.c
> +++ b/drivers/mtd/nand/raw/atmel/nand-controller.c
> @@ -1976,13 +1976,9 @@ static int atmel_nand_controller_init(struct atmel_nand_controller *nc,
> platform_set_drvdata(pdev, nc);
>
> nc->pmecc = devm_atmel_pmecc_get(dev);
> - if (IS_ERR(nc->pmecc)) {
> - ret = PTR_ERR(nc->pmecc);
> - if (ret != -EPROBE_DEFER)
> - dev_err(dev, "Could not get PMECC object (err = %d)\n",
> - ret);
> - return ret;
> - }
> + if (IS_ERR(nc->pmecc))
> + return dev_err_probe(dev, PTR_ERR(nc->pmecc),
> + "Could not get PMECC object\n");
>
> if (nc->caps->has_dma && !atmel_nand_avoid_dma) {
> dma_cap_mask_t mask;
> --
> 2.17.1
>
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 6/6] mtd: rawnand: qcom: Simplify with dev_err_probe()
2020-09-01 14:25 ` [PATCH 6/6] mtd: rawnand: qcom: Simplify with dev_err_probe() Krzysztof Kozlowski
@ 2020-09-11 16:55 ` Miquel Raynal
0 siblings, 0 replies; 13+ messages in thread
From: Miquel Raynal @ 2020-09-11 16:55 UTC (permalink / raw)
To: Krzysztof Kozlowski, Kyungmin Park, Miquel Raynal,
Richard Weinberger, Vignesh Raghavendra, Tudor Ambarus,
Nicolas Ferre, Alexandre Belloni, Ludovic Desroches, Han Xu,
linux-mtd, linux-kernel, linux-arm-kernel
On Tue, 2020-09-01 at 14:25:35 UTC, Krzysztof Kozlowski wrote:
> Common pattern of handling deferred probe can be simplified with
> dev_err_probe(). Less code and the error value gets printed.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next, thanks.
Miquel
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 5/6] mtd: rawnand: marvell: Fix and update kerneldoc
2020-09-01 14:25 ` [PATCH 5/6] mtd: rawnand: marvell: Fix and update kerneldoc Krzysztof Kozlowski
@ 2020-09-11 16:55 ` Miquel Raynal
0 siblings, 0 replies; 13+ messages in thread
From: Miquel Raynal @ 2020-09-11 16:55 UTC (permalink / raw)
To: Krzysztof Kozlowski, Kyungmin Park, Miquel Raynal,
Richard Weinberger, Vignesh Raghavendra, Tudor Ambarus,
Nicolas Ferre, Alexandre Belloni, Ludovic Desroches, Han Xu,
linux-mtd, linux-kernel, linux-arm-kernel
On Tue, 2020-09-01 at 14:25:34 UTC, Krzysztof Kozlowski wrote:
> Fix kerneldoc comments and add missing documentation for members to fix
> W=1 compile warnings like:
>
> drivers/mtd/nand/raw/marvell_nand.c:251: warning:
> cannot understand function prototype: 'struct marvell_hw_ecc_layout '
>
> drivers/mtd/nand/raw/marvell_nand.c:342: warning:
> Function parameter or member 'layout' not described in 'marvell_nand_chip'
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next, thanks.
Miquel
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 4/6] mtd: rawnand: marvell: Simplify with dev_err_probe()
2020-09-01 14:25 ` [PATCH 4/6] mtd: rawnand: marvell: " Krzysztof Kozlowski
@ 2020-09-11 16:55 ` Miquel Raynal
0 siblings, 0 replies; 13+ messages in thread
From: Miquel Raynal @ 2020-09-11 16:55 UTC (permalink / raw)
To: Krzysztof Kozlowski, Kyungmin Park, Miquel Raynal,
Richard Weinberger, Vignesh Raghavendra, Tudor Ambarus,
Nicolas Ferre, Alexandre Belloni, Ludovic Desroches, Han Xu,
linux-mtd, linux-kernel, linux-arm-kernel
On Tue, 2020-09-01 at 14:25:33 UTC, Krzysztof Kozlowski wrote:
> Common pattern of handling deferred probe can be simplified with
> dev_err_probe(). Less code and the error value gets printed.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next, thanks.
Miquel
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 3/6] mtd: rawnand: gpmi: Simplify with dev_err_probe()
2020-09-01 14:25 ` [PATCH 3/6] mtd: rawnand: gpmi: " Krzysztof Kozlowski
@ 2020-09-11 16:55 ` Miquel Raynal
0 siblings, 0 replies; 13+ messages in thread
From: Miquel Raynal @ 2020-09-11 16:55 UTC (permalink / raw)
To: Krzysztof Kozlowski, Kyungmin Park, Miquel Raynal,
Richard Weinberger, Vignesh Raghavendra, Tudor Ambarus,
Nicolas Ferre, Alexandre Belloni, Ludovic Desroches, Han Xu,
linux-mtd, linux-kernel, linux-arm-kernel
On Tue, 2020-09-01 at 14:25:32 UTC, Krzysztof Kozlowski wrote:
> Common pattern of handling deferred probe can be simplified with
> dev_err_probe(). Less code and the error value gets printed.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next, thanks.
Miquel
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 2/6] mtd: rawnand: atmel: Simplify with dev_err_probe()
2020-09-01 14:25 ` [PATCH 2/6] mtd: rawnand: atmel: " Krzysztof Kozlowski
2020-09-01 19:12 ` Alexandre Belloni
@ 2020-09-11 16:56 ` Miquel Raynal
1 sibling, 0 replies; 13+ messages in thread
From: Miquel Raynal @ 2020-09-11 16:56 UTC (permalink / raw)
To: Krzysztof Kozlowski, Kyungmin Park, Miquel Raynal,
Richard Weinberger, Vignesh Raghavendra, Tudor Ambarus,
Nicolas Ferre, Alexandre Belloni, Ludovic Desroches, Han Xu,
linux-mtd, linux-kernel, linux-arm-kernel
On Tue, 2020-09-01 at 14:25:31 UTC, Krzysztof Kozlowski wrote:
> Common pattern of handling deferred probe can be simplified with
> dev_err_probe(). Less code and the error value gets printed.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> Reviewed-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next, thanks.
Miquel
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 1/6] mtd: onenand: Simplify with dev_err_probe()
2020-09-01 14:25 [PATCH 1/6] mtd: onenand: Simplify with dev_err_probe() Krzysztof Kozlowski
` (4 preceding siblings ...)
2020-09-01 14:25 ` [PATCH 6/6] mtd: rawnand: qcom: Simplify with dev_err_probe() Krzysztof Kozlowski
@ 2020-09-11 16:56 ` Miquel Raynal
5 siblings, 0 replies; 13+ messages in thread
From: Miquel Raynal @ 2020-09-11 16:56 UTC (permalink / raw)
To: Krzysztof Kozlowski, Kyungmin Park, Miquel Raynal,
Richard Weinberger, Vignesh Raghavendra, Tudor Ambarus,
Nicolas Ferre, Alexandre Belloni, Ludovic Desroches, Han Xu,
linux-mtd, linux-kernel, linux-arm-kernel
On Tue, 2020-09-01 at 14:25:30 UTC, Krzysztof Kozlowski wrote:
> Common pattern of handling deferred probe can be simplified with
> dev_err_probe(). Less code and the error value gets printed.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next, thanks.
Miquel
^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2020-09-11 16:57 UTC | newest]
Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-01 14:25 [PATCH 1/6] mtd: onenand: Simplify with dev_err_probe() Krzysztof Kozlowski
2020-09-01 14:25 ` [PATCH 2/6] mtd: rawnand: atmel: " Krzysztof Kozlowski
2020-09-01 19:12 ` Alexandre Belloni
2020-09-11 16:56 ` Miquel Raynal
2020-09-01 14:25 ` [PATCH 3/6] mtd: rawnand: gpmi: " Krzysztof Kozlowski
2020-09-11 16:55 ` Miquel Raynal
2020-09-01 14:25 ` [PATCH 4/6] mtd: rawnand: marvell: " Krzysztof Kozlowski
2020-09-11 16:55 ` Miquel Raynal
2020-09-01 14:25 ` [PATCH 5/6] mtd: rawnand: marvell: Fix and update kerneldoc Krzysztof Kozlowski
2020-09-11 16:55 ` Miquel Raynal
2020-09-01 14:25 ` [PATCH 6/6] mtd: rawnand: qcom: Simplify with dev_err_probe() Krzysztof Kozlowski
2020-09-11 16:55 ` Miquel Raynal
2020-09-11 16:56 ` [PATCH 1/6] mtd: onenand: " Miquel Raynal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).