* linux-next: build warning after merge of the char-misc.current tree
@ 2020-09-07 23:43 Stephen Rothwell
2020-09-09 12:22 ` Greg KH
0 siblings, 1 reply; 4+ messages in thread
From: Stephen Rothwell @ 2020-09-07 23:43 UTC (permalink / raw)
To: Greg KH, Arnd Bergmann
Cc: Jim Cromie, Linux Next Mailing List, Linux Kernel Mailing List
[-- Attachment #1: Type: text/plain, Size: 1436 bytes --]
Hi all,
After merging the char-misc.current tree, today's linux-next build
(x86_64 allmodconfig) produced this warning:
In file included from include/linux/printk.h:7,
from include/linux/kernel.h:15,
from lib/dynamic_debug.c:16:
lib/dynamic_debug.c: In function 'ddebug_parse_query':
include/linux/kern_levels.h:5:18: warning: format '%s' expects a matching 'char *' argument [-Wformat=]
5 | #define KERN_SOH "\001" /* ASCII Start Of Header */
| ^~~~~~
include/linux/kern_levels.h:14:19: note: in expansion of macro 'KERN_SOH'
14 | #define KERN_INFO KERN_SOH "6" /* informational */
| ^~~~~~~~
include/linux/printk.h:369:9: note: in expansion of macro 'KERN_INFO'
369 | printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~~~
lib/dynamic_debug.c:116:3: note: in expansion of macro 'pr_info'
116 | pr_info(fmt, ##__VA_ARGS__); \
| ^~~~~~~
lib/dynamic_debug.c:119:28: note: in expansion of macro 'vnpr_info'
119 | #define vpr_info(fmt, ...) vnpr_info(1, fmt, ##__VA_ARGS__)
| ^~~~~~~~~
lib/dynamic_debug.c:388:3: note: in expansion of macro 'vpr_info'
388 | vpr_info("module:%s queries:'%s'\n", modname);
| ^~~~~~~~
Introduced by commit
42f07816ac0c ("dyndbg: fix problem parsing format="foo bar"")
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: linux-next: build warning after merge of the char-misc.current tree
2020-09-07 23:43 linux-next: build warning after merge of the char-misc.current tree Stephen Rothwell
@ 2020-09-09 12:22 ` Greg KH
0 siblings, 0 replies; 4+ messages in thread
From: Greg KH @ 2020-09-09 12:22 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Arnd Bergmann, Jim Cromie, Linux Next Mailing List,
Linux Kernel Mailing List
On Tue, Sep 08, 2020 at 09:43:17AM +1000, Stephen Rothwell wrote:
> Hi all,
>
> After merging the char-misc.current tree, today's linux-next build
> (x86_64 allmodconfig) produced this warning:
>
> In file included from include/linux/printk.h:7,
> from include/linux/kernel.h:15,
> from lib/dynamic_debug.c:16:
> lib/dynamic_debug.c: In function 'ddebug_parse_query':
> include/linux/kern_levels.h:5:18: warning: format '%s' expects a matching 'char *' argument [-Wformat=]
> 5 | #define KERN_SOH "\001" /* ASCII Start Of Header */
> | ^~~~~~
> include/linux/kern_levels.h:14:19: note: in expansion of macro 'KERN_SOH'
> 14 | #define KERN_INFO KERN_SOH "6" /* informational */
> | ^~~~~~~~
> include/linux/printk.h:369:9: note: in expansion of macro 'KERN_INFO'
> 369 | printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__)
> | ^~~~~~~~~
> lib/dynamic_debug.c:116:3: note: in expansion of macro 'pr_info'
> 116 | pr_info(fmt, ##__VA_ARGS__); \
> | ^~~~~~~
> lib/dynamic_debug.c:119:28: note: in expansion of macro 'vnpr_info'
> 119 | #define vpr_info(fmt, ...) vnpr_info(1, fmt, ##__VA_ARGS__)
> | ^~~~~~~~~
> lib/dynamic_debug.c:388:3: note: in expansion of macro 'vpr_info'
> 388 | vpr_info("module:%s queries:'%s'\n", modname);
> | ^~~~~~~~
>
> Introduced by commit
>
> 42f07816ac0c ("dyndbg: fix problem parsing format="foo bar"")
Odd it doesn't show up in my builds, or in 0-day :(
Jim, can you send a fix for this, or is this due to some other tree's
issues?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
* linux-next: build warning after merge of the char-misc.current tree
@ 2019-07-22 22:22 Stephen Rothwell
2019-07-22 23:31 ` Mauro Rossi
0 siblings, 1 reply; 4+ messages in thread
From: Stephen Rothwell @ 2019-07-22 22:22 UTC (permalink / raw)
To: Greg KH, Arnd Bergmann
Cc: Linux Next Mailing List, Linux Kernel Mailing List, Mauro Rossi,
Takashi Iwai
[-- Attachment #1: Type: text/plain, Size: 850 bytes --]
Hi all,
After merging the char-misc.current tree, today's linux-next build
(arm multi_v7_defconfig) produced this warning:
In file included from drivers/base/firmware_loader/main.c:41:
drivers/base/firmware_loader/firmware.h:145:12: warning: 'fw_map_paged_buf' defined but not used [-Wunused-function]
static int fw_map_paged_buf(struct fw_priv *fw_priv) { return -ENXIO; }
^~~~~~~~~~~~~~~~
drivers/base/firmware_loader/firmware.h:144:12: warning: 'fw_grow_paged_buf' defined but not used [-Wunused-function]
static int fw_grow_paged_buf(struct fw_priv *fw_priv, int pages_needed) { return -ENXIO; }
^~~~~~~~~~~~~~~~~
Introduced by commit
c8917b8ff09e ("firmware: fix build errors in paged buffer handling code")
These need to be inline (as well as static) ... :-(
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: linux-next: build warning after merge of the char-misc.current tree
2019-07-22 22:22 Stephen Rothwell
@ 2019-07-22 23:31 ` Mauro Rossi
0 siblings, 0 replies; 4+ messages in thread
From: Mauro Rossi @ 2019-07-22 23:31 UTC (permalink / raw)
To: Stephen Rothwell, Takashi Iwai
Cc: Greg KH, Arnd Bergmann, Linux Next Mailing List,
Linux Kernel Mailing List
On Tue, Jul 23, 2019 at 12:23 AM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> After merging the char-misc.current tree, today's linux-next build
> (arm multi_v7_defconfig) produced this warning:
>
> In file included from drivers/base/firmware_loader/main.c:41:
> drivers/base/firmware_loader/firmware.h:145:12: warning: 'fw_map_paged_buf' defined but not used [-Wunused-function]
> static int fw_map_paged_buf(struct fw_priv *fw_priv) { return -ENXIO; }
> ^~~~~~~~~~~~~~~~
> drivers/base/firmware_loader/firmware.h:144:12: warning: 'fw_grow_paged_buf' defined but not used [-Wunused-function]
> static int fw_grow_paged_buf(struct fw_priv *fw_priv, int pages_needed) { return -ENXIO; }
> ^~~~~~~~~~~~~~~~~
>
> Introduced by commit
>
> c8917b8ff09e ("firmware: fix build errors in paged buffer handling code")
>
> These need to be inline (as well as static) ... :-(
>
> --
> Cheers,
> Stephen Rothwell
They were 'static inline' in the patch I have submitted for review
when I reported the problem, but it was luck I am an hobbyst, not a
professional coder.
I checked with Takashi and Greg, because I noticed the inline removed
in the post review commit
and Takashi was checking if inline was really needed, now it's confirmed.
No big issue, now the important thing is that inline is added,
please Takashi kindly confirm when it's done.
Mauro
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-09-09 12:34 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-07 23:43 linux-next: build warning after merge of the char-misc.current tree Stephen Rothwell
2020-09-09 12:22 ` Greg KH
-- strict thread matches above, loose matches on Subject: below --
2019-07-22 22:22 Stephen Rothwell
2019-07-22 23:31 ` Mauro Rossi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).