* [PATCH] drm/imx/dcss: fix compilation issue on 32bit
@ 2020-09-10 9:52 Laurentiu Palcu
2020-09-10 9:57 ` Daniel Vetter
0 siblings, 1 reply; 5+ messages in thread
From: Laurentiu Palcu @ 2020-09-10 9:52 UTC (permalink / raw)
To: Lucas Stach, Philipp Zabel, David Airlie, Daniel Vetter,
Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
NXP Linux Team
Cc: laurentiu.palcu, dri-devel, linux-arm-kernel, linux-kernel
When compiling for 32bit platforms, the compilation fails with:
ERROR: modpost: "__aeabi_ldivmod"
[drivers/gpu/drm/imx/dcss/imx-dcss.ko] undefined!
ERROR: modpost: "__aeabi_uldivmod"
[drivers/gpu/drm/imx/dcss/imx-dcss.ko] undefined!
This patch adds a dependency on ARM64 since no 32bit SoCs have DCSS, so far.
Signed-off-by: Laurentiu Palcu <laurentiu.palcu@oss.nxp.com>
Reported-by: Daniel Vetter <daniel@ffwll.ch>
---
drivers/gpu/drm/imx/dcss/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/imx/dcss/Kconfig b/drivers/gpu/drm/imx/dcss/Kconfig
index 69860de8861f..2b17a964ff05 100644
--- a/drivers/gpu/drm/imx/dcss/Kconfig
+++ b/drivers/gpu/drm/imx/dcss/Kconfig
@@ -3,7 +3,7 @@ config DRM_IMX_DCSS
select IMX_IRQSTEER
select DRM_KMS_CMA_HELPER
select VIDEOMODE_HELPERS
- depends on DRM && ARCH_MXC
+ depends on DRM && ARCH_MXC && ARM64
help
Choose this if you have a NXP i.MX8MQ based system and want to use the
Display Controller Subsystem. This option enables DCSS support.
--
2.17.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/imx/dcss: fix compilation issue on 32bit
2020-09-10 9:52 [PATCH] drm/imx/dcss: fix compilation issue on 32bit Laurentiu Palcu
@ 2020-09-10 9:57 ` Daniel Vetter
2020-09-10 10:21 ` Laurentiu Palcu
0 siblings, 1 reply; 5+ messages in thread
From: Daniel Vetter @ 2020-09-10 9:57 UTC (permalink / raw)
To: Laurentiu Palcu
Cc: Lucas Stach, Philipp Zabel, David Airlie, Shawn Guo,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
NXP Linux Team, dri-devel, Linux ARM, Linux Kernel Mailing List
On Thu, Sep 10, 2020 at 11:53 AM Laurentiu Palcu
<laurentiu.palcu@oss.nxp.com> wrote:
>
> When compiling for 32bit platforms, the compilation fails with:
>
> ERROR: modpost: "__aeabi_ldivmod"
> [drivers/gpu/drm/imx/dcss/imx-dcss.ko] undefined!
> ERROR: modpost: "__aeabi_uldivmod"
> [drivers/gpu/drm/imx/dcss/imx-dcss.ko] undefined!
>
> This patch adds a dependency on ARM64 since no 32bit SoCs have DCSS, so far.
Usual way to fix this correctly is using the right division macros,
not limiting the driver to 64bit. But this works for now, would be
good to fix this properly for compile-testing and all that.
> Signed-off-by: Laurentiu Palcu <laurentiu.palcu@oss.nxp.com>
> Reported-by: Daniel Vetter <daniel@ffwll.ch>
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Please push to drm-misc-next.
-Daniel
---
> drivers/gpu/drm/imx/dcss/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/imx/dcss/Kconfig b/drivers/gpu/drm/imx/dcss/Kconfig
> index 69860de8861f..2b17a964ff05 100644
> --- a/drivers/gpu/drm/imx/dcss/Kconfig
> +++ b/drivers/gpu/drm/imx/dcss/Kconfig
> @@ -3,7 +3,7 @@ config DRM_IMX_DCSS
> select IMX_IRQSTEER
> select DRM_KMS_CMA_HELPER
> select VIDEOMODE_HELPERS
> - depends on DRM && ARCH_MXC
> + depends on DRM && ARCH_MXC && ARM64
> help
> Choose this if you have a NXP i.MX8MQ based system and want to use the
> Display Controller Subsystem. This option enables DCSS support.
> --
> 2.17.1
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/imx/dcss: fix compilation issue on 32bit
2020-09-10 9:57 ` Daniel Vetter
@ 2020-09-10 10:21 ` Laurentiu Palcu
2020-09-10 10:24 ` Lucas Stach
0 siblings, 1 reply; 5+ messages in thread
From: Laurentiu Palcu @ 2020-09-10 10:21 UTC (permalink / raw)
To: Daniel Vetter
Cc: Lucas Stach, Philipp Zabel, David Airlie, Shawn Guo,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
NXP Linux Team, dri-devel, Linux ARM, Linux Kernel Mailing List
On Thu, Sep 10, 2020 at 11:57:10AM +0200, Daniel Vetter wrote:
> On Thu, Sep 10, 2020 at 11:53 AM Laurentiu Palcu
> <laurentiu.palcu@oss.nxp.com> wrote:
> >
> > When compiling for 32bit platforms, the compilation fails with:
> >
> > ERROR: modpost: "__aeabi_ldivmod"
> > [drivers/gpu/drm/imx/dcss/imx-dcss.ko] undefined!
> > ERROR: modpost: "__aeabi_uldivmod"
> > [drivers/gpu/drm/imx/dcss/imx-dcss.ko] undefined!
> >
> > This patch adds a dependency on ARM64 since no 32bit SoCs have DCSS, so far.
>
> Usual way to fix this correctly is using the right division macros,
> not limiting the driver to 64bit. But this works for now, would be
> good to fix this properly for compile-testing and all that.
I didn't see the point in using the macros since this is running only on
64bit. Though I will probably revisit it and fix it properly in a
subsequent patch.
>
> > Signed-off-by: Laurentiu Palcu <laurentiu.palcu@oss.nxp.com>
> > Reported-by: Daniel Vetter <daniel@ffwll.ch>
>
> Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
>
> Please push to drm-misc-next.
About that, I may need some help pushing it. Apparently, my request for
a legacy SSH account for contributing to drm-misc got stalled:
https://gitlab.freedesktop.org/freedesktop/freedesktop/-/issues/289
Thanks,
laurentiu
> -Daniel
>
>
>
> ---
> > drivers/gpu/drm/imx/dcss/Kconfig | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/imx/dcss/Kconfig b/drivers/gpu/drm/imx/dcss/Kconfig
> > index 69860de8861f..2b17a964ff05 100644
> > --- a/drivers/gpu/drm/imx/dcss/Kconfig
> > +++ b/drivers/gpu/drm/imx/dcss/Kconfig
> > @@ -3,7 +3,7 @@ config DRM_IMX_DCSS
> > select IMX_IRQSTEER
> > select DRM_KMS_CMA_HELPER
> > select VIDEOMODE_HELPERS
> > - depends on DRM && ARCH_MXC
> > + depends on DRM && ARCH_MXC && ARM64
> > help
> > Choose this if you have a NXP i.MX8MQ based system and want to use the
> > Display Controller Subsystem. This option enables DCSS support.
> > --
> > 2.17.1
> >
>
>
> --
> Daniel Vetter
> Software Engineer, Intel Corporation
> http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/imx/dcss: fix compilation issue on 32bit
2020-09-10 10:21 ` Laurentiu Palcu
@ 2020-09-10 10:24 ` Lucas Stach
2020-09-10 10:28 ` Laurentiu Palcu
0 siblings, 1 reply; 5+ messages in thread
From: Lucas Stach @ 2020-09-10 10:24 UTC (permalink / raw)
To: Laurentiu Palcu, Daniel Vetter
Cc: Philipp Zabel, David Airlie, Shawn Guo, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, NXP Linux Team,
dri-devel, Linux ARM, Linux Kernel Mailing List
On Do, 2020-09-10 at 13:21 +0300, Laurentiu Palcu wrote:
> On Thu, Sep 10, 2020 at 11:57:10AM +0200, Daniel Vetter wrote:
> > On Thu, Sep 10, 2020 at 11:53 AM Laurentiu Palcu
> > <laurentiu.palcu@oss.nxp.com> wrote:
> > > When compiling for 32bit platforms, the compilation fails with:
> > >
> > > ERROR: modpost: "__aeabi_ldivmod"
> > > [drivers/gpu/drm/imx/dcss/imx-dcss.ko] undefined!
> > > ERROR: modpost: "__aeabi_uldivmod"
> > > [drivers/gpu/drm/imx/dcss/imx-dcss.ko] undefined!
> > >
> > > This patch adds a dependency on ARM64 since no 32bit SoCs have DCSS, so far.
> >
> > Usual way to fix this correctly is using the right division macros,
> > not limiting the driver to 64bit. But this works for now, would be
> > good to fix this properly for compile-testing and all that.
>
> I didn't see the point in using the macros since this is running only on
> 64bit. Though I will probably revisit it and fix it properly in a
> subsequent patch.
>
> > > Signed-off-by: Laurentiu Palcu <laurentiu.palcu@oss.nxp.com>
> > > Reported-by: Daniel Vetter <daniel@ffwll.ch>
> >
> > Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> >
> > Please push to drm-misc-next.
>
> About that, I may need some help pushing it.
I've already pushed a few minutes ago, so we don't disturb the build
tests any longer.
Regards,
Lucas
> Apparently, my request for
> a legacy SSH account for contributing to drm-misc got stalled:
>
> https://gitlab.freedesktop.org/freedesktop/freedesktop/-/issues/289
>
> Thanks,
> laurentiu
>
> > -Daniel
> >
> >
> >
> > ---
> > > drivers/gpu/drm/imx/dcss/Kconfig | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/gpu/drm/imx/dcss/Kconfig b/drivers/gpu/drm/imx/dcss/Kconfig
> > > index 69860de8861f..2b17a964ff05 100644
> > > --- a/drivers/gpu/drm/imx/dcss/Kconfig
> > > +++ b/drivers/gpu/drm/imx/dcss/Kconfig
> > > @@ -3,7 +3,7 @@ config DRM_IMX_DCSS
> > > select IMX_IRQSTEER
> > > select DRM_KMS_CMA_HELPER
> > > select VIDEOMODE_HELPERS
> > > - depends on DRM && ARCH_MXC
> > > + depends on DRM && ARCH_MXC && ARM64
> > > help
> > > Choose this if you have a NXP i.MX8MQ based system and want to use the
> > > Display Controller Subsystem. This option enables DCSS support.
> > > --
> > > 2.17.1
> > >
> >
> > --
> > Daniel Vetter
> > Software Engineer, Intel Corporation
> > http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/imx/dcss: fix compilation issue on 32bit
2020-09-10 10:24 ` Lucas Stach
@ 2020-09-10 10:28 ` Laurentiu Palcu
0 siblings, 0 replies; 5+ messages in thread
From: Laurentiu Palcu @ 2020-09-10 10:28 UTC (permalink / raw)
To: Lucas Stach
Cc: Daniel Vetter, Philipp Zabel, David Airlie, Shawn Guo,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
NXP Linux Team, dri-devel, Linux ARM, Linux Kernel Mailing List
Hi Lucas,
On Thu, Sep 10, 2020 at 12:24:44PM +0200, Lucas Stach wrote:
> On Do, 2020-09-10 at 13:21 +0300, Laurentiu Palcu wrote:
> > On Thu, Sep 10, 2020 at 11:57:10AM +0200, Daniel Vetter wrote:
> > > On Thu, Sep 10, 2020 at 11:53 AM Laurentiu Palcu
> > > <laurentiu.palcu@oss.nxp.com> wrote:
> > > > When compiling for 32bit platforms, the compilation fails with:
> > > >
> > > > ERROR: modpost: "__aeabi_ldivmod"
> > > > [drivers/gpu/drm/imx/dcss/imx-dcss.ko] undefined!
> > > > ERROR: modpost: "__aeabi_uldivmod"
> > > > [drivers/gpu/drm/imx/dcss/imx-dcss.ko] undefined!
> > > >
> > > > This patch adds a dependency on ARM64 since no 32bit SoCs have DCSS, so far.
> > >
> > > Usual way to fix this correctly is using the right division macros,
> > > not limiting the driver to 64bit. But this works for now, would be
> > > good to fix this properly for compile-testing and all that.
> >
> > I didn't see the point in using the macros since this is running only on
> > 64bit. Though I will probably revisit it and fix it properly in a
> > subsequent patch.
> >
> > > > Signed-off-by: Laurentiu Palcu <laurentiu.palcu@oss.nxp.com>
> > > > Reported-by: Daniel Vetter <daniel@ffwll.ch>
> > >
> > > Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> > >
> > > Please push to drm-misc-next.
> >
> > About that, I may need some help pushing it.
>
> I've already pushed a few minutes ago, so we don't disturb the build
> tests any longer.
Thanks a lot,
laurentiu
>
> Regards,
> Lucas
>
> > Apparently, my request for
> > a legacy SSH account for contributing to drm-misc got stalled:
> >
> > https://gitlab.freedesktop.org/freedesktop/freedesktop/-/issues/289
> >
> > Thanks,
> > laurentiu
> >
> > > -Daniel
> > >
> > >
> > >
> > > ---
> > > > drivers/gpu/drm/imx/dcss/Kconfig | 2 +-
> > > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > > >
> > > > diff --git a/drivers/gpu/drm/imx/dcss/Kconfig b/drivers/gpu/drm/imx/dcss/Kconfig
> > > > index 69860de8861f..2b17a964ff05 100644
> > > > --- a/drivers/gpu/drm/imx/dcss/Kconfig
> > > > +++ b/drivers/gpu/drm/imx/dcss/Kconfig
> > > > @@ -3,7 +3,7 @@ config DRM_IMX_DCSS
> > > > select IMX_IRQSTEER
> > > > select DRM_KMS_CMA_HELPER
> > > > select VIDEOMODE_HELPERS
> > > > - depends on DRM && ARCH_MXC
> > > > + depends on DRM && ARCH_MXC && ARM64
> > > > help
> > > > Choose this if you have a NXP i.MX8MQ based system and want to use the
> > > > Display Controller Subsystem. This option enables DCSS support.
> > > > --
> > > > 2.17.1
> > > >
> > >
> > > --
> > > Daniel Vetter
> > > Software Engineer, Intel Corporation
> > > http://blog.ffwll.ch
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-09-10 10:28 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-10 9:52 [PATCH] drm/imx/dcss: fix compilation issue on 32bit Laurentiu Palcu
2020-09-10 9:57 ` Daniel Vetter
2020-09-10 10:21 ` Laurentiu Palcu
2020-09-10 10:24 ` Lucas Stach
2020-09-10 10:28 ` Laurentiu Palcu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).