From: David Brazdil <dbrazdil@google.com>
To: "H. Nikolaus Schaller" <hns@goldelico.com>
Cc: Sasha Levin <sashal@kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Marc Zyngier <maz@kernel.org>
Subject: Re: [BUG]: KVM: arm64: Fix symbol dependency in __hyp_call_panic_nvhe
Date: Mon, 14 Sep 2020 14:36:26 +0100 [thread overview]
Message-ID: <20200914133626.hlsvu5kces3wsirr@google.com> (raw)
In-Reply-To: <3FB315D0-C65D-49C0-A632-6E103F1D02B7@goldelico.com>
Hi Nikolaus,
> > Right, it got moved around in upstream.
>
> Maybe this has fixed something...
>
Thanks for reporting this. I've managed to reproduce the problem with Linaro
GCC 4.9.4 and I can also confirm that the same toolchain builds v5.9-rc5 fine.
As Sasha pointed out, the patch was part of a larger series that ended up
moving the definition of __hyp_panic_string to a different source file. That
means in 5.8.7 switch.c sees it declared as 'static const char[]' but in
5.9 it is declared as 'extern const char[]'. When changed to 'extern', 5.8.7
compiles fine so this sounds to me like a bug in GCC that has since been fixed.
That means we have two options:
(a) define __hyp_panic_string in a different .c file in all pre-5.9 branches, or
(b) revert the backported patch.
The patch was needed in 5.9 and should stay there. It wasn't needed in earlier
versions because the symbol was being kept alive by another user. It did "fix"
the inline asm semantics, but the problem was never triggered in pre-5.9.
Sasha, with this and the GCC bug in mind, would you agree that (b) is the
better course of action?
-David
next prev parent reply other threads:[~2020-09-14 13:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-07 13:29 [BUG]: KVM: arm64: Fix symbol dependency in __hyp_call_panic_nvhe H. Nikolaus Schaller
2020-09-07 14:22 ` Sasha Levin
2020-09-07 14:42 ` H. Nikolaus Schaller
2020-09-14 13:36 ` David Brazdil [this message]
2021-01-25 20:07 ` Oliver Upton
2021-01-25 20:56 ` Marc Zyngier
2021-01-26 18:23 ` Oliver Upton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200914133626.hlsvu5kces3wsirr@google.com \
--to=dbrazdil@google.com \
--cc=hns@goldelico.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maz@kernel.org \
--cc=sashal@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).