linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "H. Nikolaus Schaller" <hns@goldelico.com>
To: Sasha Levin <sashal@kernel.org>
Cc: David Brazdil <dbrazdil@google.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Marc Zyngier <maz@kernel.org>
Subject: Re: [BUG]: KVM: arm64: Fix symbol dependency in __hyp_call_panic_nvhe
Date: Mon, 7 Sep 2020 16:42:02 +0200	[thread overview]
Message-ID: <3FB315D0-C65D-49C0-A632-6E103F1D02B7@goldelico.com> (raw)
In-Reply-To: <20200907142206.GL8670@sasha-vm>

Hi,

> Am 07.09.2020 um 16:22 schrieb Sasha Levin <sashal@kernel.org>:
> 
> On Mon, Sep 07, 2020 at 03:29:40PM +0200, H. Nikolaus Schaller wrote:
>> Hi,
>> it seems as if your patch
>> 
>> 34f379956e9d7 ("KVM: arm64: Fix symbol dependency in __hyp_call_panic_nvhe")
>> [ Upstream commit b38b298aa4397e2dc74a89b4dd3eac9e59b64c96 ]
>> 
>> fails to compile in v5.8.7 for me (using an aarch64 gcc 4.9 cross-toolchain to try
>> to build a kernel for the PinePhone):
>> 
>> CC      arch/arm64/kvm/hyp/switch.o - due to target missing
>> arch/arm64/kvm/hyp/switch.c: In function 'hyp_panic':
>> arch/arm64/kvm/hyp/switch.c:904:2: error: impossible constraint in 'asm'
>> asm volatile("ldr %0, =%1" : "=r" (str_va) : "S" (__hyp_panic_string));
>> ^
> 
> Does upstream build correctly for you?

It is 100% upstream code in arch/arm64, just with a private config.
diff --stat arch/arm64 shows only 2 dts and 2 config files. It did
compile well with v5.8.5 and just broke after merge v5.8.7.

> 
>> I can find the commit b38b298aa4397e2dc74a89b4dd3eac9e59b64c96 in upstream
>> but not the affected file. There is also "KVM: arm64: Split hyp/switch.c to VHE/nVHE"
>> which does a cleanup and rename and v5.9-rc4 compiles fine.
> 
> Right, it got moved around in upstream.

Maybe this has fixed something...

BR and thanks,
Nikolaus


  reply	other threads:[~2020-09-07 14:52 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-07 13:29 [BUG]: KVM: arm64: Fix symbol dependency in __hyp_call_panic_nvhe H. Nikolaus Schaller
2020-09-07 14:22 ` Sasha Levin
2020-09-07 14:42   ` H. Nikolaus Schaller [this message]
2020-09-14 13:36     ` David Brazdil
2021-01-25 20:07       ` Oliver Upton
2021-01-25 20:56         ` Marc Zyngier
2021-01-26 18:23           ` Oliver Upton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3FB315D0-C65D-49C0-A632-6E103F1D02B7@goldelico.com \
    --to=hns@goldelico.com \
    --cc=dbrazdil@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maz@kernel.org \
    --cc=sashal@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).