* [PATCH] IB/rxe: fix kconfig dependency warning for RDMA_RXE
@ 2020-09-15 10:16 Necip Fazil Yildiran
2020-09-15 10:59 ` Leon Romanovsky
2020-09-15 11:23 ` Jason Gunthorpe
0 siblings, 2 replies; 4+ messages in thread
From: Necip Fazil Yildiran @ 2020-09-15 10:16 UTC (permalink / raw)
To: dledford; +Cc: jgg, linux-rdma, linux-kernel, paul, jeho, Necip Fazil Yildiran
When RDMA_RXE is enabled and CRYPTO is disabled, it results in the
following Kbuild warning:
WARNING: unmet direct dependencies detected for CRYPTO_CRC32
Depends on [n]: CRYPTO [=n]
Selected by [y]:
- RDMA_RXE [=y] && (INFINIBAND_USER_ACCESS [=y] || !INFINIBAND_USER_ACCESS [=y]) && INET [=y] && PCI [=y] && INFINIBAND [=y] && (!64BIT || ARCH_DMA_ADDR_T_64BIT [=n])
The reason is that RDMA_RXE selects CRYPTO_CRC32 without depending on or
selecting CRYPTO while CRYPTO_CRC32 is subordinate to CRYPTO.
Honor the kconfig menu hierarchy to remove kconfig dependency warnings.
Fixes: 0812ed132178 ("IB/rxe: Change RDMA_RXE kconfig to use select")
Signed-off-by: Necip Fazil Yildiran <fazilyildiran@gmail.com>
---
drivers/infiniband/sw/rxe/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/infiniband/sw/rxe/Kconfig b/drivers/infiniband/sw/rxe/Kconfig
index a0c6c7dfc181..e1f52710edfc 100644
--- a/drivers/infiniband/sw/rxe/Kconfig
+++ b/drivers/infiniband/sw/rxe/Kconfig
@@ -4,6 +4,7 @@ config RDMA_RXE
depends on INET && PCI && INFINIBAND
depends on !64BIT || ARCH_DMA_ADDR_T_64BIT
select NET_UDP_TUNNEL
+ select CRYPTO
select CRYPTO_CRC32
select DMA_VIRT_OPS
help
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] IB/rxe: fix kconfig dependency warning for RDMA_RXE
2020-09-15 10:16 [PATCH] IB/rxe: fix kconfig dependency warning for RDMA_RXE Necip Fazil Yildiran
@ 2020-09-15 10:59 ` Leon Romanovsky
2020-09-15 11:23 ` Jason Gunthorpe
1 sibling, 0 replies; 4+ messages in thread
From: Leon Romanovsky @ 2020-09-15 10:59 UTC (permalink / raw)
To: Necip Fazil Yildiran; +Cc: dledford, jgg, linux-rdma, linux-kernel, paul, jeho
On Tue, Sep 15, 2020 at 01:16:00PM +0300, Necip Fazil Yildiran wrote:
> When RDMA_RXE is enabled and CRYPTO is disabled, it results in the
> following Kbuild warning:
>
> WARNING: unmet direct dependencies detected for CRYPTO_CRC32
> Depends on [n]: CRYPTO [=n]
> Selected by [y]:
> - RDMA_RXE [=y] && (INFINIBAND_USER_ACCESS [=y] || !INFINIBAND_USER_ACCESS [=y]) && INET [=y] && PCI [=y] && INFINIBAND [=y] && (!64BIT || ARCH_DMA_ADDR_T_64BIT [=n])
>
> The reason is that RDMA_RXE selects CRYPTO_CRC32 without depending on or
> selecting CRYPTO while CRYPTO_CRC32 is subordinate to CRYPTO.
It is not RXE specific issue and almost all users of CRYPTO_* configs
don't select CRYPTO.
There are two possible solutions.
1. Fix crypto/Kconfig to enable CRYPTO.
2. Change "select CRYPTO_CRC32" to be "depends on CRYPTO_CRC32".
Thanks
>
> Honor the kconfig menu hierarchy to remove kconfig dependency warnings.
>
> Fixes: 0812ed132178 ("IB/rxe: Change RDMA_RXE kconfig to use select")
> Signed-off-by: Necip Fazil Yildiran <fazilyildiran@gmail.com>
> ---
> drivers/infiniband/sw/rxe/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/infiniband/sw/rxe/Kconfig b/drivers/infiniband/sw/rxe/Kconfig
> index a0c6c7dfc181..e1f52710edfc 100644
> --- a/drivers/infiniband/sw/rxe/Kconfig
> +++ b/drivers/infiniband/sw/rxe/Kconfig
> @@ -4,6 +4,7 @@ config RDMA_RXE
> depends on INET && PCI && INFINIBAND
> depends on !64BIT || ARCH_DMA_ADDR_T_64BIT
> select NET_UDP_TUNNEL
> + select CRYPTO
> select CRYPTO_CRC32
> select DMA_VIRT_OPS
> help
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] IB/rxe: fix kconfig dependency warning for RDMA_RXE
2020-09-15 10:16 [PATCH] IB/rxe: fix kconfig dependency warning for RDMA_RXE Necip Fazil Yildiran
2020-09-15 10:59 ` Leon Romanovsky
@ 2020-09-15 11:23 ` Jason Gunthorpe
2020-09-15 12:45 ` Necip F. Yıldıran
1 sibling, 1 reply; 4+ messages in thread
From: Jason Gunthorpe @ 2020-09-15 11:23 UTC (permalink / raw)
To: Necip Fazil Yildiran; +Cc: dledford, linux-rdma, linux-kernel, paul, jeho
On Tue, Sep 15, 2020 at 01:16:00PM +0300, Necip Fazil Yildiran wrote:
> When RDMA_RXE is enabled and CRYPTO is disabled, it results in the
> following Kbuild warning:
>
> WARNING: unmet direct dependencies detected for CRYPTO_CRC32
> Depends on [n]: CRYPTO [=n]
> Selected by [y]:
> - RDMA_RXE [=y] && (INFINIBAND_USER_ACCESS [=y] || !INFINIBAND_USER_ACCESS [=y]) && INET [=y] && PCI [=y] && INFINIBAND [=y] && (!64BIT || ARCH_DMA_ADDR_T_64BIT [=n])
?? how did you get here? I thought the kconfig front ends were
supposed to prevent this.
Jason
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] IB/rxe: fix kconfig dependency warning for RDMA_RXE
2020-09-15 11:23 ` Jason Gunthorpe
@ 2020-09-15 12:45 ` Necip F. Yıldıran
0 siblings, 0 replies; 4+ messages in thread
From: Necip F. Yıldıran @ 2020-09-15 12:45 UTC (permalink / raw)
To: Jason Gunthorpe; +Cc: dledford, linux-rdma, linux-kernel, paul, jeho
Steps to reproduce this for v5.9-rc4 on x86 machine (using make.cross [1]
to cross compile for arm64):
1. make.cross ARCH=arm64 allnoconfig
2. make.cross ARCH=arm64 menuconfig
a. Enable NET
b. Enable INET
c. Enable PCI
d. Enable INFINIBAND
e. Enable RDMA_RXE
3. make.cross ARCH=arm64 olddefconfig # WARNING: unmet direct
dependencies detected for CRYPTO_CRC32
[1] https://github.com/fengguang/lkp-tests/blob/master/sbin/make.cross
Thanks
Necip
On Tue, Sep 15, 2020 at 2:23 PM Jason Gunthorpe <jgg@nvidia.com> wrote:
>
> On Tue, Sep 15, 2020 at 01:16:00PM +0300, Necip Fazil Yildiran wrote:
> > When RDMA_RXE is enabled and CRYPTO is disabled, it results in the
> > following Kbuild warning:
> >
> > WARNING: unmet direct dependencies detected for CRYPTO_CRC32
> > Depends on [n]: CRYPTO [=n]
> > Selected by [y]:
> > - RDMA_RXE [=y] && (INFINIBAND_USER_ACCESS [=y] || !INFINIBAND_USER_ACCESS [=y]) && INET [=y] && PCI [=y] && INFINIBAND [=y] && (!64BIT || ARCH_DMA_ADDR_T_64BIT [=n])
>
> ?? how did you get here? I thought the kconfig front ends were
> supposed to prevent this.
>
> Jason
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-09-15 12:55 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-15 10:16 [PATCH] IB/rxe: fix kconfig dependency warning for RDMA_RXE Necip Fazil Yildiran
2020-09-15 10:59 ` Leon Romanovsky
2020-09-15 11:23 ` Jason Gunthorpe
2020-09-15 12:45 ` Necip F. Yıldıran
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).