* [PATCH] ipvs: adjust the debug order of src and dst
@ 2020-09-23 6:06 yue longguang
2020-09-23 12:07 ` Andrew Lunn
0 siblings, 1 reply; 4+ messages in thread
From: yue longguang @ 2020-09-23 6:06 UTC (permalink / raw)
To: wensong, horms, ja, pablo, kadlec, fw, David Miller, kuba,
netdev, lvs-devel, netfilter-devel, coreteam, LKML
From: ylg <bigclouds@163.com>
adjust the debug order of src and dst when tcp state changes
Signed-off-by: ylg <bigclouds@163.com>
---
net/netfilter/ipvs/ip_vs_proto_tcp.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/netfilter/ipvs/ip_vs_proto_tcp.c
b/net/netfilter/ipvs/ip_vs_proto_tcp.c
index dc2e7da2742a..6567eb45a234 100644
--- a/net/netfilter/ipvs/ip_vs_proto_tcp.c
+++ b/net/netfilter/ipvs/ip_vs_proto_tcp.c
@@ -548,10 +548,10 @@ set_tcp_state(struct ip_vs_proto_data *pd,
struct ip_vs_conn *cp,
th->fin ? 'F' : '.',
th->ack ? 'A' : '.',
th->rst ? 'R' : '.',
- IP_VS_DBG_ADDR(cp->daf, &cp->daddr),
- ntohs(cp->dport),
IP_VS_DBG_ADDR(cp->af, &cp->caddr),
ntohs(cp->cport),
+ IP_VS_DBG_ADDR(cp->daf, &cp->daddr),
+ ntohs(cp->dport),
tcp_state_name(cp->state),
tcp_state_name(new_state),
refcount_read(&cp->refcnt));
--
2.20.1 (Apple Git-117)
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] ipvs: adjust the debug order of src and dst
2020-09-23 6:06 [PATCH] ipvs: adjust the debug order of src and dst yue longguang
@ 2020-09-23 12:07 ` Andrew Lunn
0 siblings, 0 replies; 4+ messages in thread
From: Andrew Lunn @ 2020-09-23 12:07 UTC (permalink / raw)
To: yue longguang
Cc: wensong, horms, ja, pablo, kadlec, fw, David Miller, kuba,
netdev, lvs-devel, netfilter-devel, coreteam, LKML
On Wed, Sep 23, 2020 at 02:06:25PM +0800, yue longguang wrote:
> From: ylg <bigclouds@163.com>
>
> adjust the debug order of src and dst when tcp state changes
Hi Yue
You need to explain why you are doing something, not what you are
doing, in the commit message.
Andrew
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] ipvs: adjust the debug order of src and dst
@ 2020-09-23 5:49 longguang.yue
2020-09-24 15:55 ` Simon Horman
0 siblings, 1 reply; 4+ messages in thread
From: longguang.yue @ 2020-09-23 5:49 UTC (permalink / raw)
Cc: ylg, Wensong Zhang, Simon Horman, Julian Anastasov,
Pablo Neira Ayuso, Jozsef Kadlecsik, Florian Westphal,
David S. Miller, Jakub Kicinski, netdev, lvs-devel,
netfilter-devel, coreteam, linux-kernel
From: ylg <bigclouds@163.com>
adjust the debug order of src and dst when tcp state changes
Signed-off-by: ylg <bigclouds@163.com>
---
net/netfilter/ipvs/ip_vs_proto_tcp.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/netfilter/ipvs/ip_vs_proto_tcp.c b/net/netfilter/ipvs/ip_vs_proto_tcp.c
index dc2e7da2742a..6567eb45a234 100644
--- a/net/netfilter/ipvs/ip_vs_proto_tcp.c
+++ b/net/netfilter/ipvs/ip_vs_proto_tcp.c
@@ -548,10 +548,10 @@ set_tcp_state(struct ip_vs_proto_data *pd, struct ip_vs_conn *cp,
th->fin ? 'F' : '.',
th->ack ? 'A' : '.',
th->rst ? 'R' : '.',
- IP_VS_DBG_ADDR(cp->daf, &cp->daddr),
- ntohs(cp->dport),
IP_VS_DBG_ADDR(cp->af, &cp->caddr),
ntohs(cp->cport),
+ IP_VS_DBG_ADDR(cp->daf, &cp->daddr),
+ ntohs(cp->dport),
tcp_state_name(cp->state),
tcp_state_name(new_state),
refcount_read(&cp->refcnt));
--
2.20.1 (Apple Git-117)
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ipvs: adjust the debug order of src and dst
2020-09-23 5:49 longguang.yue
@ 2020-09-24 15:55 ` Simon Horman
0 siblings, 0 replies; 4+ messages in thread
From: Simon Horman @ 2020-09-24 15:55 UTC (permalink / raw)
To: longguang.yue
Cc: Wensong Zhang, Julian Anastasov, Pablo Neira Ayuso,
Jozsef Kadlecsik, Florian Westphal, David S. Miller,
Jakub Kicinski, netdev, lvs-devel, netfilter-devel, coreteam,
linux-kernel
On Wed, Sep 23, 2020 at 01:49:59PM +0800, longguang.yue wrote:
> From: ylg <bigclouds@163.com>
>
> adjust the debug order of src and dst when tcp state changes
>
> Signed-off-by: ylg <bigclouds@163.com>
Hi,
This sounds reasonable to me but please provide your real name
in the Signed-off-by name, which should be consistent with the From field
at the top of the commit message (or, if absent of the email).
Thanks!
> ---
> net/netfilter/ipvs/ip_vs_proto_tcp.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/net/netfilter/ipvs/ip_vs_proto_tcp.c b/net/netfilter/ipvs/ip_vs_proto_tcp.c
> index dc2e7da2742a..6567eb45a234 100644
> --- a/net/netfilter/ipvs/ip_vs_proto_tcp.c
> +++ b/net/netfilter/ipvs/ip_vs_proto_tcp.c
> @@ -548,10 +548,10 @@ set_tcp_state(struct ip_vs_proto_data *pd, struct ip_vs_conn *cp,
> th->fin ? 'F' : '.',
> th->ack ? 'A' : '.',
> th->rst ? 'R' : '.',
> - IP_VS_DBG_ADDR(cp->daf, &cp->daddr),
> - ntohs(cp->dport),
> IP_VS_DBG_ADDR(cp->af, &cp->caddr),
> ntohs(cp->cport),
> + IP_VS_DBG_ADDR(cp->daf, &cp->daddr),
> + ntohs(cp->dport),
> tcp_state_name(cp->state),
> tcp_state_name(new_state),
> refcount_read(&cp->refcnt));
> --
> 2.20.1 (Apple Git-117)
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-09-24 15:55 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-23 6:06 [PATCH] ipvs: adjust the debug order of src and dst yue longguang
2020-09-23 12:07 ` Andrew Lunn
-- strict thread matches above, loose matches on Subject: below --
2020-09-23 5:49 longguang.yue
2020-09-24 15:55 ` Simon Horman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).