* [PATCH 1/8] arm64: dts: ti: k3-j7200-main: Add gpio nodes in main domain
2020-10-01 19:05 [PATCH 0/8] Add support for UHS modes in TI's J721e and J7200 boards Faiz Abbas
@ 2020-10-01 19:05 ` Faiz Abbas
2020-10-01 19:05 ` [PATCH 2/8] arm64: dts: ti: k3-j7200: Add gpio nodes in wakeup domain Faiz Abbas
` (5 subsequent siblings)
6 siblings, 0 replies; 12+ messages in thread
From: Faiz Abbas @ 2020-10-01 19:05 UTC (permalink / raw)
To: linux-kernel, devicetree, linux-arm-kernel
Cc: will, robh+dt, nm, t-kristo, faiz_abbas
There are 4 instances of gpio modules in main domain:
gpio0, gpio2, gpio4 and gpio6
Groups are created to provide protection between different processor virtual
worlds. Each of these modules I/O pins are muxed within the group. Exactly
one module can be selected to control the corresponding pin by selecting it
in the pad mux configuration registers.
This group pins out 69 lines (5 banks).
Add DT modes for each module instance in the main domain.
Signed-off-by: Faiz Abbas <faiz_abbas@ti.com>
---
arch/arm64/boot/dts/ti/k3-j7200-main.dtsi | 68 +++++++++++++++++++++++
1 file changed, 68 insertions(+)
diff --git a/arch/arm64/boot/dts/ti/k3-j7200-main.dtsi b/arch/arm64/boot/dts/ti/k3-j7200-main.dtsi
index 4a4fcd24f852..f21f22237e0f 100644
--- a/arch/arm64/boot/dts/ti/k3-j7200-main.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-j7200-main.dtsi
@@ -395,4 +395,72 @@
no-1-8-v;
dma-coherent;
};
+
+ main_gpio0: gpio@600000 {
+ compatible = "ti,j721e-gpio", "ti,keystone-gpio";
+ reg = <0x00 0x00600000 0x00 0x100>;
+ gpio-controller;
+ #gpio-cells = <2>;
+ interrupt-parent = <&main_gpio_intr>;
+ interrupts = <145>, <146>, <147>, <148>,
+ <149>;
+ interrupt-controller;
+ #interrupt-cells = <2>;
+ ti,ngpio = <69>;
+ ti,davinci-gpio-unbanked = <0>;
+ power-domains = <&k3_pds 105 TI_SCI_PD_EXCLUSIVE>;
+ clocks = <&k3_clks 105 0>;
+ clock-names = "gpio";
+ };
+
+ main_gpio2: gpio@610000 {
+ compatible = "ti,j721e-gpio", "ti,keystone-gpio";
+ reg = <0x00 0x00610000 0x00 0x100>;
+ gpio-controller;
+ #gpio-cells = <2>;
+ interrupt-parent = <&main_gpio_intr>;
+ interrupts = <154>, <155>, <156>, <157>,
+ <158>;
+ interrupt-controller;
+ #interrupt-cells = <2>;
+ ti,ngpio = <69>;
+ ti,davinci-gpio-unbanked = <0>;
+ power-domains = <&k3_pds 107 TI_SCI_PD_EXCLUSIVE>;
+ clocks = <&k3_clks 107 0>;
+ clock-names = "gpio";
+ };
+
+ main_gpio4: gpio@620000 {
+ compatible = "ti,j721e-gpio", "ti,keystone-gpio";
+ reg = <0x00 0x00620000 0x00 0x100>;
+ gpio-controller;
+ #gpio-cells = <2>;
+ interrupt-parent = <&main_gpio_intr>;
+ interrupts = <163>, <164>, <165>, <166>,
+ <167>;
+ interrupt-controller;
+ #interrupt-cells = <2>;
+ ti,ngpio = <69>;
+ ti,davinci-gpio-unbanked = <0>;
+ power-domains = <&k3_pds 109 TI_SCI_PD_EXCLUSIVE>;
+ clocks = <&k3_clks 109 0>;
+ clock-names = "gpio";
+ };
+
+ main_gpio6: gpio@630000 {
+ compatible = "ti,j721e-gpio", "ti,keystone-gpio";
+ reg = <0x00 0x00630000 0x00 0x100>;
+ gpio-controller;
+ #gpio-cells = <2>;
+ interrupt-parent = <&main_gpio_intr>;
+ interrupts = <172>, <173>, <174>, <175>,
+ <176>;
+ interrupt-controller;
+ #interrupt-cells = <2>;
+ ti,ngpio = <69>;
+ ti,davinci-gpio-unbanked = <0>;
+ power-domains = <&k3_pds 111 TI_SCI_PD_EXCLUSIVE>;
+ clocks = <&k3_clks 111 0>;
+ clock-names = "gpio";
+ };
};
--
2.17.1
^ permalink raw reply related [flat|nested] 12+ messages in thread* [PATCH 2/8] arm64: dts: ti: k3-j7200: Add gpio nodes in wakeup domain
2020-10-01 19:05 [PATCH 0/8] Add support for UHS modes in TI's J721e and J7200 boards Faiz Abbas
2020-10-01 19:05 ` [PATCH 1/8] arm64: dts: ti: k3-j7200-main: Add gpio nodes in main domain Faiz Abbas
@ 2020-10-01 19:05 ` Faiz Abbas
2020-10-01 19:05 ` [PATCH 3/8] arm64: dts: ti: k3-j7200-common-proc-board: Disable unused gpio modules Faiz Abbas
` (4 subsequent siblings)
6 siblings, 0 replies; 12+ messages in thread
From: Faiz Abbas @ 2020-10-01 19:05 UTC (permalink / raw)
To: linux-kernel, devicetree, linux-arm-kernel
Cc: will, robh+dt, nm, t-kristo, faiz_abbas
Similar to the gpio groups in main domain, there is one gpio group in
wakeup domain with 2 mdoules instances in it. The gpio group pins out
73 pins (5 banks). Add DT nodes for these 2 gpio module instances.
Signed-off-by: Faiz Abbas <faiz_abbas@ti.com>
---
.../boot/dts/ti/k3-j7200-mcu-wakeup.dtsi | 32 +++++++++++++++++++
1 file changed, 32 insertions(+)
diff --git a/arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi
index eb2a78a53512..5ee64d4ee41f 100644
--- a/arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi
@@ -107,6 +107,38 @@
ti,interrupt-ranges = <16 960 16>;
};
+ wkup_gpio0: gpio@42110000 {
+ compatible = "ti,j721e-gpio", "ti,keystone-gpio";
+ reg = <0x00 0x42110000 0x00 0x100>;
+ gpio-controller;
+ #gpio-cells = <2>;
+ interrupt-parent = <&wkup_gpio_intr>;
+ interrupts = <103>, <104>, <105>, <106>, <107>, <108>;
+ interrupt-controller;
+ #interrupt-cells = <2>;
+ ti,ngpio = <73>;
+ ti,davinci-gpio-unbanked = <0>;
+ power-domains = <&k3_pds 113 TI_SCI_PD_EXCLUSIVE>;
+ clocks = <&k3_clks 113 0>;
+ clock-names = "gpio";
+ };
+
+ wkup_gpio1: gpio@42100000 {
+ compatible = "ti,j721e-gpio", "ti,keystone-gpio";
+ reg = <0x00 0x42100000 0x00 0x100>;
+ gpio-controller;
+ #gpio-cells = <2>;
+ interrupt-parent = <&wkup_gpio_intr>;
+ interrupts = <112>, <113>, <114>, <115>, <116>, <117>;
+ interrupt-controller;
+ #interrupt-cells = <2>;
+ ti,ngpio = <73>;
+ ti,davinci-gpio-unbanked = <0>;
+ power-domains = <&k3_pds 114 TI_SCI_PD_EXCLUSIVE>;
+ clocks = <&k3_clks 114 0>;
+ clock-names = "gpio";
+ };
+
mcu_navss: bus@28380000 {
compatible = "simple-mfd";
#address-cells = <2>;
--
2.17.1
^ permalink raw reply related [flat|nested] 12+ messages in thread* [PATCH 3/8] arm64: dts: ti: k3-j7200-common-proc-board: Disable unused gpio modules
2020-10-01 19:05 [PATCH 0/8] Add support for UHS modes in TI's J721e and J7200 boards Faiz Abbas
2020-10-01 19:05 ` [PATCH 1/8] arm64: dts: ti: k3-j7200-main: Add gpio nodes in main domain Faiz Abbas
2020-10-01 19:05 ` [PATCH 2/8] arm64: dts: ti: k3-j7200: Add gpio nodes in wakeup domain Faiz Abbas
@ 2020-10-01 19:05 ` Faiz Abbas
2020-10-01 19:05 ` [PATCH 4/8] arm64: dts: ti: k3-j721e-main: Add output tap delay values Faiz Abbas
` (3 subsequent siblings)
6 siblings, 0 replies; 12+ messages in thread
From: Faiz Abbas @ 2020-10-01 19:05 UTC (permalink / raw)
To: linux-kernel, devicetree, linux-arm-kernel
Cc: will, robh+dt, nm, t-kristo, faiz_abbas
There are 6 gpio instances inside SoC with 2 groups as show below:
Group one: wkup_gpio0, wkup_gpio1
Group two: main_gpio0, main_gpio2, main_gpio4, main_gpio6
Only one instance from each group can be used at a time. So use main_gpio0
and wkup_gpio0 in current linux context and disable the rest of the nodes.
Signed-off-by: Faiz Abbas <faiz_abbas@ti.com>
---
.../boot/dts/ti/k3-j7200-common-proc-board.dts | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
diff --git a/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts b/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts
index 1541311cecb4..50d330245a42 100644
--- a/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts
+++ b/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts
@@ -120,6 +120,22 @@
status = "disabled";
};
+&main_gpio2 {
+ status = "disabled";
+};
+
+&main_gpio4 {
+ status = "disabled";
+};
+
+&main_gpio6 {
+ status = "disabled";
+};
+
+&wkup_gpio1 {
+ status = "disabled";
+};
+
&mcu_cpsw {
pinctrl-names = "default";
pinctrl-0 = <&mcu_cpsw_pins_default &mcu_mdio_pins_default>;
--
2.17.1
^ permalink raw reply related [flat|nested] 12+ messages in thread* [PATCH 4/8] arm64: dts: ti: k3-j721e-main: Add output tap delay values
2020-10-01 19:05 [PATCH 0/8] Add support for UHS modes in TI's J721e and J7200 boards Faiz Abbas
` (2 preceding siblings ...)
2020-10-01 19:05 ` [PATCH 3/8] arm64: dts: ti: k3-j7200-common-proc-board: Disable unused gpio modules Faiz Abbas
@ 2020-10-01 19:05 ` Faiz Abbas
2020-10-01 19:05 ` [PATCH 5/8] arm64: dts: ti: k3-j721e-common-proc-board: Add support SD card UHS modes Faiz Abbas
` (2 subsequent siblings)
6 siblings, 0 replies; 12+ messages in thread
From: Faiz Abbas @ 2020-10-01 19:05 UTC (permalink / raw)
To: linux-kernel, devicetree, linux-arm-kernel
Cc: will, robh+dt, nm, t-kristo, faiz_abbas
Add output tap delay values as given in the latest Data Manual[1].
[1] https://www.ti.com/lit/gpn/tda4vm
Signed-off-by: Faiz Abbas <faiz_abbas@ti.com>
---
arch/arm64/boot/dts/ti/k3-j721e-main.dtsi | 20 +++++++++++++++++---
1 file changed, 17 insertions(+), 3 deletions(-)
diff --git a/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi b/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi
index e2a96b2c423c..630b195cbc8a 100644
--- a/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi
@@ -1081,7 +1081,11 @@
bus-width = <8>;
mmc-hs400-1_8v;
mmc-ddr-1_8v;
- ti,otap-del-sel = <0x2>;
+ ti,otap-del-sel-legacy = <0xf>;
+ ti,otap-del-sel-mmc-hs = <0xf>;
+ ti,otap-del-sel-ddr52 = <0x5>;
+ ti,otap-del-sel-hs200 = <0x6>;
+ ti,otap-del-sel-hs400 = <0x0>;
ti,trm-icp = <0x8>;
ti,strobe-sel = <0x77>;
dma-coherent;
@@ -1096,7 +1100,12 @@
clocks = <&k3_clks 92 0>, <&k3_clks 92 5>;
assigned-clocks = <&k3_clks 92 0>;
assigned-clock-parents = <&k3_clks 92 1>;
- ti,otap-del-sel = <0x2>;
+ ti,otap-del-sel-legacy = <0x0>;
+ ti,otap-del-sel-sd-hs = <0xf>;
+ ti,otap-del-sel-sdr12 = <0xf>;
+ ti,otap-del-sel-sdr25 = <0xf>;
+ ti,otap-del-sel-sdr50 = <0xc>;
+ ti,otap-del-sel-ddr50 = <0xc>;
ti,trm-icp = <0x8>;
ti,clkbuf-sel = <0x7>;
dma-coherent;
@@ -1112,7 +1121,12 @@
clocks = <&k3_clks 93 0>, <&k3_clks 93 5>;
assigned-clocks = <&k3_clks 93 0>;
assigned-clock-parents = <&k3_clks 93 1>;
- ti,otap-del-sel = <0x2>;
+ ti,otap-del-sel-legacy = <0x0>;
+ ti,otap-del-sel-sd-hs = <0xf>;
+ ti,otap-del-sel-sdr12 = <0xf>;
+ ti,otap-del-sel-sdr25 = <0xf>;
+ ti,otap-del-sel-sdr50 = <0xc>;
+ ti,otap-del-sel-ddr50 = <0xc>;
ti,trm-icp = <0x8>;
ti,clkbuf-sel = <0x7>;
dma-coherent;
--
2.17.1
^ permalink raw reply related [flat|nested] 12+ messages in thread* [PATCH 5/8] arm64: dts: ti: k3-j721e-common-proc-board: Add support SD card UHS modes
2020-10-01 19:05 [PATCH 0/8] Add support for UHS modes in TI's J721e and J7200 boards Faiz Abbas
` (3 preceding siblings ...)
2020-10-01 19:05 ` [PATCH 4/8] arm64: dts: ti: k3-j721e-main: Add output tap delay values Faiz Abbas
@ 2020-10-01 19:05 ` Faiz Abbas
2020-10-01 19:05 ` [PATCH 6/8] arm64: dts: ti: k3-j7200-common-proc-board: " Faiz Abbas
2020-10-01 19:13 ` [PATCH 0/8] Add support for UHS modes in TI's J721e and J7200 boards Nishanth Menon
6 siblings, 0 replies; 12+ messages in thread
From: Faiz Abbas @ 2020-10-01 19:05 UTC (permalink / raw)
To: linux-kernel, devicetree, linux-arm-kernel
Cc: will, robh+dt, nm, t-kristo, faiz_abbas
Add support for UHS modes for the SD card connected at sdhci1. This
involves adding regulators for voltage switching and power cycling the
SD card and removing the no-1-8-v property.
Signed-off-by: Faiz Abbas <faiz_abbas@ti.com>
---
.../dts/ti/k3-j721e-common-proc-board.dts | 35 ++++++++++++++++++-
arch/arm64/boot/dts/ti/k3-j721e-main.dtsi | 2 --
2 files changed, 34 insertions(+), 3 deletions(-)
diff --git a/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts b/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts
index 52e121155563..0df9e6117b7c 100644
--- a/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts
+++ b/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts
@@ -67,6 +67,31 @@
regulator-boot-on;
};
+ vdd_mmc1: fixedregulator-sd {
+ compatible = "regulator-fixed";
+ regulator-name = "vdd_mmc1";
+ regulator-min-microvolt = <3300000>;
+ regulator-max-microvolt = <3300000>;
+ regulator-boot-on;
+ enable-active-high;
+ vin-supply = <&vsys_3v3>;
+ gpio = <&exp2 2 GPIO_ACTIVE_HIGH>;
+ };
+
+ vdd_sd_dv_alt: gpio-regulator-TLV71033 {
+ compatible = "regulator-gpio";
+ pinctrl-names = "default";
+ pinctrl-0 = <&vdd_sd_dv_alt_pins_default>;
+ regulator-name = "tlv71033";
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <3300000>;
+ regulator-boot-on;
+ vin-supply = <&vsys_5v0>;
+ gpios = <&main_gpio0 117 GPIO_ACTIVE_HIGH>;
+ states = <1800000 0x0
+ 3300000 0x1>;
+ };
+
sound0: sound@0 {
compatible = "ti,j721e-cpb-audio";
model = "j721e-cpb";
@@ -106,7 +131,13 @@
>;
};
- main_usbss0_pins_default: main-usbss0-pins-default {
+ vdd_sd_dv_alt_pins_default: vdd_sd_dv_alt_pins_default {
+ pinctrl-single,pins = <
+ J721E_IOPAD(0x1d8, PIN_INPUT, 7) /* (W4) SPI1_CS1.GPIO0_117 */
+ >;
+ };
+
+ main_usbss0_pins_default: main_usbss0_pins_default {
pinctrl-single,pins = <
J721E_IOPAD(0x290, PIN_OUTPUT, 0) /* (U6) USB0_DRVVBUS */
J721E_IOPAD(0x210, PIN_INPUT, 7) /* (W3) MCAN1_RX.GPIO1_3 */
@@ -295,6 +326,8 @@
&main_sdhci1 {
/* SD/MMC */
+ vmmc-supply = <&vdd_mmc1>;
+ vqmmc-supply = <&vdd_sd_dv_alt>;
pinctrl-names = "default";
pinctrl-0 = <&main_mmc1_pins_default>;
ti,driver-strength-ohm = <50>;
diff --git a/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi b/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi
index 630b195cbc8a..a38d772b8356 100644
--- a/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi
@@ -1109,7 +1109,6 @@
ti,trm-icp = <0x8>;
ti,clkbuf-sel = <0x7>;
dma-coherent;
- no-1-8-v;
};
main_sdhci2: sdhci@4f98000 {
@@ -1130,7 +1129,6 @@
ti,trm-icp = <0x8>;
ti,clkbuf-sel = <0x7>;
dma-coherent;
- no-1-8-v;
};
usbss0: cdns-usb@4104000 {
--
2.17.1
^ permalink raw reply related [flat|nested] 12+ messages in thread* [PATCH 6/8] arm64: dts: ti: k3-j7200-common-proc-board: Add support SD card UHS modes
2020-10-01 19:05 [PATCH 0/8] Add support for UHS modes in TI's J721e and J7200 boards Faiz Abbas
` (4 preceding siblings ...)
2020-10-01 19:05 ` [PATCH 5/8] arm64: dts: ti: k3-j721e-common-proc-board: Add support SD card UHS modes Faiz Abbas
@ 2020-10-01 19:05 ` Faiz Abbas
2020-10-01 19:13 ` [PATCH 0/8] Add support for UHS modes in TI's J721e and J7200 boards Nishanth Menon
6 siblings, 0 replies; 12+ messages in thread
From: Faiz Abbas @ 2020-10-01 19:05 UTC (permalink / raw)
To: linux-kernel, devicetree, linux-arm-kernel
Cc: will, robh+dt, nm, t-kristo, faiz_abbas
Add support for UHS modes for the SD card connected at sdhci1. This
involves adding regulators for voltage switching and power cycling the
SD card and removing the no-1-8-v property.
Signed-off-by: Faiz Abbas <faiz_abbas@ti.com>
---
.../dts/ti/k3-j7200-common-proc-board.dts | 32 +++++++++++++++++++
arch/arm64/boot/dts/ti/k3-j7200-main.dtsi | 1 -
2 files changed, 32 insertions(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts b/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts
index 50d330245a42..02112c2a63e9 100644
--- a/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts
+++ b/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts
@@ -7,12 +7,36 @@
#include "k3-j7200-som-p0.dtsi"
#include <dt-bindings/net/ti-dp83867.h>
+#include <dt-bindings/gpio/gpio.h>
/ {
chosen {
stdout-path = "serial2:115200n8";
bootargs = "console=ttyS2,115200n8 earlycon=ns16550a,mmio32,0x02800000";
};
+
+ vdd_mmc1: fixedregulator-sd {
+ compatible = "regulator-fixed";
+ regulator-name = "vdd_mmc1";
+ regulator-min-microvolt = <3300000>;
+ regulator-max-microvolt = <3300000>;
+ regulator-boot-on;
+ enable-active-high;
+ gpios = <&exp2 2 GPIO_ACTIVE_HIGH>;
+ };
+
+ vdd_sd_dv: gpio-regulator-vdd-sd-dv {
+ compatible = "regulator-gpio";
+ regulator-name = "vdd_sd_dv";
+ pinctrl-names = "default";
+ pinctrl-0 = <&vdd_sd_dv_pins_default>;
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <3300000>;
+ regulator-boot-on;
+ gpios = <&main_gpio0 55 GPIO_ACTIVE_HIGH>;
+ states = <1800000 0x0
+ 3300000 0x1>;
+ };
};
&wkup_pmx0 {
@@ -68,6 +92,12 @@
J721E_IOPAD(0xe4, PIN_INPUT, 8) /* (V1) TIMER_IO0.MMC1_SDCD */
>;
};
+
+ vdd_sd_dv_pins_default: vdd_sd_dv_pins_default {
+ pinctrl-single,pins = <
+ J721E_IOPAD(0xd0, PIN_INPUT, 7) /* (T5) SPI0_D1.GPIO0_55 */
+ >;
+ };
};
&wkup_uart0 {
@@ -196,6 +226,8 @@
&main_sdhci1 {
/* SD card */
+ vmmc-supply = <&vdd_mmc1>;
+ vqmmc-supply = <&vdd_sd_dv>;
pinctrl-0 = <&main_mmc1_pins_default>;
pinctrl-names = "default";
ti,driver-strength-ohm = <50>;
diff --git a/arch/arm64/boot/dts/ti/k3-j7200-main.dtsi b/arch/arm64/boot/dts/ti/k3-j7200-main.dtsi
index f21f22237e0f..7307a94f7f3e 100644
--- a/arch/arm64/boot/dts/ti/k3-j7200-main.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-j7200-main.dtsi
@@ -392,7 +392,6 @@
ti,otap-del-sel-sdr50 = <0xc>;
ti,otap-del-sel-sdr104 = <0x5>;
ti,otap-del-sel-ddr50 = <0xc>;
- no-1-8-v;
dma-coherent;
};
--
2.17.1
^ permalink raw reply related [flat|nested] 12+ messages in thread* Re: [PATCH 0/8] Add support for UHS modes in TI's J721e and J7200 boards
2020-10-01 19:05 [PATCH 0/8] Add support for UHS modes in TI's J721e and J7200 boards Faiz Abbas
` (5 preceding siblings ...)
2020-10-01 19:05 ` [PATCH 6/8] arm64: dts: ti: k3-j7200-common-proc-board: " Faiz Abbas
@ 2020-10-01 19:13 ` Nishanth Menon
2020-10-02 4:44 ` Faiz Abbas
6 siblings, 1 reply; 12+ messages in thread
From: Nishanth Menon @ 2020-10-01 19:13 UTC (permalink / raw)
To: Faiz Abbas
Cc: linux-kernel, devicetree, linux-arm-kernel, will, robh+dt, t-kristo
On 00:35-20201002, Faiz Abbas wrote:
> The following patches add support for UHS modes for TI's j721e and j7200
> boards.
>
> Patches 1-3 add support for gpios to j7200-evm
>
> Patches 4-6 add support for voltage regulators for required by the
> SD card in both devices as well as enable UHS modes at 1.8V
>
> Patches 5-6 add some required configs to the arm64 defconfig.
>
> This series depends on driver patches adding tuning support here:
> https://lore.kernel.org/linux-arm-kernel/20200923105206.7988-1-faiz_abbas@ti.com/
>
> Faiz Abbas (8):
> arm64: dts: ti: k3-j7200-main: Add gpio nodes in main domain
> arm64: dts: ti: k3-j7200: Add gpio nodes in wakeup domain
> arm64: dts: ti: k3-j7200-common-proc-board: Disable unused gpio
> modules
> arm64: dts: ti: k3-j721e-main: Add output tap delay values
> arm64: dts: ti: k3-j721e-common-proc-board: Add support SD card UHS
> modes
> arm64: dts: ti: k3-j7200-common-proc-board: Add support SD card UHS
> modes
Split these up please!
> arm64: defconfig: Enable OMAP I2C driver
> arm64: defconfig: Enable DAVINCI_GPIO driver
>
defconfig patches can be posted independent of dts patches, they go to
different branches.
Also, These are a little too late for 5.10 at this point.
> .../dts/ti/k3-j7200-common-proc-board.dts | 48 +++++++++++++
> arch/arm64/boot/dts/ti/k3-j7200-main.dtsi | 69 ++++++++++++++++++-
> .../boot/dts/ti/k3-j7200-mcu-wakeup.dtsi | 32 +++++++++
> .../dts/ti/k3-j721e-common-proc-board.dts | 35 +++++++++-
> arch/arm64/boot/dts/ti/k3-j721e-main.dtsi | 22 ++++--
> arch/arm64/configs/defconfig | 2 +
> 6 files changed, 201 insertions(+), 7 deletions(-)
>
> --
> 2.17.1
>
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH 0/8] Add support for UHS modes in TI's J721e and J7200 boards
2020-10-01 19:13 ` [PATCH 0/8] Add support for UHS modes in TI's J721e and J7200 boards Nishanth Menon
@ 2020-10-02 4:44 ` Faiz Abbas
2020-10-02 12:49 ` Nishanth Menon
0 siblings, 1 reply; 12+ messages in thread
From: Faiz Abbas @ 2020-10-02 4:44 UTC (permalink / raw)
To: Nishanth Menon
Cc: linux-kernel, devicetree, linux-arm-kernel, will, robh+dt, t-kristo
Hi Nishanth,
On 02/10/20 12:43 am, Nishanth Menon wrote:
> On 00:35-20201002, Faiz Abbas wrote:
>> The following patches add support for UHS modes for TI's j721e and j7200
>> boards.
>>
>> Patches 1-3 add support for gpios to j7200-evm
>>
>> Patches 4-6 add support for voltage regulators for required by the
>> SD card in both devices as well as enable UHS modes at 1.8V
>>
>> Patches 5-6 add some required configs to the arm64 defconfig.
>>
>> This series depends on driver patches adding tuning support here:
>> https://lore.kernel.org/linux-arm-kernel/20200923105206.7988-1-faiz_abbas@ti.com/
>>
>> Faiz Abbas (8):
>> arm64: dts: ti: k3-j7200-main: Add gpio nodes in main domain
>> arm64: dts: ti: k3-j7200: Add gpio nodes in wakeup domain
>> arm64: dts: ti: k3-j7200-common-proc-board: Disable unused gpio
>> modules
>> arm64: dts: ti: k3-j721e-main: Add output tap delay values
>> arm64: dts: ti: k3-j721e-common-proc-board: Add support SD card UHS
>> modes
>> arm64: dts: ti: k3-j7200-common-proc-board: Add support SD card UHS
>> modes
>
> Split these up please!
Into SD card UHS and gpio series?
>> arm64: defconfig: Enable OMAP I2C driver
>> arm64: defconfig: Enable DAVINCI_GPIO driver
>>
>
> defconfig patches can be posted independent of dts patches, they go to
> different branches.
I was trying to follow Arnd's advice here:
https://lore.kernel.org/linux-arm-kernel/CAK8P3a1JpCCCV-CVQj3+eMfWF+=4AuHPpv390Tyj2pKn63_ZVg@mail.gmail.com/
He says that defconfig patches can be sent at the same time as dts updates and maintainers can send those
as separate pull requests.
Thanks,
Faiz
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 0/8] Add support for UHS modes in TI's J721e and J7200 boards
2020-10-02 4:44 ` Faiz Abbas
@ 2020-10-02 12:49 ` Nishanth Menon
2020-10-02 16:09 ` Faiz Abbas
0 siblings, 1 reply; 12+ messages in thread
From: Nishanth Menon @ 2020-10-02 12:49 UTC (permalink / raw)
To: Faiz Abbas
Cc: linux-kernel, devicetree, linux-arm-kernel, will, robh+dt, t-kristo
On 10:14-20201002, Faiz Abbas wrote:
> Hi Nishanth,
>
> On 02/10/20 12:43 am, Nishanth Menon wrote:
> > On 00:35-20201002, Faiz Abbas wrote:
> >> The following patches add support for UHS modes for TI's j721e and j7200
> >> boards.
> >>
> >> Patches 1-3 add support for gpios to j7200-evm
> >>
> >> Patches 4-6 add support for voltage regulators for required by the
> >> SD card in both devices as well as enable UHS modes at 1.8V
> >>
> >> Patches 5-6 add some required configs to the arm64 defconfig.
> >>
> >> This series depends on driver patches adding tuning support here:
> >> https://lore.kernel.org/linux-arm-kernel/20200923105206.7988-1-faiz_abbas@ti.com/
> >>
> >> Faiz Abbas (8):
> >> arm64: dts: ti: k3-j7200-main: Add gpio nodes in main domain
> >> arm64: dts: ti: k3-j7200: Add gpio nodes in wakeup domain
> >> arm64: dts: ti: k3-j7200-common-proc-board: Disable unused gpio
> >> modules
> >> arm64: dts: ti: k3-j721e-main: Add output tap delay values
> >> arm64: dts: ti: k3-j721e-common-proc-board: Add support SD card UHS
> >> modes
> >> arm64: dts: ti: k3-j7200-common-proc-board: Add support SD card UHS
> >> modes
> >
> > Split these up please!
>
> Into SD card UHS and gpio series?
>
> >> arm64: defconfig: Enable OMAP I2C driver
> >> arm64: defconfig: Enable DAVINCI_GPIO driver
> >>
> >
> > defconfig patches can be posted independent of dts patches, they go to
> > different branches.
>
> I was trying to follow Arnd's advice here:
> https://lore.kernel.org/linux-arm-kernel/CAK8P3a1JpCCCV-CVQj3+eMfWF+=4AuHPpv390Tyj2pKn63_ZVg@mail.gmail.com/
>
> He says that defconfig patches can be sent at the same time as dts updates and maintainers can send those
> as separate pull requests.
BTW, [1] your patches 7/8 and 8/8 never hit the mailing list, So, I am
commenting on the defconfig patches without actually seeing the patches,
and solely based on $subject in the cover letter.
The reason for my comment was that I think defconfig series could go
independent of the remaining series into 5.10, since they are not
related specifically to this series, they are probably needed even for
am654 and j721e nodes that already exist and was a miss that we didn't
enable. Tying that to this specific series didn't make sense to me.
But either way, we are way past rc7. I don't have enough time for
these patches to bake in -next to make it to 5.10 window. So, lets try
reposting this after rc1 tag is done so that I can send the defconfig
(separately for 5.10 window) and the dts staged towards 5.11 (and no,
I don't consider the dts patches as fixes - they are enabling the next
level of functionality).
[1] https://lore.kernel.org/linux-arm-kernel/20201001190541.6364-7-faiz_abbas@ti.com/
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 0/8] Add support for UHS modes in TI's J721e and J7200 boards
2020-10-02 12:49 ` Nishanth Menon
@ 2020-10-02 16:09 ` Faiz Abbas
2020-10-26 14:55 ` Nishanth Menon
0 siblings, 1 reply; 12+ messages in thread
From: Faiz Abbas @ 2020-10-02 16:09 UTC (permalink / raw)
To: Nishanth Menon
Cc: linux-kernel, devicetree, linux-arm-kernel, will, robh+dt, t-kristo
Hi Nishanth,
On 02/10/20 6:19 pm, Nishanth Menon wrote:
> On 10:14-20201002, Faiz Abbas wrote:
>> Hi Nishanth,
>>
>> On 02/10/20 12:43 am, Nishanth Menon wrote:
>>> On 00:35-20201002, Faiz Abbas wrote:
>>>> The following patches add support for UHS modes for TI's j721e and j7200
>>>> boards.
>>>>
>>>> Patches 1-3 add support for gpios to j7200-evm
>>>>
>>>> Patches 4-6 add support for voltage regulators for required by the
>>>> SD card in both devices as well as enable UHS modes at 1.8V
>>>>
>>>> Patches 5-6 add some required configs to the arm64 defconfig.
>>>>
>>>> This series depends on driver patches adding tuning support here:
>>>> https://lore.kernel.org/linux-arm-kernel/20200923105206.7988-1-faiz_abbas@ti.com/
>>>>
>>>> Faiz Abbas (8):
>>>> arm64: dts: ti: k3-j7200-main: Add gpio nodes in main domain
>>>> arm64: dts: ti: k3-j7200: Add gpio nodes in wakeup domain
>>>> arm64: dts: ti: k3-j7200-common-proc-board: Disable unused gpio
>>>> modules
>>>> arm64: dts: ti: k3-j721e-main: Add output tap delay values
>>>> arm64: dts: ti: k3-j721e-common-proc-board: Add support SD card UHS
>>>> modes
>>>> arm64: dts: ti: k3-j7200-common-proc-board: Add support SD card UHS
>>>> modes
>>>
>>> Split these up please!
>>
>> Into SD card UHS and gpio series?
>>
>>>> arm64: defconfig: Enable OMAP I2C driver
>>>> arm64: defconfig: Enable DAVINCI_GPIO driver
>>>>
>>>
>>> defconfig patches can be posted independent of dts patches, they go to
>>> different branches.
>>
>> I was trying to follow Arnd's advice here:
>> https://lore.kernel.org/linux-arm-kernel/CAK8P3a1JpCCCV-CVQj3+eMfWF+=4AuHPpv390Tyj2pKn63_ZVg@mail.gmail.com/
>>
>> He says that defconfig patches can be sent at the same time as dts updates and maintainers can send those
>> as separate pull requests.
>
> BTW, [1] your patches 7/8 and 8/8 never hit the mailing list, So, I am
> commenting on the defconfig patches without actually seeing the patches,
> and solely based on $subject in the cover letter.
This is weird. They are there in my patches/ folder and I always do a "git send-email patches/* ..."
Not sure why they didn't get sent. My last send-email command does have all the patches being sent:
https://pastebin.ubuntu.com/p/VNWsrMcBZd/
>
> The reason for my comment was that I think defconfig series could go
> independent of the remaining series into 5.10, since they are not
> related specifically to this series, they are probably needed even for
> am654 and j721e nodes that already exist and was a miss that we didn't
> enable. Tying that to this specific series didn't make sense to me.
You're right that they are not tied to the series.
>
> But either way, we are way past rc7. I don't have enough time for
> these patches to bake in -next to make it to 5.10 window. So, lets try
> reposting this after rc1 tag is done so that I can send the defconfig
> (separately for 5.10 window) and the dts staged towards 5.11 (and no,
> I don't consider the dts patches as fixes - they are enabling the next
> level of functionality).
>
Ok. I'll send only the defconfig patches in a new series and repost v2 of this at rc1.
Thanks,
Fai
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 0/8] Add support for UHS modes in TI's J721e and J7200 boards
2020-10-02 16:09 ` Faiz Abbas
@ 2020-10-26 14:55 ` Nishanth Menon
0 siblings, 0 replies; 12+ messages in thread
From: Nishanth Menon @ 2020-10-26 14:55 UTC (permalink / raw)
To: Faiz Abbas
Cc: devicetree, linux-kernel, t-kristo, robh+dt, will, linux-arm-kernel
On 21:39-20201002, Faiz Abbas wrote:
> Ok. I'll send only the defconfig patches in a new series and repost v2 of this at rc1.
>
Just a reminder, please retest and repost based off v5.10-rc1
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
^ permalink raw reply [flat|nested] 12+ messages in thread