linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/1] mfd: sl28cpld: Depend on I2C
@ 2020-10-02  8:35 Lee Jones
  2020-10-02 16:18 ` Randy Dunlap
  0 siblings, 1 reply; 2+ messages in thread
From: Lee Jones @ 2020-10-02  8:35 UTC (permalink / raw)
  To: lee.jones; +Cc: linux-arm-kernel, linux-kernel, Randy Dunlap

Fixes the following randconfig build error:

 ld: drivers/mfd/simple-mfd-i2c.o: in function `simple_mfd_i2c_probe':
 simple-mfd-i2c.c:(.text+0x48): undefined reference to `__devm_regmap_init_i2c'
 ld: drivers/mfd/simple-mfd-i2c.o: in function `simple_mfd_i2c_driver_init':
 simple-mfd-i2c.c:(.init.text+0x14): undefined reference to `i2c_register_driver'
 ld: drivers/mfd/simple-mfd-i2c.o: in function `simple_mfd_i2c_driver_exit':
 simple-mfd-i2c.c:(.exit.text+0xd): undefined reference to `i2c_del_driver'

Reported-by: Randy Dunlap <rdunlap@infradead.org>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 drivers/mfd/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
index bdf8cb962027b..8b99a13669bfc 100644
--- a/drivers/mfd/Kconfig
+++ b/drivers/mfd/Kconfig
@@ -1188,6 +1188,7 @@ config MFD_SIMPLE_MFD_I2C
 
 config MFD_SL28CPLD
 	tristate "Kontron sl28cpld Board Management Controller"
+	depends on I2C
 	select MFD_SIMPLE_MFD_I2C
 	help
 	  Say yes here to enable support for the Kontron sl28cpld board
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH 1/1] mfd: sl28cpld: Depend on I2C
  2020-10-02  8:35 [PATCH 1/1] mfd: sl28cpld: Depend on I2C Lee Jones
@ 2020-10-02 16:18 ` Randy Dunlap
  0 siblings, 0 replies; 2+ messages in thread
From: Randy Dunlap @ 2020-10-02 16:18 UTC (permalink / raw)
  To: Lee Jones; +Cc: linux-arm-kernel, linux-kernel

On 10/2/20 1:35 AM, Lee Jones wrote:
> Fixes the following randconfig build error:
> 
>  ld: drivers/mfd/simple-mfd-i2c.o: in function `simple_mfd_i2c_probe':
>  simple-mfd-i2c.c:(.text+0x48): undefined reference to `__devm_regmap_init_i2c'
>  ld: drivers/mfd/simple-mfd-i2c.o: in function `simple_mfd_i2c_driver_init':
>  simple-mfd-i2c.c:(.init.text+0x14): undefined reference to `i2c_register_driver'
>  ld: drivers/mfd/simple-mfd-i2c.o: in function `simple_mfd_i2c_driver_exit':
>  simple-mfd-i2c.c:(.exit.text+0xd): undefined reference to `i2c_del_driver'
> 
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
> ---
>  drivers/mfd/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> index bdf8cb962027b..8b99a13669bfc 100644
> --- a/drivers/mfd/Kconfig
> +++ b/drivers/mfd/Kconfig
> @@ -1188,6 +1188,7 @@ config MFD_SIMPLE_MFD_I2C
>  
>  config MFD_SL28CPLD
>  	tristate "Kontron sl28cpld Board Management Controller"
> +	depends on I2C
>  	select MFD_SIMPLE_MFD_I2C
>  	help
>  	  Say yes here to enable support for the Kontron sl28cpld board
> 

Acked-by: Randy Dunlap <rdunlap@infradead.org> # build-tested

thanks.
-- 
~Randy

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-10-02 16:18 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-02  8:35 [PATCH 1/1] mfd: sl28cpld: Depend on I2C Lee Jones
2020-10-02 16:18 ` Randy Dunlap

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).