From: Sudeep Holla <sudeep.holla@arm.com>
To: Michal Simek <michal.simek@xilinx.com>
Cc: muhammad.husaini.zulkifli@intel.com, adrian.hunter@intel.com,
Sudeep Holla <sudeep.holla@arm.com>,
ulf.hansson@linaro.org, linux-mmc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
lakshmi.bai.raja.subramanian@intel.com,
wan.ahmad.zainie.wan.mohamad@intel.com, arnd@arndb.de
Subject: Re: [PATCH v3 2/2] firmware: Keem Bay: Add support for Arm Trusted Firmware Service call
Date: Wed, 7 Oct 2020 11:10:38 +0100 [thread overview]
Message-ID: <20201007101038.ec7ymdhiaf7rhyrm@bogus> (raw)
In-Reply-To: <4677c614-ac00-fb69-d22c-54f9015249f4@xilinx.com>
On Wed, Oct 07, 2020 at 10:20:21AM +0200, Michal Simek wrote:
> Hi,
>
> 1. Keem Bay: in subject is wrong. Tools are working with it and you
> should just use keembay: instead.
>
> 2. This should come first before actual change to keep the tree bisectable.
>
> On 06. 10. 20 17:55, muhammad.husaini.zulkifli@intel.com wrote:
> > From: Muhammad Husaini Zulkifli <muhammad.husaini.zulkifli@intel.com>
> >
> > Add header file to handle API function for device driver to communicate
> > with Arm Trusted Firmware.
> >
> > Signed-off-by: Muhammad Husaini Zulkifli <muhammad.husaini.zulkifli@intel.com>
> > ---
> > .../linux/firmware/intel/keembay_firmware.h | 46 +++++++++++++++++++
> > 1 file changed, 46 insertions(+)
> > create mode 100644 include/linux/firmware/intel/keembay_firmware.h
> >
> > diff --git a/include/linux/firmware/intel/keembay_firmware.h b/include/linux/firmware/intel/keembay_firmware.h
> > new file mode 100644
> > index 000000000000..9adb8c87b788
> > --- /dev/null
> > +++ b/include/linux/firmware/intel/keembay_firmware.h
> > @@ -0,0 +1,46 @@
> > +/* SPDX-License-Identifier: GPL-2.0 */
> > +/*
> > + * Intel Keembay SOC Firmware API Layer
> > + *
> > + * Copyright (C) 2020-2021, Intel Corporation
> > + *
> > + * Muhammad Husaini Zulkifli <Muhammad.Husaini.Zulkifli@intel.com>
> > + */
> > +
> > +#ifndef __FIRMWARE_KEEMBAY_SMC_H__
> > +#define __FIRMWARE_KEEMBAY_SMC_H__
> > +
> > +#include <linux/arm-smccc.h>
> > +
> > +/**
>
> This is not a kernel doc comment. Just use /*
>
> > + * This file defines API function that can be called by device driver in order to
> > + * communicate with Arm Trusted Firmware.
> > + */
> > +
> > +/* Setting for Keem Bay IO Pad Line Voltage Selection */
> > +#define KEEMBAY_SET_SD_VOLTAGE_FUNC_ID 0x8200ff26
>
> Sudeep: Don't we have any macros for composing these IDs?
> nit: IMHO composing these IDs from macros would make more sense to me.
>
Yes we do. Refer include/linux/arm-smccc.h
I expect something like below, which also indicated you are using wrong
OWNER space. You can't be 0 which is reserved for CPU ARCH. You need to
be SIP(0x2)
#define ARM_SMCCC_SIP_KEEMBAY_SET_SD_VOLTAGE \
ARM_SMCCC_CALL_VAL(ARM_SMCCC_FAST_CALL, \
ARM_SMCCC_SMC_32, \
ARM_SMCCC_OWNER_SIP, \
0xFF26)
--
Regards,
Sudeep
next prev parent reply other threads:[~2020-10-07 10:10 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-06 15:55 [PATCH v3 0/2] mmc: sdhci-of-arasan: Enable UHS-1 support for Keem Bay SOC muhammad.husaini.zulkifli
2020-10-06 15:55 ` [PATCH v3 1/2] " muhammad.husaini.zulkifli
2020-10-07 8:33 ` Michal Simek
2020-10-07 8:55 ` Andy Shevchenko
2020-10-07 9:10 ` Michal Simek
2020-10-07 12:08 ` Andy Shevchenko
2020-10-07 13:28 ` Zulkifli, Muhammad Husaini
2020-10-07 14:54 ` Andy Shevchenko
2020-10-07 16:08 ` Zulkifli, Muhammad Husaini
2020-10-07 13:25 ` Zulkifli, Muhammad Husaini
2020-10-06 15:55 ` [PATCH v3 2/2] firmware: Keem Bay: Add support for Arm Trusted Firmware Service call muhammad.husaini.zulkifli
2020-10-06 20:37 ` kernel test robot
2020-10-07 3:41 ` Zulkifli, Muhammad Husaini
2020-10-07 8:20 ` Michal Simek
2020-10-07 10:10 ` Sudeep Holla [this message]
2020-10-07 13:29 ` Zulkifli, Muhammad Husaini
2020-10-07 13:21 ` Zulkifli, Muhammad Husaini
2020-10-07 13:37 ` Michal Simek
2020-10-07 13:52 ` Zulkifli, Muhammad Husaini
2020-10-07 13:58 ` Michal Simek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201007101038.ec7ymdhiaf7rhyrm@bogus \
--to=sudeep.holla@arm.com \
--cc=adrian.hunter@intel.com \
--cc=arnd@arndb.de \
--cc=lakshmi.bai.raja.subramanian@intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=muhammad.husaini.zulkifli@intel.com \
--cc=ulf.hansson@linaro.org \
--cc=wan.ahmad.zainie.wan.mohamad@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).